[PATCH] D29437: [ubsan] Detect signed overflow UB in remainder operations

[Eli Friedman via Phabricator via cfe-commits]

efriedma added inline comments.


================
Comment at: lib/CodeGen/CGExprScalar.cpp:2380
+       CGF.SanOpts.has(SanitizerKind::SignedIntegerOverflow)) &&
+      Ops.Ty->isIntegerType()) {
     CodeGenFunction::SanitizerScope SanScope(&CGF);
----------------
I don't think you need the isIntegerType check here?


https://reviews.llvm.org/D29437



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits