aaron.ballman added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:2973
+ // recognize that scenario and recover gracefully.
+ if (!getLangOpts().MicrosoftExt && Tok.is(tok::identifier) &&
+ Tok.getIdentifierInfo()->getName().equals("__declspec")) {
-
aaron.ballman updated this revision to Diff 88122.
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
Correcting review feedback.
https://reviews.llvm.org/D29868
Files:
include/clang/Basic/DiagnosticParseKinds.td
lib/Parse/ParseDecl.cpp
test/Parser/declspec-rec
aaron.ballman added a comment.
In https://reviews.llvm.org/D29839#674301, @xazax.hun wrote:
> Shouldn't this be a path sensitive check within the clang static analyzer
> instead? So branches are properly handled and interprocedural analysis is
> done.
I agree; I think this check should be par
aaron.ballman added a comment.
One big concern I have with this is the potential to introduce ODR violations
into the user's code. We may want to limit this check to only trigger on macros
that are defined in the primary source file of the TU rather than something in
the include stack.
One oth
aaron.ballman added a comment.
I found a few more small nits, but basically LGTM.
Comment at: clang-tidy/modernize/ReturnBracedInitListCheck.cpp:70
+
+ for (int I = 0, NumParams = MatchedFunctionDecl->getNumParams();
+ I < NumParams; ++I) {
`I` should be
aaron.ballman added a reviewer: delesley.
aaron.ballman added a subscriber: delesley.
aaron.ballman added a comment.
The changes to the format string look good to me, but the changes to the
thread-safety attributes do not make sense. I *think* those are indicative of a
bug with thready safety an
madsravn updated this revision to Diff 88123.
madsravn marked an inline comment as done.
madsravn added a comment.
Added comment in CHECK-FIX to ensure the line we are referring to is uniquely
identified.
https://reviews.llvm.org/D29726
Files:
clang-tidy/readability/DeleteNullPointerCheck.cp
Author: compnerd
Date: Sun Feb 12 10:44:17 2017
New Revision: 294899
URL: http://llvm.org/viewvc/llvm-project?rev=294899&view=rev
Log:
cmath: adjust math forwards for Windows
The newer versions of ucrt have the math routines. Use the CRT version
to determine if we should include the math routine
Author: compnerd
Date: Sun Feb 12 11:37:44 2017
New Revision: 294901
URL: http://llvm.org/viewvc/llvm-project?rev=294901&view=rev
Log:
test: squelch -Wreturn-type error
Add an unreachable marker to avoid a -Wreturn-type error when building
on Windows.
Modified:
libcxx/trunk/test/std/utilitie
Author: compnerd
Date: Sun Feb 12 11:37:48 2017
New Revision: 294903
URL: http://llvm.org/viewvc/llvm-project?rev=294903&view=rev
Log:
test: mark requirement for pthread test
This test explicitly is checking the behaviour of std::thread and
pthread interactions. This requires pthreads. Add an a
Author: compnerd
Date: Sun Feb 12 11:37:45 2017
New Revision: 294902
URL: http://llvm.org/viewvc/llvm-project?rev=294902&view=rev
Log:
math: pull more C functions from std
The newer ucrt version provides the gamma meth routines. Includede them
when building the library.
Modified:
libcxx/tru
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D29726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
A couple of comments.
Comment at: clang-tidy/modernize/ReturnBracedInitListCheck.cpp:35
+
+ auto HasConstructExpr = has(ConstructExpr);
+
Nit: I s
Author: dblaikie
Date: Sun Feb 12 12:45:31 2017
New Revision: 294904
URL: http://llvm.org/viewvc/llvm-project?rev=294904&view=rev
Log:
ASTReader: Refactor common code for writing function definitions, to match the
writing code
Modified:
cfe/trunk/lib/Serialization/ASTReaderDecl.cpp
Modified
Author: rengolin
Date: Sun Feb 12 13:08:02 2017
New Revision: 294910
URL: http://llvm.org/viewvc/llvm-project?rev=294910&view=rev
Log:
Revert "Attributes on K&R C functions should not cause incompatible..."
...function type with a redeclaration having the same attribute. Fixing this
introduced a
On 11 February 2017 at 18:00, Aaron Ballman via cfe-commits
wrote:
> Author: aaronballman
> Date: Sat Feb 11 12:00:32 2017
> New Revision: 294862
>
> URL: http://llvm.org/viewvc/llvm-project?rev=294862&view=rev
> Log:
> Hopefully fixes a compile error introduced by r294861.
Didn't... :)
http://l
On Sun, Feb 12, 2017 at 2:20 PM, Renato Golin wrote:
> On 11 February 2017 at 18:00, Aaron Ballman via cfe-commits
> wrote:
>> Author: aaronballman
>> Date: Sat Feb 11 12:00:32 2017
>> New Revision: 294862
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=294862&view=rev
>> Log:
>> Hopefully fix
Author: aaronballman
Date: Sun Feb 12 13:24:47 2017
New Revision: 294911
URL: http://llvm.org/viewvc/llvm-project?rev=294911&view=rev
Log:
Revert r294910 and recommit r294861 and r294862 with a target triple to
hopefully appease the bots.
Modified:
cfe/trunk/include/clang/AST/Type.h
cfe/
On Sun, Feb 12, 2017 at 2:08 PM, Renato Golin via cfe-commits
wrote:
> Author: rengolin
> Date: Sun Feb 12 13:08:02 2017
> New Revision: 294910
>
> URL: http://llvm.org/viewvc/llvm-project?rev=294910&view=rev
> Log:
> Revert "Attributes on K&R C functions should not cause incompatible..."
>
> ...f
On 12 February 2017 at 19:24, Aaron Ballman wrote:
> Did, just that the test also needs a triple. I guess I'll do the dance
> to add it and re-commit.
Makes sense. Thanks!
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: madsravn
Date: Sun Feb 12 14:09:59 2017
New Revision: 294912
URL: http://llvm.org/viewvc/llvm-project?rev=294912&view=rev
Log:
[clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work
for class members
I have made a small fix for readability-delete-null-pointer check
This revision was automatically updated to reflect the committed changes.
Closed by commit rL294912: [clang-tidy] Fix for bug 31838:
readability-delete-null-pointer does not work… (authored by madsravn).
Changed prior to commit:
https://reviews.llvm.org/D29726?vs=88123&id=88143#toc
Repository:
Author: madsravn
Date: Sun Feb 12 14:35:42 2017
New Revision: 294913
URL: http://llvm.org/viewvc/llvm-project?rev=294913&view=rev
Log:
[clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work
for class members
Fix for commit r294912 which had a small error in the AST matcher
arpith-jacob updated this revision to Diff 88144.
arpith-jacob added a comment.
Updated patch to address Alexey's comments. Condensed parameters in
emitReduction() to a struct Options.
https://reviews.llvm.org/D29758
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
l
rsmith added inline comments.
Comment at: include/string:782
_LIBCPP_INLINE_VISIBILITY
basic_string(const value_type* __s, size_type __n);
_LIBCPP_INLINE_VISIBILITY
EricWF wrote:
> rsmith wrote:
> > Did you skip this one intentionally?
> Yes. `size
v.g.vassilev created this revision.
Repository:
rL LLVM
https://reviews.llvm.org/D29877
Files:
lib/Sema/Sema.cpp
lib/Sema/SemaDecl.cpp
lib/Serialization/ASTReader.cpp
test/SemaCXX/warn-unused-filescoped.cpp
Index: test/SemaCXX/warn-unused-filescoped.cpp
==
Author: jketema
Date: Sun Feb 12 15:31:41 2017
New Revision: 294915
URL: http://llvm.org/viewvc/llvm-project?rev=294915&view=rev
Log:
Add the correct prefixes to the cl_khr_fp64 pragma
Modified:
libclc/trunk/generic/include/clc/shared/vstore.h
Modified: libclc/trunk/generic/include/clc/share
Author: jketema
Date: Sun Feb 12 15:33:49 2017
New Revision: 294916
URL: http://llvm.org/viewvc/llvm-project?rev=294916&view=rev
Log:
Move BufferPtr into the block where it it being used
The previous location outside the block would crash prepare-builtins
when no the builtins file accidentially n
Author: compnerd
Date: Sun Feb 12 15:42:37 2017
New Revision: 294918
URL: http://llvm.org/viewvc/llvm-project?rev=294918&view=rev
Log:
math: follow up to SVN r294902
Pull in the math functions from ucrt 14+ after auditing the library. It
seems that they are now complete for C99 math. Fixes more
Author: compnerd
Date: Sun Feb 12 15:42:35 2017
New Revision: 294917
URL: http://llvm.org/viewvc/llvm-project?rev=294917&view=rev
Log:
test: use char32_t rather than wchar_t
wchar_t is not as portable as char32_t. On Windows, wchar_t is
16-bytes and on Linux 32-bits. The conversion to utf8 caus
compnerd added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:2989
+
+ Diag(Loc, diag::err_ms_attributes_not_enabled);
+ continue;
aaron.ballman wrote:
> compnerd wrote:
> > I think that we want to emit the diagnostic even if there is no p
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
In https://reviews.llvm.org/D29839#674517, @aaron.ballman wrote:
> In https://reviews.llvm.org/D29839#674301, @xazax.hun wrote:
>
> > Shouldn't this be a path sensitive check within t
dcoughlin added a comment.
Thanks for updating the tests to be able to run both the z3 and
range-constraint managers! I think this will make it much easier to ensure the
z3-backed manager continues to work as as expected moving forward. I suggested
an alternative approach inline to running the
arpith-jacob updated this revision to Diff 88149.
arpith-jacob added a comment.
Minor fixup of comment style on emitInterWarpCopyFunction().
https://reviews.llvm.org/D29758
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
lib/Code
arpith-jacob created this revision.
Herald added a subscriber: jholewinski.
This patch implements codegen for the reduction clause on
any teams construct for elementary data types. It builds
on parallel reductions on the GPU. Subsequently,
the team master writes to a unique location in a global
cryptoad added a comment.
So if I understand correctly, the consensus is to abandon this and rewrite it
to be part of the clang static analyzer?
https://reviews.llvm.org/D29839
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
GorNishanov updated this revision to Diff 88151.
GorNishanov added a comment.
Initialized member variable to zero.
https://reviews.llvm.org/D28835
Files:
include/clang/AST/StmtCXX.h
include/clang/Sema/ScopeInfo.h
lib/AST/StmtCXX.cpp
lib/Sema/SemaCoroutine.cpp
test/SemaCXX/coroutines.c
GorNishanov updated this revision to Diff 88152.
GorNishanov added a comment.
Initialized PromiseRecordDecl to nullptr
https://reviews.llvm.org/D28835
Files:
include/clang/AST/StmtCXX.h
include/clang/Sema/ScopeInfo.h
lib/AST/StmtCXX.cpp
lib/Sema/SemaCoroutine.cpp
test/SemaCXX/coroutin
GorNishanov marked an inline comment as done.
GorNishanov added a comment.
Preparing to land. Thank you very much for review!
Comment at: lib/Sema/SemaCoroutine.cpp:719
+
+ if (!PromiseRecordDecl)
+return true;
EricWF wrote:
> I figured out what's going on
Author: gornishanov
Date: Sun Feb 12 23:05:02 2017
New Revision: 294933
URL: http://llvm.org/viewvc/llvm-project?rev=294933&view=rev
Log:
[coroutines] NFC: Refactor Sema::CoroutineBodyStmt construction.
Summary:
Sema::CheckCompletedCoroutineBody was growing unwieldy with building all of the
subs
This revision was automatically updated to reflect the committed changes.
GorNishanov marked an inline comment as done.
Closed by commit rL294933: [coroutines] NFC: Refactor Sema::CoroutineBodyStmt
construction. (authored by GorNishanov).
Changed prior to commit:
https://reviews.llvm.org/D28835
Hi Nico,
The documentation might confuse people now that the warning is on by default,
but it’s correct as clang still qualifies indirect parameters with
__autoreleasing. We had to add this warning and turn it on by default because a
lot of people capture indirect parameters in their code not r
ahatanak added inline comments.
Comment at: lib/Frontend/ASTUnit.cpp:2551
continue;
-FileID FID = SrcMgr.translateFile(FE);
+FileID FID;
+if (FE == CachedFE) {
Since FID is always equal to CachedFID, I think you can simplify this a bit by
remo
ahatanak added a comment.
Can this attribute be used on c++ template methods? Is the following code valid?
template
struct S {
T foo(int a) __attribute__((alloc_align(1)));
};
https://reviews.llvm.org/D29599
___
cfe-commits mailing list
44 matches
Mail list logo
