aaron.ballman added a reviewer: delesley. aaron.ballman added a subscriber: delesley. aaron.ballman added a comment.
The changes to the format string look good to me, but the changes to the thread-safety attributes do not make sense. I *think* those are indicative of a bug with thready safety analysis, but @delesley would have the definitive answer there. I'm not certain how a static function or variable can be safely guarded by an instance member. https://reviews.llvm.org/D29685 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits