LLBM master is back to work

2017-02-06 Thread Galina Kistanova via cfe-commits
LLBM master is back to work now. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

buildbot numbers for the week of 01/15/2017 - 01/21/2017

2017-02-06 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the week of 01/15/2017 - 01/21/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

Buildbot numbers for the week of 01/22/2017 - 01/28/2017

2017-02-06 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the week of 01/22/2017 - 01/28/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

r294278 - AMDGPU: Add a test checking alignments of emitted globals/allocas

2017-02-06 Thread Matt Arsenault via cfe-commits
Author: arsenm Date: Mon Feb 6 22:28:02 2017 New Revision: 294278 URL: http://llvm.org/viewvc/llvm-project?rev=294278&view=rev Log: AMDGPU: Add a test checking alignments of emitted globals/allocas Make sure the spec required type alignments are used in preparation for a possible change which ma

[PATCH] D29162: AMDGPU: Add a test checking alignments of emitted globals/allocas

2017-02-06 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm closed this revision. arsenm added a comment. r294278 https://reviews.llvm.org/D29162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

2017-02-06 Thread Ben Harper via Phabricator via cfe-commits
bmharper updated this revision to Diff 87361. bmharper added a comment. This looks a lot better IMO. Thanks @daphnediane - you should recognize the code ;) The special closing paren logic inside of nestingAndIndentLevel() is indeed redundant now. https://reviews.llvm.org/D21279 Files: lib/F

[PATCH] D26949: [libc++abi] Clean up visibility

2017-02-06 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai updated this revision to Diff 87362. smeenai edited the summary of this revision. smeenai added a comment. Addressing comments https://reviews.llvm.org/D26949 Files: include/__cxxabi_config.h src/abort_message.cpp src/abort_message.h src/cxa_exception.cpp src/cxa_exception.hpp

[PATCH] D26949: [libc++abi] Clean up visibility

2017-02-06 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added inline comments. Comment at: src/abort_message.cpp:25 -#pragma GCC visibility push(hidden) - EricWF wrote: > Is this really redundant? There is an `#include ` > after it. Is this not going to affect those symbols? That's a fair point. I think it'

[PATCH] D29267: [clang-tidy] safety-no-assembler

2017-02-06 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe added a comment. @aaron.ballman I will address post-approval comments post-commit. Repository: rL LLVM https://reviews.llvm.org/D29267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang-tools-extra] r294283 - [clang-tidy] Cleanup of no-assembler check

2017-02-06 Thread Jonathan Coe via cfe-commits
Author: jbcoe Date: Tue Feb 7 00:19:38 2017 New Revision: 294283 URL: http://llvm.org/viewvc/llvm-project?rev=294283&view=rev Log: [clang-tidy] Cleanup of no-assembler check Address outstanding comments from https://reviews.llvm.org/D29267 Modified: clang-tools-extra/trunk/clang-tidy/safety

[PATCH] D29267: [clang-tidy] safety-no-assembler

2017-02-06 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe marked an inline comment as done. jbcoe added inline comments. Comment at: clang-tools-extra/clang-tidy/safety/NoAssemblerCheck.cpp:13 +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include "clang/Lex/Lexer.h" + Eugene.Zelenko wrote: > aaron.ballman wrote

[PATCH] D28451: [AVR] Add support for the 'interrupt' and 'naked' attributes

2017-02-06 Thread Dylan McKay via Phabricator via cfe-commits
dylanmckay added inline comments. Comment at: test/CodeGen/avr/attributes/interrupt.c:3 + +// CHECK: define void @foo() #0 +__attribute__((interrupt)) void foo(void) { } aaron.ballman wrote: > dylanmckay wrote: > > aaron.ballman wrote: > > > As should this. > > I

[PATCH] D28451: [AVR] Add support for the 'interrupt' and 'naked' attributes

2017-02-06 Thread Dylan McKay via Phabricator via cfe-commits
dylanmckay updated this revision to Diff 87365. dylanmckay marked 4 inline comments as done. dylanmckay added a comment. Remove 'Attr.setInvalid()' https://reviews.llvm.org/D28451 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td lib/CodeGen/TargetInfo.cpp lib/Sema/Sema

<    1   2