[PATCH] D22587: [ASTContext] Fix part of DR224 for nontype template arguments

rsmith added a comment. In https://reviews.llvm.org/D22587#551647, @mgehre wrote: > I'm sorry if this sounds dumb, but is there a way for me to follow that > particular discussion? Only if you have access to the C++ committee's internal reflectors. Sadly this is not on the issues list yet eit

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

joerg added a comment. Always defining __mips_abicalls is certainly the saner choice. I'm discussing with the NetBSD/MIPS guys whether we just want to go with it all the time and drop our custom changes for __ABICALLS__. Chances are quite good that we are going in that direction. https://revi

[PATCH] D28933: Revert the return type for `emplace_(back|front)` to `void` in C++14 and before

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Landed as revision 292990. https://reviews.llvm.org/D28933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D27680: [CodeGen] Move lifetime.start of a variable when goto jumps back past its declaration

ahatanak updated this revision to Diff 85643. ahatanak marked an inline comment as done. ahatanak added a comment. To decide whether lifetime markers should be disabled, check whether the current LexicalScope has labels instead of introducing a new structure that keeps track of labels seen in th

[PATCH] D29101: Ignore -f(no)objc-arc-exception when -fno-objc-arc set

onhachoe created this revision. Sometime clang would be supplied -fobjc-arc -f(no)objc-arc-exceptions and then later disable ARC with -fno-objc-arc, which only negate first option, but not the latter, resulting usused argument warning. Silence this warning only when -fno-objc-arc option is present

[libcxx] r292992 - Implement LWG2556: Wide contract for future::share()

Author: marshall Date: Tue Jan 24 17:28:25 2017 New Revision: 292992 URL: http://llvm.org/viewvc/llvm-project?rev=292992&view=rev Log: Implement LWG2556: Wide contract for future::share() Modified: libcxx/trunk/include/future libcxx/trunk/test/std/thread/futures/futures.unique_future/shar

r292991 - PR31742: Don't emit a bogus "zero size array" extwarn when initializing a

Author: rsmith Date: Tue Jan 24 17:18:28 2017 New Revision: 292991 URL: http://llvm.org/viewvc/llvm-project?rev=292991&view=rev Log: PR31742: Don't emit a bogus "zero size array" extwarn when initializing a runtime-sized array from an empty list in an array new. Modified: cfe/trunk/lib/Sema/S

[libcxx] r292990 - Change the return type of emplace_[front|back] back to void when building with C++14 or before. Resolves PR31680.

Author: marshall Date: Tue Jan 24 17:09:12 2017 New Revision: 292990 URL: http://llvm.org/viewvc/llvm-project?rev=292990&view=rev Log: Change the return type of emplace_[front|back] back to void when building with C++14 or before. Resolves PR31680. Modified: libcxx/trunk/include/deque li

[PATCH] D28845: Prototype of modules codegen

dblaikie updated this revision to Diff 85649. dblaikie added a comment. - Add cc1 flag for modular codegen, -fmodule-codegen https://reviews.llvm.org/D28845 Files: include/clang/AST/ASTContext.h include/clang/AST/ExternalASTSource.h include/clang/Basic/LangOptions.def include/clang/Basi

Re: Add warning for c++ member variable shadowing

Coding style change From: James Sun Date: Tuesday, January 24, 2017 at 2:36 PM To: "cfe-commits@lists.llvm.org" Subject: Add warning for c++ member variable shadowing Dear members Here is a patch (attached) to create warnings where a member variable shadows the one in one of its inheriting cl

[PATCH] D27680: [CodeGen] Move lifetime.start of a variable when goto jumps back past its declaration

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks. Some minor changes and then LGTM. I'm currently wondering if a better solution might be to just teach the Bypasses analysis about the C lifetime rule. But we don't need to do tha

[PATCH] D22391: [Sema] Add warning for implicitly casting a null constant to a non null pointer type

ahatanak updated this revision to Diff 85651. ahatanak added a reviewer: jordan_rose. ahatanak added a comment. Rebase. https://reviews.llvm.org/D22391 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/Sema.cpp

[PATCH] D29101: Ignore -f(no)objc-arc-exception when -fno-objc-arc set

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Yes, that seems reasonable. https://reviews.llvm.org/D29101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D22391: [Sema] Add warning for implicitly casting a null constant to a non null pointer type

jordan_rose added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:290 def NullableToNonNullConversion : DiagGroup<"nullable-to-nonnull-conversion">; +def NullConstToNonnull : DiagGroup<"null-const-to-nonnull">; def NullabilityCompletenessOnArrays : DiagGro

[PATCH] D22391: [Sema] Add warning for implicitly casting a null constant to a non null pointer type

ahatanak added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:290 def NullableToNonNullConversion : DiagGroup<"nullable-to-nonnull-conversion">; +def NullConstToNonnull : DiagGroup<"null-const-to-nonnull">; def NullabilityCompletenessOnArrays : DiagGroup<

r292997 - [OpenMP] Support for the num_threads-clause on 'target parallel'.

Author: arpith Date: Tue Jan 24 18:57:16 2017 New Revision: 292997 URL: http://llvm.org/viewvc/llvm-project?rev=292997&view=rev Log: [OpenMP] Support for the num_threads-clause on 'target parallel'. The num_threads-clause on the combined directive applies to the 'parallel' region of this construc

[PATCH] D29082: [OpenMP] Support for the num_threads-clause on 'target parallel'.

This revision was automatically updated to reflect the committed changes. Closed by commit rL292997: [OpenMP] Support for the num_threads-clause on 'target parallel'. (authored by arpith). Changed prior to commit: https://reviews.llvm.org/D29082?vs=85582&id=85662#toc Repository: rL LLVM htt

[PATCH] D29083: [OpenMP] Support for the num_threads-clause on 'target parallel' on the NVPTX device.

This revision was automatically updated to reflect the committed changes. Closed by commit rL292999: [OpenMP] Support for the num_threads-clause on 'target parallel' on the NVPTX… (authored by arpith). Changed prior to commit: https://reviews.llvm.org/D29083?vs=85583&id=85670#toc Repository:

r292999 - [OpenMP] Support for the num_threads-clause on 'target parallel' on the NVPTX device.

Author: arpith Date: Tue Jan 24 19:18:34 2017 New Revision: 292999 URL: http://llvm.org/viewvc/llvm-project?rev=292999&view=rev Log: [OpenMP] Support for the num_threads-clause on 'target parallel' on the NVPTX device. This patch adds support for the Spmd construct 'target parallel' on the NVPTX

[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

timshen marked 13 inline comments as done. timshen added inline comments. Comment at: llvm/include/llvm/ADT/APFloat.h:1054 + opStatus next(bool nextDown) { +if (usesLayout(getSemantics())) jlebar wrote: > FWIW, see my screed on this: > http://jlebar.com/2

r293001 - [OpenMP] Codegen support for 'target teams' on the host.

Author: arpith Date: Tue Jan 24 19:38:33 2017 New Revision: 293001 URL: http://llvm.org/viewvc/llvm-project?rev=293001&view=rev Log: [OpenMP] Codegen support for 'target teams' on the host. This patch adds support for codegen of 'target teams' on the host. This combined directive has two captured

[PATCH] D29084: [OpenMP] Codegen support for 'target teams' on the host.

This revision was automatically updated to reflect the committed changes. Closed by commit rL293001: [OpenMP] Codegen support for 'target teams' on the host. (authored by arpith). Changed prior to commit: https://reviews.llvm.org/D29084?vs=85585&id=85673#toc Repository: rL LLVM https://revi

[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

jlebar added inline comments. Comment at: llvm/unittests/ADT/APFloatTest.cpp:3534 Op2[1]) .str(); } timshen wrote: > jlebar wrote: > > Honestly I am not sure this is an improvement over writing it out by hand: > > > > EXPEC

[PATCH] D28299: Module: use PCMCache to manage memory buffers for pcm files.

bruno added inline comments. Comment at: lib/Serialization/ASTReader.cpp:3692 +ValidationConflicts); +for (auto N : ValidationConflicts) + Diag(diag::err_module_ancestor_conflict) << N; This should honor `ARR_OutOfDate`, so th

r293003 - Reverting commit because an NVPTX patch sneaked in. Break up into two

Author: arpith Date: Tue Jan 24 19:45:59 2017 New Revision: 293003 URL: http://llvm.org/viewvc/llvm-project?rev=293003&view=rev Log: Reverting commit because an NVPTX patch sneaked in. Break up into two patches. Removed: cfe/trunk/test/OpenMP/target_teams_codegen.cpp cfe/trunk/test/OpenM

Re: [PATCH] D28299: Module: use PCMCache to manage memory buffers for pcm files.

According to the comment at line 239: if (LoadedSuccessfully.count(*victim) == 0) { // Before removing the module file, check if it was validated in an // ancestor thread, if yes, throw a hard error instead of causing // use-after-free in the ancestor thread. bool IsSys

Re: r292991 - PR31742: Don't emit a bogus "zero size array" extwarn when initializing a

Hi Hans, This is relatively minor, but it's safe and fixes a rejects-valid regression in some configurations. Might be worth taking for Clang 4. On 24 January 2017 at 15:18, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Tue Jan 24 17:18:28 2017 > New

r293004 - Use filename in linemarker when compiling preprocessed source

Author: david2050 Date: Tue Jan 24 19:55:28 2017 New Revision: 293004 URL: http://llvm.org/viewvc/llvm-project?rev=293004&view=rev Log: Use filename in linemarker when compiling preprocessed source Summary: Clang appears to always use name as specified on the command line, whereas gcc uses the na

r293005 - [OpenMP] Codegen support for 'target teams' on the host.

Author: arpith Date: Tue Jan 24 20:18:43 2017 New Revision: 293005 URL: http://llvm.org/viewvc/llvm-project?rev=293005&view=rev Log: [OpenMP] Codegen support for 'target teams' on the host. This patch adds support for codegen of 'target teams' on the host. This combined directive has two captured

[libunwind] r293008 - DWARF: fix -Asserts builds

Author: compnerd Date: Tue Jan 24 20:27:45 2017 New Revision: 293008 URL: http://llvm.org/viewvc/llvm-project?rev=293008&view=rev Log: DWARF: fix -Asserts builds no-op the DWARF tracing macros in non-debug builds. Modified: libunwind/trunk/src/DwarfParser.hpp libunwind/trunk/src/config.h

Re: [libunwind] r292722 - DWARF: allow enabling tracing at runtime

Oops. Should be fixed in SVN r293008. On Mon, Jan 23, 2017 at 4:01 AM, Oliver Stannard wrote: > Hi Saleem, > > This patch is causing our internal runs of the libc++ and libc++abi tests > to fail, because logDWARF is referenced but not defined in release builds > (with NDEBUG defined). > > Howev

Re: Add warning for c++ member variable shadowing

Some more stylistic comments: The description that you have on CheckShadowInheritedVariables isn't really the type of comments that we have in doxygen form. Im not sure if its in line with the rest of the code. The ignore warning comments are restating what is in the code, please remove them. C

[PATCH] D28845: Prototype of modules codegen

dblaikie updated this revision to Diff 85686. dblaikie added a comment. - Add test coverage https://reviews.llvm.org/D28845 Files: include/clang/AST/ASTContext.h include/clang/AST/ExternalASTSource.h include/clang/Basic/LangOptions.def include/clang/Basic/Module.h include/clang/Driver

Re: [PATCH] D28845: Prototype of modules codegen

Richard: This ought to be ready for another round of review at this point, I Think. Got test cases (showing opt and non-opt behavior, direct and indirect modular dependencies, unused modular code, etc - might need some more comments?), flag, moved the linkage code to GetGVALinkageForFunction. One

r293014 - Driver: ignore -fno-objc-arc-exception when -fno-objc-arc set

Author: compnerd Date: Tue Jan 24 21:36:28 2017 New Revision: 293014 URL: http://llvm.org/viewvc/llvm-project?rev=293014&view=rev Log: Driver: ignore -fno-objc-arc-exception when -fno-objc-arc set Sometime clang would be supplied -fobjc-arc -f(no)objc-arc-exceptions and then later disable ARC wit

[PATCH] D29101: Ignore -f(no)objc-arc-exception when -fno-objc-arc set

compnerd closed this revision. compnerd added a comment. SVN r293014. https://reviews.llvm.org/D29101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: Add warning for c++ member variable shadowing

Thanks for the comments. The new version is attached. Wrt two of your questions: (1) “The description that you have on CheckShadowInheritedVariables isn't really the type of comments that we have in doxygen form. Im not sure if its in line with the rest of the code.” I’ve read through the doxy

[PATCH] D28989: [X86][MS]Adjacent comments within multi-line inline assembly statement

coby added a comment. Ping Repository: rL LLVM https://reviews.llvm.org/D28989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r293026 - Try to fix test from r293004

Author: rovka Date: Wed Jan 25 00:23:50 2017 New Revision: 293026 URL: http://llvm.org/viewvc/llvm-project?rev=293026&view=rev Log: Try to fix test from r293004 This test broke on a lot of non-x86 buildbots with "unknowm CPU" errors. I don't see anything platform-specific about this test, and it

[PATCH] D28529: [test] Port clang tests to canonicalized booleans

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. SGTM https://reviews.llvm.org/D28529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

Re: r293004 - Use filename in linemarker when compiling preprocessed source

Hi David, Sorry, but I had to revert this (r283029) because it was breaking the non-x86 buildbots (arm, powerpc, hexagon), with errors along the lines of: error: unknown target CPU 'cortex-a8' Please recommit after you've fixed the issue. Thanks, Diana PS: I tried to fix it in r293024, but that

r293032 - Revert "Use filename in linemarker when compiling preprocessed source"

Author: rovka Date: Wed Jan 25 01:27:05 2017 New Revision: 293032 URL: http://llvm.org/viewvc/llvm-project?rev=293032&view=rev Log: Revert "Use filename in linemarker when compiling preprocessed source" This reverts commit r293004 because it broke the buildbots with "unknown CPU" errors. I tried

Re: r293004 - Use filename in linemarker when compiling preprocessed source

Erm, the revert was actually r293032, sorry about the confusion. On 25 January 2017 at 09:34, Diana Picus wrote: > Hi David, > > Sorry, but I had to revert this (r283029) because it was breaking the > non-x86 buildbots (arm, powerpc, hexagon), with errors along the lines > of: > error: unknown ta

[PATCH] D29117: SPARC: allow usage of floating-point registers in inline ASM

pboettch created this revision. Herald added a subscriber: jyknight. Make clang recognize floating point registers in inline assembler when using the targeting Sparc. This code now works: static inline float fabsf(float a) { float res; __asm __volatile__("fabss %1, %0;"

<    1   2