jlebar added inline comments.
================ Comment at: llvm/unittests/ADT/APFloatTest.cpp:3534 Op2[1]) .str(); } ---------------- timshen wrote: > jlebar wrote: > > Honestly I am not sure this is an improvement over writing it out by hand: > > > > EXPECT_TRUE(APFloat(APFloat::PPCDoubleDouble(), APInt(128, 2, {0xblah, > > 0xblah})).bitwiseIsEqual(...))) > > > > (You should be able to pass an initializer_list to the constructor, no > > problem, afaict.) Up to you though. > It's more of being consistent with other tests. I might be too lazy to > change, unless you insist. :) I mean, the only tests that use make_tuple also seem to be ppc long-double tests. :) Up to you, though; not a big deal. Repository: rL LLVM https://reviews.llvm.org/D27872 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits