pmatos added a comment.
Apologies for the delay over the holiday season, I will look into this later on
after office hours.
https://reviews.llvm.org/D27800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
chandlerc requested changes to this revision.
chandlerc added a comment.
This revision now requires changes to proceed.
There are some issues with this patch currently.
At a basic level, it needs well crafted test cases. You can find out how to
write them by looking at other Driver tests.
But a
hintonda added a comment.
Richard, is it okay to commit this?
https://reviews.llvm.org/D20428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
This change doesn't break existing tests but maybe I should extend `linux-ld.c`
and so on?
About the impact: Which libraries are there next to clang that could conflict
with the system? When I look at my current installation dir:
- `libLLVM*`, `libclang*`, `liblld*` l
chandlerc added a comment.
In https://reviews.llvm.org/D28404#640862, @probinson wrote:
> In https://reviews.llvm.org/D28404#640682, @mehdi_amini wrote:
>
> > > I'm now thinking along the lines of a `-foptimize-off` flag (bikesheds
> > > welcome) which would set the default for the pragma to 'of
Author: rogfer01
Date: Tue Jan 10 02:48:48 2017
New Revision: 291550
URL: http://llvm.org/viewvc/llvm-project?rev=291550&view=rev
Log:
Mark tests as unsupported under libcpp-no-exceptions
The destructor of std::promise needs to construct a std::future_error
exception so it calls std::make_excepti
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291550: Mark tests as unsupported under libcpp-no-exceptions
(authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D27614?vs=80877&id=83782#toc
Repository:
rL LLVM
https://review
Author: rsmith
Date: Tue Jan 10 02:51:46 2017
New Revision: 291551
URL: http://llvm.org/viewvc/llvm-project?rev=291551&view=rev
Log:
Fix rejects-valid with default member initializers exposed by r291318.
Don't prematurely clean up an RAII object; there's another RAII object in the
same scope that
On 18/11/15 20:49, David Majnemer via cfe-commits wrote:
Author: majnemer
Date: Wed Nov 18 13:49:19 2015
New Revision: 253495
URL: http://llvm.org/viewvc/llvm-project?rev=253495&view=rev
Log:
[Sema] Don't work around a malformed AST
We created a malformed TemplateSpecializationType: it was depe
Author: vvassilev
Date: Tue Jan 10 03:09:09 2017
New Revision: 291552
URL: http://llvm.org/viewvc/llvm-project?rev=291552&view=rev
Log:
Remove fixme, use ASTContext::getCanonicalTemplateSpecializationType.
Reviewed by Richard Smith (D28306).
Modified:
cfe/trunk/lib/Sema/SemaTemplate.cpp
Mod
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
Attempting to pair an `_aligned_malloc` with a regular free causes heap
corruption. Pairing with `_aligned_free` is required instead.
Makes the following libc++ tests pa
v.g.vassilev closed this revision.
v.g.vassilev added a comment.
Landed in r291552.
Repository:
rL LLVM
https://reviews.llvm.org/D28306
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Hahnfeld updated this revision to Diff 83784.
Hahnfeld added a comment.
Add test case to check that
- `bin/../lib` is the first library path by default
- user-specified `-L` preceeds
https://reviews.llvm.org/D26244
Files:
lib/Driver/ToolChains.cpp
test/Driver/clang-libraries.c
Index: tes
chandlerc added a comment.
In https://reviews.llvm.org/D26244#641076, @Hahnfeld wrote:
> This change doesn't break existing tests but maybe I should extend
> `linux-ld.c` and so on?
>
> About the impact: Which libraries are there next to clang that could conflict
> with the system? When I look
bmharper added a comment.
Hi @enyquist,
I'd like to guess that this patch will solve your problem, but I'm not intimate
enough with this code to give you a definitive answer. I hope we can get this
merged soon, so that you can just run it and see.
Ben
https://reviews.llvm.org/D21279
__
arphaman added a comment.
I think that the patch would be neater if you add "-Wno-unused-lambda-capture"
to the options for all of the tests that are modified by this patch in the CXX/
directory. This would avoid redundant `(void)` uses and ensure that the
`(void)` uses won't interfere with the
m_zuckerman added a comment.
For my intrinsics ( _mm256_cvtsd_f64, _mm256_cvtsi256_si32 and
_mm256_cvtss_f32) - ** LGTM**.
Repository:
rL LLVM
https://reviews.llvm.org/D28503
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
danielmarjamaki added a comment.
In https://reviews.llvm.org/D28278#639710, @xazax.hun wrote:
> Did you experience any problems with the array out of bounds check lately? In
> case it was stable on large code-bases and did not give too many false
> positives, I think it might be worth to move t
malcolm.parsons updated this revision to Diff 83792.
malcolm.parsons added a comment.
Use -Wno-unused-lambda-capture in existing tests.
https://reviews.llvm.org/D28467
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/ScopeInfo.h
malcolm.parsons added inline comments.
Comment at: include/clang/Sema/ScopeInfo.h:457
+/// lambda.
+bool Used = false;
+
Should this be moved into one of the `PointerIntPair`s?
https://reviews.llvm.org/D28467
_
faisalv added a comment.
Yes - I'll modify the patch to reflect that approach. Any thoughts on whether
they should also be forbidden in Lamda parameter declaration clauses?
Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D28510
___
cfe-com
faisalv added inline comments.
Comment at: include/clang/Sema/Sema.h:894-895
+/// \brief Whether lambda expressions are forbidden here.
+bool IsLambdaExprForbidden;
+
rsmith wrote:
> Rather than adding a flag, how about we have two different kinds of
>
Hahnfeld added a comment.
In https://reviews.llvm.org/D26244#641099, @chandlerc wrote:
> Those are just the libriaries LLVM is installing.
>
> If it is installed into a prefix, say, /opt/mumble/{bin,lib,...} along with
> other libraries, then suddenly that directory is searched in a very differe
arphaman created this revision.
arphaman added reviewers: manmanren, ahatanak, akyrtzi.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes an issue where cached global code completion results for a
`using` declaration included the
mgorny added a comment.
I think the easiest solution would be for you to use a path related to clang
runtime directory, and install the runtimes there.
However, this would require rethinking the structure a bit to cover multilib,
different ABIs, maybe cross. We have a cheap hack for this in cla
kromanenkov accepted this revision.
kromanenkov added a comment.
This revision is now accepted and ready to land.
Looks good to me, apart from a very small cavil introduced in not even your
code. Thanks for not leaving pointers to static member functions out of account!
Commen
arphaman added inline comments.
Comment at: include/clang/Sema/ScopeInfo.h:457
+/// lambda.
+bool Used = false;
+
malcolm.parsons wrote:
> Should this be moved into one of the `PointerIntPair`s?
I'm not sure.. If we needed other capturing information in t
Author: arphaman
Date: Tue Jan 10 08:41:13 2017
New Revision: 291564
URL: http://llvm.org/viewvc/llvm-project?rev=291564&view=rev
Log:
[Sema] Avoid -Wshadow warning when a "redefinition of " error is presented
This commit ensures that clang avoids the redundant -Wshadow warning for
variables that
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291564: [Sema] Avoid -Wshadow warning when a "redefinition
of " error is presented (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D28350?vs=83214&id=83806#toc
Repository:
r
etienneb added a comment.
jckooijman, this issue is still not solved on ToT.
You can apply this patch on your local repo.
It's fixing the problem, but your executable size will increase.
https://reviews.llvm.org/D17981
___
cfe-commits mailing list
vlad.tsyrklevich added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:443
+ if (auto LCV = Val.getAs())
+return C.getSymbolManager().getRegionValueSymbol(LCV->getRegion());
+
zaks.anna wrote:
> This might create a new symbol
thakis added a comment.
Aha, looks like this did have a `#pragma comment(lib` when it went in (for
version.lib which is actually the correct one), but takumi removed it in
http://llvm.org/viewvc/llvm-project?rev=269557&view=rev
Repository:
rL LLVM
https://reviews.llvm.org/D20136
aaron.ballman added a comment.
I think that these changes look good to me, and I noticed Richard signed off on
the other review for the exception spec changes (thank you for working on
that!), so I think this is ready to commit.
In https://reviews.llvm.org/D20428#641068, @hintonda wrote:
> Ric
Author: arpith
Date: Tue Jan 10 09:42:51 2017
New Revision: 291565
URL: http://llvm.org/viewvc/llvm-project?rev=291565&view=rev
Log:
[OpenMP] Basic support for a parallel directive in a target region on an NVPTX
device
Summary:
This patch introduces support for the execution of parallel constru
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291565: [OpenMP] Basic support for a parallel directive in a
target region on an NVPTX… (authored by arpith).
Changed prior to commit:
https://reviews.llvm.org/D28145?vs=83641&id=83808#toc
Repository:
malcolm.parsons added inline comments.
Comment at: include/clang/AST/TypeLoc.h:1355
+ bool hasExceptionSpec() const {
+if (auto FPT = dyn_cast(getTypePtr())) {
+ return FPT->hasExceptionSpec();
`auto *`
Comment at: include/clang/AST/T
mgorny abandoned this revision.
mgorny added a comment.
And the original variant landed in after all. Sorry for the noise.
https://reviews.llvm.org/D28295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
aaron.ballman requested changes to this revision.
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:41
+void UseNoexceptCheck::registerMatchers(MatchFinder *Finder) {
+ if (!getLangOpts().CPlusPlus)
+return;
Shouldn't
RKSimon added inline comments.
Comment at: test/CodeGen/arm_acle.c:247
// ARM-LABEL: test_rbit
// AArch32: call i32 @llvm.arm.rbit
+// AArch64: call i32 @llvm.bitreverse.i32
Since you're here is it worth dealing with the AARCH32 case as well? We know it
works
aaron.ballman requested changes to this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision now requires changes to proceed.
You should also regenerate the HTML matcher documentation as part of this patch.
Comment at: include/cl
aaron.ballman added a comment.
Given that this can't be expressed as a dynamic matcher, I'm wondering what the
use case is for the matcher. Do you have a specific need for this
functionality, or do you see this being generally useful?
https://reviews.llvm.org/D28260
aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.
The patch is also missing Sema tests that ensure the attributes are properly
diagnosed when applied to something other than a function, a target other than
AVR, argumen
hintonda added a comment.
Aaron, I've got this version in a branch, so if you like, I'd be happy to apply
Malcolm's suggestions.
https://reviews.llvm.org/D20428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
mcrosier added inline comments.
Comment at: test/CodeGen/arm_acle.c:247
// ARM-LABEL: test_rbit
// AArch32: call i32 @llvm.arm.rbit
+// AArch64: call i32 @llvm.bitreverse.i32
RKSimon wrote:
> Since you're here is it worth dealing with the AARCH32 case as well?
aaron.ballman added a comment.
In https://reviews.llvm.org/D20428#641416, @hintonda wrote:
> Aaron, I've got this version in a branch, so if you like, I'd be happy to
> apply Malcolm's suggestions.
Please do; they're good suggestions.
https://reviews.llvm.org/D20428
__
sbaranga accepted this revision.
sbaranga added a reviewer: sbaranga.
sbaranga added a comment.
This revision is now accepted and ready to land.
This looks straight-forward to me. LGTM.
-Silviu
https://reviews.llvm.org/D28400
___
cfe-commits mailin
hintonda updated this revision to Diff 83816.
hintonda added a comment.
- Address comments.
https://reviews.llvm.org/D20428
Files:
include/clang/AST/Decl.h
include/clang/AST/TypeLoc.h
lib/AST/Decl.cpp
lib/Parse/ParseDeclCXX.cpp
lib/Sema/SemaType.cpp
lib/Sema/TreeTransform.h
lib/Se
Author: marshall
Date: Tue Jan 10 10:59:33 2017
New Revision: 291572
URL: http://llvm.org/viewvc/llvm-project?rev=291572&view=rev
Log:
Fix up some mismatched SFINAE conditionsin shared_ptr; some used '_Tp*', others
used 'element_type *'. Today, they're the same - but soon they won't be. No
funct
NoQ added a comment.
Thanks for working on the taint! I really wish the taint analysis in the
analyzer to flourish, and the part you've digged into is particularly
sensitive, so i'd dump some thoughts here, hopefully helpful.
**What works as it should: **
> In the second example, the SVal obta
Author: mcrosier
Date: Tue Jan 10 11:20:28 2017
New Revision: 291574
URL: http://llvm.org/viewvc/llvm-project?rev=291574&view=rev
Log:
[AArch64] Use generic bitreverse intrinsic, rather than AArch64 specific.
Differential Revision: https://reviews.llvm.org/D28400
Modified:
cfe/trunk/lib/Code
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291574: [AArch64] Use generic bitreverse intrinsic, rather
than AArch64 specific. (authored by mcrosier).
Changed prior to commit:
https://reviews.llvm.org/D28400?vs=83367&id=83817#toc
Repository:
rL
arphaman updated this revision to Diff 83819.
arphaman added a comment.
Fix more issues with FIXIT for unary operators.
Repository:
rL LLVM
https://reviews.llvm.org/D28231
Files:
lib/Analysis/ReachableCode.cpp
lib/Sema/AnalysisBasedWarnings.cpp
test/Sema/warn-unreachable.c
Index: test
Author: matze
Date: Tue Jan 10 11:43:01 2017
New Revision: 291576
URL: http://llvm.org/viewvc/llvm-project?rev=291576&view=rev
Log:
CGDecl: Skip static variable initializers in unreachable code
This fixes http://llvm.org/PR31054
Differential Revision: https://reviews.llvm.org/D28505
Added:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291576: CGDecl: Skip static variable initializers in
unreachable code (authored by matze).
Changed prior to commit:
https://reviews.llvm.org/D28505?vs=83754&id=83820#toc
Repository:
rL LLVM
https://
arphaman added inline comments.
Comment at: lib/Analysis/ReachableCode.cpp:229
+ if (SilenceableCondValNotSet && SilenceableCondVal->getBegin().isValid())
+*SilenceableCondVal = UO->getSourceRange();
+ return UO->getOpcode() == UO_LNot && IsSubExprConfigValue;
-
hiraditya added a comment.
Just for the record, I ported the patch to gcc/libstdc++ as well: PR66414
optimize std::string::find
https://github.com/gcc-mirror/gcc/commit/fc7ebc4b8d9ad7e2891b7f72152e8a2b7543cd65
Repository:
rL LLVM
https://reviews.llvm.org/D27068
__
arphaman updated this revision to Diff 83822.
arphaman added a comment.
Ping
Repository:
rL LLVM
https://reviews.llvm.org/D25213
Files:
lib/Sema/SemaExpr.cpp
test/Sema/PR28181.c
Index: test/Sema/PR28181.c
===
--- /dev/null
kkwli0 marked an inline comment as done.
kkwli0 added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:6444
+
+ CapturedStmt *CS = cast(AStmt);
+ // 1.2.2 OpenMP Language Terminology
ABataev wrote:
> auto *
Will do.
https://reviews.llvm.org/D28252
hintonda marked 7 inline comments as done.
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:64
+ Finder->addMatcher(
+ parmVarDecl(hasType(pointerType(pointee(parenType(innerType(
+ functionProtoType(hasDynamicExcept
Anastasia updated this revision to Diff 83824.
Anastasia added a comment.
Updated with comments from Mats!
https://reviews.llvm.org/D28080
Files:
docs/UsersManual.rst
www/index.html
Index: www/index.html
===
--- www/index.html
Anastasia marked 4 inline comments as done.
Anastasia added a comment.
Ping! Any more comments here? It would be nice to commit this before the 4.0
rel branch is taken (on Jan 12).
https://reviews.llvm.org/D28080
___
cfe-commits mailing list
cfe-co
dim created this revision.
dim added reviewers: EricWF, mclow.lists.
dim added subscribers: cfe-commits, emaste, joerg.
Many thread-related libc++ test cases fail on FreeBSD, due to the following
-Werror warnings:
In file included from
/share/dim/src/llvm/trunk/projects/libcxx/test/std/thread
hintonda updated this revision to Diff 83827.
hintonda marked an inline comment as done.
hintonda added a comment.
- Addressed comments.
https://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexcept
rnk added a comment.
In https://reviews.llvm.org/D28365#640868, @hamzasood wrote:
> Ha, good point. Does that include the environment stuff in Command too or
> just the linker?
Yes, please make the Command environment changes as part of a separate patch
with the linker environment changes.
dcoughlin updated this revision to Diff 83828.
dcoughlin added a comment.
Updating spacing, as @kromanenkov requested.
https://reviews.llvm.org/D28033
Files:
lib/StaticAnalyzer/Core/SValBuilder.cpp
test/Analysis/pointer-to-member.cpp
Index: test/Analysis/pointer-to-member.cpp
enyquist added a comment.
Well, your patch is here for me to try, and it looks like it's been accepted.
So I guess I should just pull my finger out and try it :)
Thanks for your response-- I'll let you know if I come across any issues.
https://reviews.llvm.org/D21279
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:68
+ this);
+}
+
hintonda wrote:
> aaron.ballman wrote:
> > Also missing: typedefs and using declarations.
> As far as I know, it isn't legal to add dynamic exception
KP updated this revision to Diff 83829.
KP added a comment.
Rename IsPointerOrReference to isPointerOrReference to comply with coding style
https://reviews.llvm.org/D27651
Files:
lib/Format/WhitespaceManager.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
===
Author: marshall
Date: Tue Jan 10 12:40:01 2017
New Revision: 291580
URL: http://llvm.org/viewvc/llvm-project?rev=291580&view=rev
Log:
Qualify some type names that I thought were fine, but some of the bots don't
like.
Modified:
libcxx/trunk/include/memory
Modified: libcxx/trunk/include/memo
aaron.ballman added a reviewer: delesley.
aaron.ballman added a comment.
Alternatively, these functions could be given the proper thread safety
annotations, couldn't they?
https://reviews.llvm.org/D28520
___
cfe-commits mailing list
cfe-commits@lis
dim added a comment.
In https://reviews.llvm.org/D28520#641534, @aaron.ballman wrote:
> Alternatively, these functions could be given the proper thread safety
> annotations, couldn't they?
Aha, I was not aware of the existence of these attributes. I'll take a look.
https://reviews.llvm.org/
aaron.ballman added a comment.
In https://reviews.llvm.org/D28520#641536, @dim wrote:
> In https://reviews.llvm.org/D28520#641534, @aaron.ballman wrote:
>
> > Alternatively, these functions could be given the proper thread safety
> > annotations, couldn't they?
>
>
> Aha, I was not aware of the
probinson added a comment.
In https://reviews.llvm.org/D28404#641078, @chandlerc wrote:
> For me, the arguments you're raising against -O0 and -flto don't hold up on
> closer inspection:
>
> - O0 != optnone: correct. But this is only visible in LTO. And in LTO, Os !=
> optsize, and Oz != minsiz
Author: dcoughlin
Date: Tue Jan 10 12:49:27 2017
New Revision: 291581
URL: http://llvm.org/viewvc/llvm-project?rev=291581&view=rev
Log:
[analyzer] Treat pointers to static member functions as function pointers
Sema treats pointers to static member functions as having function pointer
type, so tre
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291581: [analyzer] Treat pointers to static member functions
as function pointers (authored by dcoughlin).
Changed prior to commit:
https://reviews.llvm.org/D28033?vs=83828&id=83830#toc
Repository:
r
Author: mcrosier
Date: Tue Jan 10 12:55:11 2017
New Revision: 291582
URL: http://llvm.org/viewvc/llvm-project?rev=291582&view=rev
Log:
[ARM] Use generic bitreverse intrinsic, rather than ARM specific rbit.
The backend already supports lowering this intrinsic to a rbit instruction.
Modified:
Author: kli
Date: Tue Jan 10 12:57:07 2017
New Revision: 291583
URL: http://llvm.org/viewvc/llvm-project?rev=291583&view=rev
Log:
[OpenMP] Remove outdated comments. NFC.
Modified:
cfe/trunk/include/clang/Basic/OpenMPKinds.def
Modified: cfe/trunk/include/clang/Basic/OpenMPKinds.def
URL:
http
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:68
+ this);
+}
+
aaron.ballman wrote:
> hintonda wrote:
> > aaron.ballman wrote:
> > > Also missing: typedefs and using declarations.
> > As far as I know, it isn't legal t
mehdi_amini added a comment.
In https://reviews.llvm.org/D28404#641538, @probinson wrote:
> > - optnone isn't *really* no optimizations: clearly this is true, but then
> > neither is -O0. We run the always inliner, a couple of other passes, and we
> > run several parts of the code generators op
sgilles marked an inline comment as done.
sgilles added a comment.
Ping - if there are no comments, could this be accepted?
https://reviews.llvm.org/D28148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
EricWF added a comment.
Also look in `__mutex` where libc++ defines its own macros for the annotations.
https://reviews.llvm.org/D28520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
dim added a comment.
In https://reviews.llvm.org/D28520#641563, @EricWF wrote:
> Also look in `__mutex` where libc++ defines its own macros for the
> annotations.
I assume you mean `__mutex_base`. Do we want to reuse the macros from that
file? If so we'd have to include it in `__thread_supp
EricWF added a comment.
In https://reviews.llvm.org/D28520#641569, @dim wrote:
> In https://reviews.llvm.org/D28520#641563, @EricWF wrote:
>
> > Also look in `__mutex` where libc++ defines its own macros for the
> > annotations.
>
>
> I assume you mean `__mutex_base`. Do we want to reuse the ma
On 01/09/2017 09:18 AM, Benjamin Kramer via cfe-commits wrote:
Author: d0k
Date: Mon Jan 9 09:18:28 2017
New Revision: 291446
URL: http://llvm.org/viewvc/llvm-project?rev=291446&view=rev
Log:
[include-fixer] Load symbol index asynchronously.
We don't actually need the index until parse time, s
probinson added a comment.
In https://reviews.llvm.org/D28404#641557, @mehdi_amini wrote:
> As I stand right now, there hasn't been any correction.
> I still consider the fact that `optnone` wouldn't produce the "same" result
> (modulo corner cases around `merging global variables` for instanc
mehdi_amini added a comment.
In https://reviews.llvm.org/D28404#641597, @probinson wrote:
> In https://reviews.llvm.org/D28404#641557, @mehdi_amini wrote:
>
> > As I stand right now, there hasn't been any correction.
> > I still consider the fact that `optnone` wouldn't produce the "same"
> >
amaiorano added a comment.
Last night, I realized that this problem extends to the clang/tests as well,
not just those in clang-tools-extra. Is there someone who knows Windows, Git,
and the testing pipeline that can weigh in more on this topic?
https://reviews.llvm.org/D28419
__
probinson added a comment.
In https://reviews.llvm.org/D28404#641606, @mehdi_amini wrote:
> If we want to support `-O0 -flto` and `optnone` it the way to convey this to
> the optimizer, I don't see the alternative.
optsize != -Os (according to Chandler)
minsize != -Oz (according to Chandler)
o
I didn't manage to reproduce this. Does adding ${PTHREAD_LIB} to
LINK_LIBS of tools/clang/tools/extra/include-fixer/plugin/CMakeLists.txt
help?
On Tue, Jan 10, 2017 at 8:31 PM, Bill Seurer wrote:
> On 01/09/2017 09:18 AM, Benjamin Kramer via cfe-commits wrote:
>>
>> Author: d0k
>> Date: Mon Jan
dim updated this revision to Diff 83843.
dim added a comment.
- Move `_LIBCPP_THREAD_SAFETY_ANNOTATION` macro definition to `__config`.
- Add `_LIBCPP_THREAD_SAFETY_ANNOTATION(no_thread_safety_analysis)` macros to
`__threading_support` function declarations which require them.
Note that I was no
Author: phosek
Date: Tue Jan 10 13:51:17 2017
New Revision: 291592
URL: http://llvm.org/viewvc/llvm-project?rev=291592&view=rev
Log:
[CMake][libcxx] Move Python check to main CMake file
This is to make sure this check is called even when building as
part of LLVM runtimes when we are doing standal
mehdi_amini added a comment.
In https://reviews.llvm.org/D28404#641632, @probinson wrote:
> In https://reviews.llvm.org/D28404#641606, @mehdi_amini wrote:
>
> > If we want to support `-O0 -flto` and `optnone` it the way to convey this
> > to the optimizer, I don't see the alternative.
>
>
> opts
weimingz created this revision.
weimingz added reviewers: olista01, jmolloy.
weimingz added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
This patch adds diagnoses when initializing a global variable using the address
of another global variable that uses ROPI/RWPI reloc
jtony created this revision.
jtony added reviewers: nemanjai, kbarton, sfertile, lei, syzaara.
jtony added subscribers: llvm-commits, cfe-commits, hfinkel, echristo.
vec_rlnm was implemented according to the old ABI, which was wrong. The ABI
team have fixed the issue (although not published yet).
yaxunl added inline comments.
Comment at: docs/UsersManual.rst:2003
+ $ clang -target nvptx64-unknown-unknown test.cl
+ $ clang -target amdgcn-unknown-amdhsa test.cl
+
$ clang -target amdgcn-amd-amdhsa-opencl test.cl
Comment at: docs/Us
dim added a comment.
Hmm, actually this does not work. The definition of
`_LIBCPP_THREAD_SAFETY_ANNOTATION` I moved from `__mutex_base` to `__config` is
only enabled if `_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS` is manually defined.
There must have been some reason to do it like this in `__mut
niravd updated this revision to Diff 83850.
niravd marked 2 inline comments as done.
niravd added a comment.
Address comments
https://reviews.llvm.org/D28001
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CodeGenFunction.cpp
lib/Driver/Tools
niravd added inline comments.
Comment at: include/clang/Driver/Options.td:1731
def mno_pie_copy_relocations : Flag<["-"], "mno-pie-copy-relocations">,
Group;
+def mfentry : Flag<["-"], "mfentry">, HelpText<"insert calls to fentry at
function entry">, Flags<[CC1Option]>, Group;
Author: rsmith
Date: Tue Jan 10 14:19:21 2017
New Revision: 291596
URL: http://llvm.org/viewvc/llvm-project?rev=291596&view=rev
Log:
Fix conversion index / argument index mismatch when diagnosing overload
resolution failure.
Modified:
cfe/trunk/lib/Sema/SemaOverload.cpp
cfe/trunk/test/Se
dim updated this revision to Diff 83851.
dim added a comment.
Let's try this simpler version instead.
https://reviews.llvm.org/D28520
Files:
include/__threading_support
Index: include/__threading_support
===
--- include/__threa
1 - 100 of 144 matches
Mail list logo
