chandlerc requested changes to this revision.
chandlerc added a comment.
This revision now requires changes to proceed.

There are some issues with this patch currently.

At a basic level, it needs well crafted test cases. You can find out how to 
write them by looking at other Driver tests.

But at a deeper level, the change here will be an very significant and 
potentially very disruptive change. While libunwind is your motivation, it 
could well have a dramatic impact on the selected set of libraries for links. 
I'm very concerned to make this kind of change without a *lot* of careful 
testing, and a very clear rationale about why this is the right search order 
*for all libraries*, not just libunwind. Because this applies to all libraries. 
=]


https://reviews.llvm.org/D26244



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to