[PATCH] D28189: Extend documentation of how to test clang-tidy checks.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Awesome! Thank you for adding clarity to this part. Looks good with a couple of nits. Comment at: docs/clang-tidy/index.rst:550 +separate `FileCheck`_ invocations: once with

[PATCH] D28189: Extend documentation of how to test clang-tidy checks.

alexfh added inline comments. Comment at: docs/clang-tidy/index.rst:558 +typically the basic `CHECK` forms (`CHECK-MESSAGES` and `CHECK-FIXES`) +are sufficient for matcher tests. Note that the `FileCheck` +documentation mostly assumes the default prefix (`CHECK`), and hence

Re: r290773 - Wdocumentation fix

On 30/12/2016 23:12, Richard Smith wrote: On 30 Dec 2016 3:06 pm, "Simon Pilgrim via cfe-commits" mailto:cfe-commits@lists.llvm.org>> wrote: Author: rksimon Date: Fri Dec 30 16:55:33 2016 New Revision: 290773 URL: http://llvm.org/viewvc/llvm-project?rev=290773&view=rev

[PATCH] D21298: [Clang-tidy] delete null check

SilverGeri updated this revision to Diff 82760. SilverGeri added a comment. reduce number `hasCondition` to 1; add FIXME comment; shorten check comments in test https://reviews.llvm.org/D21298 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/DeleteNullPointerCheck.cpp

[PATCH] D21298: [Clang-tidy] delete null check

SilverGeri marked 5 inline comments as done. SilverGeri added inline comments. Comment at: docs/clang-tidy/checks/readability-delete-null-pointer.rst:7 +Checks the 'if' statements where a pointer's existence is checked and then deletes the pointer. +The check is unnecessary as d

[clang-tools-extra] r290784 - [clang-tidy] Add delete null pointer check.

Author: xazax Date: Sat Dec 31 06:45:59 2016 New Revision: 290784 URL: http://llvm.org/viewvc/llvm-project?rev=290784&view=rev Log: [clang-tidy] Add delete null pointer check. This check detects and fixes redundant null checks before deletes. Patch by: Gergely Angeli! Differential Revision: htt

[PATCH] D21298: [Clang-tidy] delete null check

This revision was automatically updated to reflect the committed changes. Closed by commit rL290784: [clang-tidy] Add delete null pointer check. (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D21298?vs=82760&id=82761#toc Repository: rL LLVM https://reviews.llvm.org/D

[PATCH] D28081: Make GetStyle return Expected instead of FormatStyle

amaiorano added a comment. Hello everyone, so after a few more tests, I've uncovered a bug and perhaps a different meaning for fallback style. First, the bug: if you set fallback style to "none", clang-format will perform no replacements. This happens because getStyle will first initialize its

[libcxx] r290785 - remove some inherited attributes on exceptions

Author: compnerd Date: Sat Dec 31 11:34:26 2016 New Revision: 290785 URL: http://llvm.org/viewvc/llvm-project?rev=290785&view=rev Log: remove some inherited attributes on exceptions These exception types are marked with `_LIBCPP_EXCEPTION_ABI` which expands to `__attribute__((__visibility__("defa

[libcxxabi] r290788 - clean up `-Wmisleading-indentation` warning

Author: compnerd Date: Sat Dec 31 12:09:51 2016 New Revision: 290788 URL: http://llvm.org/viewvc/llvm-project?rev=290788&view=rev Log: clean up `-Wmisleading-indentation` warning Clean up the misleading indentation warning from GCC 6. NFC Modified: libcxxabi/trunk/src/cxa_demangle.cpp Modi

[libcxx] r290789 - clean up some qualifier casting

Author: compnerd Date: Sat Dec 31 12:13:34 2016 New Revision: 290789 URL: http://llvm.org/viewvc/llvm-project?rev=290789&view=rev Log: clean up some qualifier casting This cleans up the `-Wqual-cast` warnings from gcc 6 when building libc++. NFC. Modified: libcxx/trunk/include/__std_stream

[libcxx] r290791 - system_error: use strerror_r only for threaded code

Author: compnerd Date: Sat Dec 31 15:24:04 2016 New Revision: 290791 URL: http://llvm.org/viewvc/llvm-project?rev=290791&view=rev Log: system_error: use strerror_r only for threaded code When building libc++ without threading, strerror_r is not used. Define the code only when threading is enable

r290792 - [c++17] Implement P0522R0 as written. This allows a template template argument

Author: rsmith Date: Sat Dec 31 15:41:23 2016 New Revision: 290792 URL: http://llvm.org/viewvc/llvm-project?rev=290792&view=rev Log: [c++17] Implement P0522R0 as written. This allows a template template argument to be specified for a template template parameter whenever the parameter is at least a

r290795 - Fix typo in test case. NFC

Author: kli Date: Sat Dec 31 17:36:47 2016 New Revision: 290795 URL: http://llvm.org/viewvc/llvm-project?rev=290795&view=rev Log: Fix typo in test case. NFC Modified: cfe/trunk/test/OpenMP/teams_distribute_parallel_for_simd_collapse_messages.cpp Modified: cfe/trunk/test/OpenMP/teams_distr

Re: r290792 - [c++17] Implement P0522R0 as written. This allows a template template argument

On Sat, Dec 31, 2016 at 1:41 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Sat Dec 31 15:41:23 2016 > New Revision: 290792 > > URL: http://llvm.org/viewvc/llvm-project?rev=290792&view=rev > Log: > [c++17] Implement P0522R0 as written. This allows a