This revision was automatically updated to reflect the committed changes.
Closed by commit rL289422: [Driver] Simplify ToolChain::GetCXXStdlibType (NFC)
(authored by Hahnfeld).
Changed prior to commit:
https://reviews.llvm.org/D25669?vs=74948&id=81053#toc
Repository:
rL LLVM
https://reviews
Author: hahnfeld
Date: Mon Dec 12 01:53:47 2016
New Revision: 289422
URL: http://llvm.org/viewvc/llvm-project?rev=289422&view=rev
Log:
[Driver] Simplify ToolChain::GetCXXStdlibType (NFC)
I made the wrong assumption that execution would continue after an error Diag
which led to unneeded complex co
sepavloff updated this revision to Diff 81055.
sepavloff marked 4 inline comments as done.
sepavloff added a comment.
Updated patch.
- Directories which are searched for config files are now defined during
project configuration process using special cmake options.
- Driver do not warn on unused
hfinkel added inline comments.
Comment at: lib/Driver/Driver.cpp:2695
+ // Claim all arguments that come from configuration file, - driver must not
+ // warn about unused argument on them.
Grammar here is a bit odd, how about:
// Claim all arguments that c
rengolin added a comment.
We already massage the triple in many cases, and what goes into IR is not
always the same as what is used in Clang.
Examples are x86_64's "x32" extension to the ABI, ARM -> Thumb triples, adding
compulsory dashes and unknowns (ex. x86_64--linux-gnu), etc.
You just hav
malcolm.parsons added a comment.
The fixit construction looks overly complicated.
All you need to do is change a `,` to a `;` and insert a copy of the type:
<< FixItHint::CreateReplacement(CommaRange, ";")
<< FixItHint::CreateInsertionFromRange(VarLocation, TypeRange)
and insert some whitesp
rengolin resigned from this revision.
rengolin removed a reviewer: rengolin.
rengolin added a comment.
I don't know enough about x86_64's ABI to have a solid opinion.
https://reviews.llvm.org/D26887
___
cfe-commits mailing list
cfe-commits@lists.llv
malcolm.parsons added inline comments.
Comment at: clang-tidy/misc/StringCompareCheck.cpp:25
+ callee(cxxMethodDecl(hasName("compare"),
+ ofClass(classTemplateSpecializationDecl(
+ hasName("::std::basic_string"),
--
sepavloff updated this revision to Diff 81057.
sepavloff added a comment.
Fixed grammar in comment, thanks to Hal Finkel.
https://reviews.llvm.org/D24933
Files:
docs/UsersManual.rst
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Config/config.h.cmake
include/clang/Driver/Dri
rengolin added a comment.
Was this abandoned?
Repository:
rL LLVM
https://reviews.llvm.org/D23610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin added a comment.
Was this abandoned?
Repository:
rL LLVM
https://reviews.llvm.org/D16901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin added a comment.
Was this abandoned? Merged?
https://reviews.llvm.org/D24083
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin added a comment.
So, we found this issue with the different unwinds between Clang and libunwind:
https://llvm.org/bugs/show_bug.cgi?id=31035
Is this related?
https://reviews.llvm.org/D24084
___
cfe-commits mailing list
cfe-commits@lists.l
rmaprath added inline comments.
Comment at: include/__threading_support:193
+// Execute once
+int __libcpp_execute_once(__libcpp_exec_once_flag *flag,
+ void (*init_routine)(void)) {
EricWF wrote:
> These should have `inline`. In fact all
rmaprath updated this revision to Diff 81059.
https://reviews.llvm.org/D27576
Files:
CMakeLists.txt
include/__threading_support
test/CMakeLists.txt
test/libcxx/test/config.py
test/lit.site.cfg.in
Index: test/lit.site.cfg.in
==
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D27473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
Hi Malcolm,
I will look into fixing the two cases only.
argumentCountIs(1) is sufficient to narrow the matching to only string
compare with one argument.
Best regards,
Mads Ravn
On Mon, Dec 12, 2016 at 10:38 AM Malcolm Parsons via Phabricator <
revi...@reviews.llvm.org> wrote:
> malcolm.parsons
rmaprath added inline comments.
Comment at: CMakeLists.txt:121
option(LIBCXXABI_HAS_PTHREAD_API "Ignore auto-detection and force use of
pthread API" OFF)
+option(LIBCXXABI_HAS_EXTERNAL_THREAD_API
+ "Build libc++abi with an externalized threading API.
EricWF wr
rmaprath updated this revision to Diff 81062.
https://reviews.llvm.org/D27575
Files:
CMakeLists.txt
src/config.h
src/cxa_exception.cpp
src/cxa_exception_storage.cpp
src/cxa_guard.cpp
src/cxa_thread_atexit.cpp
src/fallback_malloc.cpp
src/threading_support.h
test/CMakeLists.txt
rmaprath added a comment.
Patch updated with more context.
https://reviews.llvm.org/D27575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath added a comment.
LGTM. Needs approval from @EricWF or @mclow.lists.
https://reviews.llvm.org/D27614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echuraev created this revision.
echuraev added a reviewer: Anastasia.
echuraev added subscribers: cfe-commits, yaxunl, bader.
https://reviews.llvm.org/D27671
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/SemaOpenCL/invalid-kernel.cl
Index: test/SemaOpenCL/in
Author: djasper
Date: Mon Dec 12 06:42:29 2016
New Revision: 289428
URL: http://llvm.org/viewvc/llvm-project?rev=289428&view=rev
Log:
clang-format: Separate out a language kind for ObjC.
While C(++) and ObjC are generally formatted the same way and can be
mixed, people might want to choose differ
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D27557
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
firolino added a comment.
In https://reviews.llvm.org/D27621#619649, @malcolm.parsons wrote:
> The fixit construction looks overly complicated.
> All you need to do is change a `,` to a `;` and insert a copy of the type:
>
> << FixItHint::CreateReplacement(CommaRange, ";")
> << FixItHint::Cr
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM, Thanks!
Comment at: clang-move/tool/ClangMoveMain.cpp:109
OptionsParser.getSourcePathList());
+ // Add "-fparse-all-comments" compile
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: mgorny.
Instead of moving all the helper declarations blindly, this patch
implement an AST-based call graph solution to make clang-move only move used
helper decls to n
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added subscribers: ioeric, cfe-commits.
Remove the CallGraph in addCallee as it is not used in addCallee.
It decouples addCallee from CallGraph, so that we can use CallGraphNode
within our customized CallGraph.
https://review
hokein updated this revision to Diff 81079.
hokein added a comment.
Fix code style.
https://reviews.llvm.org/D27673
Files:
clang-move/CMakeLists.txt
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/UsedHelperDeclFinder.cpp
clang-move/UsedHelperDeclFinder.h
test/clang-move/
Author: hokein
Date: Mon Dec 12 08:12:10 2016
New Revision: 289431
URL: http://llvm.org/viewvc/llvm-project?rev=289431&view=rev
Log:
[StaticAnalysis] Remove unnecessary parameter in CallGraphNode::addCallee.
Summary:
Remove the CallGraph in addCallee as it is not used in addCallee.
It decouples a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL289431: [StaticAnalysis] Remove unnecessary parameter in
CallGraphNode::addCallee. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D27674?vs=81078&id=81081#toc
Repository:
rL
Author: d0k
Date: Mon Dec 12 08:41:19 2016
New Revision: 289433
URL: http://llvm.org/viewvc/llvm-project?rev=289433&view=rev
Log:
Use function_ref to avoid allocation in std::function. NFC.
Modified:
cfe/trunk/include/clang/Sema/Sema.h
cfe/trunk/lib/Sema/SemaChecking.cpp
Modified: cfe/tr
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG. I also think it makes the code nicer by breaking out the right functions.
Thanks!
Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76
+
+
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
I believe this is fine.
https://reviews.llvm.org/D26887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
NoQ updated this revision to Diff 81083.
NoQ added a comment.
- Fix crashes on checking properties in categories.
- Address both comments.
https://reviews.llvm.org/D27535
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer
Author: mgorny
Date: Mon Dec 12 09:07:43 2016
New Revision: 289436
URL: http://llvm.org/viewvc/llvm-project?rev=289436&view=rev
Log:
[Driver] Fix finding multilib gcc install on Gentoo (with gcc-config)
Fix the gcc-config code to support multilib gcc installs properly. This
solves two problems: -
firolino added a comment.
In https://reviews.llvm.org/D27621#619649, @malcolm.parsons wrote:
> The fixit construction looks overly complicated.
Yes, you were right. I have changed a couple of things. It looks better now.
Still working on a better getUserWrittenType.
https://reviews.llvm.org/
mgorny added a comment.
Thanks for the review. Committed now.
https://reviews.llvm.org/D26887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL289436: [Driver] Fix finding multilib gcc install on Gentoo
(with gcc-config) (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D26887?vs=78623&id=81086#toc
Repository:
rL LLVM
amaiorano added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76
+
+ Clang Format Document
+
klimek wrote:
> amaiorano wrote:
> > klimek wrote:
> > > hans wrote:
> > > > amaiorano wrote:
> > > > > hans wr
mgorny abandoned this revision.
mgorny added a comment.
I give up. I'm just going to complain to Gentoo ARM people a lot and maybe
they'll fix their triples.
https://reviews.llvm.org/D25686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
arphaman added inline comments.
Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:133
+VariableLocation.setBegin(tidy::utils::lexer::findLocationAfterToken(
+VariableLocation.getEnd(), Tokens, *Result.Context));
+ }
If you use `ArrayR
firolino marked 2 inline comments as done.
firolino added inline comments.
Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:133
+VariableLocation.setBegin(tidy::utils::lexer::findLocationAfterToken(
+VariableLocation.getEnd(), Tokens, *Result.Context)
Anastasia added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8127
"invalid prototype, variadic arguments are not allowed in OpenCL">;
+def err_requires_extension : Error<
+ "use of %select{declaration|type }0%1 requires %2 extension to be enabled">;
Author: mgorny
Date: Mon Dec 12 10:04:37 2016
New Revision: 289440
URL: http://llvm.org/viewvc/llvm-project?rev=289440&view=rev
Log:
[Driver] Attempt to fix new linux-ld tests on Windows
(broken by r289436)
Modified:
cfe/trunk/test/Driver/linux-ld.c
Modified: cfe/trunk/test/Driver/linux-ld.
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
https://reviews.llvm.org/D27671
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Author: filcab
Date: Mon Dec 12 10:18:40 2016
New Revision: 289444
URL: http://llvm.org/viewvc/llvm-project?rev=289444&view=rev
Log:
[clang] Version support for UBSan handlers
This adds a way for us to version any UBSan handler by itself.
The patch overrides D21289 for a better implementation (we
This revision was automatically updated to reflect the committed changes.
Closed by commit rL289444: [clang] Version support for UBSan handlers (authored
by filcab).
Changed prior to commit:
https://reviews.llvm.org/D21695?vs=61817&id=81089#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
Anastasia added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:9624
+ if (getLangOpts().OpenCL && getLangOpts().OpenCLVersion >= 200) {
+if (LHSIsNull && RHSType->isQueueT()) {
getLangOpts().OpenCL is redundant because getLangOpts().OpenCLVersion is on
yaxunl added a comment.
> Because, notably, if you do that, then an attempt to pass &x as an int* will
> fail, which means this isn't really C++ anymore... and yet that appears to be
> exactly what you want.
How about when generating alloca instruction, I insert addrspacecast to the
default ad
ahatanak updated this revision to Diff 81090.
ahatanak added a comment.
Address review comments.
- Arrays marked "flexible_array" are now treated as flexible arrays.
- __builtin_object_size returns a more accurate numbers for normal C99 flexible
arrays (see test/CodeGen/object-size.c).
Note tha
Author: filcab
Date: Mon Dec 12 10:43:40 2016
New Revision: 289446
URL: http://llvm.org/viewvc/llvm-project?rev=289446&view=rev
Log:
[Fix] Add missing include from r289444.
Modified:
cfe/trunk/lib/CodeGen/CGExpr.cpp
Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp
URL:
http://llvm.org/viewvc/llvm
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/cppcoreguidelines/NoMallocCheck.cpp:54
+
+void NoMallocCheck::handleAquisition(const CallExpr *AquisitionCall) {
+ diag(AquisitionCall->
rnk added inline comments.
Comment at: lib/Basic/SourceManager.cpp:1447
+void SourceManager::getChecksumMD5(FileID FID, std::string &Checksum) const {
+ bool Invalid;
Let's move this whole thing to CGDebugInfo::getOrCreateFile. SourceManager
isn't caching or
dcoughlin added a comment.
In https://reviews.llvm.org/D26768#619222, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D26768#618651, @dcoughlin wrote:
>
> > The definite false positives were cases where the programmer seemed aware
> > of the semantics of virtual calls during construction/d
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
This looks good to me, I'll merge this today unless I hear otherwise.
Repository:
rL LLVM
https://reviews.llvm.org/D26846
___
cfe-commits mailing li
firolino updated this revision to Diff 81101.
firolino marked an inline comment as done.
firolino added a comment.
Simplified fix-it hint generation.
https://reviews.llvm.org/D27621
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/OneNamePerDeclarationCheck.cpp
clang-ti
ahatanak added a subscriber: cfe-commits.
ahatanak added a comment.
Add cfe-commits.
https://reviews.llvm.org/D27680
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT added a comment.
Hmm, would a pragma guarded by _MSC_VER be better? I can easily do that. I've
tried to avoid cluttering the test with VC-specific pragmas, but I understand
your concern about initializing too much memory.
https://reviews.llvm.org/D27555
malcolm.parsons added inline comments.
Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:86
+
+ Diag << FixItHint::CreateReplacement(CommaRange, ";")
+ << FixItHint::CreateReplacement(AfterCommaToVarNameRange,
A `SourceLocation` can
STL_MSFT added a comment.
Yeah, users are free to do this, which also triggers conversion warnings for
us. I think I'll need to investigate actually fixing/suppressing them in our
sources and abandoning this patch; leaving it open for now as a todo.
https://reviews.llvm.org/D27270
_
JonasToth marked 3 inline comments as done.
JonasToth added a comment.
removed the function calls, a little doc tidy as well
Repository:
rL LLVM
https://reviews.llvm.org/D26167
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
JonasToth updated this revision to Diff 81103.
JonasToth added a comment.
fixes last review comments from alex
Repository:
rL LLVM
https://reviews.llvm.org/D26167
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/
Author: sfantao
Date: Mon Dec 12 12:00:20 2016
New Revision: 289450
URL: http://llvm.org/viewvc/llvm-project?rev=289450&view=rev
Log:
Fix format and a few typos in comments.
Modified:
cfe/trunk/include/clang-c/Index.h
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
cfe/trunk/lib/Sema/SemaOp
STL_MSFT added a comment.
Actually, the compiler bug was resolved as fixed earlier today. Verifying...
https://reviews.llvm.org/D27555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
andrewford added a comment.
This broke the build on android due to use of std::to_string. Would someone
mind changing it to llvm::to_string, I don't have commit access to change it
myself. Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D21695
___
On Fri, Dec 9, 2016 at 2:55 PM Simon Pilgrim via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rksimon
> Date: Fri Dec 9 16:45:21 2016
> New Revision: 289285
>
> URL: http://llvm.org/viewvc/llvm-project?rev=289285&view=rev
> Log:
> Fix unused variable warnings. NFCI.
>
> Modified:
>
alexshap added inline comments.
Comment at: clang-move/tool/ClangMoveMain.cpp:109
OptionsParser.getSourcePathList());
+ // Add "-fparse-all-comments" compile option to make clang parse all comments
+ Tool.appendArgumentsAdjuster(tooling::getInse
Author: vedantk
Date: Mon Dec 12 12:47:33 2016
New Revision: 289452
URL: http://llvm.org/viewvc/llvm-project?rev=289452&view=rev
Log:
Avoid use of std::to_string. NFC.
Apparently this routine isn't available on some Android platforms. See
the mailing list thread re: D21695.
Modified:
cfe/tru
> On Dec 12, 2016, at 10:17 AM, Andrew Ford via Phabricator
> wrote:
>
> andrewford added a comment.
>
> This broke the build on android due to use of std::to_string. Would someone
> mind changing it to llvm::to_string, I don't have commit access to change it
> myself. Thanks!
Should be don
Thanks Vedant!
Andrew: does Android not support C++11? I don't understand why it wouldn't
have these funcions.
Thank you,
Filipe
On Mon, 12 Dec 2016 at 18:58, Vedant Kumar wrote:
>
>
> > On Dec 12, 2016, at 10:17 AM, Andrew Ford via Phabricator <
> revi...@reviews.llvm.org> wrote:
>
> >
>
> >
bruno added inline comments.
Comment at: include/clang/Driver/Driver.h:287
+ const std::string &getConfigFile() const { return ConfigFile; }
+ void setConfigFile(StringRef x, unsigned N) {
+ConfigFile = x;
x -> FileName
Comment at: lib/Dr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL289455: Bring back note about not supporting global register
variables. (authored by mkuper).
Changed prior to commit:
https://reviews.llvm.org/D27473?vs=80450&id=81113#toc
Repository:
rL LLVM
https
Author: mkuper
Date: Mon Dec 12 13:11:39 2016
New Revision: 289455
URL: http://llvm.org/viewvc/llvm-project?rev=289455&view=rev
Log:
Bring back note about not supporting global register variables.
This was accidentally removed in r260506, even though we only support
non-allocatable global registe
While it's possible to do arbitrary script things - we prefer nto to to
ensure the tests are portable. (we have some custom implementations of
common unix utilities for portability of those).
In this case, can you xfail this on platforms that don't have the feature
you want? rather than trying to
jlebar added a comment.
@alexfh , friendly ping. I'm not in a huge rush on this or anything, but I
don't want one or both of us to lose all context here...
https://reviews.llvm.org/D27284
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
Author: sfantao
Date: Mon Dec 12 13:26:31 2016
New Revision: 289458
URL: http://llvm.org/viewvc/llvm-project?rev=289458&view=rev
Log:
Fix typo and remove unnecessary statement.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
URL:
http:
Author: bruno
Date: Mon Dec 12 13:28:21 2016
New Revision: 289459
URL: http://llvm.org/viewvc/llvm-project?rev=289459&view=rev
Log:
[Frontend] Use vfs for directory iteration while searching PCHs. NFCI
Use the vfs lookup instead of real filesytem and handle the case where
-include-pch is a direct
Author: bruno
Date: Mon Dec 12 13:28:25 2016
New Revision: 289460
URL: http://llvm.org/viewvc/llvm-project?rev=289460&view=rev
Log:
[CrashReproducer] Collect PCH included via -include-pch
Collect the necessary input PCH files.
Do not try to validate the AST before copying it out because if the
c
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Nice, the patch looks good to me.
Comment at:
docs/clang-tidy/checks/readability-redundant-function-ptr-dereference.rst:25
+ int i = (*p)(10, 50);
+
Nit: a
Thanks for double-checking this. I realized that there's a problem with my
patch: skipping the encoding step when using Python 3 could cause problems when
we use difflib.SequenceMatcher.
I don't know how to fix this, since the strings in vim.current.buffer appear to
be 'raw'. They are not encoded
Author: stl_msft
Date: Mon Dec 12 13:50:22 2016
New Revision: 289463
URL: http://llvm.org/viewvc/llvm-project?rev=289463&view=rev
Log:
[libcxx] [test] Change ifstream constructor tests to handle read-only files.
Certain source control systems like to set the read-only bit on their files,
which in
Author: stl_msft
Date: Mon Dec 12 13:50:14 2016
New Revision: 289462
URL: http://llvm.org/viewvc/llvm-project?rev=289462&view=rev
Log:
[libcxx] [test] Fix an improper assumption about Null Forward Iterators.
Value-initialized iterators still can't be compared to those with parents.
Fixes D26626.
Author: alexshap
Date: Mon Dec 12 13:56:37 2016
New Revision: 289464
URL: http://llvm.org/viewvc/llvm-project?rev=289464&view=rev
Log:
[clang-move] Use appendArgumentsAdjuster for adding extra arguments
1. Remove some boilerplate code for appending -fparse-all-comments to the list
of arguments.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL289464: [clang-move] Use appendArgumentsAdjuster for adding
extra arguments (authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D27669?vs=81052&id=81124#toc
Repository:
rL LLVM
george.burgess.iv added a comment.
Glad you like it!
> The second thing that would be amazing if this attribute was late parsed so
> it the ability to reference this when applied to member functions
That seems like a good idea; I'll look into what that would take. (In the
meantime, reviews wou
Author: alexshap
Date: Mon Dec 12 14:24:44 2016
New Revision: 289465
URL: http://llvm.org/viewvc/llvm-project?rev=289465&view=rev
Log:
[clang-move] Fix buildbot failures
Fix the buildbot failures introduced by D27669
Modified:
clang-tools-extra/trunk/clang-move/tool/ClangMoveMain.cpp
Modifi
STL_MSFT abandoned this revision.
STL_MSFT added a comment.
Verified compiler fix. Abandoning this patch - nothing has been committed.
https://reviews.llvm.org/D27555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
STL_MSFT abandoned this revision.
STL_MSFT added a comment.
r289358 fixes everything for me, thanks! Abandoning this revision.
https://reviews.llvm.org/D26623
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
Sunil_Srivastava added a comment.
A friendly ping.
https://reviews.llvm.org/D22057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I looked at what's supported by "requires", and couldn't find anything
appropriate.
The problem is that I want the test to be sensitive to the size of long
double -- either no greater than 64 bits, or greater than 64 bits. It does
not seem practical to list all platforms (so I suspect your "xfail
bruno added a comment.
Ping!
https://reviews.llvm.org/D27546
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
majnemer added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.h:619
+bool hasLabel(const LabelDecl *LD) const {
+ return std::find(Labels.begin(), Labels.end(), LD) != Labels.end();
+}
This can be written as `llvm::is_contained(Labels, LD);
yixiang added a comment.
Ping.
For the additional requirements of adding a style options:
- be used in a project of significant size (have dozens of contributors)
- Yes, it's been used by almost all the iOS projects inside Google, including
Google Maps.
- have a publicly accessible style guid
yaxunl updated this revision to Diff 81142.
yaxunl marked 9 inline comments as done.
yaxunl added a comment.
Revised by Anastasia's comments.
https://reviews.llvm.org/D21698
Files:
include/clang/Basic/DiagnosticParseKinds.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basic/O
On Mon, Dec 12, 2016 at 1:11 PM David Gross wrote:
> I looked at what's supported by "requires", and couldn't find anything
> appropriate.
>
> The problem is that I want the test to be sensitive to the size of long
> double -- either no greater than 64 bits, or greater than 64 bits. It does
> no
hiraditya added a comment.
Ping
https://reviews.llvm.org/D27068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Mon Dec 12 16:41:20 2016
New Revision: 289478
URL: http://llvm.org/viewvc/llvm-project?rev=289478&view=rev
Log:
[Modules] Make header inclusion order from umbrella dirs deterministic
Sort the headers by name before adding the includes in
collectModuleHeaderIncludes. This makes
manmanren created this revision.
manmanren added reviewers: rsmith, benlangmuir, aprantl.
manmanren added subscribers: bruno, cfe-commits, dexonsmith.
We change ASTFileSignature from a random 32-bit number to the actual SHA hash
of the pcm content.
1> Definition of ASTFileSignature is moved to B
firolino marked an inline comment as done.
firolino added inline comments.
Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:87
+ Diag << FixItHint::CreateReplacement(CommaRange, ";")
+ << FixItHint::CreateReplacement(AfterCommaToVarNameRange,
+
1 - 100 of 128 matches
Mail list logo
