Author: hokein Date: Mon Dec 12 08:12:10 2016 New Revision: 289431 URL: http://llvm.org/viewvc/llvm-project?rev=289431&view=rev Log: [StaticAnalysis] Remove unnecessary parameter in CallGraphNode::addCallee.
Summary: Remove the CallGraph in addCallee as it is not used in addCallee. It decouples addCallee from CallGraph, so that we can use CallGraphNode within our customized CallGraph. Reviewers: bkramer Subscribers: cfe-commits, ioeric Differential Revision: https://reviews.llvm.org/D27674 Modified: cfe/trunk/include/clang/Analysis/CallGraph.h cfe/trunk/lib/Analysis/CallGraph.cpp Modified: cfe/trunk/include/clang/Analysis/CallGraph.h URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Analysis/CallGraph.h?rev=289431&r1=289430&r2=289431&view=diff ============================================================================== --- cfe/trunk/include/clang/Analysis/CallGraph.h (original) +++ cfe/trunk/include/clang/Analysis/CallGraph.h Mon Dec 12 08:12:10 2016 @@ -157,7 +157,7 @@ public: inline bool empty() const {return CalledFunctions.empty(); } inline unsigned size() const {return CalledFunctions.size(); } - void addCallee(CallGraphNode *N, CallGraph *CG) { + void addCallee(CallGraphNode *N) { CalledFunctions.push_back(N); } Modified: cfe/trunk/lib/Analysis/CallGraph.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/CallGraph.cpp?rev=289431&r1=289430&r2=289431&view=diff ============================================================================== --- cfe/trunk/lib/Analysis/CallGraph.cpp (original) +++ cfe/trunk/lib/Analysis/CallGraph.cpp Mon Dec 12 08:12:10 2016 @@ -55,7 +55,7 @@ public: void addCalledDecl(Decl *D) { if (G->includeInGraph(D)) { CallGraphNode *CalleeNode = G->getOrInsertNode(D); - CallerNode->addCallee(CalleeNode, G); + CallerNode->addCallee(CalleeNode); } } @@ -154,7 +154,7 @@ CallGraphNode *CallGraph::getOrInsertNod Node = llvm::make_unique<CallGraphNode>(F); // Make Root node a parent of all functions to make sure all are reachable. if (F) - Root->addCallee(Node.get(), this); + Root->addCallee(Node.get()); return Node.get(); } _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
