Author: smeenai
Date: Wed Nov 9 17:52:20 2016
New Revision: 286419
URL: http://llvm.org/viewvc/llvm-project?rev=286419&view=rev
Log:
[Sema] Use MS ABI behavior for dllexport in Itanium
Similar to r284288, make the Itanium ABI follow MS ABI dllexport
semantics in the case of an explicit instantia
Author: akirtzidis
Date: Wed Nov 9 17:58:39 2016
New Revision: 286421
URL: http://llvm.org/viewvc/llvm-project?rev=286421&view=rev
Log:
[libclang] Fix issue with clang_tokenize and make sure it interprets
CXSourceRange as half-open character range.
Patch provided by Emilio Cobos Álvarez! (https
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286419: [Sema] Use MS ABI behavior for dllexport in Itanium
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D26471?vs=77392&id=77418#toc
Repository:
rL LLVM
https://reviews.
dcoughlin added a comment.
Thanks for adding the path notes and adopting CallDescription. I've added some
additional comments inline, which are mostly minor nits.
Two additional important changes -- and I should have noted these in the
initial review -- is that it would be good to remove a MemR
dcoughlin added a comment.
In https://reviews.llvm.org/D26340#590882, @khazem wrote:
> Devin, based on Artem's review of the other checker that I have posted [1] I
> am wondering about merging both this SpinLockChecker and the MutexChecker
> into PthreadLockChecker. Do you think it is still wor
zaks.anna added a comment.
> Added a python script to merge gcov files.
When the patches that are being reviewed are growing new functionality, it's
much more difficult to review them. Please, submit the python script as a
separate patch.
Comment at: lib/StaticAnalyzer/Core/
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
I've not looked at all of the test changes in detail, but this looks fine to me.
https://reviews.llvm.org/D26452
___
jordan_rose added a comment.
Ah, my apologies, @ahatanak. I was testing against the Swift branch of Clang.
Repository:
rL LLVM
https://reviews.llvm.org/D26108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
ahatanak added a comment.
In https://reviews.llvm.org/D26108#591270, @jordan_rose wrote:
> Ah, my apologies, @ahatanak. I was testing against the Swift branch of Clang.
That's OK. I haven't tested it yet, but the patch itself looks fine to me.
Comment at: lib/Sema/SemaType.c
jordan_rose added inline comments.
Comment at: lib/Sema/SemaType.cpp:3988
// Allow arrays of auto if we are a generic lambda parameter.
// i.e. [](auto (&array)[5]) { return array[0]; }; OK
if (AT && D.getContext() != Declarator::LambdaExprParameterContext) {
Author: flx
Date: Wed Nov 9 19:28:22 2016
New Revision: 286424
URL: http://llvm.org/viewvc/llvm-project?rev=286424&view=rev
Log:
[clang-tidy] Do not issue fix for functions that are referenced outside of
callExpr
Summary: Suppress fixes for functions that are referenced within the
compilation u
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286424: [clang-tidy] Do not issue fix for functions that are
referenced outside of… (authored by flx).
Changed prior to commit:
https://reviews.llvm.org/D26203?vs=77343&id=77430#toc
Repository:
rL LL
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL286148.
https://reviews.llvm.org/D26354
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL284179.
https://reviews.llvm.org/D25522
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
alekseyshl updated this revision to Diff 77432.
alekseyshl marked 2 inline comments as done.
alekseyshl added a comment.
- Rename new options to better reflect their functionality.
https://reviews.llvm.org/D26461
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
alekseyshl added inline comments.
Comment at: test/Driver/fsanitize.c:288
+// RUN: %clang -target x86_64-linux-gnu -fsanitize=thread
-fsanitize-thread-data-races -fno-sanitize-thread-data-races %s -### 2>&1 |
FileCheck %s --check-prefix=CHECK-TSAN-DATA-RACES-OFF
+// CHECK-TSAN-
zaks.anna marked 4 inline comments as done.
zaks.anna added inline comments.
Comment at: test/CodeGen/sanitize-thread-no-checking-at-run-time.m:1
+// RUN: %clang_cc1 -triple x86_64-apple-darwin -x objective-c++ -emit-llvm -o
- %s | FileCheck -check-prefix=WITHOUT %s
+// RUN: %cl
zaks.anna updated this revision to Diff 77435.
zaks.anna marked an inline comment as done.
https://reviews.llvm.org/D25857
Files:
lib/CodeGen/CodeGenFunction.cpp
test/CodeGen/sanitize-thread-no-checking-at-run-time.m
Index: test/CodeGen/sanitize-thread-no-checking-at-run-time.m
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Looks good, thanks!
https://reviews.llvm.org/D25764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
ahatanak added inline comments.
Comment at: lib/Sema/SemaType.cpp:3988
// Allow arrays of auto if we are a generic lambda parameter.
// i.e. [](auto (&array)[5]) { return array[0]; }; OK
if (AT && D.getContext() != Declarator::LambdaExprParameterContext) {
--
ahatanak added a comment.
Do you think we can transform the Exprs for the uninstantiated default
arguments in TreeTransform::TransformLambdaExpr? I guess it would be
much simpler than trying to make getTemplateInstantiationArgs return the
correct template arguments.
https://reviews.llvm.org/D
srhines created this revision.
srhines added subscribers: danalbert, eugenis, pirama, cfe-commits.
Herald added a subscriber: tberghammer.
This macro should be defined only when the user directly specifies an
API level as part of an Android target. For any regular Android target,
we leave this mac
srhines updated this revision to Diff 77446.
srhines added a comment.
Added bug link to commit message.
https://reviews.llvm.org/D26491
Files:
lib/Basic/Targets.cpp
test/Preprocessor/init.c
Index: test/Preprocessor/init.c
===
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL286427: [clang-move] Support template class. (authored by
hokein).
Changed prior to commit:
https://reviews.llvm.org/D26423?vs=77292&id=77447#toc
Repository:
Author: hokein
Date: Wed Nov 9 23:33:26 2016
New Revision: 286427
URL: http://llvm.org/viewvc/llvm-project?rev=286427&view=rev
Log:
[clang-move] Support template class.
Reviewers: ioeric
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D26423
Added:
clang-tools-ext
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
Add decent blank line between declarations.
https://reviews.llvm.org/D26493
Files:
clang-move/ClangMove.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTe
nkakuev added a comment.
@alexfh, you're welcome!
Can you please commit this patch?
https://reviews.llvm.org/D26466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added a comment.
Ping
https://reviews.llvm.org/D22955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
ping
https://reviews.llvm.org/D25669
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
ping
https://reviews.llvm.org/D26244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 130 of 130 matches
Mail list logo
