dcoughlin added a comment.

In https://reviews.llvm.org/D26340#590882, @khazem wrote:

> Devin, based on Artem's review of the other checker that I have posted [1] I 
> am wondering about merging both this SpinLockChecker and the MutexChecker 
> into PthreadLockChecker. Do you think it is still worth landing this 
> SpinLockChecker, or do you suppose that abandoning this patch and working on 
> merging all the checkers would be a good idea? I've noted how the checkers 
> might be merged in my reply to Artem: [2].


Merging seems reasonable to me. It is also a good way to make it less likely 
that the Magenta checkers accidentally regress since the main logic of the 
checker will be exercised when checking a much more common API.


https://reviews.llvm.org/D26340



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to