malcolm.parsons added a comment.
In https://reviews.llvm.org/D26418#590383, @nkakuev wrote:
> The warning is caused by a third-party code, but header filter won't help you
> to suppress it since it now relates to your sources.
The header filter suppresses the warning location, but the note loc
neil.hickey updated this revision to Diff 77321.
neil.hickey added a comment.
Moving location of no-diagnostics statement to beginning of file
https://reviews.llvm.org/D24235
Files:
lib/Sema/SemaExpr.cpp
lib/Sema/SemaType.cpp
test/CodeGenOpenCL/fpmath.cl
test/SemaOpenCL/extensions.cl
I
malcolm.parsons added inline comments.
Comment at: include/clang/Sema/DeclSpec.h:1314
for (unsigned I = 0; I < NumParams; ++I) {
-delete Params[I].DefaultArgTokens;
-Params[I].DefaultArgTokens = nullptr;
+Params[I].DefaultArgTokens.release();
arphaman added inline comments.
Comment at: include/clang/Sema/DeclSpec.h:1313
void freeParams() {
for (unsigned I = 0; I < NumParams; ++I) {
+Params[I].DefaultArgTokens.release();
You can elide the curly braces here now that the loop has just
arphaman accepted this revision.
arphaman added a reviewer: arphaman.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
nkakuev added a comment.
In https://reviews.llvm.org/D26418#590417, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D26418#590383, @nkakuev wrote:
>
> > The warning is caused by a third-party code, but header filter won't help
> > you to suppress it since it now relates to your sources.
>
Author: arphaman
Date: Wed Nov 9 04:38:57 2016
New Revision: 286354
URL: http://llvm.org/viewvc/llvm-project?rev=286354&view=rev
Log:
[Sema] Avoid -Wshadow warnings for shadowed variables that aren't captured
by lambdas with an explicit capture list
This commit avoids the -Wshadow warning for va
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286354: [Sema] Avoid -Wshadow warnings for shadowed
variables that aren't captured (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D26278?vs=77205&id=77328#toc
Repository:
r
nkakuev added a comment.
In https://reviews.llvm.org/D26418#590417, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D26418#590383, @nkakuev wrote:
>
> > The warning is caused by a third-party code, but header filter won't help
> > you to suppress it since it now relates to your sources.
>
malcolm.parsons resigned from this revision.
malcolm.parsons removed a reviewer: malcolm.parsons.
malcolm.parsons added a comment.
In https://reviews.llvm.org/D26418#590476, @nkakuev wrote:
> On a second thought, ignoring note locations might be a good enough solution
> for me.
> How should I d
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286356: [VFS] Replace TimeValue usage with std::chrono
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D25948?vs=75723&id=77330#toc
Repository:
rL LLVM
https://reviews.llvm.o
Author: labath
Date: Wed Nov 9 04:52:22 2016
New Revision: 286356
URL: http://llvm.org/viewvc/llvm-project?rev=286356&view=rev
Log:
[VFS] Replace TimeValue usage with std::chrono
Summary: NFCI
Reviewers: benlangmuir, zturner
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm
andreadb added inline comments.
Comment at: lib/Headers/x86intrin.h:49
+static __inline__ unsigned int __attribute__((__always_inline__, __nodebug__))
+__tzcnt_u32(unsigned int __X) { return __X ? __builtin_ctz(__X) : 32; }
+#ifdef __x86_64__
hans wrote:
> probin
Author: labath
Date: Wed Nov 9 05:19:39 2016
New Revision: 286357
URL: http://llvm.org/viewvc/llvm-project?rev=286357&view=rev
Log:
Replace TimeValue with TimePoint in BuildSystem.cpp. NFC.
Modified:
cfe/trunk/tools/libclang/BuildSystem.cpp
Modified: cfe/trunk/tools/libclang/BuildSystem.cpp
sepavloff added a comment.
> For Chromium, our build system provides a specific Clang version close to
> ToT, and obviously what flags to use when invoking it. (Developers can of
> course override the flags when configuring if they want.) Now maybe a
> developer has a ~/clang.cfg because they w
arphaman created this revision.
arphaman added reviewers: rnk, rsmith.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This is a follow-up patch to r286354. This patch avoids the -Wshadow warning
for variables which shadow variables that aren't
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286363: [CodeCompletion] Show block invocation results for
block property setters (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D26071?vs=76178&id=77337#toc
Repository:
rL
Author: arphaman
Date: Wed Nov 9 07:43:18 2016
New Revision: 286363
URL: http://llvm.org/viewvc/llvm-project?rev=286363&view=rev
Log:
[CodeCompletion] Show block invocation results for block property setters
This commit changes the code completion results for block property setters:
The default
fhahn updated this revision to Diff 77317.
https://reviews.llvm.org/D25764
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
lib/CodeGen/CGLoopInfo.cpp
lib/CodeGen/CGLoopInfo.h
lib/CodeGen/CGStmt.cpp
lib/CodeGen/CGStmtOpenMP.cpp
lib/CodeGen/CodeGenFunction.cpp
lib/CodeG
fhahn added a comment.
@rjmccall thanks for the feedback. I initially kept the arguments optional
because the single Location argument used to be optional as well.
But I think we can pass proper locations for all loops constructed by clang and
I updated my patch to make the Start and End locati
ilya-palachev created this revision.
ilya-palachev added reviewers: dcoughlin, zaks.anna, NoQ.
ilya-palachev added subscribers: cfe-commits, a.sidorin.
ilya-palachev set the repository for this revision to rL LLVM.
If the pointer to the uninitialized union is casted to the structure of another
ty
Author: arphaman
Date: Wed Nov 9 08:02:18 2016
New Revision: 286365
URL: http://llvm.org/viewvc/llvm-project?rev=286365&view=rev
Log:
[AST] Dump dependent scope member expression with its member name
Modified:
cfe/trunk/lib/AST/ASTDumper.cpp
cfe/trunk/test/Misc/ast-dump-stmt.cpp
Modifie
Author: djasper
Date: Wed Nov 9 08:12:55 2016
New Revision: 286367
URL: http://llvm.org/viewvc/llvm-project?rev=286367&view=rev
Log:
clang-format: [TypeScript] Fix bug in handling of non-null operator.
Before:
var i = x!-1;
After:
var i = x! - 1;
Modified:
cfe/trunk/lib/Format/TokenAnn
flx removed rL LLVM as the repository for this revision.
flx updated this revision to Diff 77343.
https://reviews.llvm.org/D26203
Files:
clang-tidy/performance/UnnecessaryValueParamCheck.cpp
test/clang-tidy/performance-unnecessary-value-param.cpp
Index: test/clang-tidy/performance-unnecessa
flx marked an inline comment as done.
flx added a comment.
Thanks for the review!
https://reviews.llvm.org/D26203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added reviewers: rsmith, bruno.
arphaman set the repository for this revision to rL LLVM.
arphaman updated this revision to Diff 77351.
arphaman added a comment.
I rebased the patch, adjusted the test and added a test case for Objective-C
blocks.
Repository:
rL LLVM
https://reviews.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286376: [Sparc] LLONG is not lock-free atomic on v8
(authored by dougk).
Changed prior to commit:
https://reviews.llvm.org/D26286?vs=76879&id=77353#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
Author: dougk
Date: Wed Nov 9 09:43:51 2016
New Revision: 286376
URL: http://llvm.org/viewvc/llvm-project?rev=286376&view=rev
Log:
[Sparc] LLONG is not lock-free atomic on v8
Differential Revision: https://reviews.llvm.org/D26286
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/test/
baloghadamsoftware marked an inline comment as done.
baloghadamsoftware added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:423
+
+void IteratorPastEndChecker::handleComparison(CheckerContext &C,
+
will do. I'll initiate a review for the original change and a new one for
the suggestions.
The ExpectedFunctionGlobalVarMethodOrProperty diagnostic was essentially a
copy-and-paste from here:
def Alias : Attr {
let Spellings = [GCC<"alias">];
let Args = [StringArgument<"Aliasee">];
let Sub
sepavloff created this revision.
sepavloff added reviewers: ABataev, gribozavr, rtrieu.
sepavloff added a subscriber: cfe-commits.
Output generated by option -ast-print looks like C/C++ code, and it
really is for plain C. For C++ the produced output was not valid C++
code, but the differences were
The patch https://reviews.llvm.org/D26452 implements testing for output
made with -ast-print, it fixes problems which this commit addressed
(file declare_simd_ast_print.cpp) and tests them.
Thanks,
--Serge
2016-11-02 23:39 GMT+07:00 Richard Smith :
> Test?
>
> On 30 Oct 2016 10:20 pm, "Serge Pav
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, alexfh, flx.
malcolm.parsons added a subscriber: cfe-commits.
An addition to the move-constructor-init check was duplicating the
modernize-pass-by-value check.
Remove the additional check and UseCERTSemantics op
flx added a comment.
Is the modernize-pass-by-value check configurable in a way to only trigger when
copied constructor arguments are not moved?
I think our use case has been to have move-constructor-init check enabled to
catch cases that can be optimized but not trigger on every constructor th
dougk created this revision.
dougk added a reviewer: aaron.ballman.
dougk added a subscriber: cfe-commits.
This was already submitted as r284272.
Regarding the use of Attr as a local variable name, I would prefer to remain
consistent with the existing code in CodeGenFunction.cpp which was not to
malcolm.parsons added a comment.
In https://reviews.llvm.org/D26453#590636, @flx wrote:
> Is the modernize-pass-by-value check configurable in a way to only trigger
> when copied constructor arguments are not moved?
No; good idea.
https://reviews.llvm.org/D26453
__
malcolm.parsons updated this revision to Diff 77358.
malcolm.parsons added a comment.
Update comment in performance-unnecessary-value-param check.
https://reviews.llvm.org/D26453
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/misc/MoveConstructorInitCheck.cpp
clang-tidy/misc/MoveCon
Thank you!
On Tue, Nov 8, 2016 at 11:57 AM, Daniel Jasper wrote:
> Fixed in r286279.
>
> On Tue, Nov 8, 2016 at 10:45 AM, Galina Kistanova
> wrote:
>
>> Hello Daniel,
>>
>> This commit broke at least one of our builders:
>> http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/234
Author: dougk
Date: Wed Nov 9 11:02:07 2016
New Revision: 286380
URL: http://llvm.org/viewvc/llvm-project?rev=286380&view=rev
Log:
[Sparc] Unbreak test
Modified:
cfe/trunk/test/CodeGen/atomics-inlining.c
Modified: cfe/trunk/test/CodeGen/atomics-inlining.c
URL:
http://llvm.org/viewvc/llvm-p
hans added a comment.
In https://reviews.llvm.org/D24933#590493, @sepavloff wrote:
> > For Chromium, our build system provides a specific Clang version close to
> > ToT, and obviously what flags to use when invoking it. (Developers can of
> > course override the flags when configuring if they w
rogfer01 created this revision.
rogfer01 added reviewers: EricWF, rmaprath, mclow.lists.
rogfer01 added a subscriber: cfe-commits.
Skip tests that expect an exception be thrown under no-exceptions.
https://reviews.llvm.org/D26457
Files:
test/std/utilities/memory/util.smartptr/util.smartptr.s
ioeric created this revision.
ioeric added a reviewer: hokein.
ioeric added a subscriber: cfe-commits.
https://reviews.llvm.org/D26456
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceTests.cpp
=
rogfer01 created this revision.
rogfer01 added reviewers: mclow.lists, EricWF, rmaprath.
rogfer01 added a subscriber: cfe-commits.
Skip tests that expect an exception be thrown.
https://reviews.llvm.org/D26458
Files:
test/std/language.support/support.exception/except.nested/assign.pass.cpp
dougk created this revision.
dougk added a reviewer: aaron.ballman.
dougk added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
ExpectedFunctionGlobalVarMethodOrProperty would previously say "functions and
global variables" instead of "functions, methods, properties, and global
v
dougk updated this revision to Diff 77367.
dougk added a comment.
inadvertent omission of attr-section.c test
https://reviews.llvm.org/D26459
Files:
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/AttributeList.h
test/Sema/attr-section.c
Index
Author: phst
Date: Wed Nov 9 11:47:56 2016
New Revision: 286381
URL: http://llvm.org/viewvc/llvm-project?rev=286381&view=rev
Log:
Fix grammar
"allow" requires a direct object in this case.
Modified:
clang-tools-extra/trunk/include-fixer/tool/clang-include-fixer.el
Modified: clang-tools-ext
malcolm.parsons updated this revision to Diff 77371.
malcolm.parsons updated the summary for this revision.
malcolm.parsons added a comment.
Add ValuesOnly option to modernize-pass-by-value.
https://reviews.llvm.org/D26453
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/misc/MoveConstr
dtarditi updated this revision to Diff 77373.
dtarditi added a comment.
Thanks for the code review feedback - I've addressed it. Yes, we should use
reset() instead of release(). I also deleted the unnecessary brackets. I
don't have commit access, so if this looks good, could someone commit t
kastiglione added a comment.
Thanks @arphaman, are you able to commit this?
https://reviews.llvm.org/D26406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
iid_iunknown created this revision.
iid_iunknown added a reviewer: LukeCheeseman.
iid_iunknown added a subscriber: cfe-commits.
iid_iunknown set the repository for this revision to rL LLVM.
Herald added subscribers: rengolin, aemerson.
This is a simple sema check patch for arguments of `__builtin_
ogoffart created this revision.
ogoffart added reviewers: cfe-commits, rsmith.
Herald added a subscriber: sanjoy.
DiagnosticIDs::getDiagnosticSeverity function turns out to take a lot of time
in getDecomposedLoc. It is called quite often from different places. (For
example from Sema::CheckTempla
NoQ added a comment.
Sorry for inactivity, been thinking quite a bit about this checker. The checker
is very cool because it is an excellent showcase of our API problems in the
realm of C++ checkers. Once the checker is committed, we could try various
things to make it easier to develop other c
> On Nov 8, 2016, at 9:44 AM, Malcolm Parsons wrote:
>
> On 8 November 2016 at 16:59, Alexander Kornienko wrote:
>> On Nov 8, 2016 2:11 AM, "Malcolm Parsons" wrote:
>>> Oh, I was using clang-analyzer-alpha.cplusplus.VirtualCall.
>>>
>>> Should clang-tidy have an option to enable experimental
+ Anna, Alexander, and Artem.
> On Nov 9, 2016, at 10:50 AM, Devin Coughlin via cfe-commits
> wrote:
>
>
>> On Nov 8, 2016, at 9:44 AM, Malcolm Parsons
>> wrote:
>>
>> On 8 November 2016 at 16:59, Alexander Kornienko wrote:
>>> On Nov 8, 2016 2:11 AM, "Malcolm Parsons" wrote:
Oh, I w
nkakuev created this revision.
nkakuev added a reviewer: alexfh.
nkakuev added a subscriber: cfe-commits.
Test cases I've added in review https://reviews.llvm.org/D26218 were too
brittle and weren't working properly.
This patch fixes this.
https://reviews.llvm.org/D26466
Files:
test/clang-ti
nkakuev marked an inline comment as done.
nkakuev added inline comments.
Comment at: test/clang-tidy/nolint.cpp:36
+}
+// CHECK-NOT: trigger_warning.h:{{.*}} warning: The left operand of '>' is a
garbage value
+// CHECK-NOT: :[[@LINE-4]]:{{.*}} note
alexfh wrote
ioeric updated this revision to Diff 77380.
ioeric added a comment.
- Added a test case with type references.
https://reviews.llvm.org/D26456
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceTes
alekseyshl created this revision.
alekseyshl added a reviewer: eugenis.
alekseyshl added a subscriber: cfe-commits.
New clang flags, all default to true:
-f[no-]sanitize-thread-data-races
-f[no-]sanitize-thread-stack-traces
-f[no-]sanitize-thread-atomics
https://reviews.llvm.org/D26461
Files:
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg with a few nits.
Comment at: clang-move/ClangMove.cpp:417
+ if (const auto *FTD = CMD->getDescribedFunctionTemplate())
+UnremovedDeclsInOldHeader.erase(FTD);
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks
Repository:
rL LLVM
https://reviews.llvm.org/D26448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
eugenis added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:735
+ OPT_fno_sanitize_thread_data_races,
+ Opts.SanitizeThreadDataRaces);
+ Opts.SanitizeThreadStackTraces =
It seems common to hardcode the defau
rmaprath added a comment.
LGTM.
https://reviews.llvm.org/D26457
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
This is looking great, Jordan.
Repository:
rL LLVM
https://reviews.llvm.org/D25850
___
cfe-commits mailing list
cfe-commits@lists.ll
rmaprath added a comment.
Not sure if either of these tests add much value to the no-exceptions variant,
using `std::nested_exception` with such a library seem pointless to me. Perhaps
marking these as `UNSUPPORTED` is a better fix?
https://reviews.llvm.org/D26458
__
rmaprath added a comment.
In https://reviews.llvm.org/D26458#590865, @rmaprath wrote:
> Not sure if either of these tests add much value to the no-exceptions
> variant, using `std::nested_exception` with such a library seem pointless to
> me. Perhaps marking these as `UNSUPPORTED` is a better f
eugenis added a comment.
Oh, and this needs a test. See test/Driver/fsanitize.c (search for
-fsanitize-address-use-after-scope as an example).
https://reviews.llvm.org/D26461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
alekseyshl added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:735
+ OPT_fno_sanitize_thread_data_races,
+ Opts.SanitizeThreadDataRaces);
+ Opts.SanitizeThreadStackTraces =
eugenis wrote:
> It seems common t
hokein marked 3 inline comments as done.
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:417
+ if (const auto *FTD = CMD->getDescribedFunctionTemplate())
+UnremovedDeclsInOldHeader.erase(FTD);
+ else
ioeric wrote:
> `erase(FTD
dougk added a comment.
Also note: In this change, the diagnostic messages are correct; it's the enum
name that's bad. The diagnostic message is wrong for the 'section' attribute,
which is fixed by https://reviews.llvm.org/D26459
https://reviews.llvm.org/D26454
__
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:417
+ if (const auto *FTD = CMD->getDescribedFunctionTemplate())
+UnremovedDeclsInOldHeader.erase(FTD);
+ else
hokein wrote:
> ioeric wrote:
> > `erase(FTD ? FTD : CMD)`
> We can
Author: alexfh
Date: Wed Nov 9 14:03:30 2016
New Revision: 286390
URL: http://llvm.org/viewvc/llvm-project?rev=286390&view=rev
Log:
[clang-tidy docs] Recommend using add_new_check.py more
Modified:
clang-tools-extra/trunk/docs/clang-tidy/index.rst
Modified: clang-tools-extra/trunk/docs/clan
khazem added a comment.
Thanks for the detailed review Artem!
I think that it's sensible to try merging this with PthreadLockChecker. In
fact, I could also try merging the SpinLockChecker [1] that I've posted for
review with PthreadLockChecker also, since they all implement similar
functionali
khazem marked 4 inline comments as done.
khazem added a comment.
Devin, based on Artem's review of the other checker that I have posted [1] I am
wondering about merging both this SpinLockChecker and the MutexChecker into
PthreadLockChecker. Do you think it is still worth landing this
SpinLockCh
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
Looks good! I appreciate the refactoring of recordNullabilitySeen
Repository:
rL LLVM
https://reviews.llvm.org/D26108
___
cfe-commit
smeenai abandoned this revision.
smeenai added a comment.
Abandoning this then. In case the new incarnation of the test needs to
overwrite any memory allocation methods, this diff has the most reliable way to
do it on OS X :)
https://reviews.llvm.org/D26150
_
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D26109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
I don't see a better way to do this. Nice meta programming hack.
Repository:
rL LLVM
https://reviews.llvm.org/D26227
___
cfe-commits
This apparently caused https://llvm.org/bugs/show_bug.cgi?id=30527
On Tue, Jun 14, 2016 at 9:54 AM, Daniel Jasper via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: djasper
> Date: Tue Jun 14 08:54:38 2016
> New Revision: 272668
>
> URL: http://llvm.org/viewvc/llvm-project?rev=272668&
Oh, looks like someone already sent a fix: https://reviews.llvm.org/D26163
On Wed, Nov 9, 2016 at 4:41 PM, Nico Weber wrote:
> This apparently caused https://llvm.org/bugs/show_bug.cgi?id=30527
>
> On Tue, Jun 14, 2016 at 9:54 AM, Daniel Jasper via cfe-commits <
> cfe-commits@lists.llvm.org> wro
eugenis added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:735
+ OPT_fno_sanitize_thread_data_races,
+ Opts.SanitizeThreadDataRaces);
+ Opts.SanitizeThreadStackTraces =
alekseyshl wrote:
> eugenis wrote:
>
Author: adrian
Date: Wed Nov 9 15:43:51 2016
New Revision: 286400
URL: http://llvm.org/viewvc/llvm-project?rev=286400&view=rev
Log:
Use an artificial debug location for non-virtual thunks.
Thunks are artificial and have no corresponding source location except for the
line number on the DISubprogr
smeenai created this revision.
smeenai added a reviewer: compnerd.
smeenai added a subscriber: cfe-commits.
Similar to r284288, make the Itanium ABI follow MS ABI dllexport
semantics in the case of an explicit instantiation declaration followed
by a dllexport explicit instantiation definition.
h
rSerge added inline comments.
Comment at: lib/Driver/Tools.cpp:4903-4906
if (Triple.getOS() == llvm::Triple::Linux &&
(Triple.getArch() == llvm::Triple::arm ||
- Triple.getArch() == llvm::Triple::x86_64)) {
+ Triple.getArch() == llvm::Triple::x86_64
On Wed, Nov 09, 2016 at 03:43:52PM -, Douglas Katzman via cfe-commits wrote:
> Author: dougk
> Date: Wed Nov 9 09:43:51 2016
> New Revision: 286376
>
> URL: http://llvm.org/viewvc/llvm-project?rev=286376&view=rev
> Log:
> [Sparc] LLONG is not lock-free atomic on v8
Technically, even 32bit is
Author: alexfh
Date: Wed Nov 9 16:31:07 2016
New Revision: 286404
URL: http://llvm.org/viewvc/llvm-project?rev=286404&view=rev
Log:
[clang-tidy docs] Minor formatting changes.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/index.rst
Modified: clang-tools-extra/trunk/docs/clang-tidy/index
alekseyshl updated this revision to Diff 77398.
alekseyshl added a comment.
- Added ust test for the new command line args.
https://reviews.llvm.org/D26461
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/B
eugenis added inline comments.
Comment at: test/Driver/fsanitize.c:288
+// RUN: %clang -target x86_64-linux-gnu -fsanitize=thread
-fsanitize-thread-data-races -fno-sanitize-thread-data-races %s -### 2>&1 |
FileCheck %s --check-prefix=CHECK-TSAN-DATA-RACES-OFF
+// CHECK-TSAN-DAT
Author: epilk
Date: Wed Nov 9 16:52:23 2016
New Revision: 286409
URL: http://llvm.org/viewvc/llvm-project?rev=286409&view=rev
Log:
[Sema][NFC] Reset HasFallthroughStmt when clearing FunctionScopeInfo
Differential revision: https://reviews.llvm.org/D22770
Modified:
cfe/trunk/lib/Sema/ScopeIn
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286409: [Sema][NFC] Reset HasFallthroughStmt when clearing
FunctionScopeInfo (authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D22770?vs=65380&id=77399#toc
Repository:
rL LLVM
h
kzhuravl created this revision.
kzhuravl added reviewers: tstellarAMD, arsenm.
kzhuravl added a subscriber: cfe-commits.
Herald added subscribers: tony-tye, yaxunl, nhaehnle, wdng.
https://reviews.llvm.org/D26476
Files:
include/clang/Basic/BuiltinsAMDGPU.def
lib/CodeGen/CGBuiltin.cpp
test/C
dberris added inline comments.
Comment at: lib/Driver/Tools.cpp:4903-4906
if (Triple.getOS() == llvm::Triple::Linux &&
(Triple.getArch() == llvm::Triple::arm ||
- Triple.getArch() == llvm::Triple::x86_64)) {
+ Triple.getArch() == llvm::Triple::x86_64
dvyukov added inline comments.
Comment at: include/clang/Driver/Options.td:733
+ Group, Flags<[CC1Option]>,
+ HelpText<"Enable data race detection in
ThreadSanitizer">;
+def fno_sanitize_thread_data_races : Flag<[
Author: adrian
Date: Wed Nov 9 17:05:16 2016
New Revision: 286411
URL: http://llvm.org/viewvc/llvm-project?rev=286411&view=rev
Log:
Relax testcase so it also works on Windows.
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-thunk.cpp
Modified: cfe/trunk/test/CodeGenCXX/debug-info-thunk.cpp
U
nemanjai created this revision.
nemanjai added reviewers: hfinkel, kbarton, syzaara, lei, jtony, sfertile,
amehsan.
nemanjai added subscribers: cfe-commits, echristo.
nemanjai set the repository for this revision to rL LLVM.
This adds the following signatures into altivec.h:
vector bool long lon
Author: adrian
Date: Wed Nov 9 17:10:44 2016
New Revision: 286412
URL: http://llvm.org/viewvc/llvm-project?rev=286412&view=rev
Log:
Remove extra whitespace
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-thunk.cpp
Modified: cfe/trunk/test/CodeGenCXX/debug-info-thunk.cpp
URL:
http://llvm.org
bkramer updated this revision to Diff 77410.
bkramer added a comment.
Add extern "C++" test case.
https://reviews.llvm.org/D23130
Files:
clang-tidy/google/CMakeLists.txt
clang-tidy/google/GlobalNamesCheck.cpp
clang-tidy/google/GlobalNamesCheck.h
clang-tidy/google/GlobalNamesInHeadersChe
bkramer marked 2 inline comments as done.
bkramer added a comment.
In https://reviews.llvm.org/D23130#589643, @alexfh wrote:
> > and generally frowned upon in many codebases (e.g. LLVM)
>
> Should it still be a part of google/? The old check was enforcing a part of
> the Google C++ style guide,
NoQ added a comment.
In https://reviews.llvm.org/D26342#590881, @khazem wrote:
> I think that it's sensible to try merging this with PthreadLockChecker. In
> fact, I could also try merging the SpinLockChecker [1] that I've posted for
> review with PthreadLockChecker also, since they all impleme
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Thanks! LG
https://reviews.llvm.org/D26466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Malcolm, does it work for you?
On Wed, Nov 9, 2016 at 10:56 AM, Devin Coughlin wrote:
> + Anna, Alexander, and Artem.
>
> > On Nov 9, 2016, at 10:50 AM, Devin Coughlin via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
> >
> >
> >> On Nov 8, 2016, at 9:44 AM, Malcolm Parsons
> wrote:
> >>
>
1 - 100 of 130 matches
Mail list logo
