Author: abataev
Date: Mon Nov 7 02:07:25 2016
New Revision: 286098
URL: http://llvm.org/viewvc/llvm-project?rev=286098&view=rev
Log:
[OPENMP] Fixed capturing of VLA variables.
After some changes in codegen capturing of VLA variables in OpenMP
regions was broken, causing compiler crash. Patch fix
rogfer01 updated this revision to Diff 77018.
rogfer01 added a comment.
Updated with changes suggested by @EricWF
https://reviews.llvm.org/D26142
Files:
test/std/experimental/optional/optional.object/optional.object.assign/copy.pass.cpp
test/std/experimental/optional/optional.object/optio
Author: rogfer01
Date: Mon Nov 7 02:23:59 2016
New Revision: 286099
URL: http://llvm.org/viewvc/llvm-project?rev=286099&view=rev
Log:
Protect std::experimental::optional tests under libcpp-no-exceptions
In these tests there are some paths that explicitly throw, so use
the TEST_THROW macro that w
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286099: Protect std::experimental::optional tests under
libcpp-no-exceptions (authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D26142?vs=77018&id=77019#toc
Repository:
rL LLVM
Alpha added a comment.
Ping
Repository:
rL LLVM
https://reviews.llvm.org/D26137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hi,
This has been breaking the bots for almost an hour. Can you fix/revert?
http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/304
http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/657
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/347
Thanks,
Diana
On
ikudrin added a comment.
This test is extremely fragile. Maybe, it is better to disable it, or even
delete it altogether.
https://reviews.llvm.org/D26150
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
ikudrin added a comment.
Ping.
https://reviews.llvm.org/D25608
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hi Diana, will fix it in couple hours.
Best regards,
Alexey Bataev
7 нояб. 2016 г., в 12:38, Diana Picus
mailto:diana.pi...@linaro.org>> написал(а):
Hi,
This has been breaking the bots for almost an hour. Can you fix/revert?
http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/304
h
Author: rovka
Date: Mon Nov 7 04:01:43 2016
New Revision: 286102
URL: http://llvm.org/viewvc/llvm-project?rev=286102&view=rev
Log:
Revert "[OPENMP] Fixed capturing of VLA variables."
This reverts commit r286098 because the modified test breaks on many of the
buildbots.
Modified:
cfe/trunk/l
Hi Alexey,
If it is not a simple, quick fix that you can do, it is customary to revert
so the buildbots become green again. Otherwise, if people commit other
things that break the build they will not get emails and it will be much
harder to fix the whole thing.
I'll revert this for you and you ca
sylvestre.ledru updated this revision to Diff 77023.
Herald added a subscriber: mehdi_amini.
https://reviews.llvm.org/D24998
Files:
docs/CommandGuide/clang.rst
lib/Frontend/CompilerInvocation.cpp
test/Preprocessor/init.c
Index: test/Preprocessor/init.c
Author: abataev
Date: Mon Nov 7 05:16:04 2016
New Revision: 286103
URL: http://llvm.org/viewvc/llvm-project?rev=286103&view=rev
Log:
[OPENMP] Fixed capturing of VLA variables.
After some changes in codegen capturing of VLA variables in OpenMP regions was
broken, causing compiler crash. Patch fi
arphaman added a comment.
This has already been fixed in r276352. I closed PR25961.
https://reviews.llvm.org/D21126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman accepted this revision.
arphaman added a reviewer: arphaman.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM, Thanks.
https://reviews.llvm.org/D22770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
SilverGeri updated this revision to Diff 77015.
SilverGeri added a comment.
checks `if (p != 0)` conditions, too
https://reviews.llvm.org/D21298
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/DeleteNullPointerCheck.cpp
clang-tidy/misc/DeleteNullPointerCheck.h
clang-tidy/misc/Misc
aaron.ballman added a comment.
I don't suppose there's a testcase we could generate for this fix?
https://reviews.llvm.org/D22770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: abataev
Date: Mon Nov 7 07:37:34 2016
New Revision: 286106
URL: http://llvm.org/viewvc/llvm-project?rev=286106&view=rev
Log:
[OPENMP] Fixed test on MIPS-based buildbots.
Modified:
cfe/trunk/test/OpenMP/parallel_codegen.cpp
Modified: cfe/trunk/test/OpenMP/parallel_codegen.cpp
URL:
h
baloghadamsoftware added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:423
+
+void IteratorPastEndChecker::handleComparison(CheckerContext &C,
+ const SVal &LVal,
NoQ wrote:
> a.si
a.sidorin added a comment.
Hm. A pretty nice example. But we should check if the initial patch supports
`goto`s; afair, it doesn't.
https://reviews.llvm.org/D19979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Alpha updated this revision to Diff 77029.
Alpha added a comment.
Ignore export of empty fixes.
Repository:
rL LLVM
https://reviews.llvm.org/D26137
Files:
include/clang/Tooling/Core/Diagnostic.h
include/clang/Tooling/DiagnosticsYaml.h
lib/Tooling/Core/CMakeLists.txt
lib/Tooling/Core/
ogoffart created this revision.
ogoffart added reviewers: rsmith, cfe-commits.
- When the condition is invalid, replace it by an OpaqueValueExpr
- When parsing an invalid CaseStmt, don't drop the sub statement, just return
it instead.
- In Sema::ActOnStartOfSwitchStmt, always keep the SwitchSt
ogoffart added a comment.
I believe only the change in ActOnFinishSwitchStmt might be controversial.
Is it breaking an invariant than having switches kept in the AST?
https://reviews.llvm.org/D26350
___
cfe-commits mailing list
cfe-commits@lists.ll
baloghadamsoftware updated this revision to Diff 77033.
baloghadamsoftware added a comment.
Interim version, updated according to some of the comments.
https://reviews.llvm.org/D25660
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/S
baloghadamsoftware marked 9 inline comments as done.
baloghadamsoftware added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:337
+ const auto *RPos = getIteratorPosition(State, Right);
+ if (LPos && !RPos) {
+if ((LPos->isInRange() && ((
jtony updated this revision to Diff 77036.
jtony added a comment.
I migrated the commit from the old anonymous repository to the new jtony
repository to prepare for committing upstream (use git svn dcommit). Should
not have any difference with the previous patches, update it just in case.
htt
jtony updated this revision to Diff 77037.
jtony added a comment.
I also migrated this commit from the old anonymous repository to the new jtony
repository to prepare for committing upstream (use git svn dcommit). Should not
have any difference with the previous patch, update it just in case.
yaxunl added a comment.
In https://reviews.llvm.org/D26302#587480, @Anastasia wrote:
> LGTM! Thanks! Do you know the runtime of this test now?
It takes about 1s in releaser build and 20s in debug build on my machine.
https://reviews.llvm.org/D26302
_
Author: yaxunl
Date: Mon Nov 7 09:55:51 2016
New Revision: 286114
URL: http://llvm.org/viewvc/llvm-project?rev=286114&view=rev
Log:
[OpenCL] Remove redundant test for OpenCL header file
Differential Revision: https://reviews.llvm.org/D26302
Modified:
cfe/trunk/test/Headers/opencl-c-header.cl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286114: [OpenCL] Remove redundant test for OpenCL header
file (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D26302?vs=76932&id=77039#toc
Repository:
rL LLVM
https://reviews
arphaman added a comment.
I looked at the way `HasFallthroughStmt` is used, and it didn't seem so, no.
It's used in the following manner in AnalysisBasedWarnings.cpp:
bool FallThroughDiagFull =
!Diags.isIgnored(diag::warn_unannotated_fallthrough, D->getLocStart());
bool FallThroughDiag
yaxunl added inline comments.
Comment at: test/SemaOpenCL/extensions.cl:28
+#ifdef FP64
+// expected-no-diagnostics
+#endif
expected-no-diagnostics applies to the whole file. better move to the beginning
of the file.
otherwise LGTM. Thanks!
https://reviews.ll
Author: arphaman
Date: Mon Nov 7 10:56:19 2016
New Revision: 286121
URL: http://llvm.org/viewvc/llvm-project?rev=286121&view=rev
Log:
[www] Update the link to the 'include what you use' project
Modified:
cfe/trunk/www/related.html
Modified: cfe/trunk/www/related.html
URL:
http://llvm.org/v
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Some minor changes then this looks good to go.
Comment at: lib/Sema/SemaChecking.cpp:11348-11350
+ // Not the scope of this diagnostic.
+ if (!AnyIsPacked)
+return;
---
kromanenkov updated this revision to Diff 77041.
kromanenkov added a comment.
According to dcoughlin suggestion PointerToMember SVal is now modeled as a
PointerUnion of DeclaratorDecl and bump pointer-allocated object stored
DeclaratorDecl and immutable linked list of CXXBaseSpecifiers.
https:
Author: jrose
Date: Mon Nov 7 11:28:04 2016
New Revision: 286122
URL: http://llvm.org/viewvc/llvm-project?rev=286122&view=rev
Log:
Fix use-of-temporary with StringRef in code coverage
The fixed code is basically identical to the same loop below, which
might indicate an opportunity for refactorin
jordan_rose closed this revision.
jordan_rose added a comment.
Committed as r286122.
Repository:
rL LLVM
https://reviews.llvm.org/D26317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
spyffe added a comment.
Aleksei, thank you for your review.
I don't quite follow what you'd like me to do with the `Input` files, though.
Some of them certainly appear to be input files in the same way that all the
other files in `Inputs` are. Are you suggesting that I move `macro.modulemap`
Author: mehdi_amini
Date: Mon Nov 7 11:40:28 2016
New Revision: 286123
URL: http://llvm.org/viewvc/llvm-project?rev=286123&view=rev
Log:
Add some facilities to work with a git monorepo (experimental setup)
Summary:
Some changes are made to cmake, especially the addition of a new
LLVM_ENABLE_PROJ
Author: mehdi_amini
Date: Mon Nov 7 11:43:08 2016
New Revision: 286124
URL: http://llvm.org/viewvc/llvm-project?rev=286124&view=rev
Log:
Revert "Add some facilities to work with a git monorepo (experimental setup)"
This reverts commit r286123, accidentally commited while testing itself...
Modif
a.sidorin added a comment.
Hi Sean!
I meant that I'd like to have a layout like this:
macro-loc.m
Inputs/macro-loc/macro.modulemap
Inputs/macro-loc/macro1.h
Inputs/macro-loc/macro1.m
Inputs/macro-loc/macro2.m
By the way, I see that we use another workaround for this issue: we use
`getDecomposedE
On Sun, Nov 6, 2016 at 1:18 AM Michał Górny via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, 14 Oct 2016 17:17:59 +
> Joshua Hurwitz via cfe-commits wrote:
>
> > See attached.
> >
> > Returning a bool from main is a special case of return type mismatch. The
> > common convention
dcoughlin added a comment.
Thanks for upstreaming this! (And it was great to meet you at the developer
conference.)
Comment at: lib/StaticAnalyzer/Checkers/SpinLockChecker.cpp:61
+
+const ErrorCategoryStr LockInfo::LockErrCategory("Lock Error");
+const FunctionNameStr LockInfo
ioeric marked an inline comment as done.
ioeric added a comment.
ping.
https://reviews.llvm.org/D25771
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: abataev
Date: Mon Nov 7 12:15:02 2016
New Revision: 286129
URL: http://llvm.org/viewvc/llvm-project?rev=286129&view=rev
Log:
[OPENMP] Fixed codegen for __real/__imag expressions in atomic
constructs.
For __real/__imag unary expressions clang emits lvalue with the
associated type from the
hokein added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:297
+ const auto &RegisteredCheckers =
+ AnalyzerOptions::getRegisteredCheckers(IncludeExperimentalCheckers);
+ bool AnalyzerChecksEnabled = false;
Since the default argument of this funct
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
Looks good to me. Thanks, Kareem!
https://reviews.llvm.org/D26328
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
Hi Eric,
the asan bootstrap bot shows a leak in this newly added tests. Please fix
or revert ASAP.
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/136/steps/check-clang%20asan/logs/stdio
Direct leak of 720 byte(s) in 1 object(s) allocated from:
#0 0x6ace50 in operato
spyffe added a comment.
That seems reasonable, and would go a long way toward cleaning up the `Inputs`
and making clear exactly which inputs correspond to which test file.
Do you think it would be reasonable to take this diff the way it currently it
is, and start a new one that pulls all the inp
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
It appears that this code is not testable in clang. There is a compiler-rt test
in https://reviews.llvm.org/D26355.
https://reviews.llvm.org/D26354
Thanks Kostya! I'll look into this now.
On Mon, Nov 7, 2016 at 10:39 AM Kostya Serebryany wrote:
> Hi Eric,
>
> the asan bootstrap bot shows a leak in this newly added tests. Please fix
> or revert ASAP.
>
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/136/steps/chec
a.sidorin added a comment.
> Do you think it would be reasonable to take this diff the way it currently it
> is, and start a new one that pulls all the input fiels into test-specific
> subdirectories?
> That way the desired layout of the `Inputs` directory will be clear to
> future developers
Author: ioeric
Date: Mon Nov 7 12:40:41 2016
New Revision: 286132
URL: http://llvm.org/viewvc/llvm-project?rev=286132&view=rev
Log:
Fix memory leak caused by r286096.
Modified:
cfe/trunk/unittests/Tooling/RefactoringTest.cpp
Modified: cfe/trunk/unittests/Tooling/RefactoringTest.cpp
URL:
ht
Anastasia added a comment.
In https://reviews.llvm.org/D26157#586867, @pekka.jaaskelainen wrote:
> Indeed, it requires wider scale discussion to get it right, and e.g. to pass
> the info to AA. But to be honest, I think OpenCL and CUDA are still
> considered 'minority' languages in Clang/LLVM w
r286132 should fix this.
On Mon, Nov 7, 2016 at 10:40 AM Eric Liu wrote:
Thanks Kostya! I'll look into this now.
On Mon, Nov 7, 2016 at 10:39 AM Kostya Serebryany wrote:
Hi Eric,
the asan bootstrap bot shows a leak in this newly added tests. Please fix
or revert ASAP.
http://lab.llvm.org:801
Thanks!
On Mon, Nov 7, 2016 at 10:53 AM, Eric Liu wrote:
> r286132 should fix this.
>
> On Mon, Nov 7, 2016 at 10:40 AM Eric Liu wrote:
>
> Thanks Kostya! I'll look into this now.
>
> On Mon, Nov 7, 2016 at 10:39 AM Kostya Serebryany wrote:
>
> Hi Eric,
>
> the asan bootstrap bot shows a leak
Anastasia added a comment.
Cool! Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D26302
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans added inline comments.
Comment at: lib/Headers/x86intrin.h:49
+static __inline__ unsigned int __attribute__((__always_inline__, __nodebug__))
+__tzcnt_u32(unsigned int __X) { return __X ? __builtin_ctz(__X) : 32; }
+#ifdef __x86_64__
I'm worried about the co
khazem added a comment.
Thank you Sean! I've asked Petr Hosek to commit this change.
https://reviews.llvm.org/D26328
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
probinson added inline comments.
Comment at: lib/Headers/x86intrin.h:49
+static __inline__ unsigned int __attribute__((__always_inline__, __nodebug__))
+__tzcnt_u32(unsigned int __X) { return __X ? __builtin_ctz(__X) : 32; }
+#ifdef __x86_64__
hans wrote:
> I'm w
alekseyshl created this revision.
alekseyshl added a reviewer: eugenis.
alekseyshl added a subscriber: cfe-commits.
Use -fsanitize-recover instead of -mllvm -msan-keep-going: pass
-fsanitize-recover value to msan.
https://reviews.llvm.org/D26354
Files:
lib/CodeGen/BackendUtil.cpp
Index: li
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Thank you for tracking and fixing this! One nit inline.
Comment at: clang-tidy/modernize/UseNullptrCheck.cpp:194
+// Catch the castExpr inside cxxDefaultArgExpr.
+if
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
One nit. Otherwise looks good. Thank you!
Comment at: clang-tidy/rename_check.py:89
- header_guard_old = module.upper() + '_' + check_name.upper().replace('-',
'_')
- he
ioeric added a comment.
First round of comments.
The patch summary says "one moved declaration." Why it is just one moved
declaration? Doesn't this also support moving all classes in one file?
Maybe also mention the new behavior in the class comment.
Comment at: clang-move/
hokein added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:566
+ break;
+if (isDeclVisibleAtLocation(*Result.SourceManager, Using, DeclCtx, Start))
{
+ for (const auto *UsingShadow : Using->shadows()) {
ioeric wrote:
> ioeric wr
Hi Alexey,
Does this look like a good candidate for 3.9.1?
-Dimitry
> On 07 Nov 2016, at 19:15, Alexey Bataev via cfe-commits
> wrote:
>
> Author: abataev
> Date: Mon Nov 7 12:15:02 2016
> New Revision: 286129
>
> URL: http://llvm.org/viewvc/llvm-project?rev=286129&view=rev
> Log:
> [OPENMP
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Thank you for resurrecting this patch! A few comments inline.
Comment at: include/clang/Tooling/Core/Diagnostic.h:35
+ DiagnosticMessage(llvm::StringRef Message, c
Hi Dimitry,
I think so
Best regards,
Alexey Bataev
> 7 нояб. 2016 г., в 22:36, Dimitry Andric написал(а):
>
> Hi Alexey,
>
> Does this look like a good candidate for 3.9.1?
>
> -Dimitry
>
>> On 07 Nov 2016, at 19:15, Alexey Bataev via cfe-commits
>> wrote:
>>
>> Author: abataev
>> Date: M
ahatanak added a comment.
Hi Jordan,
It seems that this patch doesn't apply cleanly. Can you rebase it?
Repository:
rL LLVM
https://reviews.llvm.org/D26108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
Author: spyffe
Date: Mon Nov 7 14:42:25 2016
New Revision: 286144
URL: http://llvm.org/viewvc/llvm-project?rev=286144&view=rev
Log:
When the ASTImporter imports a source location, it avoids importing macro
expansions by calling getSpellingLoc(). That's great in most cases, but for
macros defined
spyffe closed this revision.
spyffe added a comment.
$ svn commit lib test
Sendinglib/AST/ASTImporter.cpp
Adding test/ASTMerge/Inputs/macro.modulemap
Adding test/ASTMerge/Inputs/macro1.h
Adding test/ASTMerge/Inputs/macro1.m
Adding test/ASTMerge/I
rnk added a comment.
I'd like to preserve the old behavior under -Wshadow-all. The last time I came
here to try to quiet a shadowing warning on constructor parameters, we went to
great lengths to try to satisfy users who really want to warn on any and all
kinds of shadowing. I think you can do
smeenai added a comment.
In https://reviews.llvm.org/D26150#587973, @ikudrin wrote:
> This test is extremely fragile. Maybe, it is better to disable it, or even
> delete it altogether.
I'll take your word for it, as the original author of the test, though I'm
curious about where the fragility
Author: eugenis
Date: Mon Nov 7 15:02:11 2016
New Revision: 286148
URL: http://llvm.org/viewvc/llvm-project?rev=286148&view=rev
Log:
Use -fsanitize-recover instead of -mllvm -msan-keep-going: clang.
Summary: Use -fsanitize-recover instead of -mllvm -msan-keep-going: pass
-fsanitize-recover valu
On Mon, Nov 7, 2016 at 11:44 AM, Alex Lorenz wrote:
> arphaman added a comment.
>
> I looked at the way `HasFallthroughStmt` is used, and it didn't seem so, no.
> It's used in the following manner in AnalysisBasedWarnings.cpp:
>
> bool FallThroughDiagFull =
> !Diags.isIgnored(diag::warn_u
flx created this revision.
flx added reviewers: alexfh, aaron.ballman, sbenza.
flx added a subscriber: cfe-commits.
flx set the repository for this revision to rL LLVM.
Move in complete type test which does not compile into its own test file.
Repository:
rL LLVM
https://reviews.llvm.org/D2636
flx added a comment.
Comment at:
clang-tools-extra/trunk/test/clang-tidy/performance-unnecessary-value-param.cpp:241
+
+// Ensure that incomplete types result in an error from the frontend and not a
+// clang-tidy diagnostic about IncompleteType being expensive to copy.
-
Author: rjmccall
Date: Mon Nov 7 15:13:27 2016
New Revision: 286152
URL: http://llvm.org/viewvc/llvm-project?rev=286152&view=rev
Log:
Name some anonymous structs to avoid using a (very common) extension.
Modified:
cfe/trunk/lib/CodeGen/CGCall.h
Modified: cfe/trunk/lib/CodeGen/CGCall.h
URL:
> On Nov 4, 2016, at 12:36 AM, Yaron Keren wrote:
> Hi John,
>
> clang warns on this:
>
> /llvm/tools/zapccs/../clang/include/../lib/CodeGen/CGCall.h:79:7: warning:
> anonymous types declared in an anonymous union are an extension
> [-Wnested-anon-types]
> struct {
> ^
> /llvm/too
hans added inline comments.
Comment at: lib/Headers/x86intrin.h:49
+static __inline__ unsigned int __attribute__((__always_inline__, __nodebug__))
+__tzcnt_u32(unsigned int __X) { return __X ? __builtin_ctz(__X) : 32; }
+#ifdef __x86_64__
probinson wrote:
> hans
Author: spyffe
Date: Mon Nov 7 15:10:31 2016
New Revision: 286151
URL: http://llvm.org/viewvc/llvm-project?rev=286151&view=rev
Log:
Updated ASTMerge/macro.m to use _Nullable.
Modified:
cfe/trunk/test/ASTMerge/Inputs/macro1.h
Modified: cfe/trunk/test/ASTMerge/Inputs/macro1.h
URL:
http://llv
spyffe added a comment.
Fixed the testcase to use _Nullable instead of __nullable, for Linux buildbots
$ svn commit test
Sendingtest/ASTMerge/Inputs/macro1.h
Transmitting file data .done
Committing transaction...
Committed revision 286151.
https://reviews.llvm.org/D26054
__
Author: akirtzidis
Date: Mon Nov 7 15:20:15 2016
New Revision: 286154
URL: http://llvm.org/viewvc/llvm-project?rev=286154&view=rev
Log:
[index] Handle properly C++14's template variables.
- Infer the right symbol kind.
- Provide a templated USR, similar to how we handle class templates.
rdar://
Author: akirtzidis
Date: Mon Nov 7 15:20:08 2016
New Revision: 286153
URL: http://llvm.org/viewvc/llvm-project?rev=286153&view=rev
Log:
[index] Make sure to mark class template symbols as having 'generic' sub-kind.
Modified:
cfe/trunk/lib/Index/IndexSymbol.cpp
cfe/trunk/test/Index/Core/i
hokein updated this revision to Diff 77093.
hokein marked 5 inline comments as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D26236
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
test/clang-move/Inputs/test.h
test/clang-move/move-class.cpp
uni
hokein added a comment.
> The patch summary says "one moved declaration." Why it is just one moved
> declaration? Doesn't this also support moving all classes in one file?
Oh, the patch summary is not totally correct. It actually does what you mention
above. Have updated the summary.
===
aaron.ballman added inline comments.
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:257
-
-void PositiveNonConstDeclaration(ExpensiveToCopyType A);
-// CHECK-FIXES: void PositiveNonConstDeclaration(const ExpensiveToCopyType& A);
Why are these
flx removed rL LLVM as the repository for this revision.
flx updated this revision to Diff 77094.
https://reviews.llvm.org/D26369
Files:
test/clang-tidy/performance-unnecessary-value-param-incomplete-type.cpp
test/clang-tidy/performance-unnecessary-value-param.cpp
Index: test/clang-tidy/per
flx marked an inline comment as done.
flx added inline comments.
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:257
-
-void PositiveNonConstDeclaration(ExpensiveToCopyType A);
-// CHECK-FIXES: void PositiveNonConstDeclaration(const ExpensiveToCopyType& A);
--
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from a commenting nit, LGTM.
Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:130
+ // Do not propose fixes when:
+ // 1. in macros sin
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:257
-
-void PositiveNonConstDeclaration(ExpensiveToCopyType A);
-// CHECK-FIXES: void
flx marked an inline comment as done.
flx added inline comments.
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:257
-
-void PositiveNonConstDeclaration(ExpensiveToCopyType A);
-// CHECK-FIXES: void PositiveNonConstDeclaration(const ExpensiveToCopyType& A);
--
Hello everyone,
LLVM buildmaster will be restarted at 5 PM Pacific time today for
maintenance.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: flx
Date: Mon Nov 7 15:45:58 2016
New Revision: 286155
URL: http://llvm.org/viewvc/llvm-project?rev=286155&view=rev
Log:
[clang-tidy] Move incomplete type test into separate test file
Summary: Move in complete type test which does not compile into its own test
file.
Reviewers: alexfh,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286156: [clang-tidy] Fix a regression issue introduced by
r285239. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D26301?vs=76920&id=77096#toc
Repository:
rL LLVM
https://re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286155: [clang-tidy] Move incomplete type test into separate
test file (authored by flx).
Changed prior to commit:
https://reviews.llvm.org/D26369?vs=77094&id=77095#toc
Repository:
rL LLVM
https://r
Author: hokein
Date: Mon Nov 7 15:46:24 2016
New Revision: 286156
URL: http://llvm.org/viewvc/llvm-project?rev=286156&view=rev
Log:
[clang-tidy] Fix a regression issue introduced by r285239.
Summary:
r285239 changes the behavior of AST CXXDefaultArgExpr node.
Update `modernize-use-nullptr` to h
hokein added a comment.
friendly ping.
https://reviews.llvm.org/D25911
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl retitled this revision from "AMDGPU: Translate null pointers in private
and local addr space" to "[WIP] Add support for non-zero null pointers".
yaxunl updated this revision to Diff 77097.
yaxunl added a comment.
This is work in progress. Revised by John's comments.
Refactored getNullPtr
alexfh updated this revision to Diff 77098.
alexfh added a comment.
- Don't expose debug checkers.
https://reviews.llvm.org/D26310
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
unittests/StaticAnalyzer/AnalyzerOptionsTest.cpp
Inde
1 - 100 of 155 matches
Mail list logo
