aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
Aside from a commenting nit, LGTM. ================ Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:130 + // Do not propose fixes when: + // 1. in macros since we cannot place them correctly + // 2. the function is virtual as it might break overrides ---------------- Not grammatically correct; should be "1. when the ParmVarDecl is in a macro, since..." Repository: rL LLVM https://reviews.llvm.org/D26203 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
