Author: mzuckerm
Date: Tue Oct 25 02:56:04 2016
New Revision: 285054
URL: http://llvm.org/viewvc/llvm-project?rev=285054&view=rev
Log:
[X86][AVX512][Clang][Intrinsics][reduce] Adding missing reduce (Operators:
+,*,&&,||) intrinsics to Clang
Committed after LGTM and check-all
Vector-reduction
srhines accepted this revision.
srhines added a reviewer: srhines.
srhines added a comment.
This revision is now accepted and ready to land.
Looks good for the Android side.
Repository:
rL LLVM
https://reviews.llvm.org/D25928
___
cfe-commits mail
bkramer added a comment.
CodeGen depending on Analysis is fine with me. Any clang tool that builds an
AST will have Analysis linked in anyways so there's virtually no cost to it.
Repository:
rL LLVM
https://reviews.llvm.org/D25888
___
cfe-commit
bkramer added a comment.
Very nice.
Comment at: unittests/Driver/ToolChainsTest.cpp:15
+// FIXME: I presume this is not the correct way of doing this
+#include "../lib/Driver/ToolChains.h"
+#include "clang/Basic/VirtualFileSystem.h"
Yeah. It's better to hoist t
bkramer added inline comments.
Comment at: lib/Driver/ToolChains.cpp:1438
+ if (GCCToolchainDir == "" || GCCToolchainDir == D.SysRoot + "/usr") {
+for (const StringRef& CandidateTriple : CandidateTripleAliases) {
+ llvm::ErrorOr> File =
drop the const&.
massberg accepted this revision.
massberg added a comment.
This revision is now accepted and ready to land.
looks good to me
https://reviews.llvm.org/D25658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
massberg accepted this revision.
massberg added a comment.
This revision is now accepted and ready to land.
looks good to me
https://reviews.llvm.org/D25657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
Author: erikjv
Date: Tue Oct 25 05:06:11 2016
New Revision: 285056
URL: http://llvm.org/viewvc/llvm-project?rev=285056&view=rev
Log:
Fix 'unknown documentation command' warning ranges
Warnings generated by -Wdocumentation-unknown-command did only have a
start location, not a full source range. Th
koriakin added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:422
// Set up the per-function pass manager.
+ FPM.add(new TargetLibraryInfoWrapperPass(*TLII));
if (CodeGenOpts.VerifyModule)
mehdi_amini wrote:
> This seems unnecessary?
This ensures
Author: erikjv
Date: Tue Oct 25 05:13:10 2016
New Revision: 285057
URL: http://llvm.org/viewvc/llvm-project?rev=285057&view=rev
Log:
Include full filename range for missing includes
For the purpose of highlighting in an IDE.
Added:
cfe/trunk/test/Preprocessor/missing-include-range-check.h
Mo
bader added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1272
+if (getLangOpts().OpenCL) {
+ UA = llvm::GlobalValue::UnnamedAddr::None;
+ AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant);
Anastasia wrote:
> bader wrote:
>
delena accepted this revision.
delena added a comment.
This revision is now accepted and ready to land.
LGTM. Agree, one-by-one.
https://reviews.llvm.org/D25902
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Anastasia created this revision.
Anastasia added a reviewer: yaxunl.
Anastasia added a subscriber: cfe-commits.
OpenCL disallows using variadic arguments (s6.9.e and s6.12.5 OpenCL v2.0)
apart from some exceptions:
- printf
- enqueue_kernel
This change adds error diagnostic for variadic functio
Author: klimek
Date: Tue Oct 25 06:30:28 2016
New Revision: 285059
URL: http://llvm.org/viewvc/llvm-project?rev=285059&view=rev
Log:
Load clang-include-fixer.el from the unit test suite so that the unit tests can
run in batch mode.
Patch by Philipp Stephani.
Modified:
clang-tools-extra/trun
Author: klimek
Date: Tue Oct 25 06:31:22 2016
New Revision: 285060
URL: http://llvm.org/viewvc/llvm-project?rev=285060&view=rev
Log:
include-fixer: Don't overwrite buffer changes
Raise a signal if the buffer has been modified before replacing it, to
avoid overwriting users' changes.
Patch by Phi
mehdi_amini added a comment.
Good catch! How did you find this?
We need a test though.
(I can take over if you want, as I introduced the issue in the first place)
https://reviews.llvm.org/D25936
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285065: Fix diagnostic format string for
err_os_log_argument_to_big (authored by d0k).
Changed prior to commit:
https://reviews.llvm.org/D25936?vs=75685&id=75687#toc
Repository:
rL LLVM
https://revi
Author: d0k
Date: Tue Oct 25 07:39:28 2016
New Revision: 285065
URL: http://llvm.org/viewvc/llvm-project?rev=285065&view=rev
Log:
Fix diagnostic format string for err_os_log_argument_to_big
Patch by Sam McCall, test case by me.
Differential Revision: https://reviews.llvm.org/D25936
Modified:
Thanks!
> On Oct 25, 2016, at 5:39 AM, Benjamin Kramer via cfe-commits
> wrote:
>
> Author: d0k
> Date: Tue Oct 25 07:39:28 2016
> New Revision: 285065
>
> URL: http://llvm.org/viewvc/llvm-project?rev=285065&view=rev
> Log:
> Fix diagnostic format string for err_os_log_argument_to_big
>
> Pat
Author: rksimon
Date: Tue Oct 25 07:59:15 2016
New Revision: 285067
URL: http://llvm.org/viewvc/llvm-project?rev=285067&view=rev
Log:
Fix MSVC unused variable warning.
LLVM_ATTRIBUTE_UNUSED doesn't work for non-gcc style compilers.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/StdLibraryFu
arphaman created this revision.
arphaman added reviewers: rjmccall, thakis.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch makes the `-Wunused-variable` warning behaviour more consistent: Now
clang won't warn on variables with consta
erikjv closed this revision.
erikjv added a comment.
r285057
https://reviews.llvm.org/D25871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erikjv closed this revision.
erikjv added a comment.
r285056
https://reviews.llvm.org/D25870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erikjv created this revision.
erikjv added a reviewer: bkramer.
erikjv added a subscriber: cfe-commits.
NFC
https://reviews.llvm.org/D25938
Files:
include/clang/Lex/Preprocessor.h
lib/Lex/PPDirectives.cpp
Index: lib/Lex/PPDirectives.cpp
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D25938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
bkramer added inline comments.
Comment at: lib/Lex/PPDirectives.cpp:804
if (LangOpts.MSVCCompat && !isAngled) {
- for (unsigned i = 0, e = IncludeMacroStack.size(); i != e; ++i) {
IncludeStackInfo &ISEntry = IncludeMacroStack[e - i - 1];
While
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin, a.sidorin, xazax.hun.
NoQ added a subscriber: cfe-commits.
The mechanism for filtering out wrong functions with the same name was too
aggressive to filter out eg. `int` vs. `long`, when sizes of both are equal.
Such issues wer
sammccall created this revision.
sammccall added a reviewer: bkramer.
sammccall added subscribers: cfe-commits, mehdi_amini.
https://reviews.llvm.org/D25936
Files:
include/clang/Basic/DiagnosticSemaKinds.td
Index: include/clang/Basic/DiagnosticSemaKinds.td
The failure cannot be reproduced. I re-apply r279045. Committed revision
285066.
Thanks,
Kelvin
On Thu, Aug 18, 2016 at 5:46 AM, Diana Picus wrote:
> Hi,
>
> I had to revert this (r279045) because it breaks some of our buildbots
> (e.g.
> clang-cmake-aarch64-quick, clang-x86_64-linux-selfhost
lukasza updated the summary for this revision.
lukasza updated this revision to Diff 75661.
lukasza added a comment.
Reverted changes in the patch that are not related to the issue of
hasDeclaration not matching *anything* in some cases.
https://reviews.llvm.org/D24361
Files:
include/clang/A
sammccall added a comment.
In https://reviews.llvm.org/D25936#578341, @mehdi_amini wrote:
> Good catch! How did you find this?
We've got a library that parses diagnostics that consumes
DiagnosticSemaKinds.inc, and it failed to parse this message format.
> We need a test though.
> (I can take
sfantao added a comment.
Hi Hal,
Thanks for the review!
In https://reviews.llvm.org/D21840#555719, @hfinkel wrote:
> The naming here is a bit hard to follow, we have 'dependent action',
> 'dependency action', 'depending action', and I think they're all supposed to
> mean the same thing. Only
sfantao updated this revision to Diff 75698.
sfantao marked 10 inline comments as done.
sfantao added a comment.
- Address Hal Finkel suggestions - rename functions/reorder code/fix comments.
https://reviews.llvm.org/D21840
Files:
include/clang/Driver/Action.h
lib/Driver/Driver.cpp
Index:
AlexeySotkin added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1272
+if (getLangOpts().OpenCL) {
+ UA = llvm::GlobalValue::UnnamedAddr::None;
+ AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant);
bader wrote:
> Anastasia wr
arphaman created this revision.
arphaman added reviewers: rjmccall, rsmith.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes a NULL pointer crash that happens when clang is trying to
create an implicit default constructor for a s
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
https://reviews.llvm.org/D25935
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
mgorny updated this revision to Diff 75704.
mgorny added a comment.
Updated to perform `.startswith()` check before splitting.
https://reviews.llvm.org/D24954
Files:
lib/Driver/ToolChains.cpp
Index: lib/Driver/ToolChains.cpp
==
sfantao updated this revision to Diff 75705.
sfantao marked an inline comment as done.
sfantao added a comment.
- Address Hal Finkel comments - make diagnostic message more informative.
https://reviews.llvm.org/D21843
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/
mgorny planned changes to this revision.
mgorny added inline comments.
Comment at: unittests/Driver/ToolChainsTest.cpp:15
+// FIXME: I presume this is not the correct way of doing this
+#include "../lib/Driver/ToolChains.h"
+#include "clang/Basic/VirtualFileSystem.h"
Author: compnerd
Date: Tue Oct 25 09:50:44 2016
New Revision: 285073
URL: http://llvm.org/viewvc/llvm-project?rev=285073&view=rev
Log:
CodeGen: mark protocols as common data
This allows for the coalescing of the protocol declarations. When the protocols
are declared in headers, multiple definiti
sfantao added a comment.
Hi Hal,
Thanks for the review!
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:163
+def err_drv_expecting_fopenmp_with_fopenmp_targets : Error<
+ "The option -fopenmp-targets must be used in conjunction with a -fopenmp
option compatible with
mgorny updated this revision to Diff 75707.
mgorny marked 3 inline comments as done.
mgorny added a comment.
Thanks for the review. Implemented all three suggestions.
https://reviews.llvm.org/D25661
Files:
lib/Driver/ToolChains.cpp
test/Driver/Inputs/gentoo_linux_gcc_multi_version_tree/etc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285074: [Driver] Support obtaining active toolchain from
gcc-config on Gentoo (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D25661?vs=75707&id=75710#toc
Repository:
rL LLVM
sdardis updated this revision to Diff 75708.
sdardis marked an inline comment as done.
sdardis added a comment.
Extra testing for cases where the operand on the left of an operation is a
vector.
Removed two spurious checks for vector types.
https://reviews.llvm.org/D25866
Files:
lib/Sema/Sem
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
ship it.
https://reviews.llvm.org/D25661
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D24954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
bruno added a comment.
This is great!
Comment at: unittests/Driver/ToolChainsTest.cpp:154
+
"BUG_REPORT_URL=\"https://bugs.debian.org/\"\n";));
+ ASSERT_EQ(DebianStretch, DetectDistro(DebianStretchSidFileSystem));
+}
Can
> On 2016-Oct-24, at 21:43, Mehdi AMINI wrote:
>
> mehdi_amini created this revision.
> mehdi_amini added a reviewer: dexonsmith.
> mehdi_amini added a subscriber: cfe-commits.
>
> We're only doing it with -flto currently, however it never "hurt"
> to pass it, and users that are linking without
Author: mgorny
Date: Tue Oct 25 10:07:41 2016
New Revision: 285074
URL: http://llvm.org/viewvc/llvm-project?rev=285074&view=rev
Log:
[Driver] Support obtaining active toolchain from gcc-config on Gentoo
Support using gcc-config to determine the correct GCC toolchain location
on Gentoo. In order t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285076: [Driver] Disable OpenSUSE rules for OpenSUSE/SLES 10
and older (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D24954?vs=75704&id=75713#toc
Repository:
rL LLVM
https:
arphaman updated this revision to Diff 75712.
arphaman added a comment.
The updated patch addresses Richard's comment by making sure the fixit isn't
emitted when the destructor call is invalid.
Repository:
rL LLVM
https://reviews.llvm.org/D25817
Files:
lib/Sema/SemaExprCXX.cpp
test/CXX/
Author: mgorny
Date: Tue Oct 25 10:33:32 2016
New Revision: 285076
URL: http://llvm.org/viewvc/llvm-project?rev=285076&view=rev
Log:
[Driver] Disable OpenSUSE rules for OpenSUSE/SLES 10 and older
Disable the OpenSUSE rules for OpenSUSE versions older than 11 as they
are incompatible with the old
mgorny added inline comments.
Comment at: unittests/Driver/ToolChainsTest.cpp:154
+
"BUG_REPORT_URL=\"https://bugs.debian.org/\"\n";));
+ ASSERT_EQ(DebianStretch, DetectDistro(DebianStretchSidFileSystem));
+}
bruno wrote:
>
bruno added a comment.
Hi,
Nice, thanks for working on this!
Comment at: lib/Sema/SemaExpr.cpp:8051
+ if (!LHSVecType) {
+assert(RHSVecType && "RHSVecType is not a vector!");
if (!tryVectorConvertAndSplat(*this, (IsCompAssign ? nullptr : &LHS),
`tryV
rjmccall requested changes to this revision.
rjmccall added a comment.
This revision now requires changes to proceed.
There's no reason for this to only consider constant-sized arrays, and you
should use getBaseElementTypeUnsafe() so you look through nested array types.
That method is a no-op o
sfantao added a comment.
Hi Hal,
Thanks for the review! Fixed the typos in the new diff.
Comment at: lib/Driver/Driver.cpp:1949
+SpecializedBuilders.push_back(new OpenMPActionBuilder(C, Args, Inputs));
+
//
hfinkel wrote:
> Since we can have both Open
sfantao updated this revision to Diff 75722.
sfantao marked 7 inline comments as done.
sfantao added a comment.
- Fix typos and add test tht checks phases when OpenMP and CUDA are used
simultaneously.
https://reviews.llvm.org/D21845
Files:
lib/Driver/Driver.cpp
test/Driver/openmp-offload.c
labath created this revision.
labath added reviewers: benlangmuir, zturner.
labath added a subscriber: cfe-commits.
NFCI
https://reviews.llvm.org/D25948
Files:
include/clang/Basic/VirtualFileSystem.h
lib/Basic/FileSystemStatCache.cpp
lib/Basic/VirtualFileSystem.cpp
lib/Frontend/ASTUnit.
mgorny created this revision.
mgorny added reviewers: bruno, bkramer.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: modocache, beanz.
Refactor the Distro enum along with helper functions into a full-fledged
Distro class, inspired by llvm::Triple, and make it a public API.
The n
Anastasia added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1272
+if (getLangOpts().OpenCL) {
+ UA = llvm::GlobalValue::UnnamedAddr::None;
+ AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant);
AlexeySotkin wrote:
> bader wr
sfantao updated this revision to Diff 75730.
sfantao marked 3 inline comments as done.
sfantao added a comment.
- Address Hal Finkel comments - fix comments/fix linker script comment.
https://reviews.llvm.org/D21847
Files:
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
lib/Driver/T
sfantao added a comment.
Hi Hal,
Thanks for the review! Comments inlined.
Comment at: lib/Driver/Tools.cpp:334
+ LksStream << " OpenMP Offload Linker Script.\n";
+ LksStream << "*/\n";
+ LksStream << "TARGET(binary)\n";
hfinkel wrote:
> We should also say
beanz added a comment.
I think doing just the suffix is the right starting point.
https://reviews.llvm.org/D23752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao updated this revision to Diff 75732.
sfantao marked 3 inline comments as done.
sfantao added a comment.
- Fix typos and check -dynamic when it comes to translating arguments for
offloading gcc toolchains.
https://reviews.llvm.org/D21848
Files:
include/clang/Driver/Compilation.h
inc
sfantao added a comment.
Hi Hal,
Thanks for the review!
Comment at: lib/Driver/ToolChains.cpp:2854
+ case options::OPT_shared:
+ case options::OPT_static:
+ case options::OPT_fPIC:
hfinkel wrote:
> And also?
>
> case options::OPT_dynamic:
Oh,
sfantao marked 7 inline comments as done.
sfantao added a comment.
Hi Hal,
Thanks for the review! Comments inlined.
Comment at: include/clang/Driver/Action.h:504
+ /// unbundling action.
+ struct DependingActionInfoTy final {
+/// \brief The tool chain of the depending a
NoQ added inline comments.
Comment at: test/Analysis/dispatch-once.m:13
+
+void test_stack() {
+ dispatch_once_t once;
dcoughlin wrote:
> Should the tests for dispatch_once in unix-fns.c be moved here?
In fact we need to de-duplicate code with unix.API's pthread
NoQ updated this revision to Diff 75739.
NoQ marked 2 inline comments as done.
NoQ added a comment.
Consider a lot more dispatch_once_t regions: improve diagnostics for local
structs containing predicates, find ivar structs with predicates.
Address a couple of review comments, discuss the rest.
yaxunl created this revision.
yaxunl added a reviewer: Anastasia.
yaxunl added subscribers: cfe-commits, b-sumner.
https://reviews.llvm.org/D25954
Files:
lib/Headers/opencl-c.h
Index: lib/Headers/opencl-c.h
===
--- lib/Headers/op
sfantao updated this revision to Diff 75741.
sfantao marked 3 inline comments as done.
sfantao added a comment.
- Fix typos and use StringRef() instead of const char * to follow what the
Driver does today when it comes to specify the bound architectures.
https://reviews.llvm.org/D21853
Files:
jordan_rose added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:2493-2499
case Type::Adjusted:
- case Type::Decayed:
+ case Type::Decayed: {
// Decayed and adjusted types use the adjusted type in LLVM and DWARF.
-return CreateType(
-cast(cast(Ty)-
NoQ added inline comments.
Comment at: test/Analysis/CFNumber.c:39
+ unsigned char scalar = 0;
+ CFNumberGetValue(x, kCFNumberSInt16Type, &scalar); // expected-warning{{A
CFNumber object that represents a 16-bit integer is used to initialize an 8-bit
integer; 8 bits of the C
Author: epilk
Date: Tue Oct 25 14:05:50 2016
New Revision: 285098
URL: http://llvm.org/viewvc/llvm-project?rev=285098&view=rev
Log:
Reapply r284265: "[Sema] Refactor context checking for availability diagnostics"
The problem with the original commit was that some of Apple's headers depended
on an
CaseyCarter created this revision.
CaseyCarter added reviewers: EricWF, mclow.lists.
CaseyCarter added a subscriber: cfe-commits.
Fairly straightforward: simply removes the parameter names from the unused
parameters.
https://reviews.llvm.org/D25958
Files:
test/support/archetypes.hpp
Index:
Author: ericwf
Date: Tue Oct 25 14:33:14 2016
New Revision: 285100
URL: http://llvm.org/viewvc/llvm-project?rev=285100&view=rev
Log:
[libc++] Fix modules build - Rework __refstring definition
Summary:
`__libcpp_refstring` currently has two different definitions. First there is
the complete defi
EricWF updated this revision to Diff 75770.
EricWF added a comment.
- Address review comments by adding better documentation in the CHANGELOG.TXT.
https://reviews.llvm.org/D25593
Files:
CMakeLists.txt
lib/abi/CHANGELOG.TXT
lib/abi/x86_64-linux-gnu.abilist
Index: lib/abi/x86_64-linux-gnu.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285101: [libcxx] Build with -fvisibility-inlines-hidden --
Remove 20 inline definitions… (authored by EricWF).
Changed prior to commit:
https://reviews.llvm.org/D25593?vs=75770&id=75772#toc
Repository:
Author: ericwf
Date: Tue Oct 25 14:44:38 2016
New Revision: 285102
URL: http://llvm.org/viewvc/llvm-project?rev=285102&view=rev
Log:
Update revision number in CHANGELOG.TXT
Modified:
libcxx/trunk/lib/abi/CHANGELOG.TXT
Modified: libcxx/trunk/lib/abi/CHANGELOG.TXT
URL:
http://llvm.org/viewvc/
Author: ericwf
Date: Tue Oct 25 14:43:44 2016
New Revision: 285101
URL: http://llvm.org/viewvc/llvm-project?rev=285101&view=rev
Log:
[libcxx] Build with -fvisibility-inlines-hidden -- Remove 20 inline definitions
from the dylib
Summary:
This patch turns on `-fvisibility-inlines-hidden` when buil
aprantl added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:2493-2499
case Type::Adjusted:
- case Type::Decayed:
+ case Type::Decayed: {
// Decayed and adjusted types use the adjusted type in LLVM and DWARF.
-return CreateType(
-cast(cast(Ty)->get
Author: ericwf
Date: Tue Oct 25 15:07:49 2016
New Revision: 285107
URL: http://llvm.org/viewvc/llvm-project?rev=285107&view=rev
Log:
Get libc++abi building with LLVM_ENABLE_MODULES
Modified:
libcxxabi/trunk/src/CMakeLists.txt
Modified: libcxxabi/trunk/src/CMakeLists.txt
URL:
http://llvm.org
mgorny added a reviewer: beanz.
mgorny added a subscriber: beanz.
mgorny added a comment.
@beanz, could you also look at this one? I'd like to replace
CLANG_LIBDIR_SUFFIX with the runtimes suffix, and for this I'd have to get rid
of this CLANG_LIBDIR_SUFFIX occurrence as well. However, I don't t
Author: ericwf
Date: Tue Oct 25 15:45:17 2016
New Revision: 285117
URL: http://llvm.org/viewvc/llvm-project?rev=285117&view=rev
Log:
Fix nullptr tests
Modified:
libcxx/trunk/include/__nullptr
libcxx/trunk/test/std/language.support/support.types/nullptr_t.pass.cpp
Modified: libcxx/trunk/i
On Mon, Oct 24, 2016 at 4:58 PM, Bruno Cardoso Lopes via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Mon, Oct 24, 2016 at 4:17 PM, Richard Smith
> wrote:
> > On Mon, Oct 24, 2016 at 3:30 PM, Bruno Cardoso Lopes
> > wrote:
> >>
> >> > Sure, go ahead.
> >>
> >> I committed in r284797 and
Author: akirtzidis
Date: Tue Oct 25 16:11:22 2016
New Revision: 285120
URL: http://llvm.org/viewvc/llvm-project?rev=285120&view=rev
Log:
[index] Fixes for locations and relations in Objective C categories and
getters/setters
- Add entries for protocols on categories
- Add relation between catego
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D25954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MacOSXAPIChecker.cpp:94
+ else if (isa(RS)) {
+// FIXME: Presence of an IVar region has priority over this branch, because
+// ObjC objects are on the heap even if the core doesn't realize this.
---
Author: yaxunl
Date: Tue Oct 25 16:37:05 2016
New Revision: 285125
URL: http://llvm.org/viewvc/llvm-project?rev=285125&view=rev
Log:
[OpenCL] Add missing atom_xor for 64 bit to opencl-c.h
Differential Revision: https://reviews.llvm.org/D25954
Modified:
cfe/trunk/lib/Headers/opencl-c.h
Modif
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285125: [OpenCL] Add missing atom_xor for 64 bit to
opencl-c.h (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D25954?vs=75740&id=75797#toc
Repository:
rL LLVM
https://review
Author: compnerd
Date: Tue Oct 25 16:43:28 2016
New Revision: 285126
URL: http://llvm.org/viewvc/llvm-project?rev=285126&view=rev
Log:
CodeGen: be more conservative about setting section
The section names currently are MachO specific. Only set the section on the
variables if the file format is M
Author: srhines
Date: Tue Oct 25 16:44:35 2016
New Revision: 285127
URL: http://llvm.org/viewvc/llvm-project?rev=285127&view=rev
Log:
Use linker flag --fix-cortex-a53-843419 on Android ARM64 compilation.
Summary:
This is only forced on if there is no non-Cortex-A53 CPU specified as
well. Android'
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285127: Use linker flag --fix-cortex-a53-843419 on Android
ARM64 compilation. (authored by srhines).
Changed prior to commit:
https://reviews.llvm.org/D25761?vs=75174&id=75801#toc
Repository:
rL LLVM
This was a thinko on my part: clang's builtin headers include_next the
system headers, not the other way around, so the system headers should be
implicitly textual, not clang's headers. This patch fixes the problem for
me with glibc. Does this help for Darwin too?
On Tue, Oct 25, 2016 at 2:01 PM,
Missed one change from the test suite:
Index: test/Modules/cstd.m
===
--- test/Modules/cstd.m (revision 285117)
+++ test/Modules/cstd.m (working copy)
@@ -1,5 +1,5 @@
// RUN: rm -rf %t
-// RUN: %clang_cc1 -fsyntax-only -isystem %S/In
Hello,
> As far as I understand the whole problem is that the optimized functions are
> marked by __attribute__((pure)). If the attribute is removed from your
> example, we get LLVM dump preserving correctness:
>
> define i32 @bar(i32 %x) local_unnamed_addr #0 {
> entry:
> %call = tail call i3
ahatanak added reviewers: bruno, erik.pilkington, majnemer.
ahatanak added a comment.
Add more reviewers.
https://reviews.llvm.org/D25206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
rsmith added inline comments.
Comment at: lib/Parse/ParseExprCXX.cpp:951
Init = ParseInitializer();
+ Init = Actions.CorrectDelayedTyposInExpr(Init.get());
ahatanak wrote:
> mehdi_amini wrote:
> > What happens when there is no typo correctio
mehdi_amini added inline comments.
Comment at: lib/Parse/ParseExprCXX.cpp:951
Init = ParseInitializer();
+ Init = Actions.CorrectDelayedTyposInExpr(Init.get());
rsmith wrote:
> ahatanak wrote:
> > mehdi_amini wrote:
> > > What happens when t
zaks.anna added inline comments.
Comment at: test/Analysis/CFNumber.c:39
+ unsigned char scalar = 0;
+ CFNumberGetValue(x, kCFNumberSInt16Type, &scalar); // expected-warning{{A
CFNumber object that represents a 16-bit integer is used to initialize an 8-bit
integer; 8 bits of
jordan_rose added a comment.
> `_Nonnull` in this position seems very similar to `static` (which typically
> also implies non-nullness).
I wasn't actually sure if it was okay to assume this, but the standard does
seem pretty clear:
> If the keyword `static` also appears within the `[` and `]`
1 - 100 of 136 matches
Mail list logo
