sfantao added a comment.
Hi Hal,
Thanks for the review! Fixed the typos in the new diff.
================
Comment at: lib/Driver/Driver.cpp:1949
+ SpecializedBuilders.push_back(new OpenMPActionBuilder(C, Args, Inputs));
+
//
----------------
hfinkel wrote:
> Since we can have both OpenMP offloading and CUDA, please add a test that the
> phases work correctly for that case (or that we produce an error if that
> can't currently work correctly).
Added new test for that. The phases generation should work well if CUDA and
OpenMP offloading are used on the same file.
However, the bindings for these phases cannot be generated given that the NVPTX
toolchain support for OpenMP is not implemented yet and the CUDA implementation
interprets actions differently, e.g. in CUDA linking is the combination of
binaries of different devices (GPUs) whereas for OpenMP actual linking takes
place, i.e. symbols are resolved by looking into other compilation units.
https://reviews.llvm.org/D21845
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
