alexshap created this revision.
alexshap added reviewers: NoQ, zaks.anna.
alexshap added a subscriber: cfe-commits.
alexshap set the repository for this revision to rL LLVM.
The class DataflowWorklist internally maintains a sorted list of pointers to
CFGBlock and
the method enqueuePredecessors ha
Author: hokein
Date: Wed Oct 12 02:59:54 2016
New Revision: 283981
URL: http://llvm.org/viewvc/llvm-project?rev=283981&view=rev
Log:
[ClangTidy] Add UsingInserter and NamespaceAliaser
Summary: This adds helper classes to add using declaractions and namespace
aliases to function bodies. These hel
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283981: [ClangTidy] Add UsingInserter and NamespaceAliaser
(authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D24997?vs=74311&id=74338#toc
Repository:
rL LLVM
https://reviews.ll
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: change-namespace/ChangeNamespace.cpp:387
+ Token Tok;
+ while (!Lex->LexFromRawLexer(Tok) && Tok.isNot(tok::TokenKind::l_brace)) {
+ }
i
danielmarjamaki added inline comments.
Comment at: clang-tidy/readability/RedundantDeclarationCheck.cpp:60
+auto Diag = diag(D->getLocation(), "redundant '%0' declaration")
+<< cast(D)->getName();
+if (!MultiVar && !DifferentHeaders)
alexfh wrote:
Author: ericwf
Date: Wed Oct 12 03:09:22 2016
New Revision: 283983
URL: http://llvm.org/viewvc/llvm-project?rev=283983&view=rev
Log:
Protect special members of NullBase archetype to avoid exposing them
Modified:
libcxx/trunk/test/support/archetypes.hpp
Modified: libcxx/trunk/test/support/arc
Author: hokein
Date: Wed Oct 12 03:19:44 2016
New Revision: 283985
URL: http://llvm.org/viewvc/llvm-project?rev=283985&view=rev
Log:
Revert "[ClangTidy] Add UsingInserter and NamespaceAliaser"
This reverts commit r283981. This patch breaks the buildbot.
Removed:
clang-tools-extra/trunk/clang
hokein added a comment.
@jbangert, your patch broke the buildbot, and I reverted it in r283985. You
need to add the new source files to the CMakefile. (I saw other compilation
errors after I updated the cmake files, Could you take a look on it? )
Repository:
rL LLVM
https://reviews.llvm.org
rmaprath added a comment.
In https://reviews.llvm.org/D21803#567774, @tavianator wrote:
> In https://reviews.llvm.org/D21803#556857, @EricWF wrote:
>
> > @rmaprath I'll merge this if needed. Feel free to commit your patch first.
>
>
> Yeah, @rmaprath I'm happy to rebase this over your patch.
My
Author: mkurdej
Date: Wed Oct 12 03:32:59 2016
New Revision: 283986
URL: http://llvm.org/viewvc/llvm-project?rev=283986&view=rev
Log:
[clang-tidy-vs] Fix ClangTidy extension name in the manifest.
Modified:
clang-tools-extra/trunk/clang-tidy-vs/source.extension.vsixmanifest.in
Modified: clang
Author: ericwf
Date: Wed Oct 12 03:54:10 2016
New Revision: 283988
URL: http://llvm.org/viewvc/llvm-project?rev=283988&view=rev
Log:
Provide a fallback __cxa_thread_atexit() implementation. Patch from Tavian
Barnes
Added:
libcxxabi/trunk/test/thread_local_destruction_order.pass.cpp
Modified:
EricWF closed this revision.
EricWF added a comment.
Committed as r283988. Thanks for the patch!
https://reviews.llvm.org/D21803
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D25492
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
On 12 October 2016 at 08:59, Haojian Wu via cfe-commits
wrote:
> Author: hokein
> Date: Wed Oct 12 02:59:54 2016
> New Revision: 283981
>
> URL: http://llvm.org/viewvc/llvm-project?rev=283981&view=rev
> Log:
> [ClangTidy] Add UsingInserter and NamespaceAliaser
Hi Haojian,
Many, if not all buildb
Author: ericwf
Date: Wed Oct 12 04:06:12 2016
New Revision: 283991
URL: http://llvm.org/viewvc/llvm-project?rev=283991&view=rev
Log:
Remove use of _VSTD::__invoke in the not_fn tests
Modified:
libcxx/trunk/test/std/utilities/function.objects/func.not_fn/not_fn.pass.cpp
Modified:
libcxx/trun
Author: ericwf
Date: Wed Oct 12 04:20:58 2016
New Revision: 283993
URL: http://llvm.org/viewvc/llvm-project?rev=283993&view=rev
Log:
Fix use of C++14 constexpr in C++11
Modified:
libcxx/trunk/test/support/archetypes.ipp
Modified: libcxx/trunk/test/support/archetypes.ipp
URL:
http://llvm.org
Author: ericwf
Date: Wed Oct 12 04:31:26 2016
New Revision: 283994
URL: http://llvm.org/viewvc/llvm-project?rev=283994&view=rev
Log:
Fix nasty_containers.hpp for other stdlibs
Modified:
libcxx/trunk/test/support/nasty_containers.hpp
libcxx/trunk/test/support/test_macros.h
Modified: libcx
Author: arphaman
Date: Wed Oct 12 04:36:35 2016
New Revision: 283995
URL: http://llvm.org/viewvc/llvm-project?rev=283995&view=rev
Log:
[Sema] Handle transparent_union attributes in C mode only
This commit marks the transparent_union attributes as C only because clang
doesn't support them in C++ m
Author: ericwf
Date: Wed Oct 12 04:48:44 2016
New Revision: 283996
URL: http://llvm.org/viewvc/llvm-project?rev=283996&view=rev
Log:
Fix more C++11 constexpr issues in the tests
Modified:
libcxx/trunk/test/support/archetypes.hpp
Modified: libcxx/trunk/test/support/archetypes.hpp
URL:
http:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283995: [Sema] Handle transparent_union attributes in C mode
only (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D25308?vs=74127&id=74350#toc
Repository:
rL LLVM
https://r
Author: ericwf
Date: Wed Oct 12 04:53:35 2016
New Revision: 283997
URL: http://llvm.org/viewvc/llvm-project?rev=283997&view=rev
Log:
support --param=std=gnu++XX
Modified:
libcxx/trunk/test/libcxx/test/config.py
Modified: libcxx/trunk/test/libcxx/test/config.py
URL:
http://llvm.org/viewvc/ll
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added subscribers: bkramer, cfe-commits.
Herald added subscribers: mgorny, beanz.
This patch is kind of reverting r283202 (but keep the updated lint test),
because it leads to a few annoying problems by comparing absolute file p
v.g.vassilev updated this revision to Diff 74353.
v.g.vassilev marked 2 inline comments as done.
v.g.vassilev added a comment.
We should not access the IsThisDeclarationADemotedDefinition bits if the decl
is ParmVarDecl.
https://reviews.llvm.org/D24508
Files:
include/clang/AST/Decl.h
lib/A
rengolin added inline comments.
Comment at: test/Driver/denormal-fp-math.c:4
// RUN: %clang -### -target arm-unknown-linux-gnu -c %s
-fdenormal-fp-math=positive-zero -v 2>&1 | FileCheck -check-prefix=CHECK-PZ %s
+// RUN: %clang -### -target arm-unknown-linux-gnu -c %s
-fdenorm
Author: ericwf
Date: Wed Oct 12 05:19:48 2016
New Revision: 283999
URL: http://llvm.org/viewvc/llvm-project?rev=283999&view=rev
Log:
Remove usages of _ALIGNAS_TYPE
Modified:
libcxx/trunk/test/std/atomics/atomics.flag/default.pass.cpp
libcxx/trunk/test/std/atomics/atomics.types.generic/add
Author: ericwf
Date: Wed Oct 12 05:28:09 2016
New Revision: 284002
URL: http://llvm.org/viewvc/llvm-project?rev=284002&view=rev
Log:
Remove usages of _LIBCPP_CONSTEXPR under test/std
Modified:
libcxx/trunk/test/std/numerics/rand/rand.adapt/rand.adapt.ibits/eval.pass.cpp
libcxx/trunk/tes
Author: ericwf
Date: Wed Oct 12 06:20:27 2016
New Revision: 284004
URL: http://llvm.org/viewvc/llvm-project?rev=284004&view=rev
Log:
Unbreak C++03 build
Modified:
libcxx/trunk/test/support/test_macros.h
Modified: libcxx/trunk/test/support/test_macros.h
URL:
http://llvm.org/viewvc/llvm-proje
Author: ericwf
Date: Wed Oct 12 06:29:18 2016
New Revision: 284005
URL: http://llvm.org/viewvc/llvm-project?rev=284005&view=rev
Log:
Remove incorrect XFAILS
Modified:
libcxx/trunk/test/libcxx/utilities/optional/optional.object/optional.object.assign/copy.pass.cpp
libcxx/trunk/test/libcx
Thanks!
I still have that no-exception cleanup in my TODO list. Just pressed on
time, hope to get to it soon.
/ Asiri
On Wed, Oct 12, 2016 at 12:29 PM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Wed Oct 12 06:29:18 2016
> New Revision: 284005
>
>
Author: ericwf
Date: Wed Oct 12 06:35:37 2016
New Revision: 284006
URL: http://llvm.org/viewvc/llvm-project?rev=284006&view=rev
Log:
Correctly grant rebound limited_allocators friendship.
Modified:
libcxx/trunk/test/support/test_allocator.h
Modified: libcxx/trunk/test/support/test_allocator.
Author: arphaman
Date: Wed Oct 12 06:40:15 2016
New Revision: 284007
URL: http://llvm.org/viewvc/llvm-project?rev=284007&view=rev
Log:
[CodeCompletion] Show protocol properties that are accessed through qualified id
This commit improves code completion for properties that are declared in
Objectiv
I just committed those tests, so I kinda had to fix them :-P
On Wed, Oct 12, 2016 at 5:40 AM, Asiri Rathnayake <
asiri.rathnay...@gmail.com> wrote:
> Thanks!
>
> I still have that no-exception cleanup in my TODO list. Just pressed on
> time, hope to get to it soon.
>
> / Asiri
>
> On Wed, Oct 12,
More love for no-exceptions in any case ;)
Cheers!
On Wed, Oct 12, 2016 at 12:52 PM, Eric Fiselier wrote:
> I just committed those tests, so I kinda had to fix them :-P
>
> On Wed, Oct 12, 2016 at 5:40 AM, Asiri Rathnayake <
> asiri.rathnay...@gmail.com> wrote:
>
>> Thanks!
>>
>> I still have t
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/RedundantDeclarationCheck.cpp:60
+auto Diag = diag(D->getLocation(), "redundant '%0' declaration")
+<< cast(D)->getName();
+if (!MultiVar && !DifferentHeaders)
danielmarjamaki
Author: vvassilev
Date: Wed Oct 12 06:57:08 2016
New Revision: 284008
URL: http://llvm.org/viewvc/llvm-project?rev=284008&view=rev
Log:
Reinstate r283887 and r283882.
Original message:
"[modules] PR28752: Do not instantiate variable declarations which are not
visible.
https://reviews.llvm.org/D
SjoerdMeijer updated this revision to Diff 74363.
SjoerdMeijer added a comment.
Thanks for catching this: the logic and test have been updated.
https://reviews.llvm.org/D25479
Files:
lib/Driver/Tools.cpp
test/Driver/denormal-fp-math.c
Index: test/Driver/denormal-fp-math.c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284007: [CodeCompletion] Show protocol properties that are
accessed through qualified id (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D25436?vs=74227&id=74364#toc
Repositor
Author: javed.absar
Date: Wed Oct 12 07:13:55 2016
New Revision: 284009
URL: http://llvm.org/viewvc/llvm-project?rev=284009&view=rev
Log:
[ARM] Fix - missing target-cpu in test
Fixes an incomplete test, wherein the target-cpu name (cortex-r52) was missing.
Differential Revision: http://reviews.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284009: [ARM] Fix - missing target-cpu in test (authored by
javed.absar).
Changed prior to commit:
https://reviews.llvm.org/D25474?vs=74247&id=74365#toc
Repository:
rL LLVM
https://reviews.llvm.org/
joerg added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:11370
+// we are here such increase has not been enough. So pointing the first
+// FieldDecl that either is packed orelse its RecordDecl is,
+// seems reasonable.
Missing space.
http
v.g.vassilev closed this revision.
v.g.vassilev marked an inline comment as done.
v.g.vassilev added a comment.
Relanded in r284008.
https://reviews.llvm.org/D24508
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Author: ioeric
Date: Wed Oct 12 07:34:18 2016
New Revision: 284011
URL: http://llvm.org/viewvc/llvm-project?rev=284011&view=rev
Log:
[change-namespace] don't miss comments in the beginning of a namespace block.
Reviewers: hokein
Subscribers: cfe-commits
Differential Revision: https://reviews.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284011: [change-namespace] don't miss comments in the
beginning of a namespace block. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D25397?vs=74038&id=74368#toc
Repository:
smeenai added a comment.
In https://reviews.llvm.org/D25145#565027, @mclow.lists wrote:
> Sigh. Make an expedient choice that you don't really agree with, and you get
> immediately reminded of it. I suggested on an earlier review (not this
> patch) that I really didn't want to see `_WIN32` in
Author: smeenai
Date: Wed Oct 12 08:48:14 2016
New Revision: 284016
URL: http://llvm.org/viewvc/llvm-project?rev=284016&view=rev
Log:
[libc++] Correct explanation of _LIBCPP_NEW_DELETE_VIS
The behavior of this macro actually needs to apply universally on
Windows and not just when using the Micros
NoQ added a comment.
Yay, thanks for posting this! :)
I've got a bit of concern for some assert-suppressions.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:2314
{
+ // Return to fulfil assert condition
+ if (location.getAs())
Hmm. Why would anybody try
smeenai closed this revision.
smeenai added a comment.
Not sure why Phabricator isn't closing this out, but this was committed as SVN
r284016
https://reviews.llvm.org/D25145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
hokein updated this revision to Diff 74375.
hokein added a comment.
Update the patch based on offline discussion.
https://reviews.llvm.org/D25508
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/database_template.json
test/clang-move/move-class.cpp
Index: test/clang-move/move-clas
elsteveogrande added a comment.
Ping again -- addressed all issues, looking ok now?
Note about this change + review process here. First I know the every 1-2 day
pinging generates noise on the lists, and for that I'm SorryNotSorry :-p
I just want to ensure this is reaching at least the right p
tejohnson added a comment.
Ping. It seems like using attributes is not feasible at this time due to the
lack of data attributes.
https://reviews.llvm.org/D24644
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg with one nit.
Comment at: clang-move/ClangMove.cpp:410
std::string AbsolutePath = MakeAbsolutePath(SM, FileName);
if (MakeAbsolutePath(OriginalRunningDirectory, Spec
taniabarg updated this revision to Diff 74377.
taniabarg added a comment.
Added test to test/Sema/builtin-unary-fp.c that will fail without the proposed
change (without the change, the test will -not- attempt to implicitly cast the
5th parameter to int).
https://reviews.llvm.org/D25480
Files:
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG with a nit
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:312
+ assert(ArgLVal.getType()->isPointerType());
+ ArgAddr = this->EmitLoadOfPointer(
+
hokein updated this revision to Diff 74382.
hokein added a comment.
Update.
https://reviews.llvm.org/D25508
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/database_template.json
test/clang-move/move-class.cpp
Index: test/clang-move/move-class.cpp
=
ABataev added a comment.
Ping
https://reviews.llvm.org/D22955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane updated this revision to Diff 74386.
erichkeane marked an inline comment as done.
erichkeane added a comment.
Fixed Alexey's nit. Will need someone else to commit this, I don't yet have
commit access.
https://reviews.llvm.org/D25373
Files:
lib/CodeGen/CGStmtOpenMP.cpp
test/Code
Author: arphaman
Date: Wed Oct 12 10:33:35 2016
New Revision: 284019
URL: http://llvm.org/viewvc/llvm-project?rev=284019&view=rev
Log:
NFC: CodeCompletionResult's constructor should take const NamedDecl
CodeCompletionResult's Declaration field is a const pointer to the
NamedDecl, and thus the con
ABataev added a comment.
I will commit it for you, Erich, no problems
https://reviews.llvm.org/D25373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai added a comment.
In https://reviews.llvm.org/D25208#564930, @EricWF wrote:
> Why do you want to build `libc++.so` with hidden visibility? What's wrong
> with the existing way we build `libc++.so`?
There's nothing wrong with the existing way, per se. I personally prefer hidden
visibil
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: test/Sema/builtins-x86_64.c:17
+ v8ll vec8longlongs;
+ (void)__builtin_ia32_readeflags_u64(); //
expected-error{{use of unknown buil
arphaman created this revision.
arphaman added a reviewer: manmanren.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch extracts two new functions from the function
`FormatFunctionParameter` that are related to Objective-C block formatt
Author: hokein
Date: Wed Oct 12 10:50:30 2016
New Revision: 284020
URL: http://llvm.org/viewvc/llvm-project?rev=284020&view=rev
Log:
[clang-move] Compare with real paths of symlinks
Summary: MakeAbsolutePath does wrong things with symlinks previously. When
comparing with a symlink, we need to co
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284020: [clang-move] Compare with real paths of symlinks
(authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25508?vs=74382&id=74391#toc
Repository:
rL LLVM
https://reviews.llvm
arphaman created this revision.
arphaman added reviewers: manmanren, doug.gregor.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch depends on https://reviews.llvm.org/D25519.
This patch changes the way that Objective-C block properties
Author: marshall
Date: Wed Oct 12 11:13:48 2016
New Revision: 284021
URL: http://llvm.org/viewvc/llvm-project?rev=284021&view=rev
Log:
Mark ostream_iterator's constructors as noexcept.
Modified:
libcxx/trunk/include/iterator
Modified: libcxx/trunk/include/iterator
URL:
http://llvm.org/viewv
yaxunl retitled this revision from "[OpenCL] Mark group functions as
noduplicate in opencl-c.h" to "[OpenCL] Mark group functions as convergent in
opencl-c.h".
yaxunl updated the summary for this revision.
yaxunl added a reviewer: aaron.ballman.
yaxunl updated this revision to Diff 74394.
https:
hiraditya created this revision.
hiraditya added reviewers: EricWF, mclow.lists.
hiraditya added subscribers: sebpop, cfe-commits.
https://reviews.llvm.org/D25522
Files:
libcxx/benchmarks/ContainerBenchmarks.hpp
libcxx/benchmarks/GenerateInput.hpp
Index: libcxx/benchmarks/GenerateInput.hpp
agutowski updated this revision to Diff 74398.
agutowski added a comment.
add -fno-spell-checking to tests
https://reviews.llvm.org/D25494
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Basic/BuiltinsX86_64.def
lib/Basic/Targets.cpp
lib/Sema/SemaChecking.cpp
test/CodeGen/bui
Author: agutowski
Date: Wed Oct 12 12:28:44 2016
New Revision: 284026
URL: http://llvm.org/viewvc/llvm-project?rev=284026&view=rev
Log:
Move x86-64 builtins from SemaChecking.cpp to BuiltinsX86_64.def
Summary: Follow-up to https://reviews.llvm.org/D24598 (separating builtins for
x84-64 and i386)
manmanren added a comment.
Cheers,
Manman
Comment at: lib/Sema/SemaCodeComplete.cpp:2165
+static void findTypeLocationForBlockDecl(const TypeSourceInfo *TSInfo,
+ FunctionTypeLoc &Block,
Please add comments for the help
majnemer added inline comments.
Comment at: lib/Sema/SemaLookup.cpp:1044-1070
+static bool isBaseClass(const CXXRecordDecl *Record, CXXRecordDecl *Base) {
+ SmallVector Queue;
+
+ while (true) {
+for (const auto &I : Record->bases()) {
+ const RecordType *Ty = I.getTyp
phosek updated this revision to Diff 74402.
phosek marked an inline comment as done.
Repository:
rL LLVM
https://reviews.llvm.org/D25491
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.txt
+++ CMakeLists.txt
@@
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:378
+ Lexer::getLocForEndOfToken(Range.getEnd(), 0, SM,
Context->getLangOpts());
+ bool Whitespace = isWhitespace(*FullSourceLoc(Next, SM).getCharacterData());
+
malcolm
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:612
+ let Content = [{
+The ``convergent`` attribute can be placed on function declarations. It is
+translated to LLVM ``convergent`` attribute, which indicates the call
on a functi
Hi Vassil,
Any change between this commit and “r283887 + r283882”?
And what was the issue that caused the revert?
Thanks,
Manman
> On Oct 12, 2016, at 4:57 AM, Vassil Vassilev via cfe-commits
> wrote:
>
> Author: vvassilev
> Date: Wed Oct 12 06:57:08 2016
> New Revision: 284008
>
> URL: http
akyrtzi added a comment.
What if the user just wants to invoke the block, this is as common or more,
like:
`self.onEventHandler(10)`
The assign literal completion is useful but it should be an additional entry
(with maybe lower priority) not replace the property completion.
BTW, it would be gr
Author: kcc
Date: Wed Oct 12 13:33:54 2016
New Revision: 284029
URL: http://llvm.org/viewvc/llvm-project?rev=284029&view=rev
Log:
Document potential implementation of CFI in hardware.
Summary: Document potential implementation of CFI in hardware.
Reviewers: eugenis, pcc
Subscribers: llvm-commit
hfinkel added inline comments.
Comment at: CMakeLists.txt:327
# Required flags ==
set(LIBCXX_STANDARD_VER c++11 CACHE INTERNAL "internal option to change build
dialect")
add_compile_flags_if_supported(-std=${LIBCXX_S
zaks.anna added a comment.
Do you have results that show how this effects performance on average code and
machine generated code?
One concern is that multiset is malloc intensive. See
http://llvm.org/docs/ProgrammersManual.html#picking-the-right-data-structure-for-a-task.
Maybe SparseSet/Spars
idlecode updated this revision to Diff 74412.
https://reviews.llvm.org/D25439
Files:
lib/Format/FormatTokenLexer.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
===
--- unittests/Format/FormatTest.cpp
NoQ added a reviewer: a.sidorin.
NoQ added a comment.
This looks familiar, i think i've seen significant slowdowns around there on
some very rare files. Nice catch! Probably a binary-search insert could have
also been much better than re-sorting, even if it's still a vector.
Repository:
rL L
Author: arnolds
Date: Wed Oct 12 13:59:24 2016
New Revision: 284032
URL: http://llvm.org/viewvc/llvm-project?rev=284032&view=rev
Log:
Declare WinX86_64ABIInfo to satisfy SwiftABI info
This is minimal support that allows swift's test cases on non windows platforms
to pass.
rdar://28738985
Added:
Author: ygao
Date: Wed Oct 12 14:33:33 2016
New Revision: 284033
URL: http://llvm.org/viewvc/llvm-project?rev=284033&view=rev
Log:
[NFC] Trial change to remove a redundant blank line.
Modified:
cfe/trunk/lib/Headers/xmmintrin.h
Modified: cfe/trunk/lib/Headers/xmmintrin.h
URL:
http://llvm.or
BillyONeal created this revision.
BillyONeal added reviewers: EricWF, mclow.lists.
BillyONeal added a subscriber: cfe-commits.
The string_view::copy test calls std::min, which is not required to be
made available by including .
(The MSVC++ STL does not use std::min internally because we need to
a
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
@BillyONeal Do you have commit access?
https://reviews.llvm.org/D25531
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
BillyONeal added a comment.
No, I don't believe any of us in MSVC++ land have commit access.
https://reviews.llvm.org/D25531
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:378
+ Lexer::getLocForEndOfToken(Range.getEnd(), 0, SM,
Context->getLangOpts());
+ bool Whitespace = isWhitespace(*FullSourceLoc(Next, SM).getCharacterData());
+
aaron
alexshap added inline comments.
Comment at: lib/Analysis/LiveVariables.cpp:66
return nullptr;
- const CFGBlock *b = worklist.pop_back_val();
+ const auto I = --worklist.end();
+ const CFGBlock *b = *I;
zaks.anna wrote:
> '--wroklist.end()' -> 'worklist.rb
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:378
+ Lexer::getLocForEndOfToken(Range.getEnd(), 0, SM,
Context->getLangOpts());
+ bool Whitespace = isWhitespace(*FullSourceLoc(Next, SM).getCharacterData());
+
malcolm
alexshap added inline comments.
Comment at: lib/Analysis/LiveVariables.cpp:66
return nullptr;
- const CFGBlock *b = worklist.pop_back_val();
+ const auto I = --worklist.end();
+ const CFGBlock *b = *I;
alexshap wrote:
> zaks.anna wrote:
> > '--wroklist.en
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D24644
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
alexshap added inline comments.
Comment at: lib/Analysis/LiveVariables.cpp:66
return nullptr;
- const CFGBlock *b = worklist.pop_back_val();
+ const auto I = --worklist.end();
+ const CFGBlock *b = *I;
alexshap wrote:
> alexshap wrote:
> > zaks.anna wrote
Author: dim
Date: Wed Oct 12 15:26:47 2016
New Revision: 284047
URL: http://llvm.org/viewvc/llvm-project?rev=284047&view=rev
Log:
Disable trivial pair copy/move tests when unsupported
Summary:
On FreeBSD, for ABI compatibility reasons, the pair trivial copy
constructor is disabled, using the aptl
Hi Manman,
On 12/10/16 20:28, Manman wrote:
Hi Vassil,
Any change between this commit and “r283887 + r283882”?
The only extra change is in:
+ bool isThisDeclarationADemotedDefinition() const {
+return isa(this) ? false :
+ NonParmVarDeclBits.IsThisDeclarationADemotedDefinition;
+ }
Author: arnolds
Date: Wed Oct 12 15:30:24 2016
New Revision: 284048
URL: http://llvm.org/viewvc/llvm-project?rev=284048&view=rev
Log:
Specify a target cpu in test case
Hopefully, this makes the bots happy
Modified:
cfe/trunk/test/CodeGen/windows-swiftcall.c
Modified: cfe/trunk/test/CodeGen/
agutowski updated this revision to Diff 74435.
agutowski added a comment.
rebase
https://reviews.llvm.org/D25264
Files:
include/clang/Basic/BuiltinsARM.def
include/clang/Basic/BuiltinsX86.def
include/clang/Basic/BuiltinsX86_64.def
lib/Basic/Targets.cpp
lib/CodeGen/CGBuiltin.cpp
lib/
alexshap updated the summary for this revision.
alexshap updated this revision to Diff 74437.
alexshap added a comment.
Switch to priority queue.
I have rerun the tests - they are all green.
I will post the numbers about the perf a bit later.
Repository:
rL LLVM
https://reviews.llvm.org/D2550
phosek updated this revision to Diff 74439.
phosek marked an inline comment as done.
Repository:
rL LLVM
https://reviews.llvm.org/D25491
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.txt
+++ CMakeLists.txt
@@
> On Oct 12, 2016, at 1:39 PM, Vassil Vassilev wrote:
>
> Hi Manman,
> On 12/10/16 20:28, Manman wrote:
>> Hi Vassil,
>>
>> Any change between this commit and “r283887 + r283882”?
> The only extra change is in:
>
> + bool isThisDeclarationADemotedDefinition() const {
> +return isa(this) ?
Author: arnolds
Date: Wed Oct 12 16:36:15 2016
New Revision: 284055
URL: http://llvm.org/viewvc/llvm-project?rev=284055&view=rev
Log:
Remove basic block label in test case
Another attempt to make a bot happy
Modified:
cfe/trunk/test/CodeGen/windows-swiftcall.c
Modified: cfe/trunk/test/CodeG
1 - 100 of 135 matches
Mail list logo
