jlebar closed this revision.
jlebar added a comment.
https://github.com/llvm-mirror/clang/commit/7b7c816e52feba6f89acde8b43bb0d67b5042697
https://reviews.llvm.org/D25421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
jlebar closed this revision.
jlebar added a comment.
https://github.com/llvm-mirror/clang/commit/7c4b8c0a7921b999f5a73d6ba47ee8350676f747
https://reviews.llvm.org/D25420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
jlebar closed this revision.
jlebar added a comment.
https://github.com/llvm-mirror/clang/commit/1f062cda84f537547021640c8bcd9c589c418d96
https://reviews.llvm.org/D25405
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: include/clang/AST/Decl.h:1222
+ void demoteThisDefinitionToDeclaration() {
+assert (!isThisDeclarationADemotedDefinition() && "Aleady demoted!");
+as
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Closed in rL283788.
Repository:
rL LLVM
https://reviews.llvm.org/D25414
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Author: mehdi_amini
Date: Mon Oct 10 17:52:47 2016
New Revision: 283815
URL: http://llvm.org/viewvc/llvm-project?rev=283815&view=rev
Log:
Store FileEntry::Filename as a StringRef instead of raw pointer (NFC)
Modified:
cfe/trunk/include/clang/Basic/FileManager.h
cfe/trunk/lib/Basic/FileMan
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in rL283777.
https://reviews.llvm.org/D25244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL283543.
https://reviews.llvm.org/D25210
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
jhen updated this revision to Diff 74184.
jhen added a comment.
- Prevent multiple fixes for macro expansion
https://reviews.llvm.org/D25450
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
test/clang-tidy/readability-identifier-naming.cpp
Index: test/clang-tidy/readability-identifi
jhen added a comment.
I just found and fixed another bug in this patch. Before, I wasn't using the
spelling location for the fixit hint. This meant that a macro argument that was
expanded to two locations, for example, would have the same fixit hint applied
to it twice. My new test case verifie
Author: mehdi_amini
Date: Mon Oct 10 18:24:16 2016
New Revision: 283819
URL: http://llvm.org/viewvc/llvm-project?rev=283819&view=rev
Log:
Fix clang-tools-extra build after r283815 (Store FileEntry::Filename as a
StringRef instead of raw pointer)
Modified:
clang-tools-extra/trunk/clang-apply
bruno updated this revision to Diff 74185.
bruno added a comment.
Update after Vedant's review!
https://reviews.llvm.org/D24516
Files:
include/clang/Frontend/CompilerInvocation.h
lib/Frontend/CompilerInvocation.cpp
test/Driver/show-option-names.c
Index: test/Driver/show-option-names.c
=
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Lgtm, with one potential nit.
Comment at: test/Driver/show-option-names.c:4
+// RUN: %clang -c -target i386-apple-darwin10 -fno-diagnostics-show-option
-isysroot /FOO %s 2>&1 | Fi
jbangert updated this revision to Diff 74187.
jbangert marked 15 inline comments as done.
https://reviews.llvm.org/D24997
Files:
clang-tidy/utils/ASTUtils.cpp
clang-tidy/utils/ASTUtils.h
clang-tidy/utils/NamespaceAliaser.cpp
clang-tidy/utils/NamespaceAliaser.h
clang-tidy/utils/UsingInse
manmanren added a comment.
Nice cleanup! Thanks for working on this,
Manman
Comment at: include/clang/Sema/DelayedDiagnostic.h:232
union {
/// Deprecation
struct DD DeprecationData;
Can you update this comment now we have generalized this to handl
Author: bruno
Date: Mon Oct 10 19:01:22 2016
New Revision: 283827
URL: http://llvm.org/viewvc/llvm-project?rev=283827&view=rev
Log:
[Driver][Diagnostics] Make 'show option names' default for driver warnings
Currently, driver level warnings do not show option names (e.g. warning:
complain about fo
rsmith added a comment.
As discussed on IRC, I have a mild concern about using
`-fsave-optimization-record` (with no argument) to enable the feature, and
`-fsave-optimization-record=X` to enable the feature and specify a filename; in
most (but not all) cases, `-option arg` and `-option=arg` mea
bruno closed this revision.
bruno added a comment.
Committed r283827
Comment at: test/Driver/show-option-names.c:4
+// RUN: %clang -c -target i386-apple-darwin10 -fno-diagnostics-show-option
-isysroot /FOO %s 2>&1 | FileCheck --check-prefix=CHECK-NO-SHOW-OPTION-NAMES %s
+// CH
hfinkel added a comment.
In https://reviews.llvm.org/D25225#566854, @rsmith wrote:
> As discussed on IRC, I have a mild concern about using
> `-fsave-optimization-record` (with no argument) to enable the feature, and
> `-fsave-optimization-record=X` to enable the feature and specify a filename;
Author: rsmith
Date: Mon Oct 10 19:21:10 2016
New Revision: 283830
URL: http://llvm.org/viewvc/llvm-project?rev=283830&view=rev
Log:
Aligned allocation versus CUDA: make deallocation function preference order
match other CUDA preference orders, per discussion with jlebar. We now model
this in an a
Author: jlebar
Date: Mon Oct 10 19:23:53 2016
New Revision: 283833
URL: http://llvm.org/viewvc/llvm-project?rev=283833&view=rev
Log:
[Sema] Add explicit move constructor for ExpressionEvaluationContextRecord.
This is needed to keep MSVC 2013 happy.
Modified:
cfe/trunk/include/clang/Sema/Sema
agutowski created this revision.
agutowski added reviewers: rnk, hans, majnemer, thakis.
agutowski added a subscriber: cfe-commits.
Declarations for the builtins were created when suspected of being corrections
for a typo. That could trigger some absurd warnings about missing headers.
https://r
Author: hfinkel
Date: Mon Oct 10 19:26:09 2016
New Revision: 283834
URL: http://llvm.org/viewvc/llvm-project?rev=283834&view=rev
Log:
Add an option to save the backend-produced YAML optimization record to a file
The backend now has the capability to save information from optimizations, the
same i
majnemer added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8795-8798
+if (S.Diags.getDiagnosticLevel(
+diag::warn_typecheck_vector_element_sizes_not_equal, Loc) ==
+DiagnosticsEngine::Level::Error)
+ return Qual
Author: hfinkel
Date: Mon Oct 10 20:05:45 2016
New Revision: 283839
URL: http://llvm.org/viewvc/llvm-project?rev=283839&view=rev
Log:
Fixup test/Driver/opt-record.c for nvptx pointer size
On some systems, it looks like nvptx is used instead of nvptx64.
Modified:
cfe/trunk/test/Driver/opt-rec
thakis added a comment.
rtrieu: Is there some global "are we in typo correction?" bit somewhere already?
Comment at: lib/CodeGen/CGBuiltin.cpp:800
+ case Builtin::BI_byteswap_ulong:
+ case Builtin::BI_byteswap_uint64:
case Builtin::BI__builtin_bswap16:
Is
elsteveogrande added a comment.
cc a few more devs who have dealt with frontend lately and might be familiar
with this part. :)
https://reviews.llvm.org/D25153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
agutowski added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:800
+ case Builtin::BI_byteswap_ulong:
+ case Builtin::BI_byteswap_uint64:
case Builtin::BI__builtin_bswap16:
thakis wrote:
> Is this an unrelated change?
Yeah, mostly - I had to fix this
rsmith added a comment.
It sounds like this will hinder our ability to typo-correct to builtins. I
think we only want to suppress implicitly declaring *library* builtins here
(those that are expected to be provided by a header), not all builtins.
https://reviews.llvm.org/D25458
hfinkel added a comment.
In https://reviews.llvm.org/D25403#565603, @jlebar wrote:
> Although these pass the CUDA test-suite tests (which I haven't yet committed
> because they're broken without this change), I could use some help running
> the libcxx tests.
>
> I cannot find any documentation
- Original Message -
> From: "Justin Lebar"
> To: "Hal Finkel"
> Cc: "Clang Commits"
> Sent: Saturday, October 8, 2016 10:56:37 PM
> Subject: Re: r283680 - [CUDA] Support and std::min/max on the
> device.
>
> > > The fix is not as simple as simply changing our implementation of
> > e.
vsk added inline comments.
Comment at: test/Preprocessor/dump_include.c:3
+// RUN: %clang_cc1 -w -E -dI -isystem %S %s -o - | grep '^#include *"dump_'
+// RUN: %clang_cc1 -w -E -dI -isystem %S %s -o - | grep '^#include_next
*"dump_'
+// RUN: %clang_cc1 -w -E -dI -isystem %S -ima
Author: djasper
Date: Tue Oct 11 01:13:18 2016
New Revision: 283853
URL: http://llvm.org/viewvc/llvm-project?rev=283853&view=rev
Log:
Explicitly ignore return code in test for test systems that use pipefail
Modified:
cfe/trunk/test/Driver/show-option-names.c
Modified: cfe/trunk/test/Driver/s
201 - 233 of 233 matches
Mail list logo
