vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Lgtm, with one potential nit.
================
Comment at: test/Driver/show-option-names.c:4
+// RUN: %clang -c -target i386-apple-darwin10 -fno-diagnostics-show-option
-isysroot /FOO %s 2>&1 | FileCheck --check-prefix=CHECK-NO-SHOW-OPTION-NAMES %s
+// CHECK-NO-SHOW-OPTION-NAMES-NOT: warning: no such sysroot directory:
'{{([A-Za-z]:.*)?}}/FOO' [-Wmissing-sysroot]
----------------
vsk wrote:
> Can you split this into two checks? One to check that the warning appear, and
> another to check that the option isn't printed.
Argh, I suppose there's no "CHECK-SAME-NOT" functionality in FileCheck. If you
want to shave off a compiler invocation, maybe you could write:
CHECK: ... {{$}}
https://reviews.llvm.org/D24516
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
