Re: [PATCH] D21104: [CodeGen][ObjC] Block captures should inherit the type of the captured field in the enclosing lambda or block

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D21104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [PATCH] D24461: CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D24461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [PATCH] D24383: Add addOrMerge interface to tooling::Replacements.

ioeric abandoned this revision. ioeric added a comment. Abandon in favor of https://reviews.llvm.org/D24515 https://reviews.llvm.org/D24383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D24526: [Release notes] Mention readability-container-size-empty improvements

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a nit. Comment at: docs/ReleaseNotes.rst:94 @@ +93,3 @@ + `_ check + supports

Re: [PATCH] D22452: [libcxx] Fix last_write_time tests for filesystems that don't support negative and very large times.

Hahnfeld added a comment. In addition to this patch, my local environment would require the following changes: diff --git a/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp b/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_w

Re: [PATCH] D24461: CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds

edward-jones added a comment. Awesome, is it possible for someone to commit this on my behalf? https://reviews.llvm.org/D24461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22439: Add missing includes.

v.g.vassilev added a comment. The 'atomic' bug was fixed I assume as part of https://llvm.org/bugs/show_bug.cgi?id=28794 Other includes landed in r281450. https://reviews.llvm.org/D22439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

r281452 - Revert "[modules] When merging one definition into another, propagate the list of re-exporting modules from the discarded definition to the retained definition."

Author: ioeric Date: Wed Sep 14 05:05:10 2016 New Revision: 281452 URL: http://llvm.org/viewvc/llvm-project?rev=281452&view=rev Log: Revert "[modules] When merging one definition into another, propagate the list of re-exporting modules from the discarded definition to the retained definition."

Re: [PATCH] D24513: [AMDGPU] Expose flat work group size, register and wave control attributes

kzhuravl updated the summary for this revision. kzhuravl updated this revision to Diff 71311. kzhuravl added a comment. Update docs in AttrDocs.td https://reviews.llvm.org/D24513 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

mboehme updated this revision to Diff 71312. mboehme marked 6 inline comments as done. mboehme added a comment. Herald added subscribers: mgorny, beanz. Responses to reviewer comments. https://reviews.llvm.org/D23353 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

mboehme marked an inline comment as done. mboehme added a comment. https://reviews.llvm.org/D23353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

This revision was automatically updated to reflect the committed changes. Closed by commit rL281453: [clang-tidy] Add check 'misc-use-after-move' (authored by mboehme). Changed prior to commit: https://reviews.llvm.org/D23353?vs=71312&id=71313#toc Repository: rL LLVM https://reviews.llvm.or

[clang-tools-extra] r281453 - [clang-tidy] Add check 'misc-use-after-move'

Author: mboehme Date: Wed Sep 14 05:29:32 2016 New Revision: 281453 URL: http://llvm.org/viewvc/llvm-project?rev=281453&view=rev Log: [clang-tidy] Add check 'misc-use-after-move' Summary: The check warns if an object is used after it has been moved, without an intervening reinitialization. See u

Re: [clang-tools-extra] r281453 - [clang-tidy] Add check 'misc-use-after-move'

On Wed, Sep 14, 2016 at 3:38 AM Martin Bohme via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: mboehme > Date: Wed Sep 14 05:29:32 2016 > New Revision: 281453 > > URL: http://llvm.org/viewvc/llvm-project?rev=281453&view=rev > Log: > [clang-tidy] Add check 'misc-use-after-move' > > Sum

Re: [PATCH] D24508: PR28752: Do not instantiate var decls which are not visible.

v.g.vassilev removed rL LLVM as the repository for this revision. v.g.vassilev updated this revision to Diff 71317. v.g.vassilev marked 4 inline comments as done. v.g.vassilev added a comment. Address comments. I still find the regression test a bit clumsy. I will try to add it to `test/Modules/

[PATCH] D24550: [clang-tidy] Make test for misc-use-after-move pass under Windows

mboehme created this revision. mboehme added a reviewer: alexfh. mboehme added a subscriber: cfe-commits. Adds -fno-delayed-template-parsing https://reviews.llvm.org/D24550 Files: test/clang-tidy/misc-use-after-move.cpp Index: test/clang-tidy/misc-use-after-move.cpp ==

Re: [PATCH] D24550: [clang-tidy] Make test for misc-use-after-move pass under Windows

mboehme added a comment. Single-line trivial change, will submit without review. Please let me know if you have any objections. https://reviews.llvm.org/D24550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[clang-tools-extra] r281455 - [clang-tidy] Make test for misc-use-after-move pass under Windows

Author: mboehme Date: Wed Sep 14 07:22:35 2016 New Revision: 281455 URL: http://llvm.org/viewvc/llvm-project?rev=281455&view=rev Log: [clang-tidy] Make test for misc-use-after-move pass under Windows Summary: Adds -fno-delayed-template-parsing Reviewers: alexfh Subscribers: cfe-commits Differe

Re: [PATCH] D24550: [clang-tidy] Make test for misc-use-after-move pass under Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL281455: [clang-tidy] Make test for misc-use-after-move pass under Windows (authored by mboehme). Changed prior to commit: https://reviews.llvm.org/D24550?vs=71318&id=71319#toc Repository: rL LLVM ht

Re: [PATCH] D24518: Correct assert text in DeclGroup::getSingleDecl()

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D24518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D24500: [clang-tidy] Bugfix for readability-redundant-control-flow check

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. If there's a related buganizer item, please mention it in the commit message. https://reviews.llvm.org/D24500 ___ cfe-commits mailing list c

Re: [PATCH] D24500: [clang-tidy] Bugfix for readability-redundant-control-flow check

malcolm.parsons added a comment. I didn't report a bug for this issue, and there isn't an existing one. https://reviews.llvm.org/D24500 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

Re: [PATCH] D24339: [clang-tidy] Add check 'readability-redundant-member-init'

alexfh added a comment. In https://reviews.llvm.org/D24339#537488, @malcolm.parsons wrote: > How do I add FixIt hints? > They should be simple removals, but how do I decide whether to remove the > following comma, preceding comma or preceding colon? Just remove the entry and leave the comma a

Re: [PATCH] D24224: [clang-rename] Merge rename-{ at | all } and optimise USRFindingAction.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a nit. Comment at: clang-rename/USRFindingAction.cpp:182 @@ -161,1 +181,3 @@ +return false; } else { +unsigned CouldNotFindSymbolNamed = Engine.

Re: [PATCH] D24515: Supports adding insertion around non-insertion replacements.

djasper added inline comments. Comment at: include/clang/Tooling/Core/Replacement.h:172 @@ +171,3 @@ + /// - They do not overlap. + /// - One replacement is insertion, and the other is a replacement with + /// length > 0, and the insertion is adjecent to but not contain

Re: [PATCH] D24515: Supports adding insertion around non-insertion replacements.

ioeric updated this revision to Diff 71332. ioeric marked an inline comment as done. ioeric added a comment. - Addressed comment. https://reviews.llvm.org/D24515 Files: include/clang/Tooling/Core/Replacement.h lib/Tooling/Core/Replacement.cpp unittests/Tooling/RefactoringTest.cpp Index:

Re: [PATCH] D24224: [clang-rename] Merge rename-{ at | all } and optimise USRFindingAction.

omtcyfz updated this revision to Diff 71334. omtcyfz marked an inline comment as done. omtcyfz added a comment. Nit. https://reviews.llvm.org/D24224 Files: clang-rename/USRFindingAction.cpp clang-rename/USRFindingAction.h clang-rename/tool/ClangRename.cpp docs/clang-rename.rst test/cl

Re: [PATCH] D24515: Supports adding insertion around non-insertion replacements.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Comment at: include/clang/Tooling/Core/Replacement.h:172 @@ -169,1 +171,3 @@ + /// - aren't both inserts at the same code location. + /// Note: two insertion

[clang-tools-extra] r281456 - [clang-rename] Merge rename-{at|all} & optimize.

Author: omtcyfz Date: Wed Sep 14 08:00:36 2016 New Revision: 281456 URL: http://llvm.org/viewvc/llvm-project?rev=281456&view=rev Log: [clang-rename] Merge rename-{at|all} & optimize. Having both rename-at and rename-all both seems confusing and introduces unneeded difficulties. Allowing to use bo

Re: [PATCH] D24515: Supports adding insertion around non-insertion replacements.

ioeric updated this revision to Diff 71335. ioeric added a comment. - Updated comment. https://reviews.llvm.org/D24515 Files: include/clang/Tooling/Core/Replacement.h lib/Tooling/Core/Replacement.cpp unittests/Tooling/RefactoringTest.cpp Index: unittests/Tooling/RefactoringTest.cpp =

Re: [PATCH] D24224: [clang-rename] Merge rename-{ at | all } and optimise USRFindingAction.

This revision was automatically updated to reflect the committed changes. Closed by commit rL281456: [clang-rename] Merge rename-{at|all} & optimize. (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D24224?vs=71334&id=71336#toc Repository: rL LLVM https://reviews.llv

Re: r281452 - Revert "[modules] When merging one definition into another, propagate the list of re-exporting modules from the discarded definition to the retained definition."

When reverting something, please say why in the commit message. On Sep 14, 2016 6:13 AM, "Eric Liu via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Author: ioeric > Date: Wed Sep 14 05:05:10 2016 > New Revision: 281452 > > URL: http://llvm.org/viewvc/llvm-project?rev=281452&view=rev > Log:

Re: [PATCH] D24515: Supports adding insertion around non-insertion replacements.

This revision was automatically updated to reflect the committed changes. Closed by commit rL281457: Supports adding insertion around non-insertion replacements. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D24515?vs=71335&id=71337#toc Repository: rL LLVM https://

r281457 - Supports adding insertion around non-insertion replacements.

Author: ioeric Date: Wed Sep 14 08:04:51 2016 New Revision: 281457 URL: http://llvm.org/viewvc/llvm-project?rev=281457&view=rev Log: Supports adding insertion around non-insertion replacements. Summary: Extend `tooling::Replacements::add()` to support adding order-independent replacements. Two

Re: [clang-tools-extra] r281453 - [clang-tidy] Add check 'misc-use-after-move'

> > While I'm excited to see this go in anywhere, I have to say I'm a bit sad > it isn't going in as a warning and instead inside clang-tidy. This has been > a much requested warning from Clang for many years. > > Is there a concise description of why this design was chosen? Are there > specific pr

[clang-tools-extra] r281459 - reverting r281456

Author: omtcyfz Date: Wed Sep 14 08:23:14 2016 New Revision: 281459 URL: http://llvm.org/viewvc/llvm-project?rev=281459&view=rev Log: reverting r281456 Modified: clang-tools-extra/trunk/clang-rename/USRFindingAction.cpp clang-tools-extra/trunk/clang-rename/USRFindingAction.h clang-too

Re: r281452 - Revert "[modules] When merging one definition into another, propagate the list of re-exporting modules from the discarded definition to the retained definition."

This revision caused internal build breakage, but unfortunately I'm not sure what exactly in this revision caused the breakage. I have reported the issue to @rsmith - the revision author. On Wed, Sep 14, 2016 at 3:10 PM Nico Weber wrote: > When reverting something, please say why in the commit m

[PATCH] D24561: [clang-tidy] Add dependency on clangAnalysis to clangTidyMiscModule

mboehme created this revision. mboehme added a subscriber: cfe-commits. Herald added subscribers: mgorny, beanz. This is needed for the recently submitted misc-use-after-move check (rL281453). For some reason, this still built under Linux, but it caused the PPC build bot to fail. https://reviews.

Re: [PATCH] D24561: [clang-tidy] Add dependency on clangAnalysis to clangTidyMiscModule

mboehme added a comment. Trivial build fix, will submit without review. https://reviews.llvm.org/D24561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24561: [clang-tidy] Add dependency on clangAnalysis to clangTidyMiscModule

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM -- for these sort of post-commit fixes that are trivial and make failing bots

Re: [PATCH] D24561: [clang-tidy] Add dependency on clangAnalysis to clangTidyMiscModule

This revision was automatically updated to reflect the committed changes. Closed by commit rL281460: [clang-tidy] Add dependency on clangAnalysis to clangTidyMiscModule (authored by mboehme). Changed prior to commit: https://reviews.llvm.org/D24561?vs=71345&id=71346#toc Repository: rL LLVM

[clang-tools-extra] r281460 - [clang-tidy] Add dependency on clangAnalysis to clangTidyMiscModule

Author: mboehme Date: Wed Sep 14 08:33:11 2016 New Revision: 281460 URL: http://llvm.org/viewvc/llvm-project?rev=281460&view=rev Log: [clang-tidy] Add dependency on clangAnalysis to clangTidyMiscModule Summary: This is needed for the recently submitted misc-use-after-move check (rL281453). For so

Re: [PATCH] D24005: [compiler-rt cmake] Support overriding llvm-config query results

This revision was automatically updated to reflect the committed changes. Closed by commit rL281461: [cmake] Support overriding llvm-config query results (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D24005?vs=71040&id=71348#toc Repository: rL LLVM https://reviews.

Re: [PATCH] D24561: [clang-tidy] Add dependency on clangAnalysis to clangTidyMiscModule

mboehme added a comment. Thanks! Repository: rL LLVM https://reviews.llvm.org/D24561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24005: [compiler-rt cmake] Support overriding llvm-config query results

mgorny added a comment. Thanks again. I've left them as-is and committed. Repository: rL LLVM https://reviews.llvm.org/D24005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

rmaprath created this revision. rmaprath added reviewers: EricWF, mclow.lists. rmaprath added a subscriber: cfe-commits. When we added support for the no-exceptions build of `libc++`, all the tests that used exceptions got a blanket XFAIL for the no-exceptions variety. Previously, we tried to fi

Re: [PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

rmaprath updated this revision to Diff 71349. rmaprath added a comment. (Added more context) https://reviews.llvm.org/D24562 Files: test/std/re/re.alg/re.alg.search/grep.pass.cpp Index: test/std/re/re.alg/re.alg.search/grep.pass.cpp ===

r281469 - Fix documentation of MemberExpr::getMemberDecl

Author: sberg Date: Wed Sep 14 09:03:50 2016 New Revision: 281469 URL: http://llvm.org/viewvc/llvm-project?rev=281469&view=rev Log: Fix documentation of MemberExpr::getMemberDecl Differential Revision: https://reviews.llvm.org/D23907 Modified: cfe/trunk/include/clang/AST/Expr.h Modified: cf

Re: [PATCH] D23907: Fix documentation of MemberExpr::getMemberDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rL281469: Fix documentation of MemberExpr::getMemberDecl (authored by sberg). Changed prior to commit: https://reviews.llvm.org/D23907?vs=69317&id=71357#toc Repository: rL LLVM https://reviews.llvm.or

[libcxx] r281475 - [libcxx] Enable building and testing of libcxx with ThreadSanitizer on OS X

Author: kuba.brecka Date: Wed Sep 14 09:12:50 2016 New Revision: 281475 URL: http://llvm.org/viewvc/llvm-project?rev=281475&view=rev Log: [libcxx] Enable building and testing of libcxx with ThreadSanitizer on OS X This patch enables building and testing libcxx under ThreadSanitizer on OS X. CMak

[libcxx] r281476 - [libcxx] Fix a typo in test/libcxx/test/target_info.py that prevents running tests on Darwin with sanitizers

Author: kuba.brecka Date: Wed Sep 14 09:13:50 2016 New Revision: 281476 URL: http://llvm.org/viewvc/llvm-project?rev=281476&view=rev Log: [libcxx] Fix a typo in test/libcxx/test/target_info.py that prevents running tests on Darwin with sanitizers Differential Revision: https://reviews.llvm.org/D

[libcxx] r281477 - [libcxx] Add a TSan regression test for a data race in call_once

Author: kuba.brecka Date: Wed Sep 14 09:15:42 2016 New Revision: 281477 URL: http://llvm.org/viewvc/llvm-project?rev=281477&view=rev Log: [libcxx] Add a TSan regression test for a data race in call_once Differential Revision: https://reviews.llvm.org/D24297 Added: libcxx/trunk/test/std/thr

r281487 - CodeGen: simplify the logic a slight bit

Author: compnerd Date: Wed Sep 14 10:17:46 2016 New Revision: 281487 URL: http://llvm.org/viewvc/llvm-project?rev=281487&view=rev Log: CodeGen: simplify the logic a slight bit Move the definition of `getTriple()` into the header. It would just call `getTarget().getTriple()`. Inline the definiti

Re: [PATCH] D24245: [ARM] ARM-specific attributes should be accepted for big-endian

rovka added a subscriber: rovka. rovka accepted this revision. rovka added a reviewer: rovka. rovka added a comment. This revision is now accepted and ready to land. Looks like a sensible thing to do. Repository: rL LLVM https://reviews.llvm.org/D24245 _

[PATCH] D24567: [clang-rename] Merge rename-{at|all} & optimise.

omtcyfz created this revision. omtcyfz added reviewers: alexfh, vmiklos. omtcyfz added a subscriber: cfe-commits. Having both rename-at and rename-all both seems confusing and introduces unneeded difficulties. After merging rename-at and rename-all maintaining main function wrappers and custom h

Re: [PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

mclow.lists added a comment. What an awful test. I wonder who wrote such a steaming pile. Probably me. https://reviews.llvm.org/D24562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

Re: [PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

rmaprath added a comment. In https://reviews.llvm.org/D24562#542630, @mclow.lists wrote: > What an awful test. I wonder who wrote such a steaming pile. Probably me. I think I've thrown quite a lot of XFAILs like this in the past, just to get the no-exceptions build passing. Now I've got to c

Re: [PATCH] D24467: Fix an error after D21678

vbyakovlcl added inline comments. Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8733 @@ -8731,2 +8732,3 @@ if (!IsCompAssign) { -LHS = S.UsualUnaryConversions(LHS.get()); +if (S.LangOpts.OpenCL || S.LangOpts.ZVector) + LHS = S.UsualUnaryConversions(LHS.get());

Re: [PATCH] D21506: [analyzer] Block in critical section

zdtorok updated this revision to Diff 71375. zdtorok added a comment. Herald added subscribers: mgorny, beanz. Fixed possible integer-underflow in case of unexpected unlocking function. Also added test for this. Repository: rL LLVM https://reviews.llvm.org/D21506 Files: include/clang/Stat

Re: [PATCH] D21506: [analyzer] Block in critical section

zdtorok added a comment. You are right NoQ, thank you for the remark, I've upload a new diff containing a fix for the integer underflow case. Repository: rL LLVM https://reviews.llvm.org/D21506 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D24571: [CUDA] Disallow overloading destructors.

jlebar created this revision. jlebar added a reviewer: rsmith. jlebar added subscribers: tra, cfe-commits. We'd attempted to allow this, but turns out we were doing a very bad job. :) Making this work properly would be a giant change in clang. For example, we'd need to make CXXRecordDecl::getDe

[PATCH] D24572: [clang-tidy] Clean up code after applying replacements.

alexfh created this revision. alexfh added reviewers: ioeric, hokein. alexfh added a subscriber: cfe-commits. Remove empty namespaces and initializer list commas / colons in affected ranges. A strawman patch: proper options for enabling the cleanup and specifying the format style are needed. http

[PATCH] D24573: [CUDA] Do a better job at detecting wrong-side calls.

jlebar created this revision. jlebar added a reviewer: rsmith. jlebar added subscribers: tra, cfe-commits. Move CheckCUDACall from ActOnCallExpr and BuildDeclRefExpr to DiagnoseUseOfDecl. This lets us catch some edge cases we were missing, specifically around class operators. This necessitates a

Re: [PATCH] D24513: [AMDGPU] Expose flat work group size, register and wave control attributes

kzhuravl updated this revision to Diff 71382. kzhuravl added a comment. Fix minor typos https://reviews.llvm.org/D24513 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/TargetInfo.cpp lib/Sema/SemaDeclAttr.cpp

[PATCH] D24574: clang-format: [JS] ASI insertion after boolean literals.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. Before when a semicolon was missing after a boolean literal: a = true return 1; clang-format would parse this as one line and format as: a = tr

r281509 - Convert finite to builtin

Author: dehao Date: Wed Sep 14 12:34:14 2016 New Revision: 281509 URL: http://llvm.org/viewvc/llvm-project?rev=281509&view=rev Log: Convert finite to builtin Summary: This patch converts finite/__finite to builtin functions so that it will be inlined by compiler. Reviewers: hfinkel, davidxl, ef

Re: [PATCH] D24513: [AMDGPU] Expose flat work group size, register and wave control attributes

aaron.ballman requested changes to this revision. This revision now requires changes to proceed. Comment at: include/clang/Basic/Attr.td:1054-1056 @@ -1058,3 +1053,5 @@ +// // FIXME: This should be for OpenCLKernelFunction, but is not to // workaround needing to see kernel attri

Re: [PATCH] D24526: [Release notes] Mention readability-container-size-empty improvements

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:94 @@ +93,3 @@ + `_ check + supports arbitrary containers with ``empty()`` and ``size()`` methods. + al

[clang-tools-extra] r281510 - [Release notes] Mention readability-container-size-empty improvements.

Author: eugenezelenko Date: Wed Sep 14 12:41:51 2016 New Revision: 281510 URL: http://llvm.org/viewvc/llvm-project?rev=281510&view=rev Log: [Release notes] Mention readability-container-size-empty improvements. Differential revision: https://reviews.llvm.org/D24526 Modified: clang-tools-extr

Re: [PATCH] D24526: [Release notes] Mention readability-container-size-empty improvements

This revision was automatically updated to reflect the committed changes. Closed by commit rL281510: [Release notes] Mention readability-container-size-empty improvements. (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D24526?vs=71250&id=71394#toc Repository:

Re: [PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

aaron.ballman added inline comments. Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23 @@ +21,4 @@ + Finder->addMatcher( + declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")), + parameterCountIs(0 +

r281516 - [analyzer] scan-build-py: Remove relative path hack for SATestsBuild.py

Author: dcoughlin Date: Wed Sep 14 13:14:11 2016 New Revision: 281516 URL: http://llvm.org/viewvc/llvm-project?rev=281516&view=rev Log: [analyzer] scan-build-py: Remove relative path hack for SATestsBuild.py Remove the relative path hack in scan-build-py that converts a fully qualified directory

Re: [PATCH] D24470: [analyzer] scan-build-py: Remove relative path hack for SATestsBuild.py

This revision was automatically updated to reflect the committed changes. Closed by commit rL281516: [analyzer] scan-build-py: Remove relative path hack for SATestsBuild.py (authored by dcoughlin). Changed prior to commit: https://reviews.llvm.org/D24470?vs=71046&id=71401#toc Repository: rL

Re: [PATCH] D24330: Add some MS aliases for existing intrinsics

agutowski marked an inline comment as done. agutowski added a comment. https://reviews.llvm.org/D24330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24330: Add some MS aliases for existing intrinsics

agutowski updated this revision to Diff 71404. agutowski added a comment. Fix doxygen comment https://reviews.llvm.org/D24330 Files: include/clang/Basic/Builtins.def include/clang/Basic/Builtins.h include/clang/Basic/BuiltinsX86.def lib/Basic/Targets.cpp lib/CodeGen/CGBuiltin.cpp li

Re: [PATCH] D24467: Fix an error after D21678

ahatanak added inline comments. Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8751 @@ -8747,3 +8750,3 @@ // OpenCL v1.1 s6.3.j says that the operands need to be integers. if (!LHSEleType->isIntegerType()) { Should we mention that any vectors used as s

Re: [PATCH] D21506: [analyzer] Block in critical section

zaks.anna added a comment. Do you have commit access or should we commit? Repository: rL LLVM https://reviews.llvm.org/D21506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21506: [analyzer] Block in critical section

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Future steps: How do we plan to bring this checker out of alpha? Have you evaluated it on large codebases? Repository: rL LLVM https://reviews.llvm.org/D21506 _

Re: [PATCH] D24574: clang-format: [JS] ASI insertion after boolean literals.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Interesting.. Would have expected true/false to be literals as well, but ok :). https://reviews.llvm.org/D24574 ___ cfe-commits mailing list cf

Re: [PATCH] D24467: Fix an error after D21678

vbyakovlcl added inline comments. Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8790 @@ -8774,3 +8789,3 @@ S.Context.getExtVectorType(RHSEleType, LHSVecTy->getNumElements()); RHS = S.ImpCastExprToType(RHS.get(), VecTy, CK_VectorSplat); } ahatan

Re: [PATCH] D24518: Correct assert text in DeclGroup::getSingleDecl()

brtaylor92 added a comment. I don't have commit access. @alexfh could you please land the patch? https://reviews.llvm.org/D24518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23820: Do not warn about format strings that are indexed string literals.

meikeb marked an inline comment as done. meikeb added a comment. Thanks for reviewing my patch! It would be great if someone could submit this patch for me. https://reviews.llvm.org/D23820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

Re: [PATCH] D22452: [libcxx] Fix last_write_time tests for filesystems that don't support negative and very large times.

EricWF added a comment. Thanks. I'll update this patch today. https://reviews.llvm.org/D22452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r281525 - Correct assert text in DeclGroup::getSingleDecl()

Author: omtcyfz Date: Wed Sep 14 14:59:26 2016 New Revision: 281525 URL: http://llvm.org/viewvc/llvm-project?rev=281525&view=rev Log: Correct assert text in DeclGroup::getSingleDecl() Assert text for getSingleDecl() is inaccurate. Appears to have been copy pasted from getDeclGroup(). Patch by Be

Re: [PATCH] D24518: Correct assert text in DeclGroup::getSingleDecl()

This revision was automatically updated to reflect the committed changes. Closed by commit rL281525: Correct assert text in DeclGroup::getSingleDecl() (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D24518?vs=71188&id=71414#toc Repository: rL LLVM https://reviews.ll

Re: [PATCH] D23820: Do not warn about format strings that are indexed string literals.

srhines added a comment. I will take care of submitting this. Thanks for the reviews everybody! https://reviews.llvm.org/D23820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24372: [libcxx] Sprinkle constexpr over compressed_pair

static_cast(t) also works as a constexpr C++11 forward. On Sep 13, 2016 4:07 PM, "Keno Fischer" wrote: > loladiro added inline comments. > > > Comment at: include/memory:2137 > @@ -2132,3 +2136,3 @@ > > -_LIBCPP_INLINE_VISIBILITY > +_LIBCPP_INLINE_VISIBILITY _LIBCPP_CONS

Re: [PATCH] D23820: Do not warn about format strings that are indexed string literals.

This revision was automatically updated to reflect the committed changes. Closed by commit rL281527: Do not warn about format strings that are indexed string literals. (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D23820?vs=71286&id=71416#toc Repository: rL LLVM h

r281527 - Do not warn about format strings that are indexed string literals.

Author: srhines Date: Wed Sep 14 15:05:20 2016 New Revision: 281527 URL: http://llvm.org/viewvc/llvm-project?rev=281527&view=rev Log: Do not warn about format strings that are indexed string literals. Summary: The warning for a format string not being a sting literal and therefore being potential

[PATCH] D24579: Revert "Do not warn about format strings that are indexed string literals."

srhines created this revision. srhines added a subscriber: cfe-commits. This reverts r281527 because I messed up the attribution. https://reviews.llvm.org/D24579 Files: lib/Sema/SemaChecking.cpp test/Sema/format-strings.c Index: test/Sema/format-strings.c ===

Re: [PATCH] D24508: PR28752: Do not instantiate var decls which are not visible.

rsmith added a comment. I think you'll also need to update the `ASTDeclReader` to merge `VarDecl` definitions together if it reads a definition and there already is one in the AST. I note that right now `Sema::AddInitializerToDecl` permits multiple definitions of a `VarDecl`, which doesn't seem

r281530 - Revert "Do not warn about format strings that are indexed string literals."

Author: srhines Date: Wed Sep 14 15:20:14 2016 New Revision: 281530 URL: http://llvm.org/viewvc/llvm-project?rev=281530&view=rev Log: Revert "Do not warn about format strings that are indexed string literals." Summary: This reverts r281527 because I messed up the attribution. Reviewers: srhines

Re: [PATCH] D24579: Revert "Do not warn about format strings that are indexed string literals."

This revision was automatically updated to reflect the committed changes. Closed by commit rL281530: Revert "Do not warn about format strings that are indexed string literals." (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D24579?vs=71417&id=71419#toc Repository: r

[PATCH] D24581: [CUDA] Add test checking our ability to take a function pointer to a __global__ function on the host side.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added a subscriber: cfe-commits. This functionality is used by Thrust. https://reviews.llvm.org/D24581 Files: clang/test/SemaCUDA/reference-to-kernel-fn.cu Index: clang/test/SemaCUDA/reference-to-kernel-fn.cu =

Re: [PATCH] D24467: Fix an error after D21678

ahatanak added inline comments. Comment at: llvm/tools/clang/test/Sema/vecshift.c:56 @@ +55,3 @@ + + vc4 = vc4 << vc8; // expected-error {{vector operands do not have the same number of elements}} + vi4 = vi4 << vuc8; // expected-error {{vector operands do not have the same nu

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

EricWF added a comment. LGTM after addressing the inline comments. Comment at: src/cxa_thread_atexit.cpp:70 @@ +69,3 @@ +while (auto head = dtors) { + dtors = head->next; + head->dtor(head->obj); tavianator wrote: > EricWF wrote: > > tavianator wro

Re: [PATCH] D24581: [CUDA] Add test checking our ability to take a function pointer to a __global__ function on the host side.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D24581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D24584: Do not warn about format strings that are indexed string literals.

meikeb created this revision. meikeb added a reviewer: rsmith. meikeb added subscribers: cfe-commits, srhines. The warning for a format string not being a sting literal and therefore being potentially insecure is overly strict for indecies into sting literals. This fix checks if the index into the

Re: [PATCH] D24330: Add some MS aliases for existing intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rL281540: Add some MS aliases for existing intrinsics (authored by agutowski). Changed prior to commit: https://reviews.llvm.org/D24330?vs=71404&id=71437#toc Repository: rL LLVM https://reviews.llvm.o

r281540 - Add some MS aliases for existing intrinsics

Author: agutowski Date: Wed Sep 14 16:19:43 2016 New Revision: 281540 URL: http://llvm.org/viewvc/llvm-project?rev=281540&view=rev Log: Add some MS aliases for existing intrinsics Reviewers: thakis, compnerd, majnemer, rsmith, rnk Subscribers: alexshap, cfe-commits Differential Revision: https:

  1   2   >