djasper added a comment.
I think we should entirely drop this implementation of the check and let it
just check #includes with clang-format. clang-format's implementation isn't a
strict superset, e.g. won't sort between multiple blocks, but that's
intentional for now.
https://reviews.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278483: This patch implements PR#22821. (authored by
rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D20561?vs=64114&id=67807#toc
Repository:
rL LLVM
https://reviews.llvm.org/D20561
Fi
Author: rogfer01
Date: Fri Aug 12 03:04:13 2016
New Revision: 278483
URL: http://llvm.org/viewvc/llvm-project?rev=278483&view=rev
Log:
This patch implements PR#22821.
Taking the address of a packed member is dangerous since the reduced
alignment of the pointee is lost. This can lead to memory ali
Hahnfeld accepted this revision.
Hahnfeld added a reviewer: Hahnfeld.
Hahnfeld added a comment.
This revision is now accepted and ready to land.
LGTM with only some minor nits on some of the comments and a CMake question
Comment at: test/CMakeLists.txt:27-33
@@ -26,8 +26,9 @@
Hi,
On Tue, Aug 9, 2016 at 8:27 PM, Samuel Antao via cfe-commits
wrote:
> Author: sfantao
> Date: Tue Aug 9 12:27:24 2016
> New Revision: 278140
>
> URL: http://llvm.org/viewvc/llvm-project?rev=278140&view=rev
> Log:
> [CUDA] Regression test to make sure C++ include path are forwarded to host
>
Author: d0k
Date: Fri Aug 12 04:19:34 2016
New Revision: 278487
URL: http://llvm.org/viewvc/llvm-project?rev=278487&view=rev
Log:
[C++1z] Fix crash when decomposing structs with anonymous members.
The diagnostic format was invalid.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.
Hahnfeld accepted this revision.
Hahnfeld added a reviewer: Hahnfeld.
Hahnfeld added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: tools/clang-offload-bundler/ClangOffloadBundler.cpp:432
@@ +431,3 @@
+
+return;
+ }
Unnecessary
Author: d0k
Date: Fri Aug 12 04:23:14 2016
New Revision: 278488
URL: http://llvm.org/viewvc/llvm-project?rev=278488&view=rev
Log:
Prune unused diagnostics. NFC.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
Modified:
honggyu.kim added a comment.
In https://reviews.llvm.org/D22666#513465, @compnerd wrote:
> No, the inserted character is a literal SOH, not the string "\01".
I don't know why the string is passed in a different way but '\01' is shown in
IR previously as below
$ clang -target armv7-unknown-n
hokein added inline comments.
Comment at: clang-tidy/misc/ComparisonMisuseCheck.cpp:31
@@ +30,3 @@
+ unless(anyOf(hasOperatorName("=="), hasOperatorName("!="))),
+ hasEitherOperand(ignoringImpCasts(gnuNullExpr(
+ .bind("compareToNull"),
-
hokein added inline comments.
Comment at: clang-tidy/cert/DontModifyStdNamespaceCheck.cpp:20
@@ +19,3 @@
+
+void DontModifyStdNamespaceCheck::registerMatchers(MatchFinder *Finder) {
+ Finder->addMatcher(namespaceDecl(unless(isExpansionInSystemHeader()),
This chec
xazax.hun added inline comments.
Comment at: test/clang-tidy/cert-dont-modify-std-namespace.cpp:1
@@ +1,2 @@
+// RUN: %check_clang_tidy %s cert-msc53-cpp %t -- -- -std=c++1z
+
hokein wrote:
> Do we need `c++1z` flag here?
I think it is there for the following code
danielmarjamaki updated this revision to Diff 67817.
danielmarjamaki added a comment.
fixed review comments
https://reviews.llvm.org/D13126
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/ConversionChecker.cpp
danielmarjamaki marked 3 inline comments as done.
Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:67
@@ +66,3 @@
+ const Stmt *Parent = PM.getParent(Cast);
+ if (!Parent)
+return;
I get assertion failure then when running this test:
Analysis/
Author: hahnfeld
Date: Fri Aug 12 05:36:04 2016
New Revision: 278497
URL: http://llvm.org/viewvc/llvm-project?rev=278497&view=rev
Log:
Fix cuda-detect.cu when CLANG_DEFAULT_CXX_STDLIB is set
Reported by Ismail Donmez!
Modified:
cfe/trunk/test/Driver/cuda-detect.cu
Modified: cfe/trunk/test/D
Hi,
> -Original Message-
> From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf
> Of Ismail Donmez via cfe-commits
> Sent: Friday, August 12, 2016 11:05 AM
> To: Samuel Antao
> Cc: cfe-commits
> Subject: Re: r278140 - [CUDA] Regression test to make sure C++ include path
hokein added a comment.
> This check looks like specific case of https://reviews.llvm.org/D23427. May
> be they should be merged?
+1, I think this check can be merged there.
Comment at: test/clang-tidy/misc-comparison-function-address.cpp:20
@@ +19,3 @@
+ // CHECK-MESSAGES:
Author: asbokhan
Date: Fri Aug 12 06:22:12 2016
New Revision: 278501
URL: http://llvm.org/viewvc/llvm-project?rev=278501&view=rev
Log:
Fix For pr28288 - Error message in shift of vector values
This fixes an error in type checking of shift of vector values.
Patch by Vladimir Yakovlev.
Differenti
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278501: Fix For pr28288 - Error message in shift of vector
values (authored by asbokhan).
Changed prior to commit:
https://reviews.llvm.org/D21678?vs=67140&id=67820#toc
Repository:
rL LLVM
https://r
Neither does clang-tidy's right?
Incidentally that's exactly what i was trying to add support for. Lldb has
a mass reformat coming up, and as part of that we are defining an include
ordering. But at the moment it won't do this, so we will be left fixing
this by hand or not fixing it at all
On Fr
Author: rksimon
Date: Fri Aug 12 06:43:57 2016
New Revision: 278503
URL: http://llvm.org/viewvc/llvm-project?rev=278503&view=rev
Log:
Fix Wdocumentation unknown parameter warning
Modified:
cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp
Modified: cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp
URL
EricWF retitled this revision from "Implement __has_constant_initializer(obj)
expression traits." to "Implement
__attribute__((require_constant_initialization)) attribute".
EricWF updated the summary for this revision.
EricWF updated this revision to Diff 67821.
EricWF added a comment.
Switch to
EricWF retitled this revision from "Implement
__attribute__((require_constant_initialization)) attribute" to "Implement
__attribute__((require_constant_initialization)) for safe static
initialization.".
EricWF updated this revision to Diff 67822.
EricWF added a comment.
- Remove test from previ
EricWF marked an inline comment as done.
Comment at: lib/AST/Expr.cpp:2653-2662
@@ -2651,4 +2652,12 @@
}
-
+if (CE->getConstructor()->isConstexpr() &&
+(CE->getConstructor()->getParent()->hasTrivialDestructor() ||
+AllowNonLiteral)) {
+for (aut
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:1384
@@ +1383,3 @@
+def RequireConstantInit : InheritableAttr {
+ let Spellings = [GCC<"require_constant_initialization">];
+ let Subjects = SubjectList<[Var]>;
This should not use the
filcab added a comment.
In https://reviews.llvm.org/D21695#510788, @vsk wrote:
> After reading through the discussion in https://reviews.llvm.org/D19668, I
> don't think I understood the pros/cons of using a single ABI check (like asan
> does) versus adding version numbers to each handler routi
EricWF updated this revision to Diff 67827.
EricWF marked 7 inline comments as done.
EricWF added a comment.
Address @aaron.ballman's review comments.
https://reviews.llvm.org/D23385
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds
bcraig added a comment.
LGTM. Thanks for the patch!
Comment at: lib/StaticAnalyzer/Checkers/PaddingChecker.cpp:217
@@ +216,3 @@
+// then large field indices to small field indices
+return std::make_tuple(Align, -Size,
+ Field ?
-st
mboehme updated this revision to Diff 67828.
mboehme added a comment.
Handle case where the forwarding reference is a parameter of a generic lambda.
https://reviews.llvm.org/D0
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MoveForwardingRefer
mboehme updated this revision to Diff 67830.
mboehme added a comment.
Restore spaces around scope resolution operator in test case
https://reviews.llvm.org/D0
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MoveForwardingReferenceCheck.cpp
cl
EricWF added inline comments.
Comment at: include/clang/Basic/Attr.td:1384
@@ +1383,3 @@
+def RequireConstantInit : InheritableAttr {
+ let Spellings = [GCC<"require_constant_initialization">];
+ let Subjects = SubjectList<[Var]>;
aaron.ballman wrote:
> This sho
mboehme added inline comments.
Comment at: test/clang-tidy/misc-move-forwarding-reference.cpp:50
@@ +49,3 @@
+// operator.
+template void f5(U &&SomeU) {
+ {
Sorry, that should have been "scope resolution operator". Comment changed.
What this is trying to test
mboehme updated this revision to Diff 67829.
mboehme marked 2 inline comments as done.
mboehme added a comment.
Fix typo in comment
https://reviews.llvm.org/D0
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MoveForwardingReferenceCheck.cpp
c
mboehme created this revision.
mboehme added a reviewer: alexfh.
mboehme added a subscriber: cfe-commits.
Herald added subscribers: samparker, rengolin, aemerson, klimek.
This appears to have been forgotten when templateTypeParmDecl() was initially
added.
https://reviews.llvm.org/D23448
Files:
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D23448
__
Author: mboehme
Date: Fri Aug 12 08:51:00 2016
New Revision: 278507
URL: http://llvm.org/viewvc/llvm-project?rev=278507&view=rev
Log:
[ASTMatchers] Add templateTypeParmDecl() to Registry.cpp
Summary:
This appears to have been forgotten when templateTypeParmDecl() was initially
added.
Reviewers:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278507: [ASTMatchers] Add templateTypeParmDecl() to
Registry.cpp (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D23448?vs=67831&id=67832#toc
Repository:
rL LLVM
https://rev
zatrazz updated this revision to Diff 67835.
zatrazz added a comment.
What about this version? The only difference is for libunwind libgcc is still
included.
https://reviews.llvm.org/D23420
Files:
test/libcxx/test/target_info.py
Index: test/libcxx/test/target_info.py
===
zatrazz created this revision.
zatrazz added reviewers: jroelofs, danalbert, EricWF.
zatrazz added subscribers: rmaprath, aemerson, rengolin, cfe-commits.
The expected 'filesystem::path::compare' result states that for different
only the sign of result integer contains the information about passed
Anastasia added a comment.
Do you think testing the declaration to be available without/with an error
after the extension is enabled/disabled might be useful too?
https://reviews.llvm.org/D23322
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
jroelofs added a comment.
Doesn't libgcc_s contain bits of gcc's unwinder?
https://reviews.llvm.org/D23420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl added a comment.
In https://reviews.llvm.org/D23322#513792, @Anastasia wrote:
> Do you think testing the declaration to be available without/with an error
> after the extension is enabled/disabled might be useful too?
I feel it is not so useful for a specific extension.
When the featur
zatrazz added a comment.
Yes, but my understaning is the proposed link order will force libc++ to link
against _Unwind* symbols from libunwind (this is what I am observing also).
https://reviews.llvm.org/D23420
___
cfe-commits mailing list
cfe-comm
jroelofs added a comment.
This breaks the ODR... the behavior under those circumstances is undefined.
https://reviews.llvm.org/D23420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joey added a subscriber: joey.
Comment at: lib/CodeGen/CodeGenModule.cpp:101
@@ -100,3 +100,3 @@
DoubleTy = llvm::Type::getDoubleTy(LLVMContext);
PointerWidthInBits = C.getTargetInfo().getPointerWidth(0);
PointerAlignInBytes =
What if you create a new fun
zatrazz added a comment.
Yes, although in pratice for shared libraries this is not an issue (at least on
Linux with current linker strategies). And I open for suggestion on how to
proceed in this case since we have some other options:
1. Add the required soft-sp implementations when building fo
jroelofs added a comment.
In https://reviews.llvm.org/D23420#513820, @zatrazz wrote:
> Yes, although in pratice for shared libraries this is not an issue (at least
> on Linux with current linker strategies). And I open for suggestion on how to
> proceed in this case since we have some other opt
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
The patch LG.
In https://reviews.llvm.org/D23434#513533, @djasper wrote:
> I think we should entirely drop this implementation of the check and let it
> just check #includes with clang-format
zatrazz added a comment.
In https://reviews.llvm.org/D23420#513824, @jroelofs wrote:
> In https://reviews.llvm.org/D23420#513820, @zatrazz wrote:
>
> > Yes, although in pratice for shared libraries this is not an issue (at
> > least on Linux with current linker strategies). And I open for sugges
You and daniel both imply that clang-tidy can sort across blocks. Am I
missing this somewhere?
My intention was to add an option for this in a followup patch because it
doesn't seem to be able to currently.
On Fri, Aug 12, 2016 at 8:21 AM Alexander Kornienko
wrote:
> alexfh accepted this revisio
djasper added a comment.
I think we got confused. We once had tried to write an experimental separate
check to comply with Google's style guide. If you want to fiddle around with
that, contact me, I can send you pointers. But as I mentioned we moved away
from that. And I think it makes more sen
one disadvantage to clang format is that you have less control over how and
whether to apply fixits. Reordering across blocks has a higher risk of
breaking code, and you can't tell clang format to only apply fixits which
don't break code, or to not apply any fixits but just warn.
Code duplication
alexfh added a comment.
In https://reviews.llvm.org/D23434#513839, @djasper wrote:
> I think we got confused. We once had tried to write an experimental separate
> check to comply with Google's style guide. If you want to fiddle around with
> that, contact me, I can send you pointers. But as I
That's actually the reason I think it makes more sense in clang tidy. It
can be a configuration option, off by default, and since there is more
control over whether to apply fixits, and it doesn't apply fixits by
default, it would be easier to iterate on the experimental nature of it
without messin
Anastasia created this revision.
Anastasia added a reviewer: hans.
Anastasia added subscribers: yaxunl, bader, cfe-commits.
Release notes for OpenCL in Clang
https://reviews.llvm.org/D23452
Files:
docs/ReleaseNotes.rst
Index: docs/ReleaseNotes.rst
=
majnemer added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:10388-10390
@@ -10387,2 +10387,5 @@
+ // Cache the result of checking for constant initialization.
+ Optional HasConstInit;
+
if (var->getTLSKind() == VarDecl::TLS_Static) {
You could use a l
alexfh added a comment.
A few initial comments.
Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:492
@@ +491,3 @@
+ DeclRefs->clear();
+ for (CFGBlock::const_iterator I = Block->begin(), E = Block->end(); I != E;
+ ++I) {
Any reason to avoid range-based
The check's implementation will be replaced by a simple call to clang tidy.
It will remain a check in clang tidy to continue to cater to both use cases.
On Aug 12, 2016 6:19 PM, "Zachary Turner" wrote:
> That's actually the reason I think it makes more sense in clang tidy. It
> can be a configur
Ahh, I see. Just to be clear, is there an LGTM to get this path in? I
know alexfh@ lgtm'ed it, want to make sure you're ok with this too.
On Fri, Aug 12, 2016 at 9:40 AM Daniel Jasper wrote:
> The check's implementation will be replaced by a simple call to clang
> tidy. It will remain a check
aaron.ballman created this revision.
aaron.ballman added reviewers: rsmith, doug.gregor.
aaron.ballman added a subscriber: cfe-commits.
This patch adds support for a "c2x" language standard mode for the eventual new
C language standard, expected to come out in 202x. The spelling and
capitalizati
Prazek added a subscriber: Prazek.
Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:95-98
@@ +94,6 @@
+const QualType T = VD->getType();
+if (T->isPointerType() && !T->getPointeeType().isConstQualified())
+ markCanNotBeConst(VD->getInit(), true);
+els
Author: dexonsmith
Date: Fri Aug 12 11:46:25 2016
New Revision: 278525
URL: http://llvm.org/viewvc/llvm-project?rev=278525&view=rev
Log:
BugReporter: Use ilist_half_embedded_sentinel_traits, NFC
This avoids duplicated code with llvm/ADT/ilist.h. No functionality
change.
Modified:
cfe/trunk/
zatrazz updated this revision to Diff 67850.
zatrazz added a comment.
I think patch should be safe now.
https://reviews.llvm.org/D23420
Files:
test/libcxx/test/target_info.py
Index: test/libcxx/test/target_info.py
===
--- test/l
majnemer added a subscriber: majnemer.
Comment at: include/clang/Frontend/LangStandards.def:94
@@ -93,1 +93,3 @@
+// C2X modes
+LANGSTANDARD(c2x, "c2x",
Should this be C2x instead of C2X?
https://reviews.llvm.org/D23453
_
alexshap added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/PaddingChecker.cpp:217
@@ +216,3 @@
+// then large field indices to small field indices
+return std::make_tuple(Align, -Size,
+ Field ?
-static_cast(Field->getFie
tra updated this revision to Diff 67851.
tra added a comment.
Reverted argument type to std::string
https://reviews.llvm.org/D23429
Files:
lib/CodeGen/CGCUDANV.cpp
test/CodeGenCUDA/device-stub.cu
Index: test/CodeGenCUDA/device-stub.cu
===
alexfh added a comment.
The changes in Driver LGTM (though I'd prefer someone who knows Driver to look).
Could you move lib/Tooling/JSONCompilationDatabase.cpp to a separate patch? It
seems like an orthogonal change.
As for a clang-cl-mode test for clang-tidy, clang-tidy-run-with-database.cpp i
tra marked an inline comment as done.
Comment at: lib/CodeGen/CGCUDANV.cpp:62-69
@@ -60,3 +61,10 @@
llvm::ConstantInt::get(SizeTy, 0)};
auto ConstStr = CGM.GetAddrOfConstantCString(Str, Name.c_str());
+llvm::GlobalVariable *GV =
+ca
aaron.ballman marked an inline comment as done.
Comment at: include/clang/Frontend/LangStandards.def:94
@@ -93,1 +93,3 @@
+// C2X modes
+LANGSTANDARD(c2x, "c2x",
majnemer wrote:
> Should this be C2x instead of C2X?
Probably. :-D
https://reviews.llvm.org/D23453
zturner abandoned this revision.
zturner added a comment.
Once I split the JSONCompilationDatabase patch out, then the rest is strictly a
driver-only patch, and the other one is strictly a tooling patch. So I will
abandon this one and upload two new patches with a more targeted set of
reviewer
zturner created this revision.
zturner added a reviewer: rnk.
zturner added a subscriber: cfe-commits.
If `--driver-mode` is passed in one or more times, it will overwrite the
default by this patch. This patch only makes it so that if NO `--driver-mode`
is passed in, we try to do better than sa
zturner created this revision.
zturner added reviewers: alexfh, djasper.
zturner added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
When a compilation database is used on Windows, the command lines cannot be
parsed using the standard GNU style syntax. LLVM provides functions for
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D23454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: alexander_droste
Date: Fri Aug 12 12:43:58 2016
New Revision: 278533
URL: http://llvm.org/viewvc/llvm-project?rev=278533&view=rev
Log:
Test commit - first LLVM repo commit
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/MPI-Checker/MPITypes.h
Modified: cfe/trunk/lib/StaticAnalyzer/Ch
Eugene.Zelenko added a comment.
Ping. I could not proceed until my question answered.
Repository:
rL LLVM
https://reviews.llvm.org/D23045
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
rnk added a subscriber: rnk.
rnk added a comment.
We should convince cmake to emit "arguments" instead of "command" so that we
don't have this ambiguity.
https://reviews.llvm.org/D23455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
dcoughlin commandeered this revision.
dcoughlin edited reviewers, added: andrewmw94; removed: dcoughlin.
dcoughlin added a comment.
Thanks for the patches! I've commandeered this revision to be able to update
the diff to merge the two patch files into one. You should commandeer it back
by using
zturner added a comment.
I mentioned offline that we could detect CRLF or LF and heuristically decide
whether it's a windows compilation database. That seems like a horrible hack,
so failing that, yes having CMake do it for us would be better.
https://reviews.llvm.org/D23455
__
dcoughlin removed rL LLVM as the repository for this revision.
dcoughlin updated this revision to Diff 67862.
dcoughlin added a comment.
Merge the two patches into one diff.
https://reviews.llvm.org/D23375
Files:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
test/Analysis/kmalloc-linux.c
I
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278535: [Driver] Set the default driver mode based on the
executable. (authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D23454?vs=67853&id=67861#toc
Repository:
rL LLVM
https:
Author: alexander_droste
Date: Fri Aug 12 12:46:23 2016
New Revision: 278534
URL: http://llvm.org/viewvc/llvm-project?rev=278534&view=rev
Log:
Revert test commit
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/MPI-Checker/MPITypes.h
Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/MPI-Checker
Author: zturner
Date: Fri Aug 12 12:47:52 2016
New Revision: 278535
URL: http://llvm.org/viewvc/llvm-project?rev=278535&view=rev
Log:
[Driver] Set the default driver mode based on the executable.
Currently, if --driver-mode is not passed at all, it will default
to GCC style driver. This is never
Author: hans
Date: Fri Aug 12 12:59:24 2016
New Revision: 278538
URL: http://llvm.org/viewvc/llvm-project?rev=278538&view=rev
Log:
Merging r278357:
r278357 | compnerd | 2016-08-11 09:58:12 -0700 (Thu, 11 Aug 2016) | 6 lines
On Thu, Aug 11, 2016 at 8:50 PM, Saleem Abdulrasool
wrote:
> On Thu, Aug 11, 2016 at 9:58 AM, Saleem Abdulrasool via cfe-commits
> wrote:
>>
>> Author: compnerd
>> Date: Thu Aug 11 11:58:12 2016
>> New Revision: 278357
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=278357&view=rev
>> Log:
>>
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm!
Please commit to https://llvm.org/svn/llvm-project/cfe/branches/release_39 or
let me know if you'd prefer me to do it.
Comment at: docs/ReleaseNotes.rst:206
@@ +205,3 @@
+
Author: tejohnson
Date: Fri Aug 12 13:12:08 2016
New Revision: 278541
URL: http://llvm.org/viewvc/llvm-project?rev=278541&view=rev
Log:
CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution.
Summary:
This changes clang to use the llvm::lto::thinBackend function instead o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278541: CodeGen: Replace ThinLTO backend implementation with
a client of LTO/Resolution. (authored by tejohnson).
Changed prior to commit:
https://reviews.llvm.org/D21545?vs=64043&id=67868#toc
Reposito
Sounds good. Just to be clear, you plan to delete the code from
clang-tidy, then take the code from clang-format and move it to clang-tidy,
and have clang-format call clang-tidy (or otherwise share the code somehow
so they both use the same implementation)?
I may still try to implement cross-bloc
I haven't read the patch, but if Alex is ok, so am I.. just wanted to make
sure that we don't spend much more time on this, as we are likely going to
remove most of the code..
On Aug 12, 2016 6:42 PM, "Zachary Turner" wrote:
> Ahh, I see. Just to be clear, is there an LGTM to get this path in?
Author: bruno
Date: Fri Aug 12 13:18:24 2016
New Revision: 278543
URL: http://llvm.org/viewvc/llvm-project?rev=278543&view=rev
Log:
Reapply [VFS] Skip non existent files from the VFS tree
Reapply r278457 with test fixed to not abouse fs case sensitivity.
When the VFS uses a YAML file, the real f
rsmith added a comment.
Attributes are specified in include/clang/Basic/Attr.td with a (hopefully)
fairly self-explanatory declarative syntax. You'll then need to add code to
lib/Sema/SemaDeclAttr.cpp to create a corresponding attribute object and attach
it to the declaration.
Two implementati
vsk added a comment.
In https://reviews.llvm.org/D21695#513723, @filcab wrote:
> In https://reviews.llvm.org/D21695#510788, @vsk wrote:
>
> > After reading through the discussion in https://reviews.llvm.org/D19668, I
> > don't think I understood the pros/cons of using a single ABI check (like
>
hiraditya added a comment.
In https://reviews.llvm.org/D22834#504425, @EricWF wrote:
> LGTM.
>
> However I would like to see a small benchmark that demonstrates the
> performance change. Please try and write the benchmark using Google Benchmark.
> Some helpful links:
>
> http://libcxx.llvm.org/
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:593
@@ -590,1 +592,3 @@
+ if (FunI == II_free || FunI == II_realloc ||
+ FunI == II_reallocf || FunI == II_kfree)
return true;
It looks like you are us
rsmith added a comment.
Sorry about the redundant previous comment, the thread got forked by the change
of subject and I missed the updated patch.
Comment at: lib/Sema/SemaDecl.cpp:10484-10485
@@ -10478,1 +10483,4 @@
+ if (var->hasAttr() && !Init)
+ Diag(var->getLocation
Anastasia added a comment.
Thanks! Is there a way to check the doc before committing? I am not sure how to
make the html generated out of this.
https://reviews.llvm.org/D23452
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D23322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278546: Analyze include order on a per-file basis. (authored
by zturner).
Changed prior to commit:
https://reviews.llvm.org/D23434?vs=6&id=67876#toc
Repository:
rL LLVM
https://reviews.llvm.org/
Author: zturner
Date: Fri Aug 12 13:38:26 2016
New Revision: 278546
URL: http://llvm.org/viewvc/llvm-project?rev=278546&view=rev
Log:
Analyze include order on a per-file basis.
The include order check would get notified of all include
directives in a depth-first manner. This created the
possibil
Author: zturner
Date: Fri Aug 12 13:39:05 2016
New Revision: 278547
URL: http://llvm.org/viewvc/llvm-project?rev=278547&view=rev
Log:
Remove accidentally committed file.
Removed:
clang-tools-extra/trunk/test/clang-tidy/clang-cl-driver.cpp
Removed: clang-tools-extra/trunk/test/clang-tidy/clan
1 - 100 of 126 matches
Mail list logo
