vmiklos created this revision.
vmiklos added reviewers: klimek, omtcyfz.
vmiklos added a subscriber: cfe-commits.
So that later commits don't introduce non-functional changes when
running clang-format before committing.
https://reviews.llvm.org/D23153
Files:
clang-rename/RenamingAction.h
cla
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D23153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: vmiklos
Date: Thu Aug 4 02:43:29 2016
New Revision: 277702
URL: http://llvm.org/viewvc/llvm-project?rev=277702&view=rev
Log:
Run clang-format on clang-rename code
So that later commits don't introduce non-functional changes when
running clang-format before committing.
Reviewers: klimek
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277702: Run clang-format on clang-rename code (authored by
vmiklos).
Changed prior to commit:
https://reviews.llvm.org/D23153?vs=66766&id=66769#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2315
mstorsjo added a comment.
Ping - any reply from @compnerd?
In any case, feel free to formulate the ifdefs whichever way you want on commit
as well (since I don't have commit access), as long as the included test passes.
https://reviews.llvm.org/D22774
___
omtcyfz created this revision.
omtcyfz added reviewers: alexfh, klimek.
omtcyfz added a subscriber: cfe-commits.
The only difference between some tests is `-offset` passed to `clang-rename`.
It makes sense to merge them into a single file and add multiple tool
invocations.
https://reviews.llvm.
Author: omtcyfz
Date: Thu Aug 4 04:23:30 2016
New Revision: 277709
URL: http://llvm.org/viewvc/llvm-project?rev=277709&view=rev
Log:
[clang-rename] add missing clang-format improvements
r277702 introduced clang-format changes so that later commits wouldn't introduce
non-functional changes while
omtcyfz added a comment.
Actually few changes `clang-format` would produce weren't there. It's either
you used old `clang-format` or you missed them, but there were header
reordering issues. Pushed quick fix.
Repository:
rL LLVM
https://reviews.llvm.org/D23153
___
Author: d0k
Date: Thu Aug 4 05:02:03 2016
New Revision: 277712
URL: http://llvm.org/viewvc/llvm-project?rev=277712&view=rev
Log:
Make isExternC work on VarDecls too.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
cfe/trunk/unit
bkramer added a comment.
In https://reviews.llvm.org/D23130#505290, @alexfh wrote:
> And the second difference is that it is limited to definitions, but I don't
> yet understand, why it is important, since declarations in the global
> namespace (except for using declarations, typedefs, etc.) wi
baloghadamsoftware added a comment.
In https://reviews.llvm.org/D22374#504855, @NoQ wrote:
> Hmm. I suggest:
>
> 1. Change this test's constructor so that it was no longer almost-trivial.
> Because it isn't significant for this test if the constructor is
> almost-trivial or not. The test would
vmiklos added a comment.
Thanks. Yes, I used the Linux-distro-provided clang-format-3.7, I didn't notice
that the trunk version now also sorts includes.
Repository:
rL LLVM
https://reviews.llvm.org/D23153
___
cfe-commits mailing list
cfe-commits
vbyakovl added a comment.
Someone, please review this.
https://reviews.llvm.org/D21678
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein added inline comments.
Comment at: clang-tidy/misc/ArgumentCommentCheck.cpp:29
@@ +28,3 @@
+void ArgumentCommentCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
+ Options.store(Opts, "StrictMode", StrictMode);
+}
I think we should add a `StringMode
aaron.ballman added a subscriber: aaron.ballman.
Comment at: clang-tidy/misc/ArgumentCommentCheck.cpp:124
@@ +123,3 @@
+ InDecl = InDecl.trim('_');
+ return InComment.compare_lower(InDecl) == 0;
+}
I think this is going to do the wrong thing for non-ASCII identi
ikudrin created this revision.
ikudrin added reviewers: vsk, davidxl, bogner.
ikudrin added a subscriber: cfe-commits.
If there were several nested statements arranged in a way that all of them end
up with the same macro,
then the expansion of this macro was assigned with all the corresponding
c
aaron.ballman added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8597
@@ -8596,4 +8596,3 @@
///by a scalar or vector shift amount.
-static QualType checkOpenCLVectorShift(Sema &S,
- ExprResult &LHS, ExprResult &
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/GlobalNamespaceCheck.cpp:72
@@ +71,3 @@
+ "move it into a namespace or give it "
+ "internal linkage to avoid ODR conflicts")
+ << MatchedDecl;
bkramer updated this revision to Diff 66792.
bkramer added a comment.
- Merge google-global-names-in-headers and misc-global-namespace into a new
check google-global-names.
https://reviews.llvm.org/D23130
Files:
clang-tidy/google/CMakeLists.txt
clang-tidy/google/GlobalNamesCheck.cpp
clan
ikudrin added a comment.
The motivation sample:
$ cat > test.cpp << EOF
void dummy() {}
#define MACRO dummy()
int main()
{
int i = 0;
while (i++ < 10)
if (i < 5)
MACRO;
return 0;
}
EOF
$ clang++ -fprofile-instr-generate -fcoverage-mapping dummy.cpp
aaron.ballman added a comment.
In https://reviews.llvm.org/D22725#505020, @JDevlieghere wrote:
> Addresses comments from Aaron Ballman
>
> @aaron.ballman Thanks for the thorough review! Can you check whether the
> tests I added address your concerns? Could you also elaborate on the case
> with
alexfh marked an inline comment as done.
Comment at: clang-tidy/misc/ArgumentCommentCheck.cpp:124
@@ +123,3 @@
+ InDecl = InDecl.trim('_');
+ return InComment.compare_lower(InDecl) == 0;
+}
aaron.ballman wrote:
> I think this is going to do the wrong thing for n
alexfh updated this revision to Diff 66796.
alexfh marked 2 inline comments as done.
alexfh added a comment.
- Documented the StrictMode option, added a couple of consts.
https://reviews.llvm.org/D23135
Files:
clang-tidy/ClangTidy.h
clang-tidy/misc/ArgumentCommentCheck.cpp
clang-tidy/misc
alexfh added a comment.
Awesome! A few improvements are still possible though. See inline comments.
Comment at: test/clang-rename/ClassAsTemplateArgument.cpp:15
@@ +14,3 @@
+
+// RUN: cat %s > %t_0.cpp
+// RUN: clang-rename -offset=7 -new-name=Bar %t_0.cpp -i --
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/ArgumentCommentCheck.cpp:124
@@ +123,3 @@
+ InDecl = InDecl.trim('_');
+ return InComment.compare_lower(InDecl) == 0;
+}
Correct, which means this won't behave properly in some locales with UTF-8
kparzysz added a comment.
In https://reviews.llvm.org/D22766#505512, @echristo wrote:
> You haven't removed the custom handling?
The one from the driver? If I remove it, it won't be passed to the compiler
(and the testcase will fail).
I forgot to move the no-long-calls from the ARM group to
aaron.ballman added a comment.
Some small nits.
Comment at: lib/AST/ExprConstant.cpp:4409
@@ +4408,3 @@
+ } else if (MD && MD->isLambdaStaticInvoker()) {
+
+// Map the static invoker for the lambda back to the call operator.
Nit: remove new l
alexfh added a comment.
Could you run the check on LLVM and post a summary of results?
Comment at: clang-tidy/google/GlobalNamesCheck.cpp:90
@@ +89,3 @@
+// extern "C" globals need to be in the global namespace.
+if (VDecl->isExternC())
+ return;
Is
omtcyfz updated this revision to Diff 66801.
omtcyfz marked an inline comment as done.
https://reviews.llvm.org/D23158
Files:
clang-rename/USRFindingAction.cpp
clang-rename/tool/ClangRename.cpp
test/clang-rename/ClassAsTemplateArgument.cpp
test/clang-rename/ClassAsTemplateArgumentFindByCl
bkramer updated this revision to Diff 66800.
bkramer added a comment.
Address review comments.
https://reviews.llvm.org/D23130
Files:
clang-tidy/google/CMakeLists.txt
clang-tidy/google/GlobalNamesCheck.cpp
clang-tidy/google/GlobalNamesCheck.h
clang-tidy/google/GlobalNamesInHeadersCheck.
bkramer added a comment.
In https://reviews.llvm.org/D23130#505769, @alexfh wrote:
> Could you run the check on LLVM and post a summary of results?
I have a full list at https://reviews.llvm.org/P7085. It's huge.
https://reviews.llvm.org/D23130
_
omtcyfz updated this revision to Diff 66803.
omtcyfz added a comment.
Rebased on master. Removed unneeded file copying etc since clang-rename can
output to the stdout.
https://reviews.llvm.org/D23158
Files:
test/clang-rename/ClassAsTemplateArgument.cpp
test/clang-rename/ClassAsTemplateArgu
aaron.ballman added a comment.
For cases where the external linkage is desired, how would you go about
silencing this diagnostic?
Comment at: test/clang-tidy/google-global-names.cpp:13-14
@@ +12,4 @@
+// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: 'i' declared in the global
names
alexfh added inline comments.
Comment at: clang-tidy/misc/ArgumentCommentCheck.cpp:124
@@ +123,3 @@
+ InDecl = InDecl.trim('_');
+ return InComment.compare_lower(InDecl) == 0;
+}
aaron.ballman wrote:
> Correct, which means this won't behave properly in some loca
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/ArgumentCommentCheck.cpp:124
@@ +123,3 @@
+ InDecl = InDecl.trim('_');
+ return InComment.compare_lower(InDecl) == 0;
+}
alexfh wrote:
> aaron.ballman wrote:
> > Correct, which means this won't beh
On Mon, Aug 01, 2016 at 08:50:59AM -0700, Vedant Kumar wrote:
>
> > On Jul 30, 2016, at 12:59 PM, Joerg Sonnenberger via cfe-commits
> > wrote:
> >
> > On Thu, Jul 28, 2016 at 10:11:05PM +, Vedant Kumar wrote:
> >> - test/Driver/netbsd.c
> >>
> >>We see -mcpu=arm1022e instead of arm92
alexfh updated this revision to Diff 66806.
alexfh added a comment.
- Added a FIXME.
https://reviews.llvm.org/D23135
Files:
clang-tidy/ClangTidy.h
clang-tidy/misc/ArgumentCommentCheck.cpp
clang-tidy/misc/ArgumentCommentCheck.h
docs/clang-tidy/checks/misc-argument-comment.rst
test/clan
bkramer added inline comments.
Comment at: test/clang-tidy/google-global-names.cpp:13-14
@@ +12,4 @@
+// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: 'i' declared in the global
namespace
+extern int ii = 0;
+// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: 'ii' declared in the global
na
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D23135
___
cfe-commits mailing list
cfe-commits@lists
alexfh added inline comments.
Comment at: clang-tidy/misc/ArgumentCommentCheck.cpp:124
@@ +123,3 @@
+ InDecl = InDecl.trim('_');
+ return InComment.compare_lower(InDecl) == 0;
+}
aaron.ballman wrote:
> alexfh wrote:
> > aaron.ballman wrote:
> > > Correct, which
On Thu, Aug 4, 2016 at 10:45 AM, Alexander Kornienko wrote:
> alexfh added inline comments.
>
>
> Comment at: clang-tidy/misc/ArgumentCommentCheck.cpp:124
> @@ +123,3 @@
> + InDecl = InDecl.trim('_');
> + return InComment.compare_lower(InDecl) == 0;
> +}
>
> aar
klimek added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:2809
@@ +2808,3 @@
+/// matches \c foo in \c foo(t);
+AST_MATCHER_P(OverloadExpr, canReferToDecl, internal::Matcher,
+ InnerMatcher) {
aaron.ballman wrote:
> I find th
aaron.ballman added inline comments.
Comment at: test/clang-tidy/google-global-names.cpp:13-14
@@ +12,4 @@
+// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: 'i' declared in the global
namespace
+extern int ii = 0;
+// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: 'ii' declared in the glob
alexfh added a comment.
hokein: I'm committing the patch; if you have more comments, I'm happy to
address them in a follow-up.
https://reviews.llvm.org/D23135
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
Author: alexfh
Date: Thu Aug 4 09:54:54 2016
New Revision: 277729
URL: http://llvm.org/viewvc/llvm-project?rev=277729&view=rev
Log:
[clang-tidy] misc-argument-comment non-strict mode
Summary:
The misc-argument-comment check now ignores leading and trailing underscores and
case. The new `StrictMo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277729: [clang-tidy] misc-argument-comment non-strict mode
(authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D23135?vs=66806&id=66807#toc
Repository:
rL LLVM
https://reviews.ll
> On Aug 3, 2016, at 1:56 PM, Bruno Cardoso Lopes
> wrote:
>
> Hi Eric,
>
> After we upgraded our green dragon bots to El Captain (10.11), the
> test below started to fail on some of our machines:
>
> --
> test/std/experimental/filesystem/fs.op.funcs/fs.op.hard_lk_ct/hard_link_count.pass.cpp
alexfh added a comment.
Much better now, please also add instruction on how to find offsets.
https://reviews.llvm.org/D23158
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mboehme updated this revision to Diff 66808.
https://reviews.llvm.org/D23004
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchersTraversalTest.cpp
Index: unittests/ASTMatchers/ASTMatchersTr
mboehme added a comment.
I've rebased the patch to a newer head revision, which seems to confuse
Phabricator when diffing against earlier versions of the patch. Apologies. I
assume this means I should avoid doing this (rebasing to a newer revision)?
https://reviews.llvm.org/D23004
_
alexfh added a comment.
In https://reviews.llvm.org/D23004#505854, @mboehme wrote:
> I assume this means I should avoid doing this (rebasing to a newer revision)?
No, rebasing is totally fine. But if some files changed in the meantime,
comparing with older revisions will contain unrelated chan
alexfh added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:2486
@@ +2485,3 @@
+
+ return (UnderlyingDecl != nullptr &&
+ InnerMatcher.matches(*UnderlyingDecl, Finder, Builder));
mboehme wrote:
> I was trying to match the style of t
mboehme marked an inline comment as done.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:2486
@@ +2485,3 @@
+
+ return (UnderlyingDecl != nullptr &&
+ InnerMatcher.matches(*UnderlyingDecl, Finder, Builder));
I was trying to match the style of the ne
aaboud updated this revision to Diff 66810.
aaboud added a comment.
Made "no_caller_saved_registers" part of function prototype.
This will allow Clang to yell a warning when there is a mismatch between
function pointer and assigned function value.
Thanks to Erich for implementing this addition c
mboehme marked 3 inline comments as done.
mboehme added a comment.
https://reviews.llvm.org/D23004
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:2855
@@ +2854,3 @@
+/// bar(t);
+/// }
+/// \endcode
alexfh wrote:
> mboehme wrote:
> > > The documentation doesn't describe what the matcher does (can you please
> > >
vleschuk created this revision.
vleschuk added a reviewer: asl.
vleschuk added a subscriber: cfe-commits.
Emit DWARF DW_AT_noreturn for C++ [[ noreturn ]] and C _Noreturn specifiers.
Corresponding LLVM patch: https://reviews.llvm.org/D23167
https://reviews.llvm.org/D23168
Files:
lib/AST/Decl
mboehme updated this revision to Diff 66815.
mboehme added a comment.
Removed superfluous parentheses
https://reviews.llvm.org/D23004
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchersTr
omtcyfz updated this revision to Diff 66818.
omtcyfz added a comment.
Make testset great again.
https://reviews.llvm.org/D23158
Files:
test/clang-rename/ClassAsTemplateArgument.cpp
test/clang-rename/ClassAsTemplateArgumentFindByClass.cpp
test/clang-rename/ClassAsTemplateArgumentFindByTemp
majnemer added a subscriber: majnemer.
majnemer requested changes to this revision.
majnemer added a reviewer: majnemer.
majnemer added a comment.
This revision now requires changes to proceed.
This has no tests.
https://reviews.llvm.org/D23168
___
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:1674
@@ +1673,3 @@
+ TargetSpecificAttr {
+ let Spellings = [GNU<"no_caller_saved_registers">];
+ let Subjects = SubjectList<[FunctionLike], WarnDiag, "ExpectedFunction
vleschuk added reviewers: dexonsmith, echristo, aprantl.
vleschuk added a subscriber: cfe-commits.
vleschuk updated this revision to Diff 66822.
vleschuk added a comment.
Herald added a subscriber: mehdi_amini.
Expanded context, added more reviewers who took part in this parts of code.
https://r
aprantl added a comment.
Thanks for working in this!
Technically this is a DWARF 5 feature, but unknown attributes can be ignored by
consumers, so there's no reason to emit it conditionally.
Could you please also add a test for llvm-dwarfdump?
Could you please also add a textual LLVM IR parser t
vleschuk updated this revision to Diff 66825.
vleschuk added a comment.
More context. Slight formatting changes.
https://reviews.llvm.org/D23168
Files:
lib/AST/Decl.cpp
lib/CodeGen/CGDebugInfo.cpp
Index: lib/CodeGen/CGDebugInfo.cpp
==
Anastasia added a comment.
I don't think it works correctly yet.
Since ndrange_t is a copyable type i.e. we should be able to allocate the space
for it at compile time and to copy it. See spec example s6.13.17.2:
ndrange_t ndrange = ndrange_1d(...);
This implies that compiler should:
1. Gen
erichkeane added a comment.
Response on CGFucntionInfo.
Comment at: include/clang/CodeGen/CGFunctionInfo.h:479
@@ +478,3 @@
+ /// Whether this function saved caller registers.
+ unsigned NoCallerSavedRegs : 1;
+
aaron.ballman wrote:
> This is unfortunate as it
Anastasia accepted this revision.
Anastasia added a comment.
LGTM! Thanks!
https://reviews.llvm.org/D23120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl added inline comments.
Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:43
@@ +42,3 @@
+
+ return llvm::StructType::create(EleTypes, "ndrange_t");
+}
Anastasia wrote:
> yaxunl wrote:
> > yaxunl wrote:
> > > struct name should be "struct.ndrange_t" to allow libr
Author: bader
Date: Thu Aug 4 13:06:27 2016
New Revision: 277743
URL: http://llvm.org/viewvc/llvm-project?rev=277743&view=rev
Log:
[OpenCL] Added underscores to the names of 'to_addr' OpenCL built-ins.
Summary:
In order to re-define OpenCL built-in functions
'to_{private,local,global}' in OpenCL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277743: [OpenCL] Added underscores to the names of 'to_addr'
OpenCL built-ins. (authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D23120?vs=66653&id=66832#toc
Repository:
rL LLVM
aaron.ballman added inline comments.
Comment at: include/clang/CodeGen/CGFunctionInfo.h:479
@@ +478,3 @@
+ /// Whether this function saved caller registers.
+ unsigned NoCallerSavedRegs : 1;
+
erichkeane wrote:
> aaron.ballman wrote:
> > This is unfortunate as i
JDevlieghere updated this revision to Diff 66835.
JDevlieghere marked 9 inline comments as done.
JDevlieghere added a comment.
- Added function pointer test case
- Used placeholders for diagnostics
I extended the matchers to include `::memcpy` and `::memset` as well because
the check otherwise d
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Thanks for catching this! I couldn't really reduce your test case any further.
This LGTM.
I guess it never makes sense to have two regions with the exact same start/end
loc, and different counters.
erichkeane added a comment.
Response on CGFucntionInfo.
Comment at: include/clang/CodeGen/CGFunctionInfo.h:479
@@ +478,3 @@
+ /// Whether this function saved caller registers.
+ unsigned NoCallerSavedRegs : 1;
+
aaron.ballman wrote:
> erichkeane wrote:
> > aar
aaron.ballman added inline comments.
Comment at: include/clang/CodeGen/CGFunctionInfo.h:479
@@ +478,3 @@
+ /// Whether this function saved caller registers.
+ unsigned NoCallerSavedRegs : 1;
+
erichkeane wrote:
> aaron.ballman wrote:
> > erichkeane wrote:
> > >
manmanren added a comment.
Hi Erik,
Thanks for working on this! It is great to see these patches coming.
Manman
Comment at: include/clang/Sema/Sema.h:9608
@@ -9604,1 +9607,3 @@
+ /// \brief Whether we should emit an availability diagnostic for \c D.
+ bool ShouldDiagnoseAv
NoQ requested changes to this revision.
NoQ added a comment.
This revision now requires changes to proceed.
Whoops, because of a merge conflict while applying the patch, i noticed a few
problems in the tests, they seem obvious, but could you have a quick look?
Comment at: test/
NoQ added a comment.
In https://reviews.llvm.org/D22374#505672, @baloghadamsoftware wrote:
> In https://reviews.llvm.org/D22374#504855, @NoQ wrote:
>
> > Hmm. I suggest:
> >
> > 1. Change this test's constructor so that it was no longer almost-trivial.
> > Because it isn't significant for this t
teemperor updated this revision to Diff 66839.
teemperor marked 3 inline comments as done.
teemperor added a comment.
- Patch should no longer cause merge conflicts.
- Improved comments and tests in functions.cpp.
https://reviews.llvm.org/D22982
Files:
lib/Analysis/CloneDetection.cpp
test/A
teemperor marked 3 inline comments as done.
teemperor added a comment.
I think the updated patch should no longer have the problems mentioned in the
inline comments :)
https://reviews.llvm.org/D22982
___
cfe-commits mailing list
cfe-commits@lists.l
Author: yaxunl
Date: Thu Aug 4 14:30:54 2016
New Revision: 277754
URL: http://llvm.org/viewvc/llvm-project?rev=277754&view=rev
Log:
[OpenCL] Remove extra native_ functions from opencl-c.h
There should be no native_ builtin functions with double type arguments.
Patch by Aaron En Ye Shi.
Differe
Author: yaxunl
Date: Thu Aug 4 14:35:17 2016
New Revision: 277756
URL: http://llvm.org/viewvc/llvm-project?rev=277756&view=rev
Log:
[OpenCL] Add the lit test for image size which was omitted by r277647.
Added:
cfe/trunk/test/CodeGenOpenCL/cast_image.cl
Added: cfe/trunk/test/CodeGenOpenCL/ca
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277757: [analyzer] Make CloneDetector recognize different
variable patterns. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D22982?vs=66839&id=66842#toc
Repository:
rL LLV
Author: dergachev
Date: Thu Aug 4 14:37:00 2016
New Revision: 277757
URL: http://llvm.org/viewvc/llvm-project?rev=277757&view=rev
Log:
[analyzer] Make CloneDetector recognize different variable patterns.
CloneDetector should be able to detect clones with renamed variables.
However, if variables
aprantl added a comment.
Please add separate testcases for C11 and C++11 (and possibly Objective-C?).
https://reviews.llvm.org/D23168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
majnemer added a subscriber: majnemer.
Comment at: include/clang/CodeGen/CGFunctionInfo.h:479
@@ +478,3 @@
+ /// Whether this function saved caller registers.
+ unsigned NoCallerSavedRegs : 1;
+
aaron.ballman wrote:
> erichkeane wrote:
> > aaron.ballman wrote:
>
erichkeane added inline comments.
Comment at: include/clang/CodeGen/CGFunctionInfo.h:479
@@ +478,3 @@
+ /// Whether this function saved caller registers.
+ unsigned NoCallerSavedRegs : 1;
+
majnemer wrote:
> aaron.ballman wrote:
> > erichkeane wrote:
> > > aaron
vsk added a subscriber: hans.
vsk added a comment.
(@hans If there are no objections, and if it's still possible, it would be
great to see this merged into 3.9 once it has landed.)
https://reviews.llvm.org/D23160
___
cfe-commits mailing list
cfe-co
Author: timshen
Date: Thu Aug 4 18:03:44 2016
New Revision: 277783
URL: http://llvm.org/viewvc/llvm-project?rev=277783&view=rev
Log:
[ADT] Migrate DepthFirstIterator to use NodeRef
Summary: The corresponding LLVM change is D23146.
Reviewers: dblaikie, chandlerc
Subscribers: cfe-commits
Differ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277783: [ADT] Migrate DepthFirstIterator to use NodeRef
(authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D23147?vs=66745&id=66872#toc
Repository:
rL LLVM
https://reviews.llvm
Author: bruno
Date: Thu Aug 4 18:55:22 2016
New Revision: 277787
URL: http://llvm.org/viewvc/llvm-project?rev=277787&view=rev
Log:
[Sema] Add sizeof diagnostics for bzero
For memset (and others) we can get diagnostics like:
struct stat { int x; };
void foo(struct stat *stamps) {
bzero(s
bruno closed this revision.
bruno added a comment.
Thanks! Committed in r277787
https://reviews.llvm.org/D22525
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hello everyone,
Below are some buildbot numbers for the last week of 7/24/2016 - 7/30/2016.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from
Author: rtrieu
Date: Thu Aug 4 21:39:30 2016
New Revision: 277796
URL: http://llvm.org/viewvc/llvm-project?rev=277796&view=rev
Log:
Allow -1 to assign max value to unsigned bitfields.
Silence the -Wbitfield-constant-conversion warning for when -1 or other
negative values are assigned to unsigned
Author: rtrieu
Date: Thu Aug 4 22:16:36 2016
New Revision: 277797
URL: http://llvm.org/viewvc/llvm-project?rev=277797&view=rev
Log:
Fix crash in template type diffing.
When the type being diffed is a type alias, and the orginal type is not a
templated type, then there will be no unsugared Templa
ikudrin added a comment.
In https://reviews.llvm.org/D23160#506061, @vsk wrote:
> I guess it never makes sense to have two regions with the exact same
> start/end loc, and different counters. Do you think we should add assertions
> in llvm (either in llvm-cov, or in the coverage reader) which g
honggyu.kim added a comment.
Hi Renato and Saleem,
I found one more testcase that has to be changed. It's in
`llvm/tools/clang/test/Frontend/gnu-mcount.c`.
But strangely, some cases provide mcount name with prefix '\01' such as below:
class ARMTargetInfo : public TargetInfo {
...
public
mstorsjo added a comment.
Ping @compnerd
https://reviews.llvm.org/D22774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
98 matches
Mail list logo
