NoQ requested changes to this revision.
NoQ added a comment.
This revision now requires changes to proceed.
Whoops, because of a merge conflict while applying the patch, i noticed a few
problems in the tests, they seem obvious, but could you have a quick look?
================
Comment at: test/Analysis/copypaste/functions.cpp:21
@@ -20,3 +20,3 @@
-// Functions below are not clones and should not be reported.
+// Different variable patterns, therefore different clones.
----------------
Not sure, do "different clones" mean "different code, should not be reported"
or "different clones of the same code, should be reported"?
================
Comment at: test/Analysis/copypaste/functions.cpp:30
@@ +29,3 @@
+
+int minClone(int x, int y) { // expected-note{{Related code clone is here.}}
+ log();
----------------
This code is exactly identical, did you mean 'x > y' in any of those places?
https://reviews.llvm.org/D22982
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
