aaboud added a comment.
Reverting https://reviews.llvm.org/rL244207, would be fine if we assure that
PR24235, is fixed in another way.
I added Reid who helped reviewing the original patch
https://reviews.llvm.org/D11476.
https://reviews.llvm.org/D22900
__
majnemer added a comment.
In https://reviews.llvm.org/D22900#501597, @aaboud wrote:
> Reverting https://reviews.llvm.org/rL244207, would be fine if we assure that
> PR24235, is fixed in another way.
> I added Reid who helped reviewing the original patch
> https://reviews.llvm.org/D11476.
IST
aaboud added a comment.
> ISTM that the DWARF spec intended such thunks to be encoded as
> `DW_AT_trampoline`. That seems more appropriate than relying on codegen
> emitting a tailcall. This way the debugger can make the policy decision of
> whether or not thunks should show up in the backtra
rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D22904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
JDevlieghere retitled this revision from "[clang-tidy] Add check
'misc-replace-memcpy'" to "[clang-tidy] Add check 'modernize-use-algorithm'".
JDevlieghere updated the summary for this revision.
JDevlieghere set the repository for this revision to rL LLVM.
JDevlieghere updated this revision to Dif
Author: dim
Date: Sun Jul 31 15:23:23 2016
New Revision: 277307
URL: http://llvm.org/viewvc/llvm-project?rev=277307&view=rev
Log:
Add more gcc compatibility names to clang's cpuid.h
Summary:
Some cpuid bit defines are named slightly different from how gcc's
cpuid.h calls them.
Define a few more
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277307: Add more gcc compatibility names to clang's cpuid.h
(authored by dim).
Changed prior to commit:
https://reviews.llvm.org/D22010?vs=62781&id=66250#toc
Repository:
rL LLVM
https://reviews.llvm
Hi Hans,
I would like to merge this one to release_39, since it fixes a few third party
programs using cpuid.h, and expecting gcc-compatible CPUID bit macros.
-Dimitry
> On 31 Jul 2016, at 22:23, Dimitry Andric via cfe-commits
> wrote:
>
> Author: dim
> Date: Sun Jul 31 15:23:23 2016
> New R
Prazek added a comment.
I see you solved the void and conmpatible types problems. Excellent!
Can you post a patch with changes after running LLVM? I would wait for Alex or
Aaron to accept it.
Comment at: clang-tidy/modernize/UseAlgorithmCheck.cpp:58-60
@@ +57,5 @@
+
+ for (co
erik.pilkington created this revision.
erik.pilkington added reviewers: manmanren, dexonsmith, dcoughlin.
erik.pilkington added a subscriber: cfe-commits.
This patch implements support for diagnostics for @available violations. This
is done with a traversal of the AST after semantic analysis of a
teemperor updated this revision to Diff 66261.
teemperor added a comment.
- Added typedef for the contents of the data vector.
- Fixed that StmtDataCollector isn't visiting all parent classes of a statement.
- Removed 'test-' prefix from test files.
- Fixed the other problems as pointed out by Art
teemperor updated this revision to Diff 66262.
teemperor added a comment.
- Fixed a few typos in the comments.
- Removed unnecessary `std::`.
- Added the new tests to functions.cpp instead of their own file.
https://reviews.llvm.org/D22982
Files:
lib/Analysis/CloneDetection.cpp
test/Analysi
teemperor marked 2 inline comments as done.
teemperor added a comment.
https://reviews.llvm.org/D22982
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
teemperor added a comment.
I've deleted false-positives.cpp because all false-positives in there are now
resolved and the test did no longer serve a purpose. We could leave the test
file in there, but I think new false-positives either belong to an existing
test category or deserve their own na
Hi Sam,
I am now using llvm39 to enable our opencl driver, but I found this patch broke
the spir target as well.
The opencl.kernels metadata is required by spir spec. I think we should keep
the old code for spir target.
Thanks
Xiuli
-Original Message-
From: Yaxun Liu [mailto:yaxun@
> On Jul 31, 2016, at 1:46 AM, Amjad Aboud wrote:
>
> aaboud added a comment.
>
>> ISTM that the DWARF spec intended such thunks to be encoded as
>> `DW_AT_trampoline`. That seems more appropriate than relying on codegen
>> emitting a tailcall. This way the debugger can make the policy deci
> On Jul 31, 2016, at 12:11 AM, Amjad Aboud wrote:
>
> aaboud added a comment.
>
> Reverting https://reviews.llvm.org/rL244207, would be fine if we assure that
> PR24235, is fixed in another way.
I think it is inappropriate for anyone who introduced a bug to condition a
revert on a correct i
honggyu.kim updated the summary for this revision.
honggyu.kim updated this revision to Diff 66276.
honggyu.kim added a comment.
I've updated the testcase again it adds 2 more tests for -O2 and without -pg.
Please have a look at it.
$ llvm-lit mcount.c
-- Testing: 1 tests, 1 threads --
PASS
18 matches
Mail list logo
