Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos updated this revision to Diff 65672. https://reviews.llvm.org/D21814 Files: clang-rename/RenamingAction.cpp clang-rename/RenamingAction.h clang-rename/tool/ClangRename.cpp clang-rename/tool/clang-rename.py docs/clang-rename.rst test/clang-rename/ClassFindByName.cpp test/clan

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. Rebased on top of r276836 and resolved conflicts. https://reviews.llvm.org/D21814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22663: Support setting default value for -rtlib at build time

zlei added a comment. @Hahnfeld Could you please commit it? I don't have the access. Thanks :) https://reviews.llvm.org/D22663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22805: [clang-include-fixer] Added Emacs integration for clang-include-fixer.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. It looks good to me now, a few comments. Let's wait to see whether @bkramer has any further comments. Comment at: docs/include-fixer.rst:81 @@ +80,3 @@ +To run `clang-includ

Re: [PATCH] D22663: Support setting default value for -rtlib at build time

This revision was automatically updated to reflect the committed changes. Closed by commit rL276848: Support setting default value for -rtlib at build time (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D22663?vs=65643&id=65678#toc Repository: rL LLVM https://revi

r276848 - Support setting default value for -rtlib at build time

Author: hahnfeld Date: Wed Jul 27 03:15:54 2016 New Revision: 276848 URL: http://llvm.org/viewvc/llvm-project?rev=276848&view=rev Log: Support setting default value for -rtlib at build time This patch introduces a new cmake variable: CLANG_DEFAULT_RTLIB, thru which we can specify a default value

Re: [PATCH] D22805: [clang-include-fixer] Added Emacs integration for clang-include-fixer.

massberg updated this revision to Diff 65679. massberg marked an inline comment as done. massberg added a comment. Updating https://reviews.llvm.org/D22805: [clang-include-fixer] Added Emacs integration for clang-include-fixer. - Corrected typos and code indentation. https://reviews.llvm.org/D

Re: [PATCH] D22805: [clang-include-fixer] Added Emacs integration for clang-include-fixer.

massberg marked 2 inline comments as done. massberg added a comment. Thanks for the comments! Comment at: include-fixer/tool/clang-include-fixer.el:24 @@ +23,3 @@ + "Location of the `clang-include-fixer' executable. + + A string containing the name or the full path of the exe

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

omtcyfz added a comment. Apart from my high level concerns, which of course I still have... Comment at: clang-rename/tool/clang-rename.py:43 @@ -42,2 +42,3 @@ command = [binary, + "rename-at", filename, `rename-at` isn't necess

r276851 - [ARM] Pass -mimplcit-it= to integrated assembler

Author: olista01 Date: Wed Jul 27 03:54:13 2016 New Revision: 276851 URL: http://llvm.org/viewvc/llvm-project?rev=276851&view=rev Log: [ARM] Pass -mimplcit-it= to integrated assembler Differential Revision: https://reviews.llvm.org/D22761 Added: cfe/trunk/test/Driver/arm-implicit-it.s Modif

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos updated this revision to Diff 65684. https://reviews.llvm.org/D21814 Files: clang-rename/RenamingAction.cpp clang-rename/RenamingAction.h clang-rename/tool/ClangRename.cpp docs/clang-rename.rst test/clang-rename/ClassFindByName.cpp test/clang-rename/ClassTestMulti.cpp test/c

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos marked 2 inline comments as done. vmiklos added a comment. > rename-at isn't necessary here anymore since it's going to be default > behavior IIUC Indeed, it can be changed back now, done. > docs should be fixed correspondingly; i.e. prefer to write clang-rename > -offset=42 over

Re: [PATCH] D21749: Changes related to new implementation of tooling::Replacements as class.

ioeric updated this revision to Diff 65685. ioeric added a comment. - Merged with origin/master. https://reviews.llvm.org/D21749 Files: clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp clang-a

Re: [PATCH] D21748: Implement tooling::Replacements as a class.

ioeric updated this revision to Diff 65686. ioeric added a comment. - Moved ReplacementTest and toReplacements to ReplacementTest.h - Merge branch 'master' of http://llvm.org/git/clang into replace https://reviews.llvm.org/D21748 Files: include/clang/Tooling/Core/Replacement.h include/clang

Re: [PATCH] D22805: [clang-include-fixer] Added Emacs integration for clang-include-fixer.

bkramer accepted this revision. bkramer added a comment. Looks good from my side. https://reviews.llvm.org/D22805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21748: Implement tooling::Replacements as a class.

ioeric updated this revision to Diff 65687. ioeric added a comment. - Clean up ReplacemenTest.h header a bit. https://reviews.llvm.org/D21748 Files: include/clang/Tooling/Core/Replacement.h include/clang/Tooling/Refactoring.h lib/Format/Format.cpp lib/Format/SortJavaScriptImports.cpp

Re: [PATCH] D21748: Implement tooling::Replacements as a class.

ioeric marked an inline comment as done. Comment at: unittests/Tooling/RefactoringTest.cpp:112 @@ -111,4 +111,3 @@ -TEST_F(ReplacementTest, CanApplyReplacements) { - FileID ID = Context.createInMemoryFile("input.cpp", - "line1\nline2\nlin

[clang-tools-extra] r276853 - [clang-include-fixer] Added Emacs integration for clang-include-fixer.

Author: d0k Date: Wed Jul 27 05:11:06 2016 New Revision: 276853 URL: http://llvm.org/viewvc/llvm-project?rev=276853&view=rev Log: [clang-include-fixer] Added Emacs integration for clang-include-fixer. Patch by Jens Massberg! Thanks a lot. Differential Revision: https://reviews.llvm.org/D22805 A

Re: [PATCH] D22805: [clang-include-fixer] Added Emacs integration for clang-include-fixer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL276853: [clang-include-fixer] Added Emacs integration for clang-include-fixer. (authored by d0k). Changed prior to commit: https://reviews.llvm.org/D22805?vs=65679&id=65689#toc Repository: rL LLVM h

r276854 - clang-format: Fix incorrect detection of QT-signals access specifier.

Author: djasper Date: Wed Jul 27 05:13:24 2016 New Revision: 276854 URL: http://llvm.org/viewvc/llvm-project?rev=276854&view=rev Log: clang-format: Fix incorrect detection of QT-signals access specifier. Before: void f() { label: signals .baz(); } After: void f() { label: s

Re: [llvm-dev] [PATCH] Add support for the 'unless' matcher in the dynamic layer.

On Wed, Jul 27, 2016 at 1:06 AM Piotr Padlewski via llvm-dev < llvm-...@lists.llvm.org> wrote: > We could also just add nothing() matcher, so debugging would be much > easier, just add anything() or nothing() matcher as extra argument. > > The other pros of it is that new developers won't send the

Re: [PATCH] D21385: Adjust Registry interface to not require plugins to export a registry

This revision was automatically updated to reflect the committed changes. Closed by commit rL276856: Adjust Registry interface to not require plugins to export a registry (authored by john.brawn). Repository: rL LLVM https://reviews.llvm.org/D21385 Files: cfe/trunk/examples/AnnotateFunction

r276856 - Adjust Registry interface to not require plugins to export a registry

Author: john.brawn Date: Wed Jul 27 06:18:38 2016 New Revision: 276856 URL: http://llvm.org/viewvc/llvm-project?rev=276856&view=rev Log: Adjust Registry interface to not require plugins to export a registry Currently the Registry class contains the vestiges of a previous attempt to allow plugins

r276857 - Revert r276856 "Adjust Registry interface to not require plugins to export a registry"

Author: john.brawn Date: Wed Jul 27 06:41:18 2016 New Revision: 276857 URL: http://llvm.org/viewvc/llvm-project?rev=276857&view=rev Log: Revert r276856 "Adjust Registry interface to not require plugins to export a registry" This is causing a huge pile of buildbot failures. Modified: cfe/tru

[PATCH] D22853: [clang-rename] add support for template parameter renaming

omtcyfz created this revision. omtcyfz added reviewers: alexfh, klimek. omtcyfz added a subscriber: cfe-commits. Few simple tweaks allow template parameters to be renamed. See TemplateTypenameFindBy{TemplateParam|TypeInside}.cpp for example how it works. https://reviews.llvm.org/D22853 Files:

[PATCH] D22854: change Vim key binding for include-fixer and clang-rename

omtcyfz created this revision. omtcyfz added reviewers: alexfh, klimek, ioeric. omtcyfz added a subscriber: cfe-commits. Change Vim key binding for include-fixer (`,cf` -> `cf`) and clang-rename (`,cr` -> `cr`) to use `` instead of `,` like cool Vim people (tm) do. https://reviews.llvm.org/D228

Re: [PATCH] D21748: Implement tooling::Replacements as a class.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D21748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D22855: [ARM] Pass thumb as architecture to the underlying tools, when targeting windows

mstorsjo created this revision. mstorsjo added a subscriber: cfe-commits. Herald added subscribers: samparker, rengolin, aemerson. This makes sure that the thumb section flag gets set by the assembler. This is an alternative fix to D22776. https://reviews.llvm.org/D22855 Files: lib/Driver/Too

Re: [PATCH] D22854: change Vim key binding for include-fixer and clang-rename

ioeric added a comment. Could you briefly explain what is and how to lookup/set it in the doc, or at least provide reference? https://reviews.llvm.org/D22854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

Re: [PATCH] D22798: Fix for compiling with clang <= 3.7 and g++6 headers.

marsupial added a comment. Would be nice...I have no commit access. Repository: rL LLVM https://reviews.llvm.org/D22798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21959: [X86] Add xgetbv xsetbv intrinsics

guyblank updated this revision to Diff 65676. guyblank marked an inline comment as done. https://reviews.llvm.org/D21959 Files: include/clang/Basic/BuiltinsX86.def lib/CodeGen/CGBuiltin.cpp lib/Headers/intrin.h lib/Headers/xsaveintrin.h test/CodeGen/builtins-x86.c test/CodeGen/x86_32-

[PATCH] D22856: [analyzer] Change -analyze-function to accept qualified names.

NoQ created this revision. NoQ added a reviewer: zaks.anna. NoQ added subscribers: dcoughlin, xazax.hun, a.sidorin, cfe-commits. The `-analyze-function` option is very useful when debugging test failures, especially when printing or viewing exploded graphs - with this option you no longer need t

Re: [PATCH] D21749: Changes related to new implementation of tooling::Replacements as class.

ioeric updated this revision to Diff 65712. ioeric added a comment. - Minor cleanup/ https://reviews.llvm.org/D21749 Files: clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp clang-apply-replace

Re: [PATCH] D21749: Changes related to new implementation of tooling::Replacements as class.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D21749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D22854: change Vim key binding for include-fixer and clang-rename

vmiklos added a subscriber: vmiklos. vmiklos added a comment. `:help leader` explains it. Or see this link: http://learnvimscriptthehardway.stevelosh.com/chapters/06.html#leader. The later describes 3 arguments for using `` instead of `,` directly. https://reviews.llvm.org/D22854 __

Re: [PATCH] D22854: change Vim key binding for include-fixer and clang-rename

omtcyfz updated this revision to Diff 65714. omtcyfz added a comment. add refernce to what `` is https://reviews.llvm.org/D22854 Files: clang-rename/tool/clang-rename.py docs/clang-rename.rst docs/include-fixer.rst include-fixer/tool/clang-include-fixer.py Index: include-fixer/tool/cla

Re: [PATCH] D22854: change Vim key binding for include-fixer and clang-rename

omtcyfz added a comment. In https://reviews.llvm.org/D22854#497496, @vmiklos wrote: > `:help leader` explains it. Or see this link: > http://learnvimscriptthehardway.stevelosh.com/chapters/06.html#leader. The > later describes 3 arguments for using `` instead of `,` directly. I think the poin

[PATCH] D22857: [ARM] Add a test for inline assembly when targeting armv7-windows

mstorsjo created this revision. mstorsjo added a subscriber: cfe-commits. Herald added subscribers: samparker, rengolin, aemerson. This test uses an immediate constant, which was previously broken in inline assembly, prior to LLVM r276859. https://reviews.llvm.org/D22857 Files: test/CodeGen/

Re: [PATCH] D22855: [ARM] Pass thumb as architecture to the underlying tools, when targeting windows

rengolin accepted this revision. rengolin added a reviewer: rengolin. rengolin added a comment. This revision is now accepted and ready to land. LGTM. I'll add the test to LLVM as a separate commit. Comment at: lib/Driver/ToolChain.cpp:499 @@ -498,1 +498,3 @@ + options::

Re: [PATCH] D22374: [analyzer] Copy and move constructors - ExprEngine extended for "almost trivial" copy and move constructors

NoQ added a comment. I see what's going on. `performTrivialCopy()` already calls `evalBind()`, which in turn calls `runCheckersForBind()`, so no effort is needed there. However, the bind event itself is now different - instead of a separate event for every bind, you're having only one event fo

Re: [PATCH] D22855: [ARM] Pass thumb as architecture to the underlying tools, when targeting windows

mstorsjo added inline comments. Comment at: test/Driver/thumb-attributes.s:1 @@ +1,2 @@ +@ RUN: %clang -target armv7-windows-itanium -c -o - %s \ +@ RUN: | llvm-readobj -s - | FileCheck %s rengolin wrote: > But we don't usually do asm tests in Clang. I can add t

Re: [PATCH] D22766: Handle -mlong-calls on Hexagon

kparzysz added a comment. It likely is sufficient. The code in Targets.cpp adds checking for "long-calls" feature in hasFeature, but it's not explicitly used anywhere. The rest of the changes are mostly to clean up the handling of feature strings. Repository: rL LLVM https://reviews.llvm.

[clang-tools-extra] r276861 - [clang-tidy] Add cppcoreguidelines-slicing entry to list.rst.

Author: hokein Date: Wed Jul 27 08:11:50 2016 New Revision: 276861 URL: http://llvm.org/viewvc/llvm-project?rev=276861&view=rev Log: [clang-tidy] Add cppcoreguidelines-slicing entry to list.rst. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst Modified: clang-tools-extra/tru

Re: [PATCH] D22855: [ARM] Pass thumb as architecture to the underlying tools, when targeting windows

rengolin added inline comments. Comment at: test/Driver/thumb-attributes.s:1 @@ +1,2 @@ +@ RUN: %clang -target armv7-windows-itanium -c -o - %s \ +@ RUN: | llvm-readobj -s - | FileCheck %s mstorsjo wrote: > rengolin wrote: > > But we don't usually do asm tests i

[clang-tools-extra] r276862 - [include-fixer] Update document.

Author: hokein Date: Wed Jul 27 08:17:16 2016 New Revision: 276862 URL: http://llvm.org/viewvc/llvm-project?rev=276862&view=rev Log: [include-fixer] Update document. Modified: clang-tools-extra/trunk/docs/include-fixer.rst Modified: clang-tools-extra/trunk/docs/include-fixer.rst URL: http:/

Re: [PATCH] D22855: [ARM] Pass thumb as architecture to the underlying tools, when targeting windows

mstorsjo updated this revision to Diff 65725. mstorsjo added a comment. Updated the test to only check what triplet is passed to the assembler https://reviews.llvm.org/D22855 Files: lib/Driver/ToolChain.cpp test/Driver/windows-thumb.s Index: test/Driver/windows-thumb.s

Re: [PATCH] D20811: [analyzer] Model some library functions

NoQ added a comment. Answering myself: Hmm, so the only reason why MPI checker class appears in doxygen (http://clang.llvm.org/doxygen/classclang_1_1ento_1_1mpi_1_1MPIChecker.html) is because this class is not in anonymous namespace (as far as i understand, they needed to be multi-file for som

[clang-tools-extra] r276866 - [clang-rename] skip CXXConversionDecl while searching for NamedDecl

Author: omtcyfz Date: Wed Jul 27 08:37:22 2016 New Revision: 276866 URL: http://llvm.org/viewvc/llvm-project?rev=276866&view=rev Log: [clang-rename] skip CXXConversionDecl while searching for NamedDecl Modified: clang-tools-extra/trunk/clang-rename/USRFinder.cpp clang-tools-extra/trunk/te

[PATCH] D22862: [analyzer] Fix for PR15623: eliminate unwanted ProgramState checker data propagation.

ayartsev created this revision. ayartsev added reviewers: zaks.anna, krememek. ayartsev added a subscriber: cfe-commits. The attached patch eliminates unneeded checker data propagation from one of the operands of a logical operation to the operation result. The result of a logical operation is c

Re: [PATCH] D22854: change Vim key binding for include-fixer and clang-rename

omtcyfz added a comment. Any other comments? https://reviews.llvm.org/D22854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22854: change Vim key binding for include-fixer and clang-rename

ioeric added inline comments. Comment at: docs/clang-rename.rst:98 @@ +97,3 @@ + +Once installed, you can point your cursor to the symbols you want to rename, +press ``cr`` and print new desired name. The s/the symbols/symbols/ Comment at: docs/c

Re: [PATCH] D22854: change Vim key binding for include-fixer and clang-rename

omtcyfz added inline comments. Comment at: docs/clang-rename.rst:101 @@ +100,3 @@ +[`` key``](http://vim.wikia.com/wiki/Mapping_keys_in_Vim_-_Tutorial_(Part_3)#Map_leader) +is a reference to a specific key defined by the mapleader variable and is binded +to backslash by default.

Re: [PATCH] D22854: change Vim key binding for include-fixer and clang-rename

omtcyfz updated this revision to Diff 65739. omtcyfz marked an inline comment as done. https://reviews.llvm.org/D22854 Files: clang-rename/tool/clang-rename.py docs/clang-rename.rst docs/include-fixer.rst include-fixer/tool/clang-include-fixer.py Index: include-fixer/tool/clang-include-f

r276869 - [ARM] Pass thumb as architecture to the underlying tools, when targeting windows

Author: rengolin Date: Wed Jul 27 09:12:20 2016 New Revision: 276869 URL: http://llvm.org/viewvc/llvm-project?rev=276869&view=rev Log: [ARM] Pass thumb as architecture to the underlying tools, when targeting windows This makes sure that the thumb section flag gets set by the assembler. Patch by

Re: [PATCH] D22855: [ARM] Pass thumb as architecture to the underlying tools, when targeting windows

rengolin closed this revision. rengolin added a comment. Committed as r276869. https://reviews.llvm.org/D22855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22854: change Vim key binding for include-fixer and clang-rename

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Comment at: docs/clang-rename.rst:101 @@ +100,3 @@ +[`` key``](http://vim.wikia.com/wiki/Mapping_keys_in_Vim_-_Tutorial_(Part_3)#Map_leader) +is a reference to a specifi

Re: [PATCH] D22854: change Vim key binding for include-fixer and clang-rename

alexfh added inline comments. Comment at: docs/include-fixer.rst:73 @@ +72,3 @@ +[`` key``](http://vim.wikia.com/wiki/Mapping_keys_in_Vim_-_Tutorial_(Part_3)#Map_leader) +is a reference to a specific key defined by the mapleader variable and is binded +to backslash by default. -

[clang-tools-extra] r276870 - change Vim key binding for include-fixer and clang-rename

Author: omtcyfz Date: Wed Jul 27 09:23:47 2016 New Revision: 276870 URL: http://llvm.org/viewvc/llvm-project?rev=276870&view=rev Log: change Vim key binding for include-fixer and clang-rename Change Vim key binding for include-fixer (`,cf` -> `cf`) and clang-rename (`,cr` -> `cr`) to use `` inste

Re: [PATCH] D22854: change Vim key binding for include-fixer and clang-rename

omtcyfz added inline comments. Comment at: docs/clang-rename.rst:101 @@ +100,3 @@ +[`` key``](http://vim.wikia.com/wiki/Mapping_keys_in_Vim_-_Tutorial_(Part_3)#Map_leader) +is a reference to a specific key defined by the mapleader variable and is binded +to backslash by default.

[clang-tools-extra] r276871 - fix typo in clang-rename and clang-tidy docs

Author: omtcyfz Date: Wed Jul 27 09:26:03 2016 New Revision: 276871 URL: http://llvm.org/viewvc/llvm-project?rev=276871&view=rev Log: fix typo in clang-rename and clang-tidy docs Modified: clang-tools-extra/trunk/docs/clang-rename.rst clang-tools-extra/trunk/docs/include-fixer.rst Modifi

Re: [PATCH] D22854: change Vim key binding for include-fixer and clang-rename

This revision was automatically updated to reflect the committed changes. Closed by commit rL276870: change Vim key binding for include-fixer and clang-rename (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D22854?vs=65739&id=65741#toc Repository: rL LLVM https://re

Re: [PATCH] D22857: [ARM] Add a test for inline assembly when targeting armv7-windows

On Wed, Jul 27, 2016 at 5:53 AM, Martin Storsjö wrote: > mstorsjo created this revision. > mstorsjo added a subscriber: cfe-commits. > Herald added subscribers: samparker, rengolin, aemerson. > > This test uses an immediate constant, which was previously broken in > inline assembly, prior to LLVM

Re: [PATCH] D22857: [ARM] Add a test for inline assembly when targeting armv7-windows

rengolin added a subscriber: compnerd. rengolin added a comment. I'll just echo @compnerd comments, since Phab didn't get it. - Change the syntax to __asm__, to be more portable - Add Microsoft asm block syntax cheers, --renato https://reviews.llvm.org/D22857 ___

Re: [PATCH] D22857: [ARM] Add a test for inline assembly when targeting armv7-windows

rengolin requested changes to this revision. This revision now requires changes to proceed. Comment at: test/CodeGen/arm-inline-asm-windows.c:2 @@ +1,3 @@ +// REQUIRES: arm-registered-target +// RUN: %clang -target armv7-windows -c -o - %s + Also, I just noticed,

Re: [llvm-dev] [PATCH] Add support for the 'unless' matcher in the dynamic layer.

Is, but it is still a lot of typing and we are talking about debuging. 2016-07-27 3:40 GMT-07:00 Manuel Klimek : > On Wed, Jul 27, 2016 at 1:06 AM Piotr Padlewski via llvm-dev < > llvm-...@lists.llvm.org> wrote: > >> We could also just add nothing() matcher, so debugging would be much >> easier,

r276878 - Implement filtering for code completion of identifiers.

Author: vvassilev Date: Wed Jul 27 09:56:59 2016 New Revision: 276878 URL: http://llvm.org/viewvc/llvm-project?rev=276878&view=rev Log: Implement filtering for code completion of identifiers. Patch by Cristina Cristescu and Axel Naumann! Agreed on post commit review (D17820). Modified: cfe/

Re: [PATCH] D17820: Clang Code Completion Filtering

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r276878. Repository: rL LLVM https://reviews.llvm.org/D17820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

RE: r276361 - Reverting r275115 which caused PR28634.

Thanks for reverting this, our internal buildbots have gone green again. > Can you add a non-regression test case? > (It seems the test-suite didn’t catch this bug right?) Do we have any upstream buildbots using -O0? I haven't investigated very far* but -O0 seems to be the common factor between

Re: [PATCH] D22518: Refactor how include paths are appended to the command arguments.

sfantao updated this revision to Diff 65747. sfantao marked 3 inline comments as done. sfantao added a comment. - Remove of use of SmallVector and include CUDA args only for the regular toolchain. https://reviews.llvm.org/D22518 Files: lib/Driver/Tools.cpp test/Driver/cuda-version-check.cu

Re: [PATCH] D22518: Refactor how include paths are appended to the command arguments.

sfantao added a comment. Hi Art, Richard, Thanks for looking at this patch. I tried to address Richard concerns in the last diff. Let me know your thoughts, Thanks again, Samuel Comment at: lib/Driver/Tools.cpp:308-335 @@ -349,1 +307,30 @@ +Action::OffloadKind ActiveOffl

Re: [PATCH] D22856: [analyzer] Change -analyze-function to accept qualified names.

dcoughlin added a comment. I think it would be better for fully-qualified Objective-C methods to be specified with their Objective-C-style names. For example: "-[Test1 myMethodWithY:withX:]". This would also remove the ambiguity when there are class and instance methods with the same selector.

Re: [PATCH] D22856: [analyzer] Change -analyze-function to accept qualified names.

NoQ added a comment. > I think it would be better for fully-qualified Objective-C methods to be > specified with their Objective-C-style names. For example: "-[Test1 > myMethodWithY:withX:]". Uhm, need to know more about those. So i just print "`-[`", then fully-qualified class name, then sel

Re: [PATCH] D22690: [OpenMP] Add support for mapping array sections through pointer references.

sfantao updated this revision to Diff 65751. sfantao marked an inline comment as done. sfantao added a comment. - Use castAs instead of getAs in pointer type. https://reviews.llvm.org/D22690 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGStmtOpenMP.cpp test/OpenMP/target_map_codegen

Re: [PATCH] D22857: [ARM] Add a test for inline assembly when targeting armv7-windows

ahatanak added a subscriber: ahatanak. ahatanak added a comment. Is r276859 fixing a bug in the assembler? I'm trying to understand why we have to add a clang test in this particular case because I don't think we normally add a test in clang every time we fix a bug in the backend or assembler.

Re: [PATCH] D22857: [ARM] Add a test for inline assembly when targeting armv7-windows

rengolin added a comment. In https://reviews.llvm.org/D22857#497805, @ahatanak wrote: > Is r276859 fixing a bug in the assembler? Sort of. It was just adding a comment character to ; instead of #. > I'm trying to understand why we have to add a clang test in this particular > case because I d

Re: [PATCH] D17820: Clang Code Completion Filtering

junbuml added a subscriber: junbuml. junbuml added a comment. It appears that build fails due to this change : llvm/tools/clang/lib/Sema/CodeCompleteConsumer.cpp:448:3: error: default label in switch which covers all enumeration values [-Werror,-Wcovered-switch-default] default: llvm_unreacha

[PATCH] D22871: Fix incorrect -Wtautological-constant-out-of-range warnings with enums

ibadawi created this revision. ibadawi added reviewers: majnemer, rjmccall. ibadawi added a subscriber: cfe-commits. This is a proposed fix for bug 16154 (https://llvm.org/bugs/show_bug.cgi?id=16154) -- it was tentatively fixed in r183084 but had the fix was backed out in r183575 because the app

Re: [PATCH] D22596: Retry: [Driver] Compute effective target triples once per job (NFCI)

vsk added a comment. Ping. https://reviews.llvm.org/D22596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r276887 - Update cxx_dr_Status after 3.9 branch

Author: hans Date: Wed Jul 27 11:39:45 2016 New Revision: 276887 URL: http://llvm.org/viewvc/llvm-project?rev=276887&view=rev Log: Update cxx_dr_Status after 3.9 branch Modified: cfe/trunk/www/cxx_dr_status.html cfe/trunk/www/make_cxx_dr_status Modified: cfe/trunk/www/cxx_dr_status.html

r276889 - Fix unnecessary default switch warning

Author: rksimon Date: Wed Jul 27 11:41:56 2016 New Revision: 276889 URL: http://llvm.org/viewvc/llvm-project?rev=276889&view=rev Log: Fix unnecessary default switch warning Modified: cfe/trunk/lib/Sema/CodeCompleteConsumer.cpp Modified: cfe/trunk/lib/Sema/CodeCompleteConsumer.cpp URL: http:

Re: [PATCH] D22518: Refactor how include paths are appended to the command arguments.

tra added a comment. Looks good. https://reviews.llvm.org/D22518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

Anastasia added inline comments. Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188 @@ +187,3 @@ + #endif +#else + #ifdef cl_khr_mipmap_image Looks good! Could you just remove indentation please as it's not common for C macros? The same for the test below!

r276891 - UsersManual.rst: update clang-cl option list

Author: hans Date: Wed Jul 27 11:56:03 2016 New Revision: 276891 URL: http://llvm.org/viewvc/llvm-project?rev=276891&view=rev Log: UsersManual.rst: update clang-cl option list Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL: http://llvm.org/viewvc/llvm-

[PATCH] D22874: [analyzer] Fixes to the checker developer manual.

NoQ created this revision. NoQ added a reviewer: zaks.anna. NoQ added subscribers: dcoughlin, xazax.hun, a.sidorin, cfe-commits. 1. Fix the explanation of how to run tests after migration from autotools to cmake. 2. Expand the "debugging" section with more interesting stuff, as accidentally dis

Re: [PATCH] D22871: Fix incorrect -Wtautological-constant-out-of-range warnings with enums

ibadawi updated this revision to Diff 65763. ibadawi added a comment. Remove extra blank line added by accident https://reviews.llvm.org/D22871 Files: lib/Sema/SemaChecking.cpp Index: lib/Sema/SemaChecking.cpp === --- lib/Sema/S

Re: [PATCH] D22871: Fix incorrect -Wtautological-constant-out-of-range warnings with enums

ibadawi updated this revision to Diff 65765. ibadawi added a comment. Restore the test lost in patch #2. Really sorry for the noise... https://reviews.llvm.org/D22871 Files: lib/Sema/SemaChecking.cpp test/Sema/outof-range-constant-compare.c Index: test/Sema/outof-range-constant-compare.c =

[PATCH] D22879: [CUDA] Align kernel launch args correctly when the LLVM type's alignment is different from the clang type's alignment.

jlebar created this revision. jlebar added a reviewer: rnk. jlebar added subscribers: tra, cfe-commits. Before this patch, we computed the offsets in memory of args passed to GPU kernel functions by throwing all of the args into an LLVM struct. clang emits packed llvm structs basically whenever i

r276896 - Update Clang Parser test error message to match new parser errors

Author: niravd Date: Wed Jul 27 12:39:47 2016 New Revision: 276896 URL: http://llvm.org/viewvc/llvm-project?rev=276896&view=rev Log: Update Clang Parser test error message to match new parser errors Modified: cfe/trunk/test/Parser/ms-inline-asm.c Modified: cfe/trunk/test/Parser/ms-inline-asm

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

ashi1 updated this revision to Diff 65773. ashi1 marked an inline comment as done. ashi1 added a comment. Removed indentation as per Anastasia's comments. Repository: rL LLVM https://reviews.llvm.org/D22637 Files: include/clang/Basic/OpenCLExtensions.def lib/Basic/Targets.cpp test/Misc

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

Anastasia added a comment. Btw, I am missing tests for generated __translate_sampler_initializer which I think we had at some point. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:84 @@ +83,3 @@ +SamplerTy = llvm::PointerType::get(llvm::StructType::create( + CGM.getLLVMCo

Re: [PATCH] D22879: [CUDA] Align kernel launch args correctly when the LLVM type's alignment is different from the clang type's alignment.

rnk added inline comments. Comment at: test/CodeGenCUDA/kernel-args-alignment.cu:1-2 @@ +1,3 @@ +// REQUIRES: x86-registered-target +// REQUIRES: nvptx-registered-target + Typically clang doesn't need a registered backend for a target to generate IR for that targ

r276900 - [Sema] Teach getCurrentThisType to reconize lambda in in-class initializer

Author: epilk Date: Wed Jul 27 13:25:10 2016 New Revision: 276900 URL: http://llvm.org/viewvc/llvm-project?rev=276900&view=rev Log: [Sema] Teach getCurrentThisType to reconize lambda in in-class initializer Fixes PR27994, a crash on valid. Differential revision: https://reviews.llvm.org/D21145

Re: [PATCH] D21145: [Sema] Fix crash on valid where instantiation of lambda cannot access type of 'this'

This revision was automatically updated to reflect the committed changes. Closed by commit rL276900: [Sema] Teach getCurrentThisType to reconize lambda in in-class initializer (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D21145?vs=60622&id=65779#toc Repository: rL L

[PATCH] D22881: Fix NamedDeclFindingASTVisitor

alexshap created this revision. alexshap added reviewers: klimek, omtcyfz. alexshap added subscribers: compnerd, cfe-commits. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Properly initialize the field Context in NamedDeclFindingAS

r276904 - Adjust coercion of aggregates on RenderScript

Author: pirama Date: Wed Jul 27 14:01:51 2016 New Revision: 276904 URL: http://llvm.org/viewvc/llvm-project?rev=276904&view=rev Log: Adjust coercion of aggregates on RenderScript Summary: In RenderScript, the size of the argument or return value emitted in the IR is expected to be the same as the

Re: [PATCH] D22857: [ARM] Add a test for inline assembly when targeting armv7-windows

mstorsjo added a comment. In https://reviews.llvm.org/D22857#497719, @rengolin wrote: > I'll just echo @compnerd comments, since Phab didn't get it. > > - Change the syntax to __asm__, to be more portable > - Add Microsoft asm block syntax MSVC doesn't support inline assembly on ARM at all (the

Re: [PATCH] D17820: Clang Code Completion Filtering

Looking into it. On 27/07/16 18:34, Jun Bum Lim wrote: junbuml added a subscriber: junbuml. junbuml added a comment. It appears that build fails due to this change : llvm/tools/clang/lib/Sema/CodeCompleteConsumer.cpp:448:3: error: default label in switch which covers all enumeration values [-W

r276907 - Add flags to toggle preservation of assembly comments

Author: niravd Date: Wed Jul 27 14:57:40 2016 New Revision: 276907 URL: http://llvm.org/viewvc/llvm-project?rev=276907&view=rev Log: Add flags to toggle preservation of assembly comments Summary: Add -fpreserve-as-comments and -fno-preserve-as-comments. Reviewers: echristo, rnk Subscribers: meh

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

yaxunl marked 9 inline comments as done. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:84 @@ +83,3 @@ +SamplerTy = llvm::PointerType::get(llvm::StructType::create( + CGM.getLLVMContext(), "__opencl_sampler_t"), + CGM.getContext().getTargetAddressSpace(

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

yaxunl updated this revision to Diff 65796. yaxunl marked 5 inline comments as done. yaxunl added a comment. Revised by Anastasia's comments. Added missing codegen test. https://reviews.llvm.org/D21567 Files: include/clang/AST/OperationKinds.def include/clang/Basic/DiagnosticGroups.td inc

  1   2   >