rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM. I'll add the test to LLVM as a separate commit.
================
Comment at: lib/Driver/ToolChain.cpp:499
@@ -498,1 +498,3 @@
+ options::OPT_mno_thumb, ThumbDefault)) || IsMProfile ||
+ getTriple().isOSWindows()) {
if (IsBigEndian)
----------------
This makes sense to me.
================
Comment at: test/Driver/thumb-attributes.s:1
@@ +1,2 @@
+@ RUN: %clang -target armv7-windows-itanium -c -o - %s \
+@ RUN: | llvm-readobj -s - | FileCheck %s
----------------
But we don't usually do asm tests in Clang. I can add this test to LLVM's MC
dir.
https://reviews.llvm.org/D22855
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
