vmiklos updated this revision to Diff 65417.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
clang-rename/tool/clang-rename.py
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clan
vmiklos added a comment.
Rebased on top of r276684 and resolved conflicts.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mmasten added a comment.
I was just recently given commit privileges, so I can do it. Thanks Hal.
https://reviews.llvm.org/D19544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar added a comment.
In https://reviews.llvm.org/D22463#495211, @vladisld wrote:
> In https://reviews.llvm.org/D22463#494828, @jlebar wrote:
>
> > I think the general feeling is that most of us (myself included) would
> > rather not learn a new tool if there's a simpler >alternative, such as
vladisld added a comment.
In https://reviews.llvm.org/D22463#494828, @jlebar wrote:
> I think the general feeling is that most of us (myself included) would rather
> not learn a new tool if there's a simpler >alternative, such as a vanilla git
> workflow.
Generally you're right, however learn
vladisld added a comment.
In https://reviews.llvm.org/D22463#495211, @vladisld wrote:
> + you get a good integration with Gerrit enabled services like Gerrithub
> (http://gerrithub.io/) and other CI systems (like Jenkins for example)
BTW, Buildbot is also supporting git-repo:
http://docs.buil
beanz added a subscriber: beanz.
beanz added a comment.
One small comment on the CMake code.
Comment at: CMakeLists.txt:210
@@ +209,3 @@
+ message(WARNING "Resetting default rtlib to use platform default")
+ set(CLANG_DEFAULT_RTLIB "")
+endif()
You'll want thi
It could, it fixes a set of issues wrt to modules.
On 25/07/16 22:39, Hans Wennborg wrote:
Should this be merged to 3.9?
On Fri, Jul 22, 2016 at 2:08 PM, Vassil Vassilev via cfe-commits
wrote:
Author: vvassilev
Date: Fri Jul 22 16:08:24 2016
New Revision: 276473
URL: http://llvm.org/viewvc/ll
etienneb added a comment.
In https://reviews.llvm.org/D22725#494167, @Prazek wrote:
> hmm It seems that I mislead you, I suck at C api - memmove source and
> destination can overlap, but std::move can't. So I guess you have to remove
> the memmove support. Sorry.
On windows (MSVC CRT), both f
sbenza added inline comments.
Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:20
@@ +19,3 @@
+
+static void ReplaceMoveWithForward(const UnresolvedLookupExpr *Callee,
+ const TemplateTypeParmType *TypeParmType,
aaron.
etienneb added inline comments.
Comment at: clang-tidy/modernize/UseAlgorithmCheck.cpp:73
@@ +72,3 @@
+ Finder->addMatcher(
+ callExpr(allOf(callee(functionDecl(matchesName("::memcpy"))),
+ argumentCountIs(3)))
It's more efficient to use
jbcoe removed rL LLVM as the repository for this revision.
jbcoe updated this revision to Diff 65423.
jbcoe added a comment.
Fix underline length in docs.
https://reviews.llvm.org/D22513
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyMod
jbcoe marked an inline comment as done.
jbcoe added a comment.
https://reviews.llvm.org/D22513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
manmanren accepted this revision.
manmanren added a comment.
This revision is now accepted and ready to land.
LGTM except one nit.
Manman
Comment at: include/clang/Sema/Sema.h:9595
@@ -9594,1 +9594,3 @@
+
+ VersionTuple getCurContextVersion() const;
Can yo
benlangmuir added a comment.
We need to add this option to the module hash (see getModuleHash - we already
add a bunch of other HSOpts there). Otherwise the pcm could still be rewritten
by a compilation that doesn't use a PCH, and then it would be out of date
because of the timestamp instead o
Author: ahatanak
Date: Mon Jul 25 16:58:19 2016
New Revision: 276696
URL: http://llvm.org/viewvc/llvm-project?rev=276696&view=rev
Log:
[Sema][ObjC] Compute the nullability of a conditional expression based
on the nullabilities of its operands.
This commit is a follow-up to r276076 and enables
com
manmanren added a comment.
In https://reviews.llvm.org/D22773#495403, @benlangmuir wrote:
> We need to add this option to the module hash (see getModuleHash - we already
> add a bunch of other HSOpts there). Otherwise the pcm could still be
> rewritten by a compilation that doesn't use a PCH,
mclow.lists added a comment.
Do we have a test for the problem that this is solving?
https://reviews.llvm.org/D22782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek added a comment.
In https://reviews.llvm.org/D22725#495329, @etienneb wrote:
> In https://reviews.llvm.org/D22725#494167, @Prazek wrote:
>
> > hmm It seems that I mislead you, I suck at C api - memmove source and
> > destination can overlap, but std::move can't. So I guess you have to rem
kkwli0 created this revision.
kkwli0 added reviewers: ABataev, sfantao, carlo.bertolli, arpith-jacob, hfinkel.
kkwli0 added a subscriber: cfe-commits.
The spec mandates that 'a teams construct must be contained within a target
construct'. Currently, this scenario is not diagnosed. This patch is
Author: jvesely
Date: Mon Jul 25 17:36:22 2016
New Revision: 276704
URL: http://llvm.org/viewvc/llvm-project?rev=276704&view=rev
Log:
Make min follow the OCL 1.0 specs
OpenCL 1.0: "Returns y if y < x, otherwise it returns x. If x *and* y
are infinite or NaN, the return values are undefined."
Ope
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: cfe-commits, caomhin.
This patch add support to map pointers through references in class members.
Although a reference does not have storage that a user can a
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: cfe-commits, caomhin.
This patch adds support for the is_device_ptr clause. It expands SEMA to use
the mappable expression logic that can only be tested with
teemperor updated this revision to Diff 65439.
teemperor marked 7 inline comments as done.
teemperor added a comment.
- Fixed the minor problems as pointed out by Artem.
- Now using AnalysisConsumer instead of RecursiveASTVisitor.
- Function names are now confirming to LLVM code-style.
- Renamed D
benlangmuir added a comment.
> the pcm could still be rewritten by a compilation that doesn't use a PCH, and
> then it would be out of date because of the timestamp instead of the
> diagnostic options
>
> "a compilation that doesn't use a PCH", is that a different project? And we
> have two
manmanren added a comment.
In https://reviews.llvm.org/D22773#495524, @benlangmuir wrote:
> > the pcm could still be rewritten by a compilation that doesn't use a PCH,
> > and then it would be out of date because of the timestamp instead of the
> > diagnostic options
>
> >
>
> > "a compilation
Author: cbieneman
Date: Mon Jul 25 18:48:14 2016
New Revision: 276711
URL: http://llvm.org/viewvc/llvm-project?rev=276711&view=rev
Log:
[CMake] Pass DYLD_LIBRARY_PATH as CMake variable instead of as envar
On OS X 10.11 System Integrity Protection prevents the DYLD environment
variables from bein
teemperor updated this revision to Diff 65441.
teemperor added a comment.
- The CloneGroup values in StringMap no longer store a copy of their own key.
https://reviews.llvm.org/D20795
Files:
include/clang/Analysis/CloneDetection.h
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/Anal
teemperor added inline comments.
Comment at: lib/Analysis/CloneDetection.cpp:178
@@ +177,3 @@
+
+ bool VisitFunctionDecl(FunctionDecl *D) {
+// If we found a function, we start the clone search on its body statement.
NoQ wrote:
> You'd probably want to add `O
teemperor marked 3 inline comments as done.
teemperor added a comment.
https://reviews.llvm.org/D20795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
teemperor added a comment.
This patch is no longer needed because the CloneDetector from patch
https://reviews.llvm.org/D20795 no longer uses custom hashing.
https://reviews.llvm.org/D22515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
manmanren updated this revision to Diff 65449.
manmanren added a comment.
Addressing Ben's comments
https://reviews.llvm.org/D22773
Files:
include/clang/Driver/Options.td
include/clang/Lex/HeaderSearchOptions.h
include/clang/Serialization/ASTReader.h
lib/Frontend/CompilerInvocation.cpp
sebpop added a comment.
In https://reviews.llvm.org/D22782#495436, @mclow.lists wrote:
> Do we have a test for the problem that this is solving?
I think we can write a testcase that shows that copy constructors are not
optimized away unless the string constructor is inlined.
This patch fixes
ahatanak updated this revision to Diff 65446.
ahatanak added a comment.
Addressed review comment and made a couple of other changes.
- Move Sema::diagnoseNullPtrToNonnullCast to SemaChecking.cpp.
- In diagnoseNullPtrToNonnullCast, call "Type::isAnyPointerType" instead of
"Type::isPointerType" so
Author: vedantk
Date: Mon Jul 25 19:24:59 2016
New Revision: 276716
URL: http://llvm.org/viewvc/llvm-project?rev=276716&view=rev
Log:
[Coverage] Do not write out coverage mappings with zero entries
After r275121, we stopped mapping regions from system headers. Lambdas
declared in regions belongin
ahatanak created this revision.
ahatanak added a reviewer: doug.gregor.
ahatanak added a subscriber: cfe-commits.
This patch fixes Sema to propagate the nullability of the initializer
expression of a variable declared with auto or __auto_type to the deduced type.
The patch consists of two parts:
mclow.lists updated this revision to Diff 65463.
mclow.lists added a comment.
Updated with Eric's constexpr tests.
Once this is approved, it will be applied twice - once in
``, and once in ``
https://reviews.llvm.org/D21343
Files:
include/experimental/numeric
test/std/experimental/numeric/
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG with a nit
Comment at: lib/Sema/SemaOpenMP.cpp:3360-3366
@@ -3356,5 +3359,9 @@
if (NestingProhibited) {
- SemaRef.Diag(StartLoc, diag::err_omp_prohibited_region
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D22787
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG with some nits
Comment at: include/clang/AST/OpenMPClause.h:4419
@@ -4405,1 +4418,3 @@
+ }
+ /// \brief Build clause with number of variables \a NumVars.
///
---
zlei added a comment.
In https://reviews.llvm.org/D22663#494460, @Hahnfeld wrote:
> With the changes applied and configured with
> `CLANG_DEFAULT_RTLIB=compiler-rt` some tests fail so you may have to adapt
> the idea of `-rtlib=platform` for the tests.
Got it. And I also need to fix those fai
kkwli0 added a comment.
Will add the braces. Thanks.
https://reviews.llvm.org/D22785
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: kli
Date: Mon Jul 25 23:32:50 2016
New Revision: 276726
URL: http://llvm.org/viewvc/llvm-project?rev=276726&view=rev
Log:
[OpenMP] diagnose orphaned teams construct
The OpenMP spec mandates that 'a teams construct must be contained within a
target construct'. Currently, this scenario is
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276726: [OpenMP] diagnose orphaned teams construct (authored
by kli).
Changed prior to commit:
https://reviews.llvm.org/D22785?vs=65430&id=65472#toc
Repository:
rL LLVM
https://reviews.llvm.org/D227
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D21343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
marsupial created this revision.
marsupial added a reviewer: vsk.
marsupial added a subscriber: cfe-commits.
marsupial set the repository for this revision to rL LLVM.
Make integers explicitly unsigned, so the tuple constructor will resolve
properly when but with clang 3.6, 3.7 and gcc 6.1.1 libs
Hahnfeld added a comment.
In https://reviews.llvm.org/D22663#495728, @zlei wrote:
> In https://reviews.llvm.org/D22663#494460, @Hahnfeld wrote:
>
> > With the changes applied and configured with
> > `CLANG_DEFAULT_RTLIB=compiler-rt` some tests fail so you may have to adapt
> > the idea of `-rtl
101 - 147 of 147 matches
Mail list logo
