Author: atanasyan
Date: Tue Jul 19 02:09:48 2016
New Revision: 275949
URL: http://llvm.org/viewvc/llvm-project?rev=275949&view=rev
Log:
[driver][mips] Support MIPS targets in modern Android NDK
Initial patch provided by Duane Sand.
Added:
cfe/trunk/test/Driver/Inputs/basic_android_ndk_tree/
Author: atanasyan
Date: Tue Jul 19 02:23:15 2016
New Revision: 275951
URL: http://llvm.org/viewvc/llvm-project?rev=275951&view=rev
Log:
[driver][mips] Remove empty folder from test inputs
Removed:
cfe/trunk/test/Driver/Inputs/basic_android_tree/lib/gcc/mipsel-linux-android/4.4.3/mips-r6/
__
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D22408
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275958: [clang-rename] add support for overridden functions
(authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D22408?vs=64293&id=64453#toc
Repository:
rL LLVM
https://reviews.
Author: omtcyfz
Date: Tue Jul 19 02:37:43 2016
New Revision: 275958
URL: http://llvm.org/viewvc/llvm-project?rev=275958&view=rev
Log:
[clang-rename] add support for overridden functions
Reviewers: klimek
Differential Revision: https://reviews.llvm.org/D22408
Modified:
clang-tools-extra/trun
omtcyfz updated this revision to Diff 64454.
omtcyfz added a comment.
applied few stylistic fixes
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/ClassNameInFunctionDefenition.cpp
test/cl
baloghadamsoftware added a comment.
Do I use an non-portable way to concatenate strings? "Assuming rhs == *this"
becomes "0*this" for some strange reason. I tested it again with the latest
master branch and all tests are passing like earlier.
Repository:
rL LLVM
https://reviews.llvm.org/D19
DmitryPolukhin added a comment.
Hi Hans, it seems that you've just created release branch for 3.9 and this
patch should go directly to the branch, right? If so could you please commit
this patch for me because I'm working with git-svn and there is no instruction
how to work with release LLVM br
DmitryPolukhin added inline comments.
Comment at: test/CodeGenCXX/dllimport-rtti.cpp:7
@@ -6,3 +6,1 @@
} s;
-// MSVC: [[VF_S:.*]] = private unnamed_addr constant [2 x i8*]
-// MSVC-DAG: @"\01??_SS@@6B@" = unnamed_addr alias i8*, getelementptr inbounds
([2 x i8*], [2 x i8*]* [[VF
a.makarov added a comment.
Richard, thank you very much! =)
https://reviews.llvm.org/D21228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dsanders
Date: Tue Jul 19 05:49:03 2016
New Revision: 275967
URL: http://llvm.org/viewvc/llvm-project?rev=275967&view=rev
Log:
[mips] Correct label prefixes for N32 and N64.
Summary:
N32 and N64 follow the standard ELF conventions (.L) whereas O32 uses its own
($).
This fixes the majorit
filcab added a comment.
Thanks a lot for working on this!
Filipe
https://reviews.llvm.org/D22463
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin added inline comments.
Comment at: docs/Proposals/GitHub.rst:68
@@ +67,3 @@
+ * Collaborate with peers directly, even without access to the Internet
+ * Have multiple trees without multiplying disk space, multiple concurrent
builds
+
vsk wrote:
> What do
rengolin updated this revision to Diff 64467.
rengolin added a comment.
More updates, following recent comments.
https://reviews.llvm.org/D22463
Files:
docs/Proposals/GitHub.rst
Index: docs/Proposals/GitHub.rst
===
--- /dev/null
rengolin updated this revision to Diff 64468.
rengolin added a comment.
Formatting issues (bullet points)
https://reviews.llvm.org/D22463
Files:
docs/Proposals/GitHub.rst
Index: docs/Proposals/GitHub.rst
===
--- /dev/null
+++ do
rengolin updated this revision to Diff 64469.
https://reviews.llvm.org/D22463
Files:
docs/Proposals/GitHub.rst
Index: docs/Proposals/GitHub.rst
===
--- /dev/null
+++ docs/Proposals/GitHub.rst
@@ -0,0 +1,254 @@
+===
LokiAstari created this revision.
LokiAstari added reviewers: djasper, klimek.
LokiAstari added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Access Modifiers (public/protected/private) causes standard indent.
```
class MyClass
{
int value1;// standard indent.
publ
Author: dpolukhin
Date: Tue Jul 19 06:29:16 2016
New Revision: 275970
URL: http://llvm.org/viewvc/llvm-project?rev=275970&view=rev
Log:
Deprecated (legacy) string literal conversion to 'char *' causes strange
overloading resolution
It's a patch for PR28050. Seems like overloading resolution wipe
DmitryPolukhin added a subscriber: DmitryPolukhin.
DmitryPolukhin closed this revision.
DmitryPolukhin added a comment.
Committed as https://reviews.llvm.org/rL275970
https://reviews.llvm.org/D21228
___
cfe-commits mailing list
cfe-commits@lists.llv
alexfh added a comment.
Thanks for addressing the comments. The code looks better now. My main concern
at this point is that the name and the location of the check: "misc" is a place
for the stuff we can't find a better place for, but here I guess we clearly
want a separate module and a subdire
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D22381
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Comment at: test/clang-tidy/modernize-loop-convert-extra.cpp:1070
@@ +1069,3 @@
+ // CHECK-FIXES: for(unsigned char value : v)
+ // CHECK-FIXES-NOT: unsigned char value =
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:21
@@ +20,3 @@
+llvm::Optional>
+getHasAnyName(const std::vector &Names) {
+ llvm::Optional> HasNameMatcher;
Looking at `VariadicFunction`, it appears that it already works
Anastasia closed this revision.
Anastasia added a comment.
r269305
https://reviews.llvm.org/D19780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
No functional changes in this patch. It is a refactoring (pull out a
structure representing the symbol being queried).
This is a preparing step for inserting missing namespace qualifiers to all
Author: dpolukhin
Date: Tue Jul 19 08:35:15 2016
New Revision: 275974
URL: http://llvm.org/viewvc/llvm-project?rev=275974&view=rev
Log:
Fix for failing bot sanitizer-x86_64-linux-fast after r275970
More info
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/14774/steps/check-c
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a nit.
Comment at: clang-tidy/cppcoreguidelines/SlicingCheck.cpp:86
@@ +85,3 @@
+ "slicing object from type %0 to %1 discards override %2")
+ << &De
joelkevinjones added a comment.
Ping. This change needs to be made once https://reviews.llvm.org/D16213 goes in.
https://reviews.llvm.org/D16538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
alexfh added a comment.
A few more nits.
Comment at: clang-tidy/performance/InefficientStringConcatenationCheck.cpp:50
@@ +49,3 @@
+ hasOverloadedOperatorName("="),
+ hasArgument(0, allOf(declRefExpr(BasicStringType),
+ declRefExpr(hasDeclarat
alexfh added a comment.
Please mark all addressed comments "Done".
Comment at: test/clang-tidy/readability-misleading-indentation.cpp:15
@@ +14,3 @@
+ foo2(); // comment
+ // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: wrong indentation,
'else' belongs to 'if(con
rnk added inline comments.
Comment at: test/CodeGenCXX/dllimport-rtti.cpp:7
@@ -6,3 +6,1 @@
} s;
-// MSVC: [[VF_S:.*]] = private unnamed_addr constant [2 x i8*]
-// MSVC-DAG: @"\01??_SS@@6B@" = unnamed_addr alias i8*, getelementptr inbounds
([2 x i8*], [2 x i8*]* [[VF_S]], i32 0
Author: sylvestre
Date: Tue Jul 19 09:00:57 2016
New Revision: 275975
URL: http://llvm.org/viewvc/llvm-project?rev=275975&view=rev
Log:
Add support of the latest Ubuntu (Yakkety Yak - 16.10)
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
Modified: cfe/trunk/lib/Driver/ToolChains.cpp
URL:
ht
teemperor created this revision.
teemperor added reviewers: v.g.vassilev, zaks.anna, NoQ.
teemperor added a subscriber: cfe-commits.
So far the CloneDetector only respected the class of each statement when
searching for clones. This means that nodes that differentiate in any other
attribute are
teemperor planned changes to this revision.
teemperor added a comment.
- Expand test suite to test newly added code.
https://reviews.llvm.org/D22514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
jbcoe retitled this revision from "clang-tidy check:
misc-deprecated-special-member-functions" to "clang-tidy check:
cppcoreguidelines-rule-of-five-and-zero".
jbcoe updated the summary for this revision.
jbcoe updated this revision to Diff 64490.
jbcoe added a comment.
Herald added a subscriber:
alexfh added a comment.
Please update the tests according to the comment
(https://reviews.llvm.org/D17990?id=62701#inline-186216).
Comment at: docs/clang-tidy/checks/modernize-deprecated-headers.rst:43
@@ -44,2 +42,3 @@
headers deprecated before C++11, otherwise -- every heade
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D21472
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/DeprecatedHeadersCheck.cpp:39
@@ -37,2 +38,3 @@
llvm::StringMap CStyledHeaderToCxx;
+ std::set DeleteHeader;
};
nit: DeleteHeaders
> > I think we could emulate any pre-commit hook we like via GitHub
> > WebHooks by having two repositories: llvm and llvm-staging (say).
> >
> > People push to llvm-staging, which notifies some LLVM server we own.
> > That does basic sanity checks and pushes to llvm proper if passed.
>
> I think
Anastasia added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:2399
@@ +2398,3 @@
+ // therefore no need to be translated.
+ if (getLangOpts().OpenCL && ASTTy->isSamplerT())
+return;
Could we lift this check right to the beginning of the function
Author: hokein
Date: Tue Jul 19 09:49:04 2016
New Revision: 275980
URL: http://llvm.org/viewvc/llvm-project?rev=275980&view=rev
Log:
[include-fixer] A refactoring of IncludeFixerContext.
Summary:
No functional changes in this patch. It is a refactoring (pull out a
structure representing the symbo
djasper added a comment.
Before we continue with the actual code review and brainstorming how we could
actually call this option, can you read through
http://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options
and provide feedback about why this option qualifies?
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275980: [include-fixer] A refactoring of
IncludeFixerContext. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D22510?vs=64481&id=64502#toc
Repository:
rL LLVM
https://reviews
sfantao created this revision.
sfantao added reviewers: tra, rsmith.
sfantao added subscribers: cfe-commits, rsmith.
This patch aims at removing redundancy in the way include paths for the regular
and offloading toolchains are appended to the arguments list in the clang tool.
This was suggested
bcraig updated the summary for this revision.
bcraig updated this revision to Diff 64504.
bcraig added a comment.
Added weak_ptr benchmark, as that's where the cost shifted.
https://reviews.llvm.org/D22470
Files:
benchmarks/shared_ptr_create_destroy.cpp
benchmarks/shared_ptr_inc_dec_ref.cpp
Hi Richard,
I posted https://reviews.llvm.org/D22518, is this more or less what you intended?
Thanks,
Samuel
- Original message -From: Richard Smith Sent by: meta...@gmail.comTo: Samuel F Antao/Watson/IBM@IBMUSCc: cfe-commits Subject: Re: r275931 - Append clang system include path for
On 7/19/16 8:55 AM, Robinson, Paul wrote:
I think we could emulate any pre-commit hook we like via GitHub
WebHooks by having two repositories: llvm and llvm-staging (say).
People push to llvm-staging, which notifies some LLVM server we own.
That does basic sanity checks and pushes to llvm prop
Author: chapuni
Date: Tue Jul 19 10:33:14 2016
New Revision: 275985
URL: http://llvm.org/viewvc/llvm-project?rev=275985&view=rev
Log:
ClangRenameTests: Update libdeps. r275958 introduced clangASTMatchers.
Modified:
clang-tools-extra/trunk/unittests/clang-rename/CMakeLists.txt
Modified: clang
Author: chapuni
Date: Tue Jul 19 10:53:11 2016
New Revision: 275986
URL: http://llvm.org/viewvc/llvm-project?rev=275986&view=rev
Log:
clangRename: Update libdeps to add clangASTMatchers.
Note, ClangRenameTests is linking USRFindingAction.cpp directly.
Modified:
clang-tools-extra/trunk/clang-
ashi1 updated this revision to Diff 64513.
ashi1 marked an inline comment as done.
ashi1 added a comment.
Revised based on Anastasia's comments. Now using new function name
appendOpenCLVersionMD(
Repository:
rL LLVM
https://reviews.llvm.org/D22424
Files:
lib/CodeGen/TargetInfo.cpp
test/
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D22518
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst. See pre-4.0 branch versions
as example.
Comment at:
docs/clang-tidy/checks/cppcoreguidelines-rule-of-five-and-zero.rst:15
@@ +14,3 @@
+
+Note
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275993: cppcoreguidelines-pro-bounds-constant-array-index:
ignore implicit constructor (authored by mgehre).
Changed prior to commit:
https://reviews.llvm.org/D22381?vs=64035&id=64515#toc
Repository:
Author: mgehre
Date: Tue Jul 19 12:02:54 2016
New Revision: 275993
URL: http://llvm.org/viewvc/llvm-project?rev=275993&view=rev
Log:
cppcoreguidelines-pro-bounds-constant-array-index: ignore implicit constructor
Summary:
The code
struct A {
int x[3];
};
gets an compiler-generated copy c
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst. See pre-4.0 branch versions
as example.
Comment at: clang-tidy/misc/EnumMisuseCheck.cpp:116
@@ +115,3 @@
+}
+// if there is only one not power-
eli.friedman added a comment.
I don't think we need to use x86-specific operations for sitofp-like
conversions; the C cast is equivalent given that a 32 or 64-bit integer is
always in within the range of a 32-bit float.
Repository:
rL LLVM
https://reviews.llvm.org/D22105
Author: emaste
Date: Tue Jul 19 12:15:50 2016
New Revision: 275996
URL: http://llvm.org/viewvc/llvm-project?rev=275996&view=rev
Log:
libunwind: Use conventional DWARF capitalization in comments and errors
Modified:
libunwind/trunk/include/libunwind.h
libunwind/trunk/include/mach-o/compact
etienneb added a comment.
drive-by, some comments.
Thanks for the check
Comment at: clang-tidy/misc/EnumMisuseCheck.cpp:20
@@ +19,3 @@
+// Return the number of EnumConstantDecls in an EnumDecl.
+static int enumLen(const EnumDecl *EnumDec) {
+ int Counter = 0;
h
apaprocki updated this revision to Diff 64518.
apaprocki added a comment.
Increased context and removed accidental inclusion of Solaris change.
https://reviews.llvm.org/D18360
Files:
lib/Basic/Targets.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
lib/Driv
RKSimon added a comment.
In https://reviews.llvm.org/D22105#488513, @eli.friedman wrote:
> I don't think we need to use x86-specific operations for sitofp-like
> conversions; the C cast is equivalent given that a 32 or 64-bit integer is
> always in within the range of a 32-bit float.
I think
Author: emaste
Date: Tue Jul 19 12:28:38 2016
New Revision: 275997
URL: http://llvm.org/viewvc/llvm-project?rev=275997&view=rev
Log:
libunwind: sync some coments with NetBSD's version
NetBSD's system unwinder is a modified version of LLVM's libunwind.
Slightly reduce diffs by updating comments to
eli.friedman added a comment.
The x86-specific operation is affected by the rounding mode... but so is a C
cast. This is specified by Annex F in the C standard.
Of course, you're going to end up with undefined behavior if you actually
modify the rounding mode because LLVM and clang don't suppo
majnemer accepted this revision.
majnemer added a reviewer: majnemer.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D18360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
mmasten added a comment.
In the process of writing test cases, I noticed that a loop with a call to
llvm.log.f32 was not getting vectorized due to cost modeling. When forcing
vectorization on the loop and throwing -fveclib=SVML, the loop was vectorized
with a widened intrinsic instead of the sv
Alexander_Droste marked 2 inline comments as done.
Alexander_Droste added a comment.
Thanks for looking over this once more. I'll set up an extra MPI folder and
rename the check.
One comment inline.
Comment at: clang-tidy/misc/MpiTypeMismatchCheck.cpp:218
@@ +217,3 @@
+
+ Str
EricWF updated this revision to Diff 64525.
EricWF added a comment.
Add test for PR28469 and remove __tree from the UBSAN blacklist.
https://reviews.llvm.org/D20786
Files:
include/__config
include/__tree
test/libcxx/containers/associative/tree_balance_after_insert.pass.cpp
test/libcxx/c
Author: ericwf
Date: Tue Jul 19 12:56:20 2016
New Revision: 276003
URL: http://llvm.org/viewvc/llvm-project?rev=276003&view=rev
Log:
Fix undefined behavior in __tree
Summary:
This patch attempts to fix the undefined behavior in __tree by changing the
node pointer types used throughout. The point
spatel added a subscriber: davide.
spatel added a comment.
In https://reviews.llvm.org/D19544#488589, @mmasten wrote:
> In the process of writing test cases, I noticed that a loop with a call to
> llvm.log.f32 was not getting vectorized due to cost modeling. When forcing
> vectorization on the
ashi1 created this revision.
ashi1 added reviewers: yaxunl, Anastasia.
ashi1 added a subscriber: cfe-commits.
ashi1 set the repository for this revision to rL LLVM.
Allows AMDGCN target to generate images (such as %opencl.image2d_t) in constant
address space.
Images will still be generated in glo
arsenm added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:6856
@@ +6855,3 @@
+ }
+ else if (StrTy->getNumElements() == 1) {
+// Coerce single element structs to its element.
No else after return
Comment at: test/CodeGenOpenCL/amd
yaxunl updated this revision to Diff 64529.
yaxunl marked 7 inline comments as done.
yaxunl added a comment.
Revised by Anastasia's comments.
https://reviews.llvm.org/D21567
Files:
include/clang/AST/OperationKinds.def
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticS
yaxunl added inline comments.
Comment at: lib/Sema/SemaInit.cpp:6917-6929
@@ -6915,4 +6916,15 @@
<< SourceType;
- } else if (Entity.getKind() != InitializedEntity::EK_Variable) {
-llvm_unreachable("Invalid EntityKind!");
+ break;
+} else
yaxunl added inline comments.
Comment at: test/CodeGenOpenCL/opencl_types.cl:1
@@ -1,1 +1,2 @@
-// RUN: %clang_cc1 %s -emit-llvm -o - -O0 | FileCheck %s
+// RUN: %clang_cc1 %s -emit-llvm -o - -O0 | FileCheck %s
--check-prefix=CHECK-NORMAL
+// RUN: %clang_cc1 %s -triple "amdgcn--a
RKSimon added a comment.
In https://reviews.llvm.org/D22105#488566, @eli.friedman wrote:
> The x86-specific operation is affected by the rounding mode... but so is a C
> cast. This is specified by Annex F in the C standard.
>
> Of course, you're going to end up with undefined behavior if you ac
bruno created this revision.
bruno added a reviewer: zaks.anna.
bruno added a subscriber: cfe-commits.
For memset (and others) we can get diagnostics like:
struct stat { int x; };
void foo(struct stat *stamps) {
memset(stamps, 0, sizeof(stamps));
}
t.c:7:28: warning: 'memset' call op
RKSimon updated this revision to Diff 64534.
RKSimon added a comment.
Removed sitofp conversion changes
Repository:
rL LLVM
https://reviews.llvm.org/D22105
Files:
include/clang/Basic/BuiltinsX86.def
lib/Headers/avxintrin.h
lib/Headers/emmintrin.h
lib/Headers/xmmintrin.h
test/CodeGe
ashi1 updated this revision to Diff 64538.
ashi1 marked an inline comment as done.
ashi1 added a comment.
Revised based on Sam's comments. Also updated test file to changes with using
triple spir-unknown-unknown.
Repository:
rL LLVM
https://reviews.llvm.org/D22523
Files:
lib/CodeGen/CGOpe
Author: arsenm
Date: Tue Jul 19 14:02:01 2016
New Revision: 276009
URL: http://llvm.org/viewvc/llvm-project?rev=276009&view=rev
Log:
amdgpu: Use right builtn for rsq
The r600 path has never actually worked sinced double is not implemented
there.
Modified:
libclc/trunk/amdgpu/lib/math/sqrt.cl
eli.friedman accepted this revision.
eli.friedman added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D22105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D22523
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
Unit test ImportVAArgExpr fails on Windows. The source file:
void declToImport(__builtin_va_list list, ...) {
(void)__builtin_va_arg(list, int);
}
When compiled on Windows it produces AST:
TranslationUnitDecl 0x638f150 <>
`-FunctionDecl 0x638f780 line:1:6 declToImport
'void (__builtin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276010: [OpenCL] Fixes bug of missing OCL version metadata
on the AMDGCN target (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D22424?vs=64513&id=64545#toc
Repository:
rL LLV
Author: yaxunl
Date: Tue Jul 19 14:39:45 2016
New Revision: 276010
URL: http://llvm.org/viewvc/llvm-project?rev=276010&view=rev
Log:
[OpenCL] Fixes bug of missing OCL version metadata on the AMDGCN target
Added the opencl.ocl.version metadata to be emitted with amdgcn. Created a
static function
Eugene.Zelenko added a comment.
Will be good idea to introduce similar check for C++98/03.
Repository:
rL LLVM
https://reviews.llvm.org/D22513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
rsmith created this revision.
rsmith added reviewers: EricWF, mclow.lists.
rsmith added a subscriber: cfe-commits.
rsmith set the repository for this revision to rL LLVM.
This fixes a bug where throwing an exception of type nullptr_t and catching it
as a pointer-to-member would not guarantee to p
rsmith added inline comments.
Comment at: src/CMakeLists.txt:94
@@ -93,3 +93,3 @@
PROPERTIES
-COMPILE_FLAGS "${LIBCXXABI_COMPILE_FLAGS}"
+COMPILE_FLAGS "${LIBCXXABI_COMPILE_FLAGS} -fno-modules"
)
Err, ignore this :)
Repository:
rL LLVM
https://r
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D22528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Author: majnemer
Date: Tue Jul 19 14:59:24 2016
New Revision: 276014
URL: http://llvm.org/viewvc/llvm-project?rev=276014&view=rev
Log:
Let FuncAttrs infer the 'returned' argument attribute
This reverts commit r275756.
Modified:
cfe/trunk/test/CodeGen/ppc64-struct-onevect.c
cfe/trunk/test
ahatanak updated this revision to Diff 64551.
ahatanak added a comment.
Address review comments.
- Rename function to computeConditionalNullability.
- Rewrite the function to compute the nullability of both normal and binary
conditional expressions.
- Add more test cases.
https://reviews.llvm.
Author: rsmith
Date: Tue Jul 19 15:19:37 2016
New Revision: 276016
URL: http://llvm.org/viewvc/llvm-project?rev=276016&view=rev
Log:
[libcxxabi] When catching an exception of type nullptr_t with a handler of
pointer-to-member type, produce a null value of the right type.
This fixes a bug where th
rsmith closed this revision.
rsmith added a comment.
Committed as r276016.
Repository:
rL LLVM
https://reviews.llvm.org/D22528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Tue Jul 19 15:21:18 2016
New Revision: 276020
URL: http://llvm.org/viewvc/llvm-project?rev=276020&view=rev
Log:
[SemaObjC] Improve ObjCDictionaryLiteral and ObjCArryLiteral diagnostics
Sema actions on ObjCDictionaryLiteral and ObjCArryLiteral are currently
done as a side-effec
bruno closed this revision.
bruno added a comment.
Thanks Manman, Committed r276020
https://reviews.llvm.org/D22183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak updated this revision to Diff 64557.
ahatanak added a comment.
Remove the check "if (LHSKind == RHSKind)" in computeConditionalNullability as
it's not needed.
https://reviews.llvm.org/D22392
Files:
lib/Sema/SemaExpr.cpp
test/Sema/nullability.c
test/SemaCXX/nullability.cpp
Index
Author: rsmith
Date: Tue Jul 19 15:35:09 2016
New Revision: 276022
URL: http://llvm.org/viewvc/llvm-project?rev=276022&view=rev
Log:
Attempt to bring peace to -Werror buildbots.
Modified:
libcxxabi/trunk/test/catch_reference_nullptr.pass.cpp
Modified: libcxxabi/trunk/test/catch_reference_nul
ahatanak added a comment.
ping
https://reviews.llvm.org/D21453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek added a subscriber: Prazek.
Comment at: clang-tidy/cppcoreguidelines/RuleOfFiveAndZeroCheck.cpp:73-77
@@ +72,7 @@
+
+ checkRuleOfFiveViolation(Result, "dtor", "destructor");
+ checkRuleOfFiveViolation(Result, "copy-ctor", "copy constructor");
+ checkRuleOfFiveViolation(R
mmasten updated this revision to Diff 64571.
https://reviews.llvm.org/D19544
Files:
include/llvm/Analysis/TargetLibraryInfo.h
lib/Analysis/TargetLibraryInfo.cpp
test/Transforms/LoopVectorize/X86/svml-calls.ll
Index: lib/Analysis/TargetLibraryInfo.cpp
===
erik.pilkington created this revision.
erik.pilkington added reviewers: rsmith, manmanren.
erik.pilkington added a subscriber: cfe-commits.
The following valid code crashes Clang in CodeGen:
```
void other_test() {
switch(0) {
case 0:
do {
default:;
} while(0);
}
}
```
The proble
EricWF created this revision.
EricWF added reviewers: mclow.lists, compnerd.
EricWF added a subscriber: cfe-commits.
_Unwind_Exception is required to be double word aligned. Currently the struct
is under aligned.
https://reviews.llvm.org/D22543
Files:
include/unwind.h
test/alignment.pass.cp
1 - 100 of 143 matches
Mail list logo
