Support setting default value for -rtlib at build time

2016-07-17 Thread Lei Zhang via cfe-commits
Hi, This patch introduces a new cmake variable: CLANG_DEFAULT_RTLIB, thru which we can specify a default value for -rtlib (libgcc or compiler-rt) at build time, just like how we set the default C++ stdlib thru CLANG_DEFAULT_CXX_STDLIB. With these two options, we can configure clang to build binar

Re: r275653 - Reimplement ExternalSemaSource delegation in terms of

2016-07-17 Thread Reid Kleckner via cfe-commits
Breaks the VS 2013 build, even though we tried to check ahead of time: https://llvm.org/bugs/show_bug.cgi?id=28589 http://lab.llvm.org:8011/builders/clang-x86-win2008-selfhost/builds/9110 On Fri, Jul 15, 2016 at 5:35 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author:

r275727 - PR28589: attempt to work around MSVC rejects-valid.

2016-07-17 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Jul 17 14:24:51 2016 New Revision: 275727 URL: http://llvm.org/viewvc/llvm-project?rev=275727&view=rev Log: PR28589: attempt to work around MSVC rejects-valid. Modified: cfe/trunk/lib/Frontend/ChainedIncludesSource.cpp Modified: cfe/trunk/lib/Frontend/ChainedIncludes

r275730 - Attempt to work around MSVC rejects-valid, round 2.

2016-07-17 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Jul 17 15:00:59 2016 New Revision: 275730 URL: http://llvm.org/viewvc/llvm-project?rev=275730&view=rev Log: Attempt to work around MSVC rejects-valid, round 2. Modified: cfe/trunk/lib/Frontend/ChainedIncludesSource.cpp Modified: cfe/trunk/lib/Frontend/ChainedIncludes

Re: [libcxx] r275114 - Don't compute modulus of hash if it is smaller than the bucket count.

2016-07-17 Thread Eric Fiselier via cfe-commits
Hi Duncan, It's possibly expected. It depends on what operation it's performing. I expected a bit of a performance drop in some cases but I have a plan to fix those. Do you have a link to LNT? On Wed, Jul 13, 2016 at 6:41 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > Hmm. I impli

[libcxx] r275732 - Fix std::experimental::optional tests. Patch from Casey Carter.

2016-07-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 17 15:32:30 2016 New Revision: 275732 URL: http://llvm.org/viewvc/llvm-project?rev=275732&view=rev Log: Fix std::experimental::optional tests. Patch from Casey Carter. Modified: libcxx/trunk/test/std/experimental/optional/optional.object/optional.object.assign/em

Re: [PATCH] D22073: libc++: test lock-free atomic alignment

2016-07-17 Thread Eric Fiselier via cfe-commits
EricWF added a comment. In https://reviews.llvm.org/D22073#482120, @jfb wrote: > In https://reviews.llvm.org/D22073#481402, @EricWF wrote: > > > - The test should be moved to `test/libcxx/atomics/atomics.align` since > > it's libc++ specific. > > > Done. > > > - Please give the anonymous struct

Re: [libcxx] r275114 - Don't compute modulus of hash if it is smaller than the bucket count.

2016-07-17 Thread Arthur O'Dwyer via cfe-commits
Given that this patch is basically Chandler's talk from CppCon 2015 ( https://www.youtube.com/watch?v=nXaxk27zwlk), I'm surprised that the commit message isn't explicitly mentioning that; and surprised that Chandler himself isn't weighing in on either the "this is a good idea" or "this is a bad ide

Re: [libcxx] r275114 - Don't compute modulus of hash if it is smaller than the bucket count.

2016-07-17 Thread Eric Fiselier via cfe-commits
On Sun, Jul 17, 2016 at 2:54 PM, Arthur O'Dwyer wrote: > Given that this patch is basically Chandler's talk from CppCon 2015 ( > https://www.youtube.com/watch?v=nXaxk27zwlk), I'm surprised that the > commit message isn't explicitly mentioning that; and surprised that > Chandler himself isn't weig

[libcxx] r275734 - Check for unconstrained hash equality before constrained hash equality.

2016-07-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 17 17:04:57 2016 New Revision: 275734 URL: http://llvm.org/viewvc/llvm-project?rev=275734&view=rev Log: Check for unconstrained hash equality before constrained hash equality. This patch implements a simple optimization in __hash_table::find. When iterating the found

Re: [libcxx] r275114 - Don't compute modulus of hash if it is smaller than the bucket count.

2016-07-17 Thread Eric Fiselier via cfe-commits
FYI, I recommitted the previously removed optimization in r275734. I believe it should fix the LNT performance regression. The benchmarks I used to test this change can be found in D22240 (https://reviews.llvm.org/D22240#3266819f ) /Eric On Sun, Jul 17, 2016 at 3:09 PM, Eric Fiselier wrote: >

Re: r275653 - Reimplement ExternalSemaSource delegation in terms of

2016-07-17 Thread Richard Smith via cfe-commits
Sigh. Fixed in r275730. On 17 Jul 2016 10:54 a.m., "Reid Kleckner via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Breaks the VS 2013 build, even though we tried to check ahead of time: > https://llvm.org/bugs/show_bug.cgi?id=28589 > http://lab.llvm.org:8011/builders/clang-x86-win2008-self

Re: [PATCH] D22053: [Sema] Fix a C++1z bug where initializer for static constexpr data member was not instantiated

2016-07-17 Thread Erik Pilkington via cfe-commits
erik.pilkington added inline comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3861 @@ -3860,3 +3860,3 @@ // static data members until a definition of the variable is needed. We need - // it right away if the type contains 'auto'. + // it right away if the type c

r275735 - CodeGen: whitespace cleanup, StringRef usage in ObjC EH type construction

2016-07-17 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Jul 17 17:27:38 2016 New Revision: 275735 URL: http://llvm.org/viewvc/llvm-project?rev=275735&view=rev Log: CodeGen: whitespace cleanup, StringRef usage in ObjC EH type construction Clean up some formatting issues and use a bit more StringRef based operations instead of

r275736 - CodeGen: whitespace, formatting cleanups, NFC

2016-07-17 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Jul 17 17:27:41 2016 New Revision: 275736 URL: http://llvm.org/viewvc/llvm-project?rev=275736&view=rev Log: CodeGen: whitespace, formatting cleanups, NFC Format some code which was oddly formatted. Use a bit of auto to make the code more legible. NFC. Modified: c

r275737 - CodeGen: honour dllstorage on ObjC types

2016-07-17 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Jul 17 17:27:44 2016 New Revision: 275737 URL: http://llvm.org/viewvc/llvm-project?rev=275737&view=rev Log: CodeGen: honour dllstorage on ObjC types Add support for ObjC types to respect the DLLImport/DLLExport storage annotations. This only effects COFF output. This

r275738 - test: add missing triple to test

2016-07-17 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Jul 17 17:54:42 2016 New Revision: 275738 URL: http://llvm.org/viewvc/llvm-project?rev=275738&view=rev Log: test: add missing triple to test The test was relying on the default triple which may not be correct. Explicitly provide it a triple. Should repair the windows

[libcxx] r275745 - Implement C++17 tuple bits. Including apply and make_from_tuple.

2016-07-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 17 19:35:56 2016 New Revision: 275745 URL: http://llvm.org/viewvc/llvm-project?rev=275745&view=rev Log: Implement C++17 tuple bits. Including apply and make_from_tuple. This patch upgrades to be C++17 compliant by implementing: * tuple_size_v: This was forgotten whe

Re: [PATCH] D21329: Rename and rework `_LIBCPP_TRIVIAL_PAIR_COPY_CTOR`. Move FreeBSD configuration in-tree.

2016-07-17 Thread Eric Fiselier via cfe-commits
EricWF added a comment. I'm committing this today, meaning it will make it into 3.9, so don't forget to remove your upstream patches before the release :-) In https://reviews.llvm.org/D21329#476455, @dim wrote: > In https://reviews.llvm.org/D21329#475105, @theraven wrote: > > > Looks fine to me

[libcxx] r275748 - Suppress warning in make_from_tuple tests.

2016-07-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 17 20:52:46 2016 New Revision: 275748 URL: http://llvm.org/viewvc/llvm-project?rev=275748&view=rev Log: Suppress warning in make_from_tuple tests. Modified: libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.apply/make_from_tuple.pass.cpp Modified: libcxx/

[libcxx] r275749 - Rename and rework `_LIBCPP_TRIVIAL_PAIR_COPY_CTOR`. Move FreeBSD configuration in-tree.

2016-07-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 17 20:58:37 2016 New Revision: 275749 URL: http://llvm.org/viewvc/llvm-project?rev=275749&view=rev Log: Rename and rework `_LIBCPP_TRIVIAL_PAIR_COPY_CTOR`. Move FreeBSD configuration in-tree. This patch does the following: * It renames `_LIBCPP_TRIVIAL_PAIR_COPY_CTO

Re: [PATCH] D21329: Rename and rework `_LIBCPP_TRIVIAL_PAIR_COPY_CTOR`. Move FreeBSD configuration in-tree.

2016-07-17 Thread Eric Fiselier via cfe-commits
EricWF closed this revision. EricWF added a comment. r275749. https://reviews.llvm.org/D21329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r275750 - Upgrade arcconfig to use https

2016-07-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 17 21:02:49 2016 New Revision: 275750 URL: http://llvm.org/viewvc/llvm-project?rev=275750&view=rev Log: Upgrade arcconfig to use https Modified: libcxx/trunk/.arcconfig Modified: libcxx/trunk/.arcconfig URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/.arcc

[libcxx] r275751 - Add includes in test. Patch from s...@microsoft.com

2016-07-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 17 21:05:31 2016 New Revision: 275751 URL: http://llvm.org/viewvc/llvm-project?rev=275751&view=rev Log: Add includes in test. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/containers/container.adaptors/priority.queue/types.pass.cpp Modified: lib

[libcxxabi] r275752 - Fix arc config to use https

2016-07-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 17 21:05:52 2016 New Revision: 275752 URL: http://llvm.org/viewvc/llvm-project?rev=275752&view=rev Log: Fix arc config to use https Modified: libcxxabi/trunk/.arcconfig Modified: libcxxabi/trunk/.arcconfig URL: http://llvm.org/viewvc/llvm-project/libcxxabi/trunk

Re: [PATCH] D22012: [libcxx] [tests] Add missing includes, especially , to priority.queue/types.pass.cpp.

2016-07-17 Thread Eric Fiselier via cfe-commits
EricWF closed this revision. EricWF added a comment. r275751. https://reviews.llvm.org/D22012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r275753 - Prevent failures by marking Clock::is_steady tests as UNSUPPORTED: asan.

2016-07-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 17 21:29:33 2016 New Revision: 275753 URL: http://llvm.org/viewvc/llvm-project?rev=275753&view=rev Log: Prevent failures by marking Clock::is_steady tests as UNSUPPORTED: asan. Modified: libcxx/trunk/test/std/utilities/time/time.clock/time.clock.hires/consistency

Re: [PATCH] D22417: [OpenMP] update test cases for -std=c++11 compile

2016-07-17 Thread Kelvin Li via cfe-commits
kkwli0 added a subscriber: cfe-commits. kkwli0 added a comment. Add cfe-commits https://reviews.llvm.org/D22417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22265: [libcxx][filesystem] Remove setgid from parent before testing permissions

2016-07-17 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Do you need me to commit this? https://reviews.llvm.org/D22265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[libcxx] r275754 - Add checkpoint diagnostics to help diagnose buildbot failures.

2016-07-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 17 22:00:09 2016 New Revision: 275754 URL: http://llvm.org/viewvc/llvm-project?rev=275754&view=rev Log: Add checkpoint diagnostics to help diagnose buildbot failures. Modified: libcxx/trunk/test/std/localization/locale.categories/category.ctype/locale.ctype.bynam

Re: [PATCH] D22417: [OpenMP] update test cases for -std=c++11 compile

2016-07-17 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D22417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D22426: Fix automatic detection of ARM MSVC toolset in clang.exe

2016-07-17 Thread Saleem Abdulrasool via cfe-commits
compnerd added a comment. I was worried about the OOM situation with the 32-bit toolchain. As long as there is a way to get to the 64-bit version, I don't think that it matters too much that we default to x86. It sounds like even then, its not been a concern? https://reviews.llvm.org/D22426

r275756 - Revert r275678, "Revert "Revert r275027 - Let FuncAttrs infer the 'returned' argument attribute""

2016-07-17 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Sun Jul 17 22:23:25 2016 New Revision: 275756 URL: http://llvm.org/viewvc/llvm-project?rev=275756&view=rev Log: Revert r275678, "Revert "Revert r275027 - Let FuncAttrs infer the 'returned' argument attribute"" This reverts also r275029, "Update Clang tests after adding infe

Re: [PATCH] D22426: Fix automatic detection of ARM MSVC toolset in clang.exe

2016-07-17 Thread David Majnemer via cfe-commits
majnemer added a comment. In https://reviews.llvm.org/D22426#486605, @compnerd wrote: > I was worried about the OOM situation with the 32-bit toolchain. As long as > there is a way to get to the 64-bit version, I don't think that it matters > too much that we default to x86. It sounds like ev

[libcxx] r275757 - Improve ABI tests for std::pair.

2016-07-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 17 23:48:37 2016 New Revision: 275757 URL: http://llvm.org/viewvc/llvm-project?rev=275757&view=rev Log: Improve ABI tests for std::pair. Added: libcxx/trunk/test/libcxx/utilities/utility/pairs/pairs.pair/non_trivial_copy_move_ABI.pass.cpp libcxx/trunk/test/l

[PATCH] D22452: [libcxx] Fix last_write_time tests for filesystems that don't support negative and very large times.

2016-07-17 Thread Eric Fiselier via cfe-commits
EricWF created this revision. EricWF added a subscriber: cfe-commits. https://reviews.llvm.org/D22452 Files: test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp Index: test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pa

[libcxx] r275759 - Rework libatomic handling in CMake and LIT.

2016-07-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Jul 18 01:01:50 2016 New Revision: 275759 URL: http://llvm.org/viewvc/llvm-project?rev=275759&view=rev Log: Rework libatomic handling in CMake and LIT. This patch updates the way libc++ handles checking for libatomic, in part to prepare for https://reviews.llvm.org/D22073

Re: [PATCH] D22073: libc++: test lock-free atomic alignment

2016-07-17 Thread Eric Fiselier via cfe-commits
EricWF added a comment. OK, IMO the way to handle this test is to have it manually link `-latomic`. This can be done by renaming the test to `.sh.cpp` and adding the following lines: // REQUIRES: libatomic // RUN: %build -latomic // RUN: %run After that this LGTM. https://reviews.llvm.

Re: [PATCH] D22265: [libcxx][filesystem] Remove setgid from parent before testing permissions

2016-07-17 Thread Jonas Hahnfeld via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL275760: [libcxx][filesystem] Remove setgid from parent before testing permissions (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D22265?vs=63672&id=64275#toc Repository: rL

[libcxx] r275760 - [libcxx][filesystem] Remove setgid from parent before testing permissions

2016-07-17 Thread Jonas Hahnfeld via cfe-commits
Author: hahnfeld Date: Mon Jul 18 01:06:50 2016 New Revision: 275760 URL: http://llvm.org/viewvc/llvm-project?rev=275760&view=rev Log: [libcxx][filesystem] Remove setgid from parent before testing permissions man page for mkdir says: "If the parent directory has the set-group-ID bit set, then so

[libcxx] r275772 - Remove locale tests that depend on enviroment variables.

2016-07-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Jul 18 01:15:55 2016 New Revision: 275772 URL: http://llvm.org/viewvc/llvm-project?rev=275772&view=rev Log: Remove locale tests that depend on enviroment variables. Constructing a std::locale object from an empty string selects the language from the current environment va