Hi,
This patch introduces a new cmake variable: CLANG_DEFAULT_RTLIB, thru
which we can specify a default value for -rtlib (libgcc or
compiler-rt) at build time, just like how we set the default C++
stdlib thru CLANG_DEFAULT_CXX_STDLIB.
With these two options, we can configure clang to build binar
Breaks the VS 2013 build, even though we tried to check ahead of time:
https://llvm.org/bugs/show_bug.cgi?id=28589
http://lab.llvm.org:8011/builders/clang-x86-win2008-selfhost/builds/9110
On Fri, Jul 15, 2016 at 5:35 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author:
Author: rsmith
Date: Sun Jul 17 14:24:51 2016
New Revision: 275727
URL: http://llvm.org/viewvc/llvm-project?rev=275727&view=rev
Log:
PR28589: attempt to work around MSVC rejects-valid.
Modified:
cfe/trunk/lib/Frontend/ChainedIncludesSource.cpp
Modified: cfe/trunk/lib/Frontend/ChainedIncludes
Author: rsmith
Date: Sun Jul 17 15:00:59 2016
New Revision: 275730
URL: http://llvm.org/viewvc/llvm-project?rev=275730&view=rev
Log:
Attempt to work around MSVC rejects-valid, round 2.
Modified:
cfe/trunk/lib/Frontend/ChainedIncludesSource.cpp
Modified: cfe/trunk/lib/Frontend/ChainedIncludes
Hi Duncan,
It's possibly expected. It depends on what operation it's performing. I
expected a bit of a performance drop in some cases but I have a plan to fix
those.
Do you have a link to LNT?
On Wed, Jul 13, 2016 at 6:41 PM, Duncan P. N. Exon Smith <
dexonsm...@apple.com> wrote:
> Hmm. I impli
Author: ericwf
Date: Sun Jul 17 15:32:30 2016
New Revision: 275732
URL: http://llvm.org/viewvc/llvm-project?rev=275732&view=rev
Log:
Fix std::experimental::optional tests. Patch from Casey Carter.
Modified:
libcxx/trunk/test/std/experimental/optional/optional.object/optional.object.assign/em
EricWF added a comment.
In https://reviews.llvm.org/D22073#482120, @jfb wrote:
> In https://reviews.llvm.org/D22073#481402, @EricWF wrote:
>
> > - The test should be moved to `test/libcxx/atomics/atomics.align` since
> > it's libc++ specific.
>
>
> Done.
>
> > - Please give the anonymous struct
Given that this patch is basically Chandler's talk from CppCon 2015 (
https://www.youtube.com/watch?v=nXaxk27zwlk), I'm surprised that the commit
message isn't explicitly mentioning that; and surprised that Chandler
himself isn't weighing in on either the "this is a good idea" or "this is a
bad ide
On Sun, Jul 17, 2016 at 2:54 PM, Arthur O'Dwyer
wrote:
> Given that this patch is basically Chandler's talk from CppCon 2015 (
> https://www.youtube.com/watch?v=nXaxk27zwlk), I'm surprised that the
> commit message isn't explicitly mentioning that; and surprised that
> Chandler himself isn't weig
Author: ericwf
Date: Sun Jul 17 17:04:57 2016
New Revision: 275734
URL: http://llvm.org/viewvc/llvm-project?rev=275734&view=rev
Log:
Check for unconstrained hash equality before constrained hash equality.
This patch implements a simple optimization in __hash_table::find. When
iterating
the found
FYI,
I recommitted the previously removed optimization in r275734. I believe it
should fix the LNT performance regression. The benchmarks I used to test
this change can be found in D22240 (https://reviews.llvm.org/D22240#3266819f
)
/Eric
On Sun, Jul 17, 2016 at 3:09 PM, Eric Fiselier wrote:
>
Sigh. Fixed in r275730.
On 17 Jul 2016 10:54 a.m., "Reid Kleckner via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Breaks the VS 2013 build, even though we tried to check ahead of time:
> https://llvm.org/bugs/show_bug.cgi?id=28589
> http://lab.llvm.org:8011/builders/clang-x86-win2008-self
erik.pilkington added inline comments.
Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3861
@@ -3860,3 +3860,3 @@
// static data members until a definition of the variable is needed. We need
- // it right away if the type contains 'auto'.
+ // it right away if the type c
Author: compnerd
Date: Sun Jul 17 17:27:38 2016
New Revision: 275735
URL: http://llvm.org/viewvc/llvm-project?rev=275735&view=rev
Log:
CodeGen: whitespace cleanup, StringRef usage in ObjC EH type construction
Clean up some formatting issues and use a bit more StringRef based operations
instead of
Author: compnerd
Date: Sun Jul 17 17:27:41 2016
New Revision: 275736
URL: http://llvm.org/viewvc/llvm-project?rev=275736&view=rev
Log:
CodeGen: whitespace, formatting cleanups, NFC
Format some code which was oddly formatted. Use a bit of auto to make the code
more legible. NFC.
Modified:
c
Author: compnerd
Date: Sun Jul 17 17:27:44 2016
New Revision: 275737
URL: http://llvm.org/viewvc/llvm-project?rev=275737&view=rev
Log:
CodeGen: honour dllstorage on ObjC types
Add support for ObjC types to respect the DLLImport/DLLExport storage
annotations. This only effects COFF output. This
Author: compnerd
Date: Sun Jul 17 17:54:42 2016
New Revision: 275738
URL: http://llvm.org/viewvc/llvm-project?rev=275738&view=rev
Log:
test: add missing triple to test
The test was relying on the default triple which may not be correct. Explicitly
provide it a triple. Should repair the windows
Author: ericwf
Date: Sun Jul 17 19:35:56 2016
New Revision: 275745
URL: http://llvm.org/viewvc/llvm-project?rev=275745&view=rev
Log:
Implement C++17 tuple bits. Including apply and make_from_tuple.
This patch upgrades to be C++17 compliant by implementing:
* tuple_size_v: This was forgotten whe
EricWF added a comment.
I'm committing this today, meaning it will make it into 3.9, so don't forget to
remove your upstream patches before the release :-)
In https://reviews.llvm.org/D21329#476455, @dim wrote:
> In https://reviews.llvm.org/D21329#475105, @theraven wrote:
>
> > Looks fine to me
Author: ericwf
Date: Sun Jul 17 20:52:46 2016
New Revision: 275748
URL: http://llvm.org/viewvc/llvm-project?rev=275748&view=rev
Log:
Suppress warning in make_from_tuple tests.
Modified:
libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.apply/make_from_tuple.pass.cpp
Modified:
libcxx/
Author: ericwf
Date: Sun Jul 17 20:58:37 2016
New Revision: 275749
URL: http://llvm.org/viewvc/llvm-project?rev=275749&view=rev
Log:
Rename and rework `_LIBCPP_TRIVIAL_PAIR_COPY_CTOR`. Move FreeBSD configuration
in-tree.
This patch does the following:
* It renames `_LIBCPP_TRIVIAL_PAIR_COPY_CTO
EricWF closed this revision.
EricWF added a comment.
r275749.
https://reviews.llvm.org/D21329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Sun Jul 17 21:02:49 2016
New Revision: 275750
URL: http://llvm.org/viewvc/llvm-project?rev=275750&view=rev
Log:
Upgrade arcconfig to use https
Modified:
libcxx/trunk/.arcconfig
Modified: libcxx/trunk/.arcconfig
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/.arcc
Author: ericwf
Date: Sun Jul 17 21:05:31 2016
New Revision: 275751
URL: http://llvm.org/viewvc/llvm-project?rev=275751&view=rev
Log:
Add includes in test. Patch from s...@microsoft.com
Modified:
libcxx/trunk/test/std/containers/container.adaptors/priority.queue/types.pass.cpp
Modified:
lib
Author: ericwf
Date: Sun Jul 17 21:05:52 2016
New Revision: 275752
URL: http://llvm.org/viewvc/llvm-project?rev=275752&view=rev
Log:
Fix arc config to use https
Modified:
libcxxabi/trunk/.arcconfig
Modified: libcxxabi/trunk/.arcconfig
URL:
http://llvm.org/viewvc/llvm-project/libcxxabi/trunk
EricWF closed this revision.
EricWF added a comment.
r275751.
https://reviews.llvm.org/D22012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Sun Jul 17 21:29:33 2016
New Revision: 275753
URL: http://llvm.org/viewvc/llvm-project?rev=275753&view=rev
Log:
Prevent failures by marking Clock::is_steady tests as UNSUPPORTED: asan.
Modified:
libcxx/trunk/test/std/utilities/time/time.clock/time.clock.hires/consistency
kkwli0 added a subscriber: cfe-commits.
kkwli0 added a comment.
Add cfe-commits
https://reviews.llvm.org/D22417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Do you need me to commit this?
https://reviews.llvm.org/D22265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
Author: ericwf
Date: Sun Jul 17 22:00:09 2016
New Revision: 275754
URL: http://llvm.org/viewvc/llvm-project?rev=275754&view=rev
Log:
Add checkpoint diagnostics to help diagnose buildbot failures.
Modified:
libcxx/trunk/test/std/localization/locale.categories/category.ctype/locale.ctype.bynam
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D22417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
compnerd added a comment.
I was worried about the OOM situation with the 32-bit toolchain. As long as
there is a way to get to the 64-bit version, I don't think that it matters too
much that we default to x86. It sounds like even then, its not been a concern?
https://reviews.llvm.org/D22426
Author: chapuni
Date: Sun Jul 17 22:23:25 2016
New Revision: 275756
URL: http://llvm.org/viewvc/llvm-project?rev=275756&view=rev
Log:
Revert r275678, "Revert "Revert r275027 - Let FuncAttrs infer the 'returned'
argument attribute""
This reverts also r275029, "Update Clang tests after adding infe
majnemer added a comment.
In https://reviews.llvm.org/D22426#486605, @compnerd wrote:
> I was worried about the OOM situation with the 32-bit toolchain. As long as
> there is a way to get to the 64-bit version, I don't think that it matters
> too much that we default to x86. It sounds like ev
Author: ericwf
Date: Sun Jul 17 23:48:37 2016
New Revision: 275757
URL: http://llvm.org/viewvc/llvm-project?rev=275757&view=rev
Log:
Improve ABI tests for std::pair.
Added:
libcxx/trunk/test/libcxx/utilities/utility/pairs/pairs.pair/non_trivial_copy_move_ABI.pass.cpp
libcxx/trunk/test/l
EricWF created this revision.
EricWF added a subscriber: cfe-commits.
https://reviews.llvm.org/D22452
Files:
test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp
Index: test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pa
Author: ericwf
Date: Mon Jul 18 01:01:50 2016
New Revision: 275759
URL: http://llvm.org/viewvc/llvm-project?rev=275759&view=rev
Log:
Rework libatomic handling in CMake and LIT.
This patch updates the way libc++ handles checking for libatomic, in part
to prepare for https://reviews.llvm.org/D22073
EricWF added a comment.
OK, IMO the way to handle this test is to have it manually link `-latomic`.
This can be done by renaming the test to `.sh.cpp` and adding the
following lines:
// REQUIRES: libatomic
// RUN: %build -latomic
// RUN: %run
After that this LGTM.
https://reviews.llvm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275760: [libcxx][filesystem] Remove setgid from parent
before testing permissions (authored by Hahnfeld).
Changed prior to commit:
https://reviews.llvm.org/D22265?vs=63672&id=64275#toc
Repository:
rL
Author: hahnfeld
Date: Mon Jul 18 01:06:50 2016
New Revision: 275760
URL: http://llvm.org/viewvc/llvm-project?rev=275760&view=rev
Log:
[libcxx][filesystem] Remove setgid from parent before testing permissions
man page for mkdir says: "If the parent directory has the set-group-ID bit set,
then so
Author: ericwf
Date: Mon Jul 18 01:15:55 2016
New Revision: 275772
URL: http://llvm.org/viewvc/llvm-project?rev=275772&view=rev
Log:
Remove locale tests that depend on enviroment variables.
Constructing a std::locale object from an empty string selects the language
from the current environment va
41 matches
Mail list logo
