alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with one comment.
Comment at: clang-rename/USRLocFinder.cpp:73-76
@@ -73,3 +72,6 @@
SourceLocation Location = Initializer->getSourceLocation();
- String
omtcyf0 updated this revision to Diff 63931.
http://reviews.llvm.org/D22091
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRLocFinder.cpp
clang-rename/USRLocFinder.h
clang-rename/tool/ClangRename.cpp
test/clang-rename/NoNewName.cpp
Index: test/clang-rename/NoNewName.cpp
omtcyf0 marked an inline comment as done.
omtcyf0 added a comment.
Thanks, @alexfh!
Can you please land it?
http://reviews.llvm.org/D22091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
klimek added inline comments.
Comment at: test/clang-rename/TemplateTypename.cpp:4
@@ +3,3 @@
+// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s
+// XFAIL: *
+
Here, too?
http://reviews.llvm.org/D22102
___
cfe-commits ma
omtcyf0 updated this revision to Diff 63934.
http://reviews.llvm.org/D22102
Files:
test/clang-rename/FunctionMacro.cpp
test/clang-rename/Namespace.cpp
test/clang-rename/TemplateTypename.cpp
test/clang-rename/UserDefinedConversion.cpp
test/clang-rename/VariableMacro.cpp
test/clang-rena
omtcyf0 marked an inline comment as done.
omtcyf0 added a comment.
Oops, sorry. Fixed it.
+1 currently unsupported test.
http://reviews.llvm.org/D22102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D22102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
omtcyf0 added a comment.
Thanks, Manuel!
Can you please land it?
http://reviews.llvm.org/D22102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vmiklos added a subscriber: vmiklos.
vmiklos added a comment.
Can you please avoid adding VirtualFunction.cpp? http://reviews.llvm.org/D22237
would add it as well, but without the FIXME. Thanks! :-)
http://reviews.llvm.org/D22102
___
cfe-commits ma
omtcyf0 updated this revision to Diff 63939.
http://reviews.llvm.org/D22102
Files:
test/clang-rename/FunctionMacro.cpp
test/clang-rename/Namespace.cpp
test/clang-rename/TemplateTypename.cpp
test/clang-rename/UserDefinedConversion.cpp
test/clang-rename/VariableMacro.cpp
Index: test/clan
omtcyf0 added a comment.
@vmiklos sure thing.
Thanks for noticing!
http://reviews.llvm.org/D22102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: abadouh
Date: Thu Jul 14 03:40:30 2016
New Revision: 275384
URL: http://llvm.org/viewvc/llvm-project?rev=275384&view=rev
Log:
[X86][AVX512F] minor fix of the parameter names
add "__" prefix
Modified:
cfe/trunk/lib/Headers/avx512fintrin.h
Modified: cfe/trunk/lib/Headers/avx512fintrin.
omtcyf0 added a subscriber: omtcyf0.
omtcyf0 added a comment.
This one doesn't fix it though.
It only deals with declarations of overridden functions.
This is the test that still fails:
/ RUN: cat %s > %t.cpp
// RUN: clang-rename -offset=161 -new-name=boo %t.cpp -i --
// RUN: sed 's,//.*,
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D22129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
The judgement that checks whether the fully-qualified name has scoped qualifiers
prefix is incorrect. Should always check whether the first matched postion is
the
beginning position.
http://re
Hi,
Your commit
Add C++ dependencies to xray runtime
Doesn't compile with gcc. At least 5.3 and 4.8.4 complains about this
change:
+ if (Args.hasArg(options::OPT_fxray_instrument,
+ options::OPT_fnoxray_instrument, false)) {
+CmdArgs.push_back("-fxray-instrument");
bkramer added inline comments.
Comment at: include-fixer/IncludeFixerContext.cpp:46
@@ +45,3 @@
+ bool HasScopedQualifiersPrefix =
+ FullyQualifiedName.find(SymbolScopedQualifiers) == 0;
+ if (!HasScopedQualifiersPrefix)
StringRef(FullyQualifiedName).starts
hokein added inline comments.
Comment at: include-fixer/IncludeFixerContext.cpp:46
@@ +45,3 @@
+ bool HasScopedQualifiersPrefix =
+ FullyQualifiedName.find(SymbolScopedQualifiers) == 0;
+ if (!HasScopedQualifiersPrefix)
bkramer wrote:
> StringRef(FullyQuali
hokein updated this revision to Diff 63941.
hokein marked an inline comment as done.
hokein added a comment.
Use StringRef::startwith.
http://reviews.llvm.org/D22343
Files:
include-fixer/IncludeFixerContext.cpp
unittests/include-fixer/IncludeFixerTest.cpp
Index: unittests/include-fixer/Inc
alexfh added a comment.
In http://reviews.llvm.org/D22091#483834, @omtcyf0 wrote:
> Thanks, @alexfh!
>
> Can you please land it?
It's not easy to do from the phone ;) Please ask someone else (Ben?).
http://reviews.llvm.org/D22091
___
cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275386: [include-fixer] Correct an incorrecst judgement
about prefix scoped qualifiers. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D22343?vs=63941&id=63942#toc
Repository:
Author: hokein
Date: Thu Jul 14 04:39:12 2016
New Revision: 275386
URL: http://llvm.org/viewvc/llvm-project?rev=275386&view=rev
Log:
[include-fixer] Correct an incorrecst judgement about prefix scoped qualifiers.
Summary:
The judgement that checks whether the fully-qualified name has scoped quali
bkramer added a comment.
on it ...
http://reviews.llvm.org/D22091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: d0k
Date: Thu Jul 14 04:46:07 2016
New Revision: 275388
URL: http://llvm.org/viewvc/llvm-project?rev=275388&view=rev
Log:
[clang-rename] add documentation
clang-rename needs at least to have a minimum documentation to provide a
small introduction for new users
Patch by Kirill Bobyrev!
D
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275388: [clang-rename] add documentation (authored by d0k).
Changed prior to commit:
http://reviews.llvm.org/D22129?vs=63646&id=63944#toc
Repository:
rL LLVM
http://reviews.llvm.org/D22129
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275387: [clang-rename] exit code-related bugfix and code
cleanup (authored by d0k).
Changed prior to commit:
http://reviews.llvm.org/D22091?vs=63931&id=63943#toc
Repository:
rL LLVM
http://reviews.l
Author: d0k
Date: Thu Jul 14 04:46:03 2016
New Revision: 275387
URL: http://llvm.org/viewvc/llvm-project?rev=275387&view=rev
Log:
[clang-rename] exit code-related bugfix and code cleanup
This patch does the following:
* enforces proper formatting for few files (i.e. deals with 80 linewidth
viol
DmitryPolukhin added a comment.
In http://reviews.llvm.org/D22034#482925, @majnemer wrote:
> A flag on CXXRecordDecl which is sensitive to the most recent expression
> evaluation might not be the best way to go.
> Perhaps we should be able to use the VFTableBuilder to build imported and
> loca
DmitryPolukhin updated this revision to Diff 63950.
DmitryPolukhin marked 2 inline comments as done.
DmitryPolukhin added a comment.
- defer var generation if their type is class with dllimport.
http://reviews.llvm.org/D22034
Files:
include/clang/AST/DeclCXX.h
lib/AST/DeclCXX.cpp
lib/AST/
klimek added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:160
@@ +159,3 @@
+ /// This returns true if the replacement is successfully inserted; otherwise,
+ /// it returns an llvm::Error, i.e. there is conflict between R and the
+ /// existing replaceme
Thanks Mikael -- this has been fixed in r275377 (
http://reviews.llvm.org/rL275377).
On Thu, Jul 14, 2016 at 7:30 PM Mikael Holmén
wrote:
> Hi,
>
> Your commit
>
> Add C++ dependencies to xray runtime
>
> Doesn't compile with gcc. At least 5.3 and 4.8.4 complains about this
> change:
>
> +
Hello,
Comparing the list of feature checks documented here [1], and the list of
checks actually implemented here [2], I found that a few are undocumented.
Below is a patch that adds documentation for them.
Thank you,
Nate
[1] http://clang.llvm.org/docs/LanguageExtensions.html#feature-checking
Pajesz updated this revision to Diff 63925.
Pajesz added a comment.
Minor changes in tests and doc and diff should be full now.
http://reviews.llvm.org/D19586
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/MisleadingIndentationCheck.cpp
clang-tidy/readability/Misleadi
mboehme added a subscriber: mboehme.
mboehme added a comment.
The test cfe/trunk/test/Frontend/opencl.cl that was added here appears to
fail.
Running "ninja check-clang" doesn't pick this up because
cfe/trunk/test/Frontend/lit.local.cfg doesn't contain '.cl' as a file
suffix:
config.suffixes = [
The test cfe/trunk/test/Frontend/opencl.cl that was added here appears to
fail.
Running "ninja check-clang" doesn't pick this up because
cfe/trunk/test/Frontend/lit.local.cfg doesn't contain '.cl' as a file
suffix:
config.suffixes = ['.c', '.cpp', '.m', '.mm', '.ll']
As soon as I add the suffix:
Author: aaronballman
Date: Thu Jul 14 07:35:00 2016
New Revision: 275404
URL: http://llvm.org/viewvc/llvm-project?rev=275404&view=rev
Log:
Correct the attribute documentation for the new XRay attributes. Fixes the
documentation build.
Modified:
cfe/trunk/include/clang/Basic/AttrDocs.td
Modi
mboehme created this revision.
mboehme added a reviewer: bkramer.
mboehme added subscribers: cfe-commits, ashi1.
rL275318 added the test Frontend/opencl.cl test, but that test was never
actually run because Frontend/lit.local.cfg doesn't contain the '.cl' file
suffix.
Once the test is activated
mboehme added a comment.
Fix in review at https://reviews.llvm.org/D22349
Repository:
rL LLVM
https://reviews.llvm.org/D22170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: d0k
Date: Thu Jul 14 07:56:21 2016
New Revision: 275405
URL: http://llvm.org/viewvc/llvm-project?rev=275405&view=rev
Log:
[OpenCL] Actually activate Frontend/opencl.cl test and fix test bugs
rL275318 added the test Frontend/opencl.cl test, but that test was never
actually run because Fro
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275405: [OpenCL] Actually activate Frontend/opencl.cl test
and fix test bugs (authored by d0k).
Changed prior to commit:
https://reviews.llvm.org/D22349?vs=63959&id=63961#toc
Repository:
rL LLVM
htt
mboehme added a comment.
Fix submitted
Repository:
rL LLVM
https://reviews.llvm.org/D22170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Thu Jul 14 08:01:00 2016
New Revision: 275407
URL: http://llvm.org/viewvc/llvm-project?rev=275407&view=rev
Log:
This is a malformed :option: tag -- we don't have an option directive that
matches it, so turning it actual text instead of a markup tag. This will
hopefully
bkramer added a subscriber: bkramer.
bkramer accepted this revision.
bkramer added a reviewer: bkramer.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D22310
___
cfe-commits mailing list
cfe-com
ericLemanissier added a comment.
After searching deeper into the C++ Core Guidelines, they are Ok with passing C
strings to function without passing there size, but the types gsl::zstring and
gsl::czstring have to be used :
https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelin
ericLemanissier added a comment.
having studied cpp core guidelines in more depth, I completely understand that
the problem in the case I described is that the function receiving
PRETTY_FUNCTION takes a const char* parameter, whereas it should take a
czstring or szstring_span. As a consequence
Author: d0k
Date: Thu Jul 14 08:15:37 2016
New Revision: 275409
URL: http://llvm.org/viewvc/llvm-project?rev=275409&view=rev
Log:
Upgrade all the .arcconfigs to https.
Modified:
cfe/trunk/.arcconfig
Modified: cfe/trunk/.arcconfig
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/.arcconfig
Author: d0k
Date: Thu Jul 14 08:15:37 2016
New Revision: 275409
URL: http://llvm.org/viewvc/llvm-project?rev=275409&view=rev
Log:
Upgrade all the .arcconfigs to https.
Modified:
clang-tools-extra/trunk/.arcconfig
Modified: clang-tools-extra/trunk/.arcconfig
URL:
http://llvm.org/viewvc/llvm-
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
A small improvement: for only one suggested header, user don't have to
type ENTER manually after running the python script.
https://reviews.llvm.org/D22351
Files:
include-fixer/tool/clang-in
On 07/14/2016 02:10 PM, Dean Michael Berris wrote:
Thanks Mikael -- this has been fixed in r275377
(http://reviews.llvm.org/rL275377).
Yes, now it compiled. Thank you!
/Mikael
On Thu, Jul 14, 2016 at 7:30 PM Mikael Holmén
mailto:mikael.hol...@ericsson.com>> wrote:
Hi,
Your commit
Author: pgousseau
Date: Thu Jul 14 08:58:27 2016
New Revision: 275415
URL: http://llvm.org/viewvc/llvm-project?rev=275415&view=rev
Log:
The test added in r275267 does not work on read-only checkouts because of the
use of touch -m -t.
Following Tom Rybka suggestion, the test files are now copied t
pgousseau added a comment.
In https://reviews.llvm.org/D22310#484017, @bkramer wrote:
> lg
Thanks for the review!
https://reviews.llvm.org/D22310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Author: aaronballman
Date: Thu Jul 14 09:07:37 2016
New Revision: 275416
URL: http://llvm.org/viewvc/llvm-project?rev=275416&view=rev
Log:
Removing more :option: tags that we do not have corresponding .. option
directives for; these are causing the sphinx bot to fail
(http://lab.llvm.org:8011/bu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275417: Diagnose taking address and reference binding of
packed members (authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D20561?vs=61089&id=63970#toc
Repository:
rL LLVM
htt
Author: rogfer01
Date: Thu Jul 14 09:10:43 2016
New Revision: 275417
URL: http://llvm.org/viewvc/llvm-project?rev=275417&view=rev
Log:
Diagnose taking address and reference binding of packed members
This patch implements PR#22821.
Taking the address of a packed member is dangerous since the redu
pgousseau closed this revision.
pgousseau added a comment.
Committed in https://reviews.llvm.org/rL275415
https://reviews.llvm.org/D22310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
mboehme created this revision.
mboehme added a reviewer: bkramer.
mboehme added a subscriber: cfe-commits.
The test currently fails if the name of the Clang binary doesn't contain
"clang".
This patch removes that requirement, as some environments may choose to run the
test with a differently na
Author: d0k
Date: Thu Jul 14 10:06:57 2016
New Revision: 275428
URL: http://llvm.org/viewvc/llvm-project?rev=275428&view=rev
Log:
[OpenCL] In test/Driver/opencl.cl, don't require name of Clang binary to
contain "clang"
The test currently fails if the name of the Clang binary doesn't contain
"cl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275428: [OpenCL] In test/Driver/opencl.cl, don't require
name of Clang binary to… (authored by d0k).
Changed prior to commit:
https://reviews.llvm.org/D22359?vs=63976&id=63981#toc
Repository:
rL LLVM
bkramer added a comment.
I'm not entirely sure if jumping cursors are a good user interface. It will
completely throw the user out of context, which is exactly what we want to
avoid with include-fixer.
https://reviews.llvm.org/D22351
___
cfe-commi
klimek added a subscriber: klimek.
klimek added a comment.
+1 to not throwing users around by default. Can we make it configurable if
folks want it?
https://reviews.llvm.org/D22351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
tejohnson added a comment.
Note that this will have the side effect of enabling linkonce/weak resolution
and internalization for the distributed backends.
I had just sent a separate patch (https://reviews.llvm.org/D22356) to do the
former, which includes a fix for a subtle linking issue in the
Author: aaronballman
Date: Thu Jul 14 10:32:11 2016
New Revision: 275430
URL: http://llvm.org/viewvc/llvm-project?rev=275430&view=rev
Log:
Removing a few more :option: tags that we do not have corresponding .. option
directives for; these are causing the sphinx bot to fail
(http://lab.llvm.org:8
rmaprath added a comment.
Update: Almost there, should be able to put it up for review tomorrow.
Cheers,
/ Asiri
https://reviews.llvm.org/D22292
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
manmanren accepted this revision.
manmanren added a comment.
This revision is now accepted and ready to land.
LGTM.
Thanks,
Manman
Repository:
rL LLVM
https://reviews.llvm.org/D22270
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D22367
Files:
include-fixer/IncludeFixerContext.cpp
unittests/include-fixer/IncludeFixerTest.cpp
Index: unittests/include-fixer/IncludeFixerTest.cpp
==
bkramer accepted this revision.
This revision is now accepted and ready to land.
Comment at: include-fixer/IncludeFixerContext.cpp:54
@@ -49,2 +53,3 @@
- return FullyQualifiedName;
+ auto FullySymbolQualifiers = SplitQualifiers(FullyQualifiedName);
+ auto ScopedQualifiers = S
probinson added a comment.
Ping.
https://reviews.llvm.org/D22113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM! I don't think we intended this to be an extension for C.
https://reviews.llv
majnemer added a subscriber: majnemer.
Comment at: lib/Sema/SemaDecl.cpp:6189-6191
@@ -6188,2 +6188,5 @@
<< FixItHint::CreateRemoval(D.getDeclSpec().getInlineSpecLoc());
+} else if (!getLangOpts().CPlusPlus) {
+ Diag(D.getDeclSpec().getInlineSpecLoc(), diag::err_
Hi,
this fires on (at least) usrsctplib [1]:
FAILED: obj/third_party/usrsctp/usrsctp/sctp_input.o
../../third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_input.c:1708:15:
error: taking address of packed member 'time_entered' of class or structure
'sctp_state_cookie' may result in an unaligne
probinson added a subscriber: probinson.
probinson added a comment.
On the thread you suggested it would affect out-of-tree targets, so this
probably deserves a release note?
https://reviews.llvm.org/D22290
___
cfe-commits mailing list
cfe-commits@
Author: aaronballman
Date: Thu Jul 14 12:15:06 2016
New Revision: 275440
URL: http://llvm.org/viewvc/llvm-project?rev=275440&view=rev
Log:
Despite there being an option, it seems that Sphinx has decided that "=123" is
part of the option directive name, and so having "=0" in the option tag is
pro
hokein updated this revision to Diff 64004.
hokein added a comment.
Add an option to make move-cursor configurable.
https://reviews.llvm.org/D22351
Files:
include-fixer/tool/clang-include-fixer.py
Index: include-fixer/tool/clang-include-fixer.py
==
bruno added a comment.
Ping!
https://reviews.llvm.org/D22248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein added a comment.
+Daniel who suggests this feature ;)
https://reviews.llvm.org/D22351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mmasten added a comment.
Hello all,
Just wanted to see if you guys have some time to review.
Thanks,
Matt
https://reviews.llvm.org/D19544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
jyknight added a subscriber: jyknight.
jyknight added a comment.
This seems to trigger even for the implicitly generated copier of a packed
struct. E.g.
#include
void copyit(epoll_event&out, const epoll_event &in) {
out = in;
}
Is that as intended?
Repository:
rL LLVM
https:/
spatel added a comment.
Hi Matt -
This looks like the right first step in the path that Hal suggested, except I
think we need a test case for each function that you want to enable. Please see
test/Transforms/LoopVectorize/X86/veclib-calls.ll as a reference for how to do
that.
https://reviews
jyknight added a comment.
Regardless, I think this should not have added a new un-disableable error, but
instead only a default-on warning.
The ""binding reference to packed member" error is firing on some of our code,
and even if it's not a false-positive, it should be possible to disable it
ioeric updated this revision to Diff 64016.
ioeric marked 6 inline comments as done.
ioeric added a comment.
- Merge branch 'master' of http://llvm.org/git/clang into replace
- Addressed reviewer's comments.
https://reviews.llvm.org/D21748
Files:
include/clang/Tooling/Core/Replacement.h
inc
On Tue, Jul 12, 2016 at 3:51 PM David Majnemer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Tue, Jul 12, 2016 at 2:55 PM, Robinson, Paul
> wrote:
>
>> A declaration that gets used within the CU generally does get a
>> debug-info description.
>>
>
> It does except if it is a static da
ioeric updated this revision to Diff 64015.
ioeric added a comment.
- merged with origin/master
- Addressed reviewer's comments in the corresponding patch.
https://reviews.llvm.org/D21749
Files:
clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h
clang-app
baloghadamsoftware created this revision.
baloghadamsoftware added a reviewer: dcoughlin.
baloghadamsoftware added subscribers: cfe-commits, o.gyorgy, xazax.hun.
Many classes (e.g. in common stl implementations) contain user-written copy and
move constructors that are identical to the implicit on
Roger, can you please revert? This seems to have caused some pain for
our users, and it would be good to unblock them while deciding what to
do about the issues.
~Aaron
On Thu, Jul 14, 2016 at 2:19 PM, James Y Knight wrote:
> jyknight added a comment.
>
> Regardless, I think this should not have
Author: benlangmuir
Date: Thu Jul 14 13:51:55 2016
New Revision: 275454
URL: http://llvm.org/viewvc/llvm-project?rev=275454&view=rev
Log:
[index] Index system ImportDecls even when there is a DeclarationsOnly filter
Whether we call an ImportDecl a decl or a reference symbol role is
somewhat acade
vsk updated this revision to Diff 64023.
vsk added a comment.
- Addressed Paul's comment: added a release note about this.
- Rebased onto master to pick up an Xray change.
https://reviews.llvm.org/D22290
Files:
docs/ReleaseNotes.rst
include/clang/Driver/Driver.h
include/clang/Driver/Sanit
pcc added a comment.
Ping.
https://reviews.llvm.org/D21537
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mehdi_amini added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:740
@@ +739,3 @@
+ ComputeCrossModuleImportForModule(M->getModuleIdentifier(), *CombinedIndex,
+ImportList);
+
This should go away at some point right?
vmiklos updated this revision to Diff 64025.
https://reviews.llvm.org/D22237
Files:
clang-rename/USRLocFinder.cpp
test/clang-rename/VirtualFunction.cpp
Index: test/clang-rename/VirtualFunction.cpp
===
--- /dev/null
+++ test/clan
vmiklos added a comment.
Forgot to add asserts for main() in the testcase.
https://reviews.llvm.org/D22237
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vmiklos updated this revision to Diff 64027.
https://reviews.llvm.org/D22237
Files:
clang-rename/USRLocFinder.cpp
test/clang-rename/VirtualFunction.cpp
Index: test/clang-rename/VirtualFunction.cpp
===
--- /dev/null
+++ test/clan
tejohnson added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:740
@@ +739,3 @@
+ ComputeCrossModuleImportForModule(M->getModuleIdentifier(), *CombinedIndex,
+ImportList);
+
mehdi_amini wrote:
> This should go away at
Author: spyffe
Date: Thu Jul 14 14:53:44 2016
New Revision: 275460
URL: http://llvm.org/viewvc/llvm-project?rev=275460&view=rev
Log:
When importing classes and structs with anonymous structs, it is critical that
distinct anonymous structs remain distinct despite having similar layout.
This is alr
Yes I will revert this ASAP.
Sorry for the fuss.
From: Aaron Ballman
Sent: 14 July 2016 19:30:58
To: reviews+d20561+public+af1fea8a731d8...@reviews.llvm.org
Cc: Roger Ferrer Ibanez; Richard Smith; James Y Knight; Evgenii Stepanov;
cfe-commits
Subject: Re: [PATC
Author: mgehre
Date: Thu Jul 14 15:00:48 2016
New Revision: 275461
URL: http://llvm.org/viewvc/llvm-project?rev=275461&view=rev
Log:
cppcoreguidelines-pro-bounds-constant-array-index: crash for value dependent
index in c++03 mode
Summary:
When the expression is value dependent,
isIntegerConstant
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275461: cppcoreguidelines-pro-bounds-constant-array-index:
crash for value dependent… (authored by mgehre).
Changed prior to commit:
https://reviews.llvm.org/D22190?vs=63795&id=64030#toc
Repository:
Author: rogfer01
Date: Thu Jul 14 15:05:30 2016
New Revision: 275462
URL: http://llvm.org/viewvc/llvm-project?rev=275462&view=rev
Log:
Reverting 275417
This change has triggered unexpected failures.
Removed:
cfe/trunk/test/Sema/address-packed-member-memops.c
cfe/trunk/test/Sema/address-
rogfer01 added a comment.
Reverted.
Repository:
rL LLVM
https://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: benlangmuir
Date: Thu Jul 14 15:08:43 2016
New Revision: 275464
URL: http://llvm.org/viewvc/llvm-project?rev=275464&view=rev
Log:
Attempt to workaround Windows bots after my previous commit
For some reason it seems the second invocation is getting DMOD_OTHER_H
set to a path with/forward/s
Hi Nico,
it seems it may be necessary to take into account the actual offset of the
field in such cases to avoid these kind of false positives.
I reverted the change until I get a better solution.
Thanks,
Roger
From: tha...@google.com on behalf of Nico Web
1 - 100 of 156 matches
Mail list logo
