tejohnson added inline comments.

================
Comment at: lib/CodeGen/BackendUtil.cpp:740
@@ +739,3 @@
+  ComputeCrossModuleImportForModule(M->getModuleIdentifier(), *CombinedIndex,
+                                    ImportList);
+
----------------
mehdi_amini wrote:
> This should go away at some point right?
> Just to double check if my memory is correct: the linker plugin will emit the 
> import decision and the backend will take it as an input instead of 
> recomputing anything?
The way they are passed down is via the individual combined index. So it simply 
computes via what is in the index, which will only include summaries for what 
should be imported. I suppose we could make the logic even simpler tho and just 
blindly import what is in the index. 

Peter, can you add a fixme? 


https://reviews.llvm.org/D21545



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to