r274484 - [AVX512] Modify what indices we emit for the zero vector we use for zero extension of the result of a v2i1 or v4i1 masked compare. This way we emit something that the backend easily interpre

2016-07-04 Thread Craig Topper via cfe-commits
Author: ctopper Date: Mon Jul 4 02:09:46 2016 New Revision: 274484 URL: http://llvm.org/viewvc/llvm-project?rev=274484&view=rev Log: [AVX512] Modify what indices we emit for the zero vector we use for zero extension of the result of a v2i1 or v4i1 masked compare. This way we emit something that

Re: r274110 - [AVX512] Zero extend cmp intrinsic return value.

2016-07-04 Thread Craig Topper via cfe-commits
I've modified the indices we use for the zero vector in r274484. This gives better codegen as it now looks like a concat to the backend. So now we just end up emitting unnecessary kshiftlw/kshiftrw pairs instead of converting to a wider vector op and back. ~Craig On Sun, Jul 3, 2016 at 1:32 PM, C

Re: [PATCH] D21787: [include-fixer] make HeaderMapCollector maps from regex instead of postfix.

2016-07-04 Thread Eric Liu via cfe-commits
ioeric added a comment. Ping http://reviews.llvm.org/D21787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

2016-07-04 Thread Alexander Droste via cfe-commits
Alexander_Droste updated this revision to Diff 62653. Alexander_Droste added a comment. - remove superflous `clang::` http://reviews.llvm.org/D21962 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/MpiTypeMismatchCheck.cpp clang-tidy/misc/MpiTypeM

Re: [PATCH] D21787: [include-fixer] make HeaderMapCollector maps from regex instead of postfix.

2016-07-04 Thread Benjamin Kramer via cfe-commits
bkramer added inline comments. Comment at: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp:16 @@ -15,2 +15,3 @@ const HeaderMapCollector::HeaderMap *getSTLPostfixHeaderMap() { static const HeaderMapCollector::HeaderMap STLPostfixHeaderMap = { + {"include/__stddef_m

Re: [PATCH] D21392: [clang-tidy] Enhance redundant-expression check

2016-07-04 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. A couple of nits. Otherwise looks good. Thanks! Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:232 @@ +231,3 @@ + +static bool rangeSubsumeRange(BinaryOperatorKind O

Re: [PATCH] D21936: [clang-tidy] UnnecessaryValueParamCheck - only warn for virtual methods

2016-07-04 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG after addressing the comment. Thanks! Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:234 @@ +233,3 @@ +}; + +struct PositiveNonVirualMethod { -

r274487 - [Sparc] Allow LEON cpu models to be selected with -mcpu

2016-07-04 Thread Jacob Baungard Hansen via cfe-commits
Author: jacob_hansen Date: Mon Jul 4 03:56:08 2016 New Revision: 274487 URL: http://llvm.org/viewvc/llvm-project?rev=274487&view=rev Log: [Sparc] Allow LEON cpu models to be selected with -mcpu Summary: This change exposes the recently added LEON CPUs (D19359) in the LLVM Sparc backend to Clang

Re: [PATCH] D21683: [Sparc] Allow LEON cpu models to be selected with -mcpu

2016-07-04 Thread Jacob Baungard Hansen via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274487: [Sparc] Allow LEON cpu models to be selected with -mcpu (authored by jacob_hansen). Changed prior to commit: http://reviews.llvm.org/D21683?vs=61789&id=62654#toc Repository: rL LLVM http://r

RE: r274110 - [AVX512] Zero extend cmp intrinsic return value.

2016-07-04 Thread Breger, Igor via cfe-commits
Hello Craig, In general for correctness we should also change AutoUpgrade code for the cmp intrinsics. But if we handle cmp intrinsic in Clang ( CGBuildin.cpp) , can we completely remove the relevant code from back-end and Auto-Upgrade? Regards, Igor From: Craig Topper [mailto:craig.top...@gma

RE: r274110 - [AVX512] Zero extend cmp intrinsic return value.

2016-07-04 Thread Breger, Igor via cfe-commits
Thanks for working on this! Regards, Igor From: Craig Topper [mailto:craig.top...@gmail.com] Sent: Monday, July 04, 2016 10:20 To: Breger, Igor Cc: Eric Christopher via cfe-commits; Demikhovsky, Elena; Ouriel, Boaz Subject: Re: r274110 - [AVX512] Zero extend cmp intrinsic return value. I've modi

Re: [PATCH] D21787: [include-fixer] make HeaderMapCollector maps from regex instead of postfix.

2016-07-04 Thread Eric Liu via cfe-commits
ioeric added inline comments. Comment at: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp:16 @@ -15,2 +15,3 @@ const HeaderMapCollector::HeaderMap *getSTLPostfixHeaderMap() { static const HeaderMapCollector::HeaderMap STLPostfixHeaderMap = { + {"include/__stddef_ma

Re: [PATCH] D21787: [include-fixer] make HeaderMapCollector maps from regex instead of postfix.

2016-07-04 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 62656. ioeric marked an inline comment as done. ioeric added a comment. - Change RegexHeaderMap from StringMap to std::vector>. http://reviews.llvm.org/D21787 Files: include-fixer/find-all-symbols/FindAllSymbolsAction.cpp include-fixer/find-all-symbols/F

Re: [PATCH] D21472: [clang-tidy] readability-identifier-naming - support for other case types

2016-07-04 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. IIUC, Stroustrup style mandates Single_capital_letter_to_start_a_type_name (http://www.stroustrup.com/Programming/PPP-style.pdf). So both styles you're adding in this patch should not be named after Stroustrup. Also, do these come from real-life projects/requirements or

Re: [PATCH] D21833: [clang-tidy] Fix more enum declaration cases in misc-unused-using-decls check.

2016-07-04 Thread Haojian Wu via cfe-commits
hokein added a comment. Friendly ping ;) http://reviews.llvm.org/D21833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21787: [include-fixer] make HeaderMapCollector maps from regex instead of postfix.

2016-07-04 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. If the regex construction turns out to be too slow we can fix it later. LGTM for now. http://reviews.llvm.org/D21787 ___ cfe-commits mailing l

Re: [PATCH] D21815: [clang-tidy] Add 'included from' details to warning message.

2016-07-04 Thread Alexander Kornienko via cfe-commits
alexfh added inline comments. Comment at: clang-tidy/google/GlobalNamesInHeadersCheck.cpp:49 @@ -48,1 +48,3 @@ +namespace { +std::string getIncludeFromMessage(SourceLocation DeclLoc, Static functions are preferred in LLVM. http://llvm.org/docs/CodingStandards.h

Re: [PATCH] D21833: [clang-tidy] Fix more enum declaration cases in misc-unused-using-decls check.

2016-07-04 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D21833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D21744: [OpenCL] Fix code generation of kernel pipe parameters.

2016-07-04 Thread Alexey Bader via cfe-commits
bader added a comment. Ping. Xiuli, do you have any comments? http://reviews.llvm.org/D21744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r274492 - [X86][AVX512] Converted the VPERMILPD/VPERMILPS intrinsics to generic IR

2016-07-04 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Mon Jul 4 06:06:15 2016 New Revision: 274492 URL: http://llvm.org/viewvc/llvm-project?rev=274492&view=rev Log: [X86][AVX512] Converted the VPERMILPD/VPERMILPS intrinsics to generic IR Modified: cfe/trunk/lib/Headers/avx512fintrin.h cfe/trunk/test/CodeGen/avx512f-bui

[clang-tools-extra] r274494 - [include-fixer] make HeaderMapCollector maps from regex instead of postfix.

2016-07-04 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Jul 4 06:22:35 2016 New Revision: 274494 URL: http://llvm.org/viewvc/llvm-project?rev=274494&view=rev Log: [include-fixer] make HeaderMapCollector maps from regex instead of postfix. Summary: this enables us to map a group of headers to one header name, e.g. headers from

Re: [PATCH] D21787: [include-fixer] make HeaderMapCollector maps from regex instead of postfix.

2016-07-04 Thread Eric Liu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274494: [include-fixer] make HeaderMapCollector maps from regex instead of postfix. (authored by ioeric). Changed prior to commit: http://reviews.llvm.org/D21787?vs=62656&id=62664#toc Repository: rL

Re: [PATCH] D21228: Deprecated (legacy) string literal conversion to 'char *' causes strange overloading resolution

2016-07-04 Thread Alexander Makarov via cfe-commits
a.makarov added a comment. Ping. http://reviews.llvm.org/D21228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r274495 - Fix broken build caused by r274494.

2016-07-04 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Jul 4 06:42:37 2016 New Revision: 274495 URL: http://llvm.org/viewvc/llvm-project?rev=274495&view=rev Log: Fix broken build caused by r274494. Modified: clang-tools-extra/trunk/include-fixer/find-all-symbols/HeaderMapCollector.h Modified: clang-tools-extra/trunk/in

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

2016-07-04 Thread Asiri Rathnayake via cfe-commits
rmaprath abandoned this revision. rmaprath added a comment. Reason for abandoning: This patch uses opaque pointers to delegate `std::mutex` and `std::condition_variable` types to the underlying platform implementation. This creates problems given that these two types have `constexpr` constructor

[clang-tools-extra] r274496 - [clang-tidy] Fix more enum declaration cases in misc-unused-using-decls check.

2016-07-04 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Jul 4 07:01:56 2016 New Revision: 274496 URL: http://llvm.org/viewvc/llvm-project?rev=274496&view=rev Log: [clang-tidy] Fix more enum declaration cases in misc-unused-using-decls check. Summary: Fix PR28350. Reviewers: alexfh Subscribers: aaron.ballman, Eugene.Zelenko,

Re: [PATCH] D21833: [clang-tidy] Fix more enum declaration cases in misc-unused-using-decls check.

2016-07-04 Thread Haojian Wu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274496: [clang-tidy] Fix more enum declaration cases in misc-unused-using-decls check. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D21833?vs=62354&id=62668#toc Repository:

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

2016-07-04 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Please re-generate the diff with full-context (http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface). A bunch of style comments. Comment at: clang-tidy/misc/MpiTypeMismatchCheck.cpp:86 @@ +85,3 @@ + +void MpiTypeMismatchCheck:

Re: [PATCH] D21601: Make tooling::applyAllReplacements return llvm::Expected instead of empty string to indicate potential error.

2016-07-04 Thread Eric Liu via cfe-commits
ioeric added a comment. PING http://reviews.llvm.org/D21601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2

2016-07-04 Thread Asiri Rathnayake via cfe-commits
rmaprath created this revision. rmaprath added reviewers: mclow.lists, EricWF, bcraig. rmaprath added a subscriber: cfe-commits. This is the replacement for D20328. Rather than using opaque pointer types to delegate the internal representations of mutex / condvar / thread types, in this patch we

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

2016-07-04 Thread Alexander Kornienko via cfe-commits
alexfh added inline comments. Comment at: clang-tidy/performance/InefficientStringConcatenationCheck.cpp:50 @@ +49,3 @@ + hasOverloadedOperatorName("="), hasDescendant(BasicStringPlusOperator), + allOf(hasArgument( +0, allOf(declRefExpr(BasicStringType),

Re: [PATCH] D21385: Adjust Registry interface to not require plugins to export a registry

2016-07-04 Thread John Brawn via cfe-commits
john.brawn added a comment. In http://reviews.llvm.org/D21385#473163, @Ilod wrote: > The PrintFunctionNames plugin works fine, but not the SampleAnalyzerPlugin? > The checker-plugins test fails. Argh, I hadn't noticed that the plugin tests depend on the 'plugins' feature, and lit.cfg sets tha

[PATCH] D21970: Add attribute abi_tag to the release notes

2016-07-04 Thread Dmitry Polukhin via cfe-commits
DmitryPolukhin created this revision. DmitryPolukhin added reviewers: hans, rsmith. DmitryPolukhin added a subscriber: cfe-commits. http://reviews.llvm.org/D21970 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --- d

[PATCH] D21971: Explicitly export symbols from the sample analyzer plugin

2016-07-04 Thread John Brawn via cfe-commits
john.brawn created this revision. john.brawn added reviewers: Ilod, chapuni, ehsan, reames. john.brawn added a subscriber: cfe-commits. john.brawn set the repository for this revision to rL LLVM. This is done so that it will work when built using MSVC if LLVM_EXPORT_SYMBOLS_FOR_PLUGINS=ON. Repos

Re: [PATCH] D21385: Adjust Registry interface to not require plugins to export a registry

2016-07-04 Thread John Brawn via cfe-commits
john.brawn added a comment. Created http://reviews.llvm.org/D21971 to make the sample analyzer plugin work. Repository: rL LLVM http://reviews.llvm.org/D21385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

Re: [PATCH] D21601: Make tooling::applyAllReplacements return llvm::Expected instead of empty string to indicate potential error.

2016-07-04 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D21601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang-tools-extra] r274501 - [include-fixer] reduce stack size by changing RegexHeaderMap to use const char * pair.

2016-07-04 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Jul 4 08:34:11 2016 New Revision: 274501 URL: http://llvm.org/viewvc/llvm-project?rev=274501&view=rev Log: [include-fixer] reduce stack size by changing RegexHeaderMap to use const char * pair. Modified: clang-tools-extra/trunk/include-fixer/find-all-symbols/HeaderM

r274502 - [X86][AVX512] Converted the VPERMPD/VPERMQ intrinsics to generic IR

2016-07-04 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Mon Jul 4 08:34:44 2016 New Revision: 274502 URL: http://llvm.org/viewvc/llvm-project?rev=274502&view=rev Log: [X86][AVX512] Converted the VPERMPD/VPERMQ intrinsics to generic IR Modified: cfe/trunk/lib/Headers/avx512fintrin.h cfe/trunk/lib/Headers/avx512vlintrin.h

Re: [PATCH] D21602: Changes related to tooling::applyAllReplacements interface change in D21601.

2016-07-04 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG. Nice! Comment at: include-fixer/IncludeFixer.cpp:323-324 @@ -322,1 +322,4 @@ +return CleanReplaces; + auto FormattedReplaces = formatReplacements(Code, *CleanReplaces

[PATCH] D21974: [clang-include-fixer] fix PEP8 warnings

2016-07-04 Thread Kirill Bobyrev via cfe-commits
omtcyf0 created this revision. omtcyf0 added a subscriber: cfe-commits. This fixes PEP8 E231, E225, E226, E302 warnings http://reviews.llvm.org/D21974 Files: include-fixer/tool/clang-include-fixer.py Index: include-fixer/tool/clang-include-fixer.py

[PATCH] D21973: [AVX512] add float/double abs intrinsics

2016-07-04 Thread Asaf Badouh via cfe-commits
AsafBadouh created this revision. AsafBadouh added reviewers: igorb, craig.topper, m_zuckerman, guyblank. AsafBadouh added a subscriber: cfe-commits. AsafBadouh set the repository for this revision to rL LLVM. add abs intrinsics that use native LLVM-IR. change and_epi{32|64} to use select intrinsi

Re: [PATCH] D21385: Adjust Registry interface to not require plugins to export a registry

2016-07-04 Thread John Brawn via cfe-commits
john.brawn updated this revision to Diff 62684. john.brawn added a comment. Updated to not touch the sample analyzer plugin. Repository: rL LLVM http://reviews.llvm.org/D21385 Files: cfe/trunk/examples/AnnotateFunctions/CMakeLists.txt cfe/trunk/examples/PrintFunctionNames/CMakeLists.txt

Re: [PATCH] D21602: Changes related to tooling::applyAllReplacements interface change in D21601.

2016-07-04 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 62685. ioeric marked an inline comment as done. ioeric added a comment. - Addressed reviewer's comment. http://reviews.llvm.org/D21602 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixer.h include-fixer/tool/ClangIncludeFixer.cpp unittes

Re: [PATCH] D21974: [clang-include-fixer] fix PEP8 warnings

2016-07-04 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Thanks. Do you have commit access? http://reviews.llvm.org/D21974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

r274509 - [OpenCL] Make OpenCL Builtins added according to the right version.

2016-07-04 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Mon Jul 4 11:07:18 2016 New Revision: 274509 URL: http://llvm.org/viewvc/llvm-project?rev=274509&view=rev Log: [OpenCL] Make OpenCL Builtins added according to the right version. Currently we only have OpenCL 2.0 Builtins i.e. pipes or address space conversions. They have

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

2016-07-04 Thread Alexander Droste via cfe-commits
Alexander_Droste updated this revision to Diff 62688. Alexander_Droste added a comment. Thanks for the review! This update should address the requested changes: - functions and variables are made static if possible - usage of `ArrayRef` instead of `SmallVector<..> &` - assignment init instead of

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

2016-07-04 Thread Tavian Barnes via cfe-commits
tavianator updated this revision to Diff 62691. tavianator added a comment. Added a test case for destructor ordering. Got rid of pthread_{get,set}specific in a loop. http://reviews.llvm.org/D21803 Files: cmake/config-ix.cmake src/CMakeLists.txt src/cxa_thread_atexit.cpp test/CMakeLis

Re: [PATCH] D21974: [clang-include-fixer] fix PEP8 warnings

2016-07-04 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. @bkramer I don't. Can you please land it? http://reviews.llvm.org/D21974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

2016-07-04 Thread Alexander Droste via cfe-commits
Alexander_Droste updated this revision to Diff 62694. Alexander_Droste added a comment. - remove TODO http://reviews.llvm.org/D21962 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/MpiTypeMismatchCheck.cpp clang-tidy/misc/MpiTypeMismatchCheck.h

Re: [PATCH] D14277: [Analyzer] Make referenced SymbolMetadata live even if its region is dead

2016-07-04 Thread Aleksei Sidorin via cfe-commits
a.sidorin added a comment. Gabor: Ok,will do. Repository: rL LLVM http://reviews.llvm.org/D14277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r274511 - [clang-include-fixer] fix PEP8 warnings

2016-07-04 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Jul 4 11:47:17 2016 New Revision: 274511 URL: http://llvm.org/viewvc/llvm-project?rev=274511&view=rev Log: [clang-include-fixer] fix PEP8 warnings This fixes PEP8 E231, E225, E226, E302 warnings. Patch by Kirill Bobyrev! Differential revision: http://reviews.llvm.org/D219

Re: [PATCH] D21974: [clang-include-fixer] fix PEP8 warnings

2016-07-04 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274511: [clang-include-fixer] fix PEP8 warnings (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D21974?vs=62680&id=62695#toc Repository: rL LLVM http://reviews.llvm.org/D21974 F

[PATCH] D21978: [analyzer] Add LocationContext to SymbolMetadata

2016-07-04 Thread Aleksei Sidorin via cfe-commits
a.sidorin created this revision. a.sidorin added reviewers: zaks.anna, dcoughlin. a.sidorin added a subscriber: cfe-commits. Currently, SymbolMetadata are distinguished by statement and block count. However, in case of inlining, block counts may be the same every time function is called because

Re: [PATCH] D21472: [clang-tidy] readability-identifier-naming - support for other case types

2016-07-04 Thread James Reynolds via cfe-commits
JamesReynolds added a comment. Ah, I took this from a single example in the CPP core guidelines - that PDF is indeed a very different style. An idea we toyed with was "UpperSeparated" and "UpperSeparatedBack"? Would that work? This comes from a concession to Window developers in a large commer

Re: r274110 - [AVX512] Zero extend cmp intrinsic return value.

2016-07-04 Thread Craig Topper via cfe-commits
We have to keep the autoupgrade code due to the requirement that we need to be able to load bitcode files from previous versions of llvm. Though the intrinsic autograde code is starting to become large. ~Craig On Mon, Jul 4, 2016 at 2:55 AM, Breger, Igor wrote: > Thanks for working on this! > >

r274516 - [AVX512] Remove VPERMD/VPERMQ/VPERMILPS/VPERMILPD builtins. These were made unused in r274492 and r274502.

2016-07-04 Thread Craig Topper via cfe-commits
Author: ctopper Date: Mon Jul 4 14:27:50 2016 New Revision: 274516 URL: http://llvm.org/viewvc/llvm-project?rev=274516&view=rev Log: [AVX512] Remove VPERMD/VPERMQ/VPERMILPS/VPERMILPD builtins. These were made unused in r274492 and r274502. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86

Re: [PATCH] D21329: Rename and rework `_LIBCPP_TRIVIAL_PAIR_COPY_CTOR`. Move FreeBSD configuration in-tree.

2016-07-04 Thread Dimitry Andric via cfe-commits
dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM. Eric, apologies that this took some time to review. I finally dug out my old test cases for the original problem report in FreeBSD, and re-tested them against this patch. (These test cases

r274523 - [X86][AVX512] Converted the VSHUFPD intrinsics to generic IR

2016-07-04 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Mon Jul 4 16:30:47 2016 New Revision: 274523 URL: http://llvm.org/viewvc/llvm-project?rev=274523&view=rev Log: [X86][AVX512] Converted the VSHUFPD intrinsics to generic IR Modified: cfe/trunk/lib/Headers/avx512fintrin.h cfe/trunk/lib/Headers/avx512vlintrin.h cfe

RE: r274110 - [AVX512] Zero extend cmp intrinsic return value.

2016-07-04 Thread Breger, Igor via cfe-commits
Thanks for the explanation. Regards, Igor From: Craig Topper [mailto:craig.top...@gmail.com] Sent: Monday, July 04, 2016 21:53 To: Breger, Igor Cc: Eric Christopher via cfe-commits; Demikhovsky, Elena Subject: Re: r274110 - [AVX512] Zero extend cmp intrinsic return value. We have to keep the aut

r274525 - [X86] Use undefined instead of setzero in shufflevector based intrinsics when the second source is unused. Rewrite immediate extractions in shuffle intrinsics to be in ((c >> x) & y) form in

2016-07-04 Thread Craig Topper via cfe-commits
Author: ctopper Date: Mon Jul 4 17:18:01 2016 New Revision: 274525 URL: http://llvm.org/viewvc/llvm-project?rev=274525&view=rev Log: [X86] Use undefined instead of setzero in shufflevector based intrinsics when the second source is unused. Rewrite immediate extractions in shuffle intrinsics to

Re: r274220 - AMDGPU: Set amdgpu_kernel calling convention for OpenCL kernels.

2016-07-04 Thread Tom Stellard via cfe-commits
On Thu, Jun 30, 2016 at 09:06:34AM -, Nikolay Haustov via cfe-commits wrote: > Author: nhaustov > Date: Thu Jun 30 04:06:33 2016 > New Revision: 274220 > > URL: http://llvm.org/viewvc/llvm-project?rev=274220&view=rev > Log: > AMDGPU: Set amdgpu_kernel calling convention for OpenCL kernels. >

RE: r274110 - [AVX512] Zero extend cmp intrinsic return value.

2016-07-04 Thread Demikhovsky, Elena via cfe-commits
I think that AVX-512 intrinsic handled in Clang should be removed from AutoUpgrade. If we decide to replace a call to llvm-backend intrinsic with generating LLVM IR directly from clang, we can remove llvm-backend intrinsic at all. Otherwise we’ll need to duplicate support in FE and BE for all AVX

Re: [PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

2016-07-04 Thread Alexander Kornienko via cfe-commits
alexfh added inline comments. Comment at: clang-tidy/modernize/DeprecatedHeadersCheck.cpp:99 @@ -88,3 +98,3 @@ // // 1. Insert std prefix for every such symbol occurance. // 2. Insert `using namespace std;` to the beginning of TU. nit: "occurrence" =

Re: r274110 - [AVX512] Zero extend cmp intrinsic return value.

2016-07-04 Thread Craig Topper via cfe-commits
Unfortunately the policy is such that the current version of LLVM must be able to read a bitcode or IR text file generated by any released version of LLVM/clang from 3.0 till now. This is why the AutoUpgrade.cpp file exists and it keeps growing and its only going to get worse. Hopefully with the d