Re: [cfe-commitsatlists.llvm.org: r271801 - Add PIE magic for NetBSD. Add tests for the correct flags for]

2016-06-06 Thread Richard Smith via cfe-commits
LGTM for branch. Please also merge r271893 to fix a test failure from this change. On Sun, Jun 5, 2016 at 12:29 PM, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Tom, > I'd like to merge this change for getting rid of the stupid '-pie is > nont used' warnings and to

Buildbot numbers for the last week of 5/29/2016 - 6/04/2016

2016-06-06 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the last week of 5/29/2016 - 6/04/2016. I added new statistics with a longest time each builder was red during the last week. Thanks Galina buildername| was_red ---

LLVM buildmaster will be restarted tonight

2016-06-06 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20997: [Coverage] Fix an assertion failure if the definition of an unused function spans multiple files.

2016-06-06 Thread Igor Kudrin via cfe-commits
ikudrin updated the summary for this revision. ikudrin removed rL LLVM as the repository for this revision. ikudrin updated this revision to Diff 59806. ikudrin added a comment. - Use `StartFileID` and `EndFileID` variables to eliminate redundant calls to `SM.getFileID()`. - Add comment strings t

Re: [PATCH] D20997: [Coverage] Fix an assertion failure if the definition of an unused function spans multiple files.

2016-06-06 Thread Vedant Kumar via cfe-commits
vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D20997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21047: [clang] Documentation fixes for LibASTMatchersTutorial

2016-06-06 Thread Simon Whittaker via cfe-commits
simon.f.whittaker created this revision. simon.f.whittaker added reviewers: silvas, bogner. simon.f.whittaker added a subscriber: cfe-commits. This patch fixes Bug 25583 as well as cleaning up some other problems in the LibASTMatchersTutorial. I've updated the tutorial to use: './configure.py —

r271966 - Improve Visual Studio visualization of DeclaratorDecl

2016-06-06 Thread Mike Spertus via cfe-commits
Author: mps Date: Mon Jun 6 19:27:37 2016 New Revision: 271966 URL: http://llvm.org/viewvc/llvm-project?rev=271966&view=rev Log: Improve Visual Studio visualization of DeclaratorDecl With this change, you can now expand its name and type. Modified: cfe/trunk/utils/ClangVisualizers/clang.nat

Re: [PATCH] D21047: [clang] Documentation fixes for LibASTMatchersTutorial

2016-06-06 Thread Sean Silva via cfe-commits
silvas accepted this revision. silvas added a comment. This revision is now accepted and ready to land. Overall this LGTM, but let Manuel or one of the other libTooling folks sign off. Comment at: docs/LibASTMatchersTutorial.rst:46 @@ -45,3 +45,3 @@ cd ~/clang-llvm

Re: [PATCH] D20878: [Coverage] Do not push a new region after a CXXTryStmt

2016-06-06 Thread Igor Kudrin via cfe-commits
ikudrin added a comment. I agree that it'd be expensive to put a new counter after each function call. Even if there is no `throw` statement within a TU, called functions still may raise exceptions. Anyway, if we come across a `try` statement, we can guess that some exceptions are expected and

[PATCH] D21050: [clang-tidy] correct clang-tidy-diff.py help message

2016-06-06 Thread Igor Sugak via cfe-commits
sugak created this revision. sugak added reviewers: klimek, alexfh. sugak added a subscriber: cfe-commits. Looks like the original code was copied from clang-format-diff.py. Update help message to make it clang-tidy specific. http://reviews.llvm.org/D21050 Files: clang-tidy/tool/clang-tidy-dif

Re: [PATCH] D20878: [Coverage] Do not push a new region after a CXXTryStmt

2016-06-06 Thread Vedant Kumar via cfe-commits
vsk abandoned this revision. vsk added a comment. I see your point that it isn't expensive to do a best-effort job here. I updated docs/SourceBasedCodeCoverage.rst with a limitations section as per my earlier comment. http://reviews.llvm.org/D20878 __

Re: [PATCH] D21050: [clang-tidy] correct clang-tidy-diff.py help message

2016-06-06 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: clang-tidy/tool/clang-tidy-diff.py:42 @@ -41,3 +41,3 @@ help='path to clang-tidy binary') parser.add_argument('-p', metavar='NUM', default=0, help='strip the smallest pr

Re: [PATCH] D21047: [clang] Documentation fixes for LibASTMatchersTutorial

2016-06-06 Thread Simon Whittaker via cfe-commits
simon.f.whittaker added a reviewer: klimek. simon.f.whittaker added a comment. Added Manuel Klimek at Sean's suggestion. http://reviews.llvm.org/D21047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [PATCH] D21050: [clang-tidy] correct clang-tidy-diff.py help message

2016-06-06 Thread Igor Sugak via cfe-commits
sugak added inline comments. Comment at: clang-tidy/tool/clang-tidy-diff.py:42 @@ -41,3 +41,3 @@ help='path to clang-tidy binary') parser.add_argument('-p', metavar='NUM', default=0, help='strip the smallest prefix containing P slas

r271969 - [Coverage] Fix an assertion failure if the definition of an unused function spans multiple files.

2016-06-06 Thread Igor Kudrin via cfe-commits
Author: ikudrin Date: Mon Jun 6 21:17:03 2016 New Revision: 271969 URL: http://llvm.org/viewvc/llvm-project?rev=271969&view=rev Log: [Coverage] Fix an assertion failure if the definition of an unused function spans multiple files. We have an assertion failure if, for example, the definition of

Re: [PATCH] D20997: [Coverage] Fix an assertion failure if the definition of an unused function spans multiple files.

2016-06-06 Thread Igor Kudrin via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL271969: [Coverage] Fix an assertion failure if the definition of an unused function… (authored by ikudrin). Changed prior to commit: http://reviews.llvm.org/D20997?vs=59806&id=59818#toc Repository: r

[PATCH] D21054: CodeGen: Update Clang to use the new type metadata.

2016-06-06 Thread Peter Collingbourne via cfe-commits
pcc created this revision. pcc added reviewers: mehdi_amini, kcc. pcc added a subscriber: cfe-commits. pcc added a dependency: D21053: IR: New representation for CFI and virtual call optimization pass metadata.. Herald added a subscriber: mehdi_amini. Depends on D21053 http://reviews.llvm.org/D2

r271971 - [OPENCL] Fix wrongly vla error for OpenCL array.

2016-06-06 Thread Xiuli Pan via cfe-commits
Author: pxl Date: Mon Jun 6 22:13:39 2016 New Revision: 271971 URL: http://llvm.org/viewvc/llvm-project?rev=271971&view=rev Log: [OPENCL] Fix wrongly vla error for OpenCL array. Summary: OpenCL should support array with const value size length, those const varibale in global and constant addres

Re: [PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

2016-06-06 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL271971: [OPENCL] Fix wrongly vla error for OpenCL array. (authored by pxl). Changed prior to commit: http://reviews.llvm.org/D20090?vs=58932&id=59823#toc Repository: rL LLVM http://reviews.llvm.org/

r271975 - Revert "[OPENCL] Fix wrongly vla error for OpenCL array."

2016-06-06 Thread Xiuli Pan via cfe-commits
Author: pxl Date: Mon Jun 6 22:41:07 2016 New Revision: 271975 URL: http://llvm.org/viewvc/llvm-project?rev=271975&view=rev Log: Revert "[OPENCL] Fix wrongly vla error for OpenCL array." Test case break on system-z. This reverts commit 9a7212e1e87f1396952d74f8c62314a775ccbb1c. Removed: cfe

r271976 - Revert [Coverage] Fix an assertion failure if the definition of an unused function spans multiple files.

2016-06-06 Thread Igor Kudrin via cfe-commits
Author: ikudrin Date: Mon Jun 6 23:11:51 2016 New Revision: 271976 URL: http://llvm.org/viewvc/llvm-project?rev=271976&view=rev Log: Revert [Coverage] Fix an assertion failure if the definition of an unused function spans multiple files. r271969 The test case fails on Windows. Removed: cfe

Re: [PATCH] D20997: [Coverage] Fix an assertion failure if the definition of an unused function spans multiple files.

2016-06-06 Thread NAKAMURA Takumi via cfe-commits
chapuni added a subscriber: chapuni. chapuni added a comment. FYI :) --- a/clang/test/CoverageMapping/unused_function.cpp +++ b/clang/test/CoverageMapping/unused_function.cpp @@ -3,34 +3,34 @@ #define START_SCOPE { #define END_SCOPE } -// CHECK: _Z2f0v: +// CHECK: {{_Z2f0v|\?f0

r271977 - [analyzer] Reapply r271907 (2nd try).

2016-06-06 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Mon Jun 6 23:23:08 2016 New Revision: 271977 URL: http://llvm.org/viewvc/llvm-project?rev=271977&view=rev Log: [analyzer] Reapply r271907 (2nd try). Second try at reapplying "[analyzer] Add checker for correct usage of MPI API in C and C++." Special thanks to Dan Liew fo

r271978 - [OPENCL] Fix wrongly vla error for OpenCL array.

2016-06-06 Thread Xiuli Pan via cfe-commits
Author: pxl Date: Mon Jun 6 23:34:00 2016 New Revision: 271978 URL: http://llvm.org/viewvc/llvm-project?rev=271978&view=rev Log: [OPENCL] Fix wrongly vla error for OpenCL array. Summary: OpenCL should support array with const value size length, those const varibale in global and constant address

r271981 - [analyzer] Speculative fix for r271907.

2016-06-06 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Mon Jun 6 23:44:52 2016 New Revision: 271981 URL: http://llvm.org/viewvc/llvm-project?rev=271981&view=rev Log: [analyzer] Speculative fix for r271907. Fix a compilation error on the bots involving brace initialization. Differential Revision: http://reviews.llvm.org/D1276

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

2016-06-06 Thread Devin Coughlin via cfe-commits
dcoughlin added a comment. Fixed the compilation issues with gcc in r271977 r271981, but it is still failing with Address Sanitizer diagnostics: 18751==ERROR: AddressSanitizer: stack-use-after-return on address 0x7f0c695ebc70 at pc 0x0867b44c bp 0x7ffe3b01d6f0 sp 0x7ffe3b01d6e8

r271984 - Revert "[analyzer] Reapply r271907 (2nd try)."

2016-06-06 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Tue Jun 7 00:37:02 2016 New Revision: 271984 URL: http://llvm.org/viewvc/llvm-project?rev=271984&view=rev Log: Revert "[analyzer] Reapply r271907 (2nd try)." Even with the fix in r271981, ASan is finding a stack use after return. This reverts commits r271977 and r271981.

<    1   2