silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.

Overall this LGTM, but let Manuel or one of the other libTooling folks sign off.


================
Comment at: docs/LibASTMatchersTutorial.rst:46
@@ -45,3 +45,3 @@
 
       cd ~/clang-llvm
       git clone git://cmake.org/stage/cmake.git
----------------
This part is a bit out of date. Ninja is pretty easy to obtain (e.g. from its 
releases page on github) and CMake has had Ninja support built-in for a while 
now.

I guess this change doesn't hurt, but (probably in a separate patch) you may 
want to revamp this whole section on ninja and cmake.


http://reviews.llvm.org/D21047



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to