Any ideas what's going on?
On Wed, May 25, 2016 at 1:35 PM, Ismail Donmez wrote:
> Hi,
>
> On Wed, May 25, 2016 at 1:32 PM, Simon Atanasyan wrote:
>> Hi,
>>
>> Thanks for the information. One more question. Does the following folder
>> exist?
>>
>> /home/abuild/rpmbuild/BUILD/llvm/tools/clang/t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270825: [Clang][AVX512][BUILTIN] Adding intrinsics for set1
(authored by mzuckerm).
Changed prior to commit:
http://reviews.llvm.org/D20562?vs=58213&id=58574#toc
Repository:
rL LLVM
http://reviews.l
Author: mzuckerm
Date: Thu May 26 01:54:52 2016
New Revision: 270825
URL: http://llvm.org/viewvc/llvm-project?rev=270825&view=rev
Log:
[Clang][AVX512][BUILTIN] Adding intrinsics for set1
Differential Revision: http://reviews.llvm.org/D20562
Modified:
cfe/trunk/lib/Headers/avx512fintrin.h
I'm trying to reproduce the problem but without success yet. And all
buildbots available to me are green. So no ideas right now.
By the way, as far as I can see you use some sort of build system
probably to get rpm package. Right? Could you try to build Clang by
hand (http://clang.llvm.org/get_sta
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added a subscriber: cfe-commits.
We should check whether a UsingDecl is defined in macros or in class
definition, not TargetDecls of the UsingDecl.
http://reviews.llvm.org/D20666
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.
hokein added inline comments.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:47
@@ +46,3 @@
+ return;
+// Ignores using-declarations defined in function definitions to avoid
+// arguement-dependent lookup.
alexfh wrote:
> hokein wrote:
> > alex
Hi Alexey,
I don't really know whether this is correct. IMO this may only be set once
OpenMP 4.5 is fully supported.
This currently isn't even the case for OpenMP 4.0 as at least support for
#pragma omp target update has not yet been committed.
In my understanding the macro may be used for feat
Hi,
I thought about this. Will it be good for you if I add and option
'-fopenmp-version=[31|40|45]', which will allow you to choose the
supported version? For now it will just modify the value of _OPENMP,
later support can be extended for better compatibility.
Best regards,
Alexey Bataev
=
Hi,
I think this is because I enable libc++ by default with
-DLLVM_ENABLE_LIBCXX=ON , so this tests need an explicit
-stdlib=libstdc++
ismail
On Thu, May 26, 2016 at 10:08 AM, Simon Atanasyan wrote:
> I'm trying to reproduce the problem but without success yet. And all
> buildbots available to
Hi Alexey,
If this defaults to the currently completely supported version (I think 4.0
when target update gets committed), that would be great. That way, the user
would have to explicitly request the newer (and possibly incomplete) version.
Greetings,
Jonas
> -Original Message-
> From:
ismail added a subscriber: ismail.
ismail added a comment.
Richard,
Does this mean this feature will never be accepted? It would help to make a
clear statement on this issue. I am not happy how this feature is introduced
but it's too late now that every big Linux distro out there switched to th
Author: mzuckerm
Date: Thu May 26 03:10:12 2016
New Revision: 270830
URL: http://llvm.org/viewvc/llvm-project?rev=270830&view=rev
Log:
Fix instrinsics names:
_mm128_cmp_ps_mask-->_mm_cmp_ps_mask
_mm128_mask_cmp_ps_mask-->_mm_mask_cmp_ps_mask
_mm128_cmp_pd_mask-->_mm_cmp_pd_mask
_mm128_mask_cmp_pd
Hi,
Have you also set CLANG_DEFAULT_CXX_STDLIB? Then you may need to add an
'-stdlib=platform' to the test... (see r260662 and r263434)
Cheers,
Jonas
> -Original Message-
> From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf
> Of Ismail Donmez via cfe-commits
> Sent:
Sounds reasonable. I will check this idea and fix the tests accordingly.
On May 26, 2016 11:03 AM, "Ismail Donmez" wrote:
> Hi,
>
> I think this is because I enable libc++ by default with
> -DLLVM_ENABLE_LIBCXX=ON , so this tests need an explicit
> -stdlib=libstdc++
>
> ismail
>
>
> On Thu, May 2
Ok, will default it to 3.1 for now.
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
26.05.2016 11:09, Hahnfeld, Jonas пишет:
> Hi Alexey,
>
> If this defaults to the currently completely supported version (I think 4.0
> when target update gets committed), that wou
Indeed the problematic option is -DCLANG_DEFAULT_CXX_STDLIB=libc++ ,
thanks Jonas!
On Thu, May 26, 2016 at 11:19 AM, Hahnfeld, Jonas
wrote:
> Hi,
>
> Have you also set CLANG_DEFAULT_CXX_STDLIB? Then you may need to add an
> '-stdlib=platform' to the test... (see r260662 and r263434)
>
> Cheers,
>
andreybokhanko marked 3 inline comments as done.
Comment at: lib/Sema/SemaExprCXX.cpp:937
@@ -936,2 +936,3 @@
+ CXXThisTypeQuals &= Qualifiers::FastMask;
S.CXXThisTypeOverride
majnemer wrote:
> Can you add a comment for this line.
Done.
Thank you for th
Author: rksimon
Date: Thu May 26 04:56:50 2016
New Revision: 270833
URL: http://llvm.org/viewvc/llvm-project?rev=270833&view=rev
Log:
[X86][AVX2] Improved checks for float/double mask generation for non-masked
gathers
Modified:
cfe/trunk/test/CodeGen/avx2-builtins.c
Modified: cfe/trunk/test
Author: asbokhan
Date: Thu May 26 05:06:01 2016
New Revision: 270834
URL: http://llvm.org/viewvc/llvm-project?rev=270834&view=rev
Log:
[MSVC] Support for __unaligned qualifier in functions
This implements support for MS-specific __unaligned qualifier in functions and
makes the following test case
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270834: [MSVC] Support for __unaligned qualifier in
functions (authored by asbokhan).
Changed prior to commit:
http://reviews.llvm.org/D20437?vs=57907&id=58585#toc
Repository:
rL LLVM
http://reviews
This is now fixed in rL270834.
Yours,
Andrey
On Thu, May 19, 2016 at 6:34 PM, Andrey Bokhanko
wrote:
> David,
>
> All these cases are handled properly now.
>
> Could you, please, review?
>
> http://reviews.llvm.org/D20437
>
> Yours,
> Andrey
>
>
> On Sat, May 14, 2016 at 6:11 AM, David Majneme
Author: rksimon
Date: Thu May 26 05:20:25 2016
New Revision: 270836
URL: http://llvm.org/viewvc/llvm-project?rev=270836&view=rev
Log:
[X86][F16C] Improved f16c intrinsics checks
Added checks for upper elements being zero'd in scalar conversions
Modified:
cfe/trunk/test/CodeGen/f16c-builtins
ismail created this revision.
ismail added reviewers: hans, rnk.
ismail added a subscriber: cfe-commits.
ismail set the repository for this revision to rL LLVM.
Since some time clang itself figures out the default for
ms-compatibility-version and uses it. Trying to figure it out during build is
bunty2020 added a comment.
Clang's help shows the following description:
**-mllvm Additional arguments to forward to LLVM's option
processing**
If -mllvm sets some internal option for cc1 then its strange for
front-end parser using some option which is supposed to be LLVM's option.
jackpoz added a subscriber: jackpoz.
jackpoz added a comment.
In http://reviews.llvm.org/D18035#440107, @rsmith wrote:
> Please try to appropriately apportion the responsibility here
It has always been clear who created the issue, GCC ABI 11 are there to stay,
with the result of having an unus
ttanner added a comment.
In http://reviews.llvm.org/D18035#440107, @rsmith wrote:
> No, they'll be shipping with a broken copy of their C++ standard library, and
> will fail to conform to the Linux Standards Base specifications due to
> deviating from the Itanium C++ ABI. This patch is working
Author: abataev
Date: Thu May 26 06:10:11 2016
New Revision: 270838
URL: http://llvm.org/viewvc/llvm-project?rev=270838&view=rev
Log:
[OPENMP] Add option '-fopenmp-version=[31|40|45]' allowing choosing
OpenMP version.
If '-fopenmp' option is provided '-fopenmp-version=' allows to control,
which v
Author: chapuni
Date: Thu May 26 06:20:54 2016
New Revision: 270841
URL: http://llvm.org/viewvc/llvm-project?rev=270841&view=rev
Log:
clang-tools-extra/test/clang-tidy/cppcoreguidelines-pro-type-vararg.cpp: Tweak
for r270775.
Modified:
clang-tools-extra/trunk/test/clang-tidy/cppcoreguidelin
Author: atanasyan
Date: Thu May 26 06:32:19 2016
New Revision: 270842
URL: http://llvm.org/viewvc/llvm-project?rev=270842&view=rev
Log:
[driver][mips] Specify stdlib used in the tests explicitly
That allows to pass the tests even if default stdlib is not libstdc++.
Modified:
cfe/trunk/test/D
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM (when Sanjoy's patch goes in), with two minor nits.
Can you also add a test that the attribute fails on one of the target
architectures Windows does not support?
=
aaron.ballman added a comment.
In http://reviews.llvm.org/D20366#433204, @hokein wrote:
> In http://reviews.llvm.org/D20366#433123, @aaron.ballman wrote:
>
> > What's the harm in leaving the props at 0644?
>
>
> Just inconvenient . And I see the `dump_format_style.py` in the same
> directory is
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a comment.
Thank you for working on this diagnostic! A few questions and comments below.
Comment at: lib/Sema/SemaExpr.cpp:10518
@@ +10517,3 @@
+ // Taking the address of a data member/field of a packed
+ //
aturetsk added inline comments.
Comment at: lib/Driver/Tools.cpp:3657
@@ +3656,3 @@
+ if (IsIAMCU && types::isCXX(Input.getType()))
+D.Diag(diag::err_drv_cxx_not_supported) <<
getToolChain().getTriple().str();
+
bruno wrote:
> Taking a look at this again I d
aturetsk created this revision.
aturetsk added reviewers: rsmith, bruno.
aturetsk added subscribers: cfe-commits, zinovy.nis, DavidKreitzer.
Herald added subscribers: srhines, danalbert, tberghammer.
This is the last patch required to support compilation for Intel MCU target
(e.g. Intel(R) Quark(
I hope r270842 fixes the problem.
Thanks a lot for your help.
On Thu, May 26, 2016 at 11:28 AM, Ismail Donmez wrote:
> Indeed the problematic option is -DCLANG_DEFAULT_CXX_STDLIB=libc++ ,
> thanks Jonas!
>
> On Thu, May 26, 2016 at 11:19 AM, Hahnfeld, Jonas
> wrote:
>> Hi,
>>
>> Have you also s
Author: ogoffart
Date: Thu May 26 07:55:34 2016
New Revision: 270845
URL: http://llvm.org/viewvc/llvm-project?rev=270845&view=rev
Log:
Fix crash while parsing variable template with variadic template arguments
It is only a crash if the compiler optimize for this!=nullptr because
LocalInstantiatio
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270845: Fix crash while parsing variable template with
variadic template arguments (authored by ogoffart).
Changed prior to commit:
http://reviews.llvm.org/D20511?vs=58043&id=58595#toc
Repository:
rL
rmaprath created this revision.
rmaprath added reviewers: bcraig, jroelofs, EricWF.
rmaprath added a subscriber: cfe-commits.
Support for building a -fno-exceptions libc++ variant was reinstated recently.
However, some of the standard library functions like `std::terminate()` are
currently sprea
Could you take a look of r270841 in clang-tools-extra?
On Thu, May 26, 2016 at 7:14 AM Hal Finkel via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: hfinkel
> Date: Wed May 25 17:08:27 2016
> New Revision: 270775
>
> URL: http://llvm.org/viewvc/llvm-project?rev=270775&view=rev
> Log:
On Thu, May 26, 2016 at 12:41 AM, David Majnemer
wrote:
> In http://reviews.llvm.org/D18035#434095, @DmitryPolukhin wrote:
>
> > One more friendly ping.. :(
>
> I think the best way to make progress on this is to refactor this patch
> along the lines @rsmith suggested back on May 3.
>
To be
dsanders created this revision.
dsanders added subscribers: cfe-commits, atanasyan.
Herald added subscribers: dschuff, jfb.
This unifies mips/mipsel and mips64/mips64el into a single class so that we can
later support O32 on mips64/mips64el and N32/N64 on mips/mipsel (when an
appropriate CPU selec
Anastasia added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:1587-1589
@@ -1579,3 +1586,4 @@
+.Case("cl", LangStandard::lang_opencl)
.Case("CL1.1", LangStandard::lang_opencl11)
.Case("CL1.2", LangStandard::lang_opencl12)
.Case("CL2.0", LangSt
aaron.ballman added a comment.
http://reviews.llvm.org/D18575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added inline comments.
Comment at: CMakeLists.txt:359
@@ -350,2 +358,3 @@
else()
- add_subdirectory(test)
+ # libc++abi tests are mostly exceptions related. The only reason we want to
+ # build libc++abi without exceptions is to support the -fno-exceptions libc++
--
atanasyan added inline comments.
Comment at: lib/Basic/Targets.cpp:6986
@@ +6985,3 @@
+ : TargetInfo(Triple), CPU((getTriple().getArch() == llvm::Triple::mips ||
+ getTriple().getArch() == llvm::Triple::mipsel)
+
Author: seaneveson
Date: Thu May 26 09:02:17 2016
New Revision: 270849
URL: http://llvm.org/viewvc/llvm-project?rev=270849&view=rev
Log:
[Analyzer] Correct stack address escape diagnostic
Summary:
Leaking a stack address via a static variable refers to it in the diagnostic as
a 'global'. This pa
dsanders created this revision.
dsanders added subscribers: cfe-commits, atanasyan.
dsanders added a dependency: D20678: [mips] Fold MipsTargetInfoBase subclasses
into MipsTargetInfoBase and rename to MipsTargetInfo. NFC.
There are no clang or llvm* tests for EABI and no EABI buildbots.
*There i
bcraig added a comment.
So I definitely see a problem, and I think your fix is a reasonable solution to
that problem. I'm still unclear on how that caused the ASAN error though.
Here's my understanding of the current problem...
The initial buffer for strstreambuf is often 4096 ( _strstream>
atanasyan accepted this revision.
atanasyan added a reviewer: atanasyan.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
Tools.cpp contains the following code. We need to remove `eabi` here too.
if (CPUName.empty()) {
// Deduce CPU name from ABI name.
C
dsanders created this revision.
dsanders added subscribers: cfe-commits, atanasyan.
dsanders added a dependency: D20679: [mips] Kill 'support' for untested EABI..
Depends on D20679
http://reviews.llvm.org/D20680
Files:
lib/Basic/Targets.cpp
Index: lib/Basic/Targets.cpp
===
seaneveson added a subscriber: seaneveson.
seaneveson closed this revision.
seaneveson added a comment.
Committed: http://reviews.llvm.org/rL270849
http://reviews.llvm.org/D19866
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
cameron314 added a comment.
Thanks @bruno, I'll have a look at using a VFS for the test.
Comment at: lib/Basic/FileManager.cpp:389
@@ -383,2 +388,3 @@
UFE->File.reset();
+ UFE->IsVirtual = true;
return UFE;
rsmith wrote:
> Rather than adding this `IsVirtu
atanasyan accepted this revision.
atanasyan added a reviewer: atanasyan.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20680
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
yaxunl created this revision.
yaxunl added reviewers: rsmith, Anastasia.
yaxunl added subscribers: cfe-commits, tstellarAMD.
Sometimes a backend needs to apply certain target-specific passes before
linking. This patch attempts to add that.
It depends on a new virtual member function addPreLinkPa
flx added a comment.
This is ready for review again.
http://reviews.llvm.org/D20277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mzuckerm
Date: Thu May 26 09:32:11 2016
New Revision: 270851
URL: http://llvm.org/viewvc/llvm-project?rev=270851&view=rev
Log:
Adding missing _mm512_castsi512_si256 intrinsic.
Modified:
cfe/trunk/lib/Headers/avx512fintrin.h
cfe/trunk/test/CodeGen/avx512f-builtins.c
Modified: c
mprobst marked 2 inline comments as done.
Comment at: lib/Format/TokenAnnotator.cpp:698
@@ +697,3 @@
+
+if (Style.Language == FormatStyle::LK_JavaScript) {
+ // JavaScript files can contain shebang lines of the form:
alexeagle wrote:
> should we still res
dsanders added inline comments.
Comment at: lib/Basic/Targets.cpp:6986
@@ +6985,3 @@
+ : TargetInfo(Triple), CPU((getTriple().getArch() == llvm::Triple::mips ||
+ getTriple().getArch() == llvm::Triple::mipsel)
+
mprobst updated this revision to Diff 58612.
mprobst marked an inline comment as done.
mprobst added a comment.
revert FormatTokenLexer, restrict to first token
http://reviews.llvm.org/D20632
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
atanasyan accepted this revision.
atanasyan added a reviewer: atanasyan.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Basic/Targets.cpp:6986
@@ +6985,3 @@
+ : TargetInfo(Triple), CPU((getTriple().getArch() == llvm::Triple:
flx added a comment.
Friendly ping.
http://reviews.llvm.org/D20010
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: majnemer.
DmitryPolukhin added subscribers: cfe-commits, rnk.
It seems that suffix '@4HA' was omitted for unknown reason. It is non-const
non-volatile 'int' type of normal variable TSS.
http://reviews.llvm.org/D20683
Files:
DmitryPolukhin abandoned this revision.
DmitryPolukhin added a comment.
It seems that there is no interest in this patch, abandon.
http://reviews.llvm.org/D18641
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
Anastasia added a subscriber: Anastasia.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7900
@@ -7897,1 +7899,3 @@
+def ext_opencl_ext_vector_type_rgba_selector: ExtWarn<
+ "vector component name '%0' is an OpenCL 2.2 extension">;
} // end of sema category
--
tstellarAMD added a comment.
Can you give some examples of what pre-link passes may be required?
http://reviews.llvm.org/D20681
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rogfer01 marked 4 inline comments as done.
Comment at: lib/Sema/SemaExpr.cpp:10527
@@ +10526,3 @@
+ME->getMemberDecl()->hasAttr()) {
+ Diag(OpLoc, diag::warn_taking_address_of_packed_member)
+ << ME->getMemberDecl() << RD;
aaron.ballman wrote
Hi,
I think this commit may have caused the failure in
http://lab.llvm.org:8011/builders/clang-cmake-mips/builds/13743. Could you
check? Buildbot will have supressed the usual email because the previous build
failed (for a different reason).
> -Original Message-
> From: cfe-commits [ma
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm if it works :-)
Repository:
rL LLVM
http://reviews.llvm.org/D20672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
It does, thanks!
On Thu, May 26, 2016 at 3:35 PM, Simon Atanasyan wrote:
> I hope r270842 fixes the problem.
>
> Thanks a lot for your help.
>
> On Thu, May 26, 2016 at 11:28 AM, Ismail Donmez wrote:
>> Indeed the problematic option is -DCLANG_DEFAULT_CXX_STDLIB=libc++ ,
>> thanks Jonas!
>>
>> O
rogfer01 added a comment.
Firefox build has ended and exposes 62 diagnostics, 44 unique ocurrences and 10
different diagnostics (shown below) in networking code.
taking address of packed member 'address' of class or structure
'sctp_state_cookie' may result in an unaligned pointer value
taki
ldionne updated this revision to Diff 58619.
ldionne added a comment.
Rebase the patch on top of the current `master`. The patch passes all of
Clang's tests (`make check-clang`). I also removed the TODO comment about
diagnostics, since that was answered by Richard Smith.
http://reviews.llvm.or
rmaprath updated this revision to Diff 58620.
http://reviews.llvm.org/D20677
Files:
CMakeLists.txt
src/cxa_aux_runtime.cpp
src/cxa_handlers.cpp
src/cxa_new_delete.cpp
src/cxa_personality.cpp
test/CMakeLists.txt
test/backtrace_test.pass.cpp
test/catch_array_01.pass.cpp
test/catch
+ Brian
-Original Message-
From: Tom Stellard [mailto:thomas.stell...@amd.com]
Sent: Thursday, May 26, 2016 11:11 AM
To: Liu, Yaxun (Sam) ; rich...@metafoo.co.uk;
anastasia.stul...@arm.com
Cc: Stellard, Thomas ; cfe-commits@lists.llvm.org
Subject: Re: [PATCH] D20681: Add target-specific
rmaprath marked 2 inline comments as done.
Comment at: src/cxa_aux_runtime.cpp:19-20
@@ -18,3 +18,4 @@
extern "C" {
_LIBCXXABI_FUNC_VIS LIBCXXABI_NORETURN void __cxa_bad_cast(void) {
+#ifndef _LIBCXXABI_NO_EXCEPTIONS
throw std::bad_cast();
I'm not very famili
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270860: Since some time clang itself figures out the default
for ms-compatibility… (authored by ismail).
Changed prior to commit:
http://reviews.llvm.org/D20672?vs=58586&id=58623#toc
Repository:
rL L
RKSimon created this revision.
RKSimon added reviewers: mkuper, craig.topper, spatel, andreadb.
RKSimon added a subscriber: cfe-commits.
RKSimon set the repository for this revision to rL LLVM.
The VPMOVSX and (V)PMOVZX sign/zero extension intrinsics can be safely
represented as generic __builtin
bcraig added inline comments.
Comment at: src/cxa_aux_runtime.cpp:19-24
@@ -18,4 +18,8 @@
extern "C" {
_LIBCXXABI_FUNC_VIS LIBCXXABI_NORETURN void __cxa_bad_cast(void) {
+#ifndef _LIBCXXABI_NO_EXCEPTIONS
throw std::bad_cast();
+#else
+ std::terminate();
+#endif
}
--
hintonda created this revision.
hintonda added a reviewer: aaron.ballman.
hintonda added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Update hasDynamicExceptionSpec to use functionType instead of
functionDecl.
http://reviews.llvm.org/D20687
Files:
docs/LibASTMatchersReference.
rmaprath marked an inline comment as done.
Comment at: src/cxa_aux_runtime.cpp:19-25
@@ -18,5 +18,9 @@
extern "C" {
_LIBCXXABI_FUNC_VIS LIBCXXABI_NORETURN void __cxa_bad_cast(void) {
+#ifndef _LIBCXXABI_NO_EXCEPTIONS
throw std::bad_cast();
+#else
+ std::terminate();
+#endif
jroelofs added a comment.
This is the canonical reference for the Itanium ABI:
https://mentorembedded.github.io/cxx-abi/abi.html
http://reviews.llvm.org/D20677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: sfantao
Date: Thu May 26 11:48:10 2016
New Revision: 270868
URL: http://llvm.org/viewvc/llvm-project?rev=270868&view=rev
Log:
[OpenMP] Adjust map type bits according to latest spec and use zero size array
sections for pointers.
Summary: This patch changes the bits used to specify the map
rmaprath added a comment.
In http://reviews.llvm.org/D20677#441061, @jroelofs wrote:
> This is the canonical reference for the Itanium ABI:
> https://mentorembedded.github.io/cxx-abi/abi.html
I was indeed looking at this, but couldn't find those exact function signatures
(or something that lo
Author: sfantao
Date: Thu May 26 11:53:38 2016
New Revision: 270870
URL: http://llvm.org/viewvc/llvm-project?rev=270870&view=rev
Log:
[OpenMP] Add support for the 'private pointer' flag to signal variables
captured in target regions and used in first-private clauses.
Summary: If a variable is im
NO_REMOVE seems like a strange way of saying it - is there existing
precedent for that naming/description? (rather than something like
_LIBCPP_PROVIDE_AUTOPTR ?
As for tests - XFAILing seems a bit general when there's really not much
value in running any of the tests anyway. REQUIRES, perhaps? (th
Author: sfantao
Date: Thu May 26 12:30:50 2016
New Revision: 270878
URL: http://llvm.org/viewvc/llvm-project?rev=270878&view=rev
Log:
[OpenMP] Parsing and sema support for target update directive
Summary:
This patch is to add parsing and sema support for `target update` directive.
Support for th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270878: [OpenMP] Parsing and sema support for target update
directive (authored by sfantao).
Changed prior to commit:
http://reviews.llvm.org/D15944?vs=58469&id=58647#toc
Repository:
rL LLVM
http://
sfantao updated this revision to Diff 58651.
sfantao added a comment.
- Mark MappableVarListInfo as final.
http://reviews.llvm.org/D18597
Files:
include/clang/AST/OpenMPClause.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basic/OpenMP
varjujan created this revision.
varjujan added a reviewer: alexfh.
varjujan added subscribers: xazax.hun, cfe-commits.
This checker finds those function calls where the function arguments are
provided in an incorrect order. It compares the name of the given variable to
the argument name in the f
Author: sfantao
Date: Thu May 26 12:39:58 2016
New Revision: 270880
URL: http://llvm.org/viewvc/llvm-project?rev=270880&view=rev
Log:
[OpenMP] Parsing and sema support for the to clause
Summary:
The patch contains the parsing and sema support for the `to` clause.
Patch based on the original pos
Author: sfantao
Date: Thu May 26 12:49:04 2016
New Revision: 270882
URL: http://llvm.org/viewvc/llvm-project?rev=270882&view=rev
Log:
[OpenMP] Parsing and sema support for the from clause
Summary:
The patch contains the parsing and sema support for the `from` clause.
Patch based on the original
hintonda created this revision.
hintonda added reviewers: alexfh, aaron.ballman.
hintonda added subscribers: etienneb, Eugene.Zelenko, cfe-commits.
[clang-tidy] New checker to replace dynamic exception
specifications
This is an alternative to D18575 which relied on reparsing the decl to
find the
pirama added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7900
@@ -7897,1 +7899,3 @@
+def ext_opencl_ext_vector_type_rgba_selector: ExtWarn<
+ "vector component name '%0' is an OpenCL 2.2 extension">;
} // end of sema category
Anastasi
hintonda added a comment.
Please see http://reviews.llvm.org/D20693 for an alternative approach.
http://reviews.llvm.org/D18575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, agreed, looks like an oversight.
http://reviews.llvm.org/D20683
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
+Jeff
To cite some of the previous discussions
(http://lists.llvm.org/pipermail/cfe-dev/2016-May/048822.html )
Brian:
On our side, we use such pre-link passes to interface with the specifics of our
built-in function library. For example, we transform printf calls into a form
that interacts w
bruno added inline comments.
Comment at: lib/Driver/Tools.cpp:3657
@@ +3656,3 @@
+ if (IsIAMCU && types::isCXX(Input.getType()))
+D.Diag(diag::err_drv_cxx_not_supported) <<
getToolChain().getTriple().str();
+
aturetsk wrote:
> bruno wrote:
> > Taking a look
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
bruno added a comment.
Ping!
http://reviews.llvm.org/D20404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Ping!
http://reviews.llvm.org/D20451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao updated this revision to Diff 58658.
sfantao added a comment.
- Adapt target update tests bits to reflect latest changes in the trunk.
http://reviews.llvm.org/D20650
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/tar
1 - 100 of 152 matches
Mail list logo
