Re: [PATCH] D19815: Support '#pragma once' in headers when using PCH

wristow added a comment. In http://reviews.llvm.org/D19815#428705, @rsmith wrote: > Rather than threading through a new flag, can you test the existing `TUKind` > field? Yes, that does seem to do the trick. I'll do some testing on it, but with that approach, it should be a simple one-line ch

Re: [PATCH] D20216: clang-rename: check that the source location we find actually has the old name

klimek added inline comments. Comment at: clang-rename/USRLocFinder.cpp:37 @@ -35,3 +36,3 @@ public: - explicit USRLocFindingASTVisitor(const std::string USR) : USR(USR) { + explicit USRLocFindingASTVisitor(const std::string USR, const std::string &PrevName) : USR(USR), PrevNa

Re: [PATCH] D20216: clang-rename: check that the source location we find actually has the old name

vmiklos added inline comments. Comment at: clang-rename/USRLocFinder.cpp:75 @@ +74,3 @@ + StringRef TokenName = Lexer::getSourceText(CharSourceRange::getTokenRange(Range), Context.getSourceManager(), Context.getLangOpts()); + if (TokenName.startswith(PrevName))

Re: [PATCH] D20216: clang-rename: check that the source location we find actually has the old name

klimek added inline comments. Comment at: clang-rename/USRLocFinder.cpp:75 @@ +74,3 @@ + StringRef TokenName = Lexer::getSourceText(CharSourceRange::getTokenRange(Range), Context.getSourceManager(), Context.getLangOpts()); + if (TokenName.startswith(PrevName))

Re: [PATCH] D20198: clang-format: [JS] sort ES6 imports.

mprobst updated this revision to Diff 57138. mprobst added a comment. - extract TokenAnalyzer.h and SortJavaScriptImports.h/cpp - clean up imports/ - includes - address review comments - pull out implementations from header files. - support side effect imports, keep in relative order at top. htt

Re: [PATCH] D17981: [clang-tidy] Fix clang-tidy to support parsing of assembly statements.

klimek added a comment. We had problems with binary size in multiple places. Overall, I think if we care about binary size we should try to make binary size smaller at a higher level (perhaps by hiding visibility of symbols by default; not sure how much that would affect the exe's though). Unti

Re: [PATCH] D20216: clang-rename: check that the source location we find actually has the old name

vmiklos updated this revision to Diff 57140. vmiklos added a comment. Got rid of startswith() and now using StringRef everywhere instead of a mix of std::string, const std::string and const std::string&. http://reviews.llvm.org/D20216 Files: clang-rename/RenamingAction.cpp clang-rename/USR

Re: [PATCH] D19804: Make clang-format cleaner remove redundant commas in list and redundant colon in constructor initializer.

ioeric added inline comments. Comment at: lib/Format/Format.cpp:1822 @@ +1821,3 @@ +cleanupRight(Line->First, Line->Last, tok::comma, tok::comma); +checkConstructorInitList(*Line); + } djasper wrote: > You could turn this into: > > for (a

Re: [PATCH] D20216: clang-rename: check that the source location we find actually has the old name

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Comment at: clang-rename/USRLocFinder.cpp:126-128 @@ -118,3 +125,5 @@ // All the locations of the USR were found. - const std::string USR; + StringRef USR; + // Old n

Re: [PATCH] D19804: Make clang-format cleaner remove redundant commas in list and redundant colon in constructor initializer.

ioeric added inline comments. Comment at: lib/Format/Format.cpp:1822 @@ +1821,3 @@ +cleanupRight(Line->First, Line->Last, tok::comma, tok::comma); +checkConstructorInitList(*Line); + } ioeric wrote: > djasper wrote: > > You could turn this int

r269400 - [ms][dll] #27212: Generating of implicit special members should take into account MSVC compatibility version

Author: dpolukhin Date: Fri May 13 04:03:56 2016 New Revision: 269400 URL: http://llvm.org/viewvc/llvm-project?rev=269400&view=rev Log: [ms][dll] #27212: Generating of implicit special members should take into account MSVC compatibility version Clang creates implicit move constructor/assign oper

Re: [PATCH] D19156: [ms][dll] #27212: Generating of implicit special members should take into account MSVC compatibility version

DmitryPolukhin closed this revision. DmitryPolukhin added a comment. Committed as http://reviews.llvm.org/rL269400 http://reviews.llvm.org/D19156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [PATCH] D20205: [include-fixer] Use scope contexts information to improve query.

hokein updated this revision to Diff 57142. hokein added a comment. Improvement and use unittest. http://reviews.llvm.org/D20205 Files: include-fixer/IncludeFixer.cpp include-fixer/XrefsDBManager.cpp unittests/include-fixer/IncludeFixerTest.cpp Index: unittests/include-fixer/IncludeFixer

Re: [PATCH] D20203: [find-all-symbols] Add enum type support.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269401: [find-all-symbols] Add enum type support. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20203?vs=57021&id=57143#toc Repository: rL LLVM http://reviews.llvm.org/D202

[clang-tools-extra] r269401 - [find-all-symbols] Add enum type support.

Author: hokein Date: Fri May 13 04:15:37 2016 New Revision: 269401 URL: http://llvm.org/viewvc/llvm-project?rev=269401&view=rev Log: [find-all-symbols] Add enum type support. Summary: Also change enums defined in SymbolInfo to scoped enums to avoid conflicts. Reviewers: bkramer Subscribers: cfe

[clang-tools-extra] r269402 - clang-rename: check that the source location we find actually has the old name

Author: vmiklos Date: Fri May 13 04:17:32 2016 New Revision: 269402 URL: http://llvm.org/viewvc/llvm-project?rev=269402&view=rev Log: clang-rename: check that the source location we find actually has the old name This more general check could have prevented the specific problem "getSourceOrder()

Re: [PATCH] D20216: clang-rename: check that the source location we find actually has the old name

This revision was automatically updated to reflect the committed changes. Closed by commit rL269402: clang-rename: check that the source location we find actually has the old name (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D20216?vs=57140&id=57144#toc Repository:

[clang-tools-extra] r269403 - [include-fixer] Rename XrefsDB to SymbolIndex.

Author: d0k Date: Fri May 13 04:27:54 2016 New Revision: 269403 URL: http://llvm.org/viewvc/llvm-project?rev=269403&view=rev Log: [include-fixer] Rename XrefsDB to SymbolIndex. It's not really containing xrefs so the name didn't fit. No functional change. Added: clang-tools-extra/trunk/inclu

Re: [PATCH] D19804: Make clang-format cleaner remove redundant commas in list and redundant colon in constructor initializer.

ioeric updated this revision to Diff 57145. ioeric marked 4 inline comments as done. ioeric added a comment. - Use reviewer's awesome templates for checkPair(). - Remove checkConstructorInitList(). - Moved InCtorInitializer context setting before checking tok::comma so that InCtorInitializer cont

Re: [PATCH] D19804: Make clang-format cleaner remove redundant commas in list and redundant colon in constructor initializer.

ioeric added inline comments. Comment at: lib/Format/Format.cpp:1822 @@ +1821,3 @@ +cleanupRight(Line->First, Line->Last, tok::comma, tok::comma); +checkConstructorInitList(*Line); + } ioeric wrote: > ioeric wrote: > > djasper wrote: > > > You

Re: [PATCH] D19804: Make clang-format cleaner remove redundant commas in list and redundant colon in constructor initializer.

ioeric updated this revision to Diff 57146. ioeric added a comment. - nit: add a missing space. http://reviews.llvm.org/D19804 Files: lib/Format/Format.cpp lib/Format/TokenAnnotator.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cpp =

Re: r269398 - Add support for derived class special members hiding functions brought in from

Hi Richard, I believe this broke our modules builds. Last successful one was with r269388 and the current with r269389 fails with: /usr/lib/gcc/x86_64-redhat-linux/4.9.2/../../../../include/c++/4.9.2/type_traits:69:12: error: constructor cannot be redeclared struct integral_constant

Re: [PATCH] D20232: [include-fixer] Simplify unittest code.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. What's a flexable (in the description)? Code LG. Repository: rL LLVM http://reviews.llvm.org/D20232 ___ cfe-commits mailing list cfe-commits

Re: [PATCH] D20232: [include-fixer] Simplify unittest code.

hokein added a comment. In http://reviews.llvm.org/D20232#429348, @bkramer wrote: > What's a flexable (in the description)? Code LG. I updated the description now. Repository: rL LLVM http://reviews.llvm.org/D20232 ___ cfe-commits mailing list

Re: [PATCH] D20205: [include-fixer] Use scope contexts information to improve query.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Tests look much better now, thanks! http://reviews.llvm.org/D20205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

Re: [PATCH] D20232: [include-fixer] Simplify unittest code.

bkramer added a comment. So s/flexable/flexible/ and commit :) Repository: rL LLVM http://reviews.llvm.org/D20232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r269411 - [mips] Consult triple's vendor field before using musl's interpreter.

Author: vkalintiris Date: Fri May 13 07:13:13 2016 New Revision: 269411 URL: http://llvm.org/viewvc/llvm-project?rev=269411&view=rev Log: [mips] Consult triple's vendor field before using musl's interpreter. This should affect only the mips-mti-linux toolchain. Modified: cfe/trunk/lib/Driver

r269412 - Simplify getLinuxDynamicLinker() by using a common variable for the triple. NFC.

Author: vkalintiris Date: Fri May 13 07:34:14 2016 New Revision: 269412 URL: http://llvm.org/viewvc/llvm-project?rev=269412&view=rev Log: Simplify getLinuxDynamicLinker() by using a common variable for the triple. NFC. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/T

Re: r269309 - [ubsan] Add -fsanitize-undefined-strip-path-components=N

> On 13 May 2016, at 07:03, Sean Silva wrote: > > > > On Thu, May 12, 2016 at 9:51 AM, Filipe Cabecinhas via cfe-commits > wrote: > Author: filcab > Date: Thu May 12 11:51:36 2016 > New Revision: 269309 > > URL: http://llvm.org/viewvc/llvm-project?rev=269309&view=rev > Log: > [ubsan] Add -f

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

bittnerbarni updated this revision to Diff 57172. http://reviews.llvm.org/D20196 Files: clang-tidy/performance/InefficientStringAdditionCheck.cpp docs/ReleaseNotes.rst docs/clang-tidy/checks/performance-inefficient-string-addition.rst test/clang-tidy/performance-inefficient-string-additio

Re: [PATCH] D19871: Add an AST matcher for CastExpr kind

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thank you for this! http://reviews.llvm.org/D19871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

Re: [PATCH] D19871: Add an AST matcher for CastExpr kind

Prazek added a subscriber: Prazek. Prazek added a comment. +1 I will probably also use this. Does hasCastKind works for implicitCastExpr? http://reviews.llvm.org/D19871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

Re: [PATCH] D19871: Add an AST matcher for CastExpr kind

jroelofs added a comment. In http://reviews.llvm.org/D19871#429153, @etienneb wrote: > In http://reviews.llvm.org/D19871#428997, @jroelofs wrote: > > > Drive-by thought: I think it would be useful to be able to match implicit > > casts separately from explicit casts when using this new matcher.

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:191 @@ +190,3 @@ + This check is to warn about the performance overhead arising from concatenating + strings, using the operator+, instead of operator+=. + Please highlight operator+ and

Re: [PATCH] D19484: [OpenCL] Add supported OpenCL extensions to target info.

yaxunl updated this revision to Diff 57177. yaxunl added a comment. Fixed available OpenCL version for some extensions. http://reviews.llvm.org/D19484 Files: include/clang/Basic/DiagnosticParseKinds.td include/clang/Basic/LangOptions.h include/clang/Basic/OpenCLExtensions.def include/cl

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

aaron.ballman added a subscriber: aaron.ballman. Comment at: lib/Driver/MSVCToolChain.cpp:42 @@ -40,1 +41,3 @@ + + #pragma comment(lib, "version.lib") #endif Eh, I am lightening up on this sort of thing, so this is fine by me. Comment at: lib/D

r269418 - [AST] Add missing const qualifiers to AstContext in Type.cpp

Author: etienneb Date: Fri May 13 09:31:44 2016 New Revision: 269418 URL: http://llvm.org/viewvc/llvm-project?rev=269418&view=rev Log: [AST] Add missing const qualifiers to AstContext in Type.cpp Summary: Add some missing const qualifiers to AstContext. The ASTContext can't be modified with acces

Re: [PATCH] D19484: [OpenCL] Add supported OpenCL extensions to target info.

bader accepted this revision. bader added a comment. LGTM. Thanks! http://reviews.llvm.org/D19484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

yaxunl marked 3 inline comments as done. Comment at: lib/Headers/opencl-c.h:14057 @@ +14056,3 @@ +event_t __attribute__((overloadable)) async_work_group_copy(__local float2 *dst, const __global float2 *src, size_t num_elements, event_t event); +event_t __attribute__((overloadable

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseNoexceptCheck.h:44-45 @@ +43,4 @@ + unsigned &Len); + const std::string ReplacementStr; + StringRef Replacement; +}; What is the difference between these two fields? The n

Re: [PATCH] D19871: Add an AST matcher for CastExpr kind

etienneb added a comment. In http://reviews.llvm.org/D19871#429466, @Prazek wrote: > +1 I will probably also use this. > > Does hasCastKind works for implicitCastExpr? Yes, there is a unittest with the code. http://reviews.llvm.org/D19871 ___ cfe

Re: [PATCH] D20219: [CodeGen] Clang does not choose aapcs-vfp calling convention for ARM bare metal target with hard float (EABIHF)

This revision was automatically updated to reflect the committed changes. Closed by commit rL269419: [CodeGen] Clang does not choose aapcs-vfp calling convention for ARM bare… (authored by oleg). Changed prior to commit: http://reviews.llvm.org/D20219?vs=57082&id=57187#toc Repository: rL LLV

[clang-tools-extra] r269422 - [find-all-symbols] Add EnumDecl type in YAML traits.

Author: hokein Date: Fri May 13 09:53:10 2016 New Revision: 269422 URL: http://llvm.org/viewvc/llvm-project?rev=269422&view=rev Log: [find-all-symbols] Add EnumDecl type in YAML traits. Modified: clang-tools-extra/trunk/include-fixer/find-all-symbols/SymbolInfo.cpp Modified: clang-tools-extr

r269423 - Prune four superfluous ExternalSemaSource.h includes and one forward declaration in Sema.h

Author: yrnkrn Date: Fri May 13 09:53:19 2016 New Revision: 269423 URL: http://llvm.org/viewvc/llvm-project?rev=269423&view=rev Log: Prune four superfluous ExternalSemaSource.h includes and one forward declaration in Sema.h where ExternalSemaSource.h was already included due to ExternalSemaSource

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

hintonda added inline comments. Comment at: clang-tidy/modernize/UseNoexceptCheck.h:44-45 @@ +43,4 @@ + unsigned &Len); + const std::string ReplacementStr; + StringRef Replacement; +}; aaron.ballman wrote: > What is the difference between these

Re: [PATCH] D20232: [include-fixer] Simplify unittest code.

hokein updated this revision to Diff 57193. hokein updated the summary for this revision. hokein added a comment. Fix clang-include-fixer build. http://reviews.llvm.org/D20232 Files: include-fixer/InMemorySymbolIndex.cpp include-fixer/InMemorySymbolIndex.h include-fixer/find-all-symbols/F

[clang-tools-extra] r269427 - [include-fixer] Simplify unittest code.

Author: hokein Date: Fri May 13 10:17:17 2016 New Revision: 269427 URL: http://llvm.org/viewvc/llvm-project?rev=269427&view=rev Log: [include-fixer] Simplify unittest code. Summary: The InMemorySymbolIndex only constructs hard-coded Class symbols from a string map. The patch provide a flexable wa

Re: [PATCH] D20232: [include-fixer] Simplify unittest code.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269427: [include-fixer] Simplify unittest code. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20232?vs=57193&id=57194#toc Repository: rL LLVM http://reviews.llvm.org/D20232

Re: [PATCH] D19667: [ubsan] Minimize size of data for type_mismatch

filcab added a comment. Hi Richard. Just want to double-check something. If we have no alignment value, for this check, can we assume 1? It seems to me that that shouldn't be a problem, but wanted to double-check. Comment at: lib/CodeGen/CGExpr.cpp:579 @@ -578,1 +578,3 @@ +

[PATCH] D20240: [clang-rename] Fix broken dependency on shared build.

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. The build is broken due to a missing dependency. To repro: [Release + Shared] ``` -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON ``` Which produce this error: ``` tools/clang/tools/ext

Re: [PATCH] D20240: [clang-rename] Fix broken dependency on shared build.

yaron.keren added a subscriber: yaron.keren. yaron.keren accepted this revision. yaron.keren added a reviewer: yaron.keren. yaron.keren added a comment. This revision is now accepted and ready to land. result of r269402, LGTM http://reviews.llvm.org/D20240 ___

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

bittnerbarni updated this revision to Diff 57185. http://reviews.llvm.org/D20196 Files: docs/clang-tidy/checks/performance-inefficient-string-addition.rst Index: docs/clang-tidy/checks/performance-inefficient-string-addition.rst =

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

bittnerbarni updated this revision to Diff 57181. http://reviews.llvm.org/D20196 Files: docs/clang-tidy/checks/performance-inefficient-string-addition.rst Index: docs/clang-tidy/checks/performance-inefficient-string-addition.rst =

Re: [PATCH] D20240: [clang-rename] Fix broken dependency on shared build.

etienneb added a comment. thanks, landing as soon as my other checkouts complete their tests (few minutes). http://reviews.llvm.org/D20240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

r269419 - [CodeGen] Clang does not choose aapcs-vfp calling convention for ARM bare metal target with hard float (EABIHF)

Author: oleg Date: Fri May 13 09:45:57 2016 New Revision: 269419 URL: http://llvm.org/viewvc/llvm-project?rev=269419&view=rev Log: [CodeGen] Clang does not choose aapcs-vfp calling convention for ARM bare metal target with hard float (EABIHF) Summary: Clang does not detect `aapcs-vfp` for the EA

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth marked 2 inline comments as done. Comment at: lib/Driver/MSVCToolChain.cpp:42 @@ -40,1 +41,3 @@ + + #pragma comment(lib, "version.lib") #endif aaron.ballman wrote: > Eh, I am lightening up on this sort of thing, so this is fine by me. I was following th

Re: [PATCH] D20205: [include-fixer] Use scope contexts information to improve query.

hokein updated this revision to Diff 57197. hokein added a comment. Rebase. http://reviews.llvm.org/D20205 Files: include-fixer/IncludeFixer.cpp include-fixer/SymbolIndexManager.cpp unittests/include-fixer/IncludeFixerTest.cpp Index: unittests/include-fixer/IncludeFixerTest.cpp =

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth updated this revision to Diff 57196. amccarth marked an inline comment as done. amccarth added a comment. Addressed additional comments. http://reviews.llvm.org/D20136 Files: include/clang/Driver/ToolChain.h lib/Driver/MSVCToolChain.cpp lib/Driver/ToolChains.h lib/Driver/Tools.

[clang-tools-extra] r269429 - [clang-rename] Fix broken dependency on shared build.

Author: etienneb Date: Fri May 13 10:38:54 2016 New Revision: 269429 URL: http://llvm.org/viewvc/llvm-project?rev=269429&view=rev Log: [clang-rename] Fix broken dependency on shared build. Summary: The build is broken due to a missing dependency. To repro: [Release + Shared] ``` -DCMAKE_BUILD_TY

[clang-tools-extra] r269430 - [include-fixer] Use scope contexts information to improve query.

Author: hokein Date: Fri May 13 10:44:16 2016 New Revision: 269430 URL: http://llvm.org/viewvc/llvm-project?rev=269430&view=rev Log: [include-fixer] Use scope contexts information to improve query. Reviewers: bkramer Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D20205

Re: [PATCH] D20205: [include-fixer] Use scope contexts information to improve query.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269430: [include-fixer] Use scope contexts information to improve query. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20205?vs=57197&id=57200#toc Repository: rL LLVM http:

r269431 - [OpenCL] Add supported OpenCL extensions to target info.

Author: yaxunl Date: Fri May 13 10:44:37 2016 New Revision: 269431 URL: http://llvm.org/viewvc/llvm-project?rev=269431&view=rev Log: [OpenCL] Add supported OpenCL extensions to target info. Add supported OpenCL extensions to target info. It serves as default values to save the users of the burde

Re: [PATCH] D19484: [OpenCL] Add supported OpenCL extensions to target info.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269431: [OpenCL] Add supported OpenCL extensions to target info. (authored by yaxunl). Changed prior to commit: http://reviews.llvm.org/D19484?vs=57177&id=57201#toc Repository: rL LLVM http://review

Re: [PATCH] D20157: Add test for D20156

rovka abandoned this revision. rovka added a comment. With the new diagnostic handler in r269428, we no longer need this test (it will be covered by the existing tests such as CodeGen/AArch64/arm64-inline-asm-error-N.ll, by removing the -exit-on-error flag). http://reviews.llvm.org/D20157

Re: [PATCH] D20194: [ModuleMap][CrashReproducer] Collect headers from inner frameworks

benlangmuir added a comment. Let's move the code looks up the alternate name out of the ModuleMap parser, and into the dependency collector callbacks. This feels like an implementation detail of the dependency collector. We could add a new callback specifically for umbrella headers and handle

[PATCH] D20243: [PCH] Disable inclusion of timestamps when generating pch files on windows.

pgousseau created this revision. pgousseau added a reviewer: rsmith. pgousseau added a subscriber: cfe-commits. On Linux, if a header file included in the pch is modified then a fatal error is emitted, which is reasonable. On Windows the check is ifdefed out, allowing the compilation to continue

RE: r269411 - [mips] Consult triple's vendor field before using musl's interpreter.

Hi, This change makes sense but it needs a test case. > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of Vasileios Kalintiris via cfe-commits > Sent: 13 May 2016 13:13 > To: cfe-commits@lists.llvm.org > Subject: r269411 - [mips] Consult tri

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[patch] Don't use appending linkage for embeded bitcode

Hi Steven, I think there was a mistake when picking this linkage. The appending linkage is really just for things that llvm itself special cases. By an historical artifact it was codegened just like external. The attached patch changes it to external linkage. I tested that the produced .o file is

Re: [patch] Don't use appending linkage for embeded bitcode

Hi Rafael Thanks for notice this! That would definitely cause duplicated symbol error and I should definitely change that. Here is some background: ld64 in Xcode 7+ knows how to handle the embedded bitcode correctly but not the ones in earlier Xcode. The old ld64 will simply concatenate the bit

[PATCH] D20245: [include-fixer] Fix broken dependency shared build

etienneb created this revision. etienneb added reviewers: bkramer, hokein. etienneb added a subscriber: cfe-commits. The shared build is broken (again). To repro: [Release + Shared] ``` -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON ``` Errors: ``` tools/clang/tools/extra/include-fixer/tool/C

Re: [PATCH] D19484: [OpenCL] Add supported OpenCL extensions to target info.

junbuml added a subscriber: junbuml. junbuml added a comment. In current trunk, I got build error : llvm/tools/clang/lib/Basic/Targets.cpp:2090:9: error: 'setSupportedOpenCLOpts' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] void setSupp

Re: [patch] Don't use appending linkage for embeded bitcode

On 13 May 2016 at 13:02, Steven Wu wrote: > Hi Rafael > > Thanks for notice this! That would definitely cause duplicated symbol error > and I should definitely change that. > Here is some background: > ld64 in Xcode 7+ knows how to handle the embedded bitcode correctly but not > the ones in earl

r269435 - Revert "[OpenCL] Add supported OpenCL extensions to target info."

Author: yaxunl Date: Fri May 13 12:16:26 2016 New Revision: 269435 URL: http://llvm.org/viewvc/llvm-project?rev=269435&view=rev Log: Revert "[OpenCL] Add supported OpenCL extensions to target info." Revert r269431 due to build failure caused by warning msg: llvm/tools/clang/lib/Basic/Targets.c

RE: [PATCH] D19484: [OpenCL] Add supported OpenCL extensions to target info.

Done. Thanks for letting me know. Sam -Original Message- From: Jun Bum Lim [mailto:junb...@codeaurora.org] Sent: Friday, May 13, 2016 1:10 PM To: Liu, Yaxun (Sam) ; anastasia.stul...@arm.com; aleksey.ba...@mail.ru Cc: junb...@codeaurora.org; Stellard, Thomas ; xiuli...@outlook.com; cfe

Re: r269431 - [OpenCL] Add supported OpenCL extensions to target info.

Hi Yaxun You seems missing some override keyword that triggers -Winconsistent-missing-override. See: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_build/24442/warnings8Result/new/ Here is a patch to fix them: diff --git a/lib/Basic/Targets.cpp b/lib/Basic/Targets.cpp inde

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

majnemer added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:481 @@ +480,3 @@ + + std::vector VersionBlock(VersionSize); + if (!::GetFileVersionInfoW(ClExeWide.c_str(), 0, VersionSize, It might be nicer to use a `SmallVector`, or whatever `VersionSi

RE: r269431 - [OpenCL] Add supported OpenCL extensions to target info.

Thanks Steven. I have reverted my change. I will apply your patch and re-commit. Sam -Original Message- From: steve...@apple.com [mailto:steve...@apple.com] Sent: Friday, May 13, 2016 1:27 PM To: Liu, Yaxun (Sam) Cc: cfe-commits@lists.llvm.org Subject: Re: r269431 - [OpenCL] Add suppor

r269440 - Fix module map typo in r269347.

Author: rsmith Date: Fri May 13 12:28:51 2016 New Revision: 269440 URL: http://llvm.org/viewvc/llvm-project?rev=269440&view=rev Log: Fix module map typo in r269347. Modified: cfe/trunk/include/clang/module.modulemap Modified: cfe/trunk/include/clang/module.modulemap URL: http://llvm.org/vie

Re: r269220 - [MSVC] Implementation of __unaligned as a proper type qualifier

This seems to crash clang: struct S { void f() __unaligned; }; void S::f() __unaligned { } clang/lib/Sema/DeclSpec.cpp:214: static clang::DeclaratorChunk clang::DeclaratorChunk::getFunction(bool, bool, clang::SourceLocation, clang::DeclaratorChunk::ParamInfo *, unsigned int, clang::SourceLocatio

Re: [PATCH] D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC

hubert.reinterpretcast updated this revision to Diff 57216. hubert.reinterpretcast added a comment. Set requires-clause when creating TemplateParameterLists; NFC Removes the default argument for the requires-clause constraint expression in TemplateParameterList::Create. An appropriate argument

[clang-tools-extra] r269441 - [include-fixer] Fix broken dependency shared build

Author: etienneb Date: Fri May 13 12:38:22 2016 New Revision: 269441 URL: http://llvm.org/viewvc/llvm-project?rev=269441&view=rev Log: [include-fixer] Fix broken dependency shared build Summary: The shared build is broken (again). To repro: [Release + Shared] ``` -DCMAKE_BUILD_TYPE=Release -DBUI

Re: [PATCH] D20245: [include-fixer] Fix broken dependency shared build

This revision was automatically updated to reflect the committed changes. Closed by commit rL269441: [include-fixer] Fix broken dependency shared build (authored by etienneb). Changed prior to commit: http://reviews.llvm.org/D20245?vs=57208&id=57221#toc Repository: rL LLVM http://reviews.ll

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:481 @@ +480,3 @@ + + std::vector VersionBlock(VersionSize); + if (!::GetFileVersionInfoW(ClExeWide.c_str(), 0, VersionSize, majnemer wrote: > It might be nicer to use a `SmallVector`, > or

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

majnemer added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:481 @@ +480,3 @@ + + std::vector VersionBlock(VersionSize); + if (!::GetFileVersionInfoW(ClExeWide.c_str(), 0, VersionSize, amccarth wrote: > majnemer wrote: > > It might be nicer to use a

[PATCH] D20249: [OpenCL] Hierarchical/dynamic parallelism - enqueue kernel in OpenCL 2.0

Anastasia created this revision. Anastasia added reviewers: bader, yaxunl. Anastasia added subscribers: pekka.jaaskelainen, pxli168, cfe-commits. An implementation of device side enqueue (DSE) - enqueue_kernel and related BIFs from OpenCL v2.0 s6.13.17. This change includes: 1. adding enqueue_k

Re: [PATCH] D20249: [OpenCL] Hierarchical/dynamic parallelism - enqueue kernel in OpenCL 2.0

Anastasia added inline comments. Comment at: include/clang/Basic/Builtins.h:39 @@ -38,3 +38,3 @@ MS_LANG = 0x10, // builtin requires MS mode. - OCLC_LANG = 0x20, // builtin for OpenCL C only. + OCLC20_LANG = 0x20, // builtin for OpenCL C only. ALL_LANGUAGES = C_LANG

Re: [PATCH] D20243: [PCH] Disable inclusion of timestamps when generating pch files on windows.

probinson added a subscriber: probinson. probinson added a comment. Please make sure the test files have newlines at the end. "touch-pragma-once.cpp" should probably be named something like "pragma-once-timestamp.cpp". http://reviews.llvm.org/D20243 __

RE: r269431 - [OpenCL] Add supported OpenCL extensions to target info.

BTW is there a way to turn on this warning with CMake? I could not see this warning in my own build. Thanks. Sam -Original Message- From: Liu, Yaxun (Sam) Sent: Friday, May 13, 2016 1:33 PM To: 'steve...@apple.com' Cc: cfe-commits@lists.llvm.org Subject: RE: r269431 - [OpenCL] Add sup

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

Anastasia added inline comments. Comment at: lib/Headers/opencl-c.h:7452 @@ +7451,3 @@ + +// OpenCL v1.2 s6.12.2, v2.0 s6.13.2 - Math functions + Could you put OpenCL v1.1 section too? Comment at: lib/Headers/opencl-c.h:7767 @@ +7766,3 @@ +/** +

Re: [PATCH] D20137: [PCH] Fixed bugs with preamble invalidation when files change (on Windows)

cameron314 updated this revision to Diff 57222. cameron314 added a comment. Updated patch to include later fixes I had made after the initial change. http://reviews.llvm.org/D20137 Files: include/clang/Basic/FileManager.h include/clang/Frontend/ASTUnit.h lib/Basic/FileManager.cpp lib/Fr

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

Anastasia added inline comments. Comment at: lib/Headers/opencl-c.h:14057 @@ +14056,3 @@ +event_t __attribute__((overloadable)) async_work_group_copy(__local float2 *dst, const __global float2 *src, size_t num_elements, event_t event); +event_t __attribute__((overloadable)) async

Re: r269431 - [OpenCL] Add supported OpenCL extensions to target info.

It is part of -Wall group and it should be on by default when you building clang. That warning is added into clang some time in 2014. Make sure you are not using a compiler that is too old. Steven > On May 13, 2016, at 10:58 AM, Liu, Yaxun (Sam) wrote: > > BTW is there a way to turn on this w

Re: [PATCH] D20137: [PCH] Fixed bugs with preamble invalidation when files change (on Windows)

rsmith added inline comments. Comment at: lib/Basic/FileManager.cpp:304-307 @@ -303,1 +303,6 @@ + if (UFE.isVirtual()) { +UFE.Name = InterndFileName; +return &UFE; + } + It looks like this is unreachable: `IsVirtual` is only ever `true` when `IsValid`

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth marked an inline comment as done. Comment at: lib/Driver/MSVCToolChain.cpp:481 @@ +480,3 @@ + + std::vector VersionBlock(VersionSize); + if (!::GetFileVersionInfoW(ClExeWide.c_str(), 0, VersionSize, majnemer wrote: > amccarth wrote: > > majnemer wrote:

r269457 - Use marginally more appropriate functions to detect if we should declare an

Author: rsmith Date: Fri May 13 13:48:05 2016 New Revision: 269457 URL: http://llvm.org/viewvc/llvm-project?rev=269457&view=rev Log: Use marginally more appropriate functions to detect if we should declare an implicit copy constructor/assignment, and other minor cleanups. No functionality change i

[PATCH] D20253: clang-rename: fix missing clangLex dependency

vmiklos created this revision. vmiklos added reviewers: cfe-commits, klimek. Blind fix for . http://reviews.llvm.org/D20253 Files: clang-rename/CMakeLists.txt Index: clang-rename/CMakeLists.txt

Re: [PATCH] D20253: clang-rename: fix missing clangLex dependency

vmiklos abandoned this revision. vmiklos added a comment. Ah, already fixed by http://reviews.llvm.org/D20240, sorry for the noise. :-) http://reviews.llvm.org/D20253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [PATCH] D20240: [clang-rename] Fix broken dependency on shared build.

vmiklos added a subscriber: vmiklos. vmiklos added a comment. Thanks for fixing the problem I introduced. :-) http://reviews.llvm.org/D20240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D20240: [clang-rename] Fix broken dependency on shared build.

etienneb added a comment. In http://reviews.llvm.org/D20240#429910, @vmiklos wrote: > Thanks for fixing the problem I introduced. :-) No worries, I did the same twice this week. http://reviews.llvm.org/D20240 ___ cfe-commits mailing list cfe-comm

  1   2   >