Author: ogoffart
Date: Mon May 9 02:09:51 2016
New Revision: 268895
URL: http://llvm.org/viewvc/llvm-project?rev=268895&view=rev
Log:
Fix spurious warnings about unused private field
If the address of a field is taken as a pointer to member, we should
not warn that the field is not used.
Normal
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268895: Fix spurious warnings about unused private field
(authored by ogoffart).
Changed prior to commit:
http://reviews.llvm.org/D20054?vs=56514&id=56530#toc
Repository:
rL LLVM
http://reviews.llvm
vmiklos created this revision.
vmiklos added reviewers: cfe-commits, klimek.
To be consistent with the other tests.
http://reviews.llvm.org/D20059
Files:
test/clang-rename/ClassTest.cpp
test/clang-rename/FieldTest.cpp
test/clang-rename/VarTest.cpp
Index: test/clang-rename/VarTest.cpp
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D20059
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: vmiklos
Date: Mon May 9 03:47:18 2016
New Revision: 268897
URL: http://llvm.org/viewvc/llvm-project?rev=268897&view=rev
Log:
clang-rename tests: move the run lines to the top of the test files
Summary: To be consistent with the other tests.
Reviewers: cfe-commits, klimek
Differential R
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268897: clang-rename tests: move the run lines to the top of
the test files (authored by vmiklos).
Changed prior to commit:
http://reviews.llvm.org/D20059?vs=56537&id=56538#toc
Repository:
rL LLVM
h
Author: nemanjai
Date: Mon May 9 03:52:33 2016
New Revision: 268898
URL: http://llvm.org/viewvc/llvm-project?rev=268898&view=rev
Log:
Enable support for __float128 in Clang and enable it on pertinent platforms
This patch corresponds to reviews:
http://reviews.llvm.org/D15120
http://reviews.llvm.
karies added a comment.
Regarding the concerns raised by @akyrtzi : maybe it's a question of making the
completer interface useful at low cost (with filtering for generic use cases
and less ASTReading) versus not breaking existing use cases (fuzzy match).
Would you still object to this change i
ioeric added inline comments.
Comment at: include-fixer/find-all-symbols/SymbolInfo.h:98-101
@@ +97,6 @@
+
+ static SymbolInfo
+ CreateFunctionSymbolInfo(const std::string &Name, const std::string
&FilePath,
+ const std::vector &Contexts, int
LineNumb
hokein updated this revision to Diff 56540.
hokein marked 5 inline comments as done.
hokein added a comment.
- Address review comments.
- Ignore using-declarations defined in class definition.
http://reviews.llvm.org/D20018
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
clang-tidy/misc/Un
hokein added a comment.
I ran the check on LLVM project. The check found 8 hits:
http://reviews.llvm.org/D20060 (Check all of them, no false positives).
http://reviews.llvm.org/D20018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
djasper added inline comments.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:39
@@ +38,3 @@
+// Ignores using-declrations defined in class definition.
+if (isa(TargetDecl->getDeclContext()))
+ return;
We should also ignore using declarations i
Author: alexfh
Date: Mon May 9 05:00:52 2016
New Revision: 268899
URL: http://llvm.org/viewvc/llvm-project?rev=268899&view=rev
Log:
Fix docs.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/misc-unconventional-assign-operator.rst
Modified:
clang-tools-extra/trunk/docs/clang-tidy/
ioeric added inline comments.
Comment at: lib/Format/Format.cpp:1821
@@ +1820,3 @@
+ if (Line->Affected)
+checkConstructorInitList(*Line);
+}
djasper wrote:
> Why are we restricting this to constructor initializers? I think we should
> directly b
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D19993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: mzuckerm
Date: Mon May 9 05:32:51 2016
New Revision: 268903
URL: http://llvm.org/viewvc/llvm-project?rev=268903&view=rev
Log:
[Clang][AVX512] completing missing intrinsics [CVT]
Differential Revision: http://reviews.llvm.org/D20056
Modified:
cfe/trunk/lib/Headers/avx512fintrin.h
Author: alexfh
Date: Mon May 9 05:56:57 2016
New Revision: 268905
URL: http://llvm.org/viewvc/llvm-project?rev=268905&view=rev
Log:
Trying to fix docs.
Modified:
clang-tools-extra/trunk/clang-tidy/misc/UnconventionalAssignOperatorCheck.cpp
clang-tools-extra/trunk/clang-tidy/misc/Unconve
GGanesh added a comment.
PING!
http://reviews.llvm.org/D19796
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
apelete added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:1317
@@ -1316,2 +1316,3 @@
}
+ assert(V && "constant must be not NULL at this point");
TemplateParams.push_back(DBuilder.createTemplateValueParameter(
dblaikie wrote:
> It lo
hokein added inline comments.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:39
@@ +38,3 @@
+// Ignores using-declrations defined in class definition.
+if (isa(TargetDecl->getDeclContext()))
+ return;
djasper wrote:
> We should also ignore usin
hokein updated this revision to Diff 56555.
hokein marked 2 inline comments as done.
hokein added a comment.
Update.
http://reviews.llvm.org/D20018
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
clang-tidy/misc/UnusedUsingDeclsCheck.h
test/clang-tidy/misc-unused-using-decls.cpp
Index:
apelete added inline comments.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:300
@@ -299,2 +299,3 @@
+ assert(SM && "SourceManager is NULL, cannot iterate through the
diagnostics");
dblaikie wrote:
> This assertion seems to be equivalent to replac
apelete updated this revision to Diff 56556.
apelete added a comment.
[scan-build] fix warnings emitted on Clang StaticAnalyzer code base
- lib/StaticAnalyzer/Core/PlistDiagnostics.cpp: factorize assert and check on
'!Diags.empty' condition.
http://reviews.llvm.org/D19962
Files:
lib/StaticA
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:39
@@ +38,3 @@
+// Ignores using-declarations defined in class definition.
+if (isa(TargetDecl->get
Author: mzuckerm
Date: Mon May 9 07:38:49 2016
New Revision: 268910
URL: http://llvm.org/viewvc/llvm-project?rev=268910&view=rev
Log:
[clang][AVX512] completing missing intrinsics [vmin/vmax].
Differential Revision: http://reviews.llvm.org/D20062
Modified:
cfe/trunk/lib/Headers/avx512fintr
Author: rafael
Date: Mon May 9 08:03:10 2016
New Revision: 268912
URL: http://llvm.org/viewvc/llvm-project?rev=268912&view=rev
Log:
RHEL: Look in more places to find g++ headers and runtime.
Some distros with ten years of support ship an old gcc but later offer
more recent versions for installat
r268912.
Thanks,
Rafael
On 6 May 2016 at 17:06, Michael Lampe wrote:
> No, I'm hoping on someone else to commit this. (You?)
>
> Same with this one:
>
> https://www.mail-archive.com/cfe-commits@lists.llvm.org/msg18696.html
>
> -Michael
>
>
> Rafael Espíndola wrote:
>>
>> LGTM. Do you have commi
RKSimon added a subscriber: RKSimon.
RKSimon added a comment.
This appears to have been fixed in http://reviews.llvm.org/rL265218
http://reviews.llvm.org/D18182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: rafael
Date: Mon May 9 08:13:50 2016
New Revision: 268914
URL: http://llvm.org/viewvc/llvm-project?rev=268914&view=rev
Log:
Proper detection and handling of RHEL and variants.
- Don't consider "/etc/lsb-release" to be Ubuntu only.
- Detect SL, too.
- Only add "--no-add-needed" for RHEL7
r268914.
Thanks,
Rafael
On 26 March 2016 at 20:35, Michael Lampe wrote:
> New patch attached. I've also removed RHEL4 which is now four years past EOL
> and certainly incapable of building or running any recent version of
> llvm/clang.
>
> -Michael
>
>
> Rafael Espíndola wrote:
>>
>> - if (IsRe
hokein updated this revision to Diff 56566.
hokein added a comment.
Address remaining comments.
http://reviews.llvm.org/D20018
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
clang-tidy/misc/UnusedUsingDeclsCheck.h
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D20018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hokein
Date: Mon May 9 08:37:12 2016
New Revision: 268917
URL: http://llvm.org/viewvc/llvm-project?rev=268917&view=rev
Log:
Support variables and functions types in misc-unused-using-decls.
Summary: Fix PR27429.
Reviewers: djasper
Subscribers: cfe-commits
Differential Revision: http:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268917: Support variables and functions types in
misc-unused-using-decls. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20018?vs=56566&id=56568#toc
Repository:
rL LLVM
http
Author: hokein
Date: Mon May 9 08:43:58 2016
New Revision: 268919
URL: http://llvm.org/viewvc/llvm-project?rev=268919&view=rev
Log:
[clang-tidy] new google-default-arguments check
Summary:
To check the google style guide rule here:
https://google.github.io/styleguide/cppguide.html#Default_Argume
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268919: [clang-tidy] new google-default-arguments check
(authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D19534?vs=56529&id=56569#toc
Repository:
rL LLVM
http://reviews.llvm.or
hubert.reinterpretcast added a comment.
Ping.
http://reviews.llvm.org/D19322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkramer created this revision.
bkramer added a reviewer: hokein.
bkramer added a subscriber: cfe-commits.
This looks for find_all_symbols_db.yaml in all parent directories of the
source file (like we do for compile_commands.json) so we don't have to
pass the path manually.
http://reviews.llvm.org
yaxunl added a comment.
In http://reviews.llvm.org/D18369#424347, @pxli168 wrote:
> In http://reviews.llvm.org/D18369#422367, @yaxunl wrote:
>
> > In http://reviews.llvm.org/D18369#421963, @pxli168 wrote:
> >
> > > If we want to save some space, could we use some macro to expand the
> > > gentyp
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D20066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: d0k
Date: Mon May 9 09:14:55 2016
New Revision: 268920
URL: http://llvm.org/viewvc/llvm-project?rev=268920&view=rev
Log:
[include-fixer] Autodetect yaml databases in parent directories.
This looks for find_all_symbols_db.yaml in all parent directories of the
source file (like we do for c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268920: [include-fixer] Autodetect yaml databases in parent
directories. (authored by d0k).
Changed prior to commit:
http://reviews.llvm.org/D20066?vs=56570&id=56575#toc
Repository:
rL LLVM
http://r
flx added a comment.
In http://reviews.llvm.org/D19865#423140, @flx wrote:
> In http://reviews.llvm.org/D19865#419905, @flx wrote:
>
> > In http://reviews.llvm.org/D19865#419830, @alexfh wrote:
> >
> > > Is it a workaround to avoid breaking the code by incorrect fixes?
> >
> >
> > Yes. We can't s
flx removed rL LLVM as the repository for this revision.
flx updated this revision to Diff 56573.
http://reviews.llvm.org/D19865
Files:
clang-tidy/performance/UnnecessaryCopyInitialization.cpp
clang-tidy/performance/UnnecessaryCopyInitialization.h
test/clang-tidy/performance-unnecessary-cop
hokein updated this revision to Diff 56579.
hokein marked an inline comment as done.
hokein added a comment.
Address comments.
http://reviews.llvm.org/D19816
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
clang-tidy/misc/UnusedUsingDeclsCheck.h
include-fixer/find-all-symbols/CMakeLists.
hokein marked an inline comment as done.
Comment at: include-fixer/find-all-symbols/PragmaCommentHandler.cpp:27
@@ +26,3 @@
+ SmallVector Matches;
+ if (!llvm::Regex(IWYUPragma).match(Text, &Matches))
+return false;
bkramer wrote:
> Isn't this regex just a c
DmitryPolukhin updated this revision to Diff 56581.
DmitryPolukhin added a comment.
- fixed tests for i686 when function may have hidden parameter
http://reviews.llvm.org/D18035
Files:
lib/AST/ItaniumMangle.cpp
lib/Sema/SemaDeclAttr.cpp
test/CodeGenCXX/mangle-abi-tag.cpp
test/SemaCXX/at
Author: dpolukhin
Date: Mon May 9 09:59:13 2016
New Revision: 268925
URL: http://llvm.org/viewvc/llvm-project?rev=268925&view=rev
Log:
[OpenMP] Parse+Sema for '#pragma omp declare target' syntax version 4.5
Support OpenMP version 4.5 syntax for #pragma omp declare target.
Syntax:
#pragma omp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268925: [OpenMP] Parse+Sema for '#pragma omp declare target'
syntax version 4.5 (authored by dpolukhin).
Changed prior to commit:
http://reviews.llvm.org/D20011?vs=56387&id=56582#toc
Repository:
rL L
FlameTop updated this revision to Diff 56591.
FlameTop added a comment.
Thank you for your review. I have removed the changes to the bug description.
Apologies, I did not realize it would alter the hash.
http://reviews.llvm.org/D19866
Files:
llvm/tools/clang/lib/StaticAnalyzer/Checkers/Stack
jlebar added a comment.
Art pointed me to the fact that CUDA 8 adds a bunch more load intrinsics, and I
said ohmygosh maybe we *do* want to do the variadic intrinsic thing here.
But now looking at how __builtin_add_overflow is implemented, we'd need special
sema checking to make it work. We wo
Since it's not a part of any official spec we could of course make it accepted
with anything.
Just out of curiosity what other programming models supported by Clang do you
think this attribute would be useful for?
Anastasia
-Original Message-
From: Matt Arsenault [mailto:matthew.arsena
yaxunl marked 4 inline comments as done.
Comment at: test/SemaOpenCL/to_addr_builtin.cl:24
@@ +23,3 @@
+
+ glob = to_global(con);
+#if __OPENCL_C_VERSION__ < CL_VERSION_2_0
pxli168 wrote:
> should this return a NULL or a build error?
the function is declared as
Anastasia accepted this revision.
Anastasia added a comment.
LGTM! Thanks!
http://reviews.llvm.org/D19780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added a comment.
Please, move cfe-commits to Subscribers list!
http://reviews.llvm.org/D19780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added a subscriber: rsmith.
Comment at: lib/Tooling/Core/QualTypeNames.cpp:386
@@ -385,2 +385,3 @@
NestedNameSpecifier *Prefix = nullptr;
- Qualifiers PrefixQualifiers;
+ // Local qualifiers are attached to the Qualtype outside of the
+ // elaborated type. Retrieve t
Hello,
> On 05/06/2016 12:11 PM, Anastasia Stulova via cfe-commits wrote:
>> I was just wondering whether it would make sense to restrict the usage of
>> the attribute to OpenCL language i.e. to add "let LangOpts = [OpenCL];" in
>> the attribute definition.
> This seems to be a pointless arbitr
tra added a comment.
OK. Let's stick with __ldg for now.
http://reviews.llvm.org/D19990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar added a comment.
Art pointed out that static_assert is c++11-only.
I'll just remove them and make a note to move them into the CUDA test-suite
stuff Art is working on.
http://reviews.llvm.org/D19990
___
cfe-commits mailing list
cfe-commits@
jlebar updated this revision to Diff 56603.
jlebar added a comment.
Remove static_asserts.
http://reviews.llvm.org/D19990
Files:
include/clang/Basic/BuiltinsNVPTX.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/CMakeLists.txt
lib/Headers/__clang_cuda_intrinsics.h
lib/Headers/__clang_cuda_ru
Author: vedantk
Date: Mon May 9 13:40:09 2016
New Revision: 268947
URL: http://llvm.org/viewvc/llvm-project?rev=268947&view=rev
Log:
[cmake] Enable zlib support for Apple stage2 builds
This allows llvm-profdata to interact with profiles containing
compressed name data.
rdar://problem/26122944
dblaikie added a subscriber: dblaikie.
Comment at: unittests/Tooling/QualTypeNamesTest.cpp:91
@@ -90,2 +90,3 @@
Visitor.ExpectedQualTypeNames["AliasTypeVal"] = "A::B::C::InnerAlias";
+ Visitor.ExpectedQualTypeNames["CheckM"] = "const A::B::Class0 *";
Visitor.runOver(
--
yaxunl updated this revision to Diff 56605.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Generate calls to void addr* to_addr(void*) with bitcasts.
http://reviews.llvm.org/D19932
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/DiagnosticSemaKinds.td
lib/AST
Author: nemanjai
Date: Mon May 9 13:58:02 2016
New Revision: 268951
URL: http://llvm.org/viewvc/llvm-project?rev=268951&view=rev
Log:
[Power9] Enable -mcpu=pwr9 (-mcpu=power9) in the front end
This patch corresponds to review:
http://reviews.llvm.org/D19684
It simply adds the handling for the o
nemanjai closed this revision.
nemanjai added a comment.
Committed revision 268951.
Repository:
rL LLVM
http://reviews.llvm.org/D19684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
sepavloff updated this revision to Diff 56607.
sepavloff added a comment.
Changed implementation of friend function set.
Friend functions declared in template classes are not added to redeclaration
chains,
but access to them is needed to make some checks. This change allows using the
set of frie
Author: dougk
Date: Mon May 9 14:09:59 2016
New Revision: 268956
URL: http://llvm.org/viewvc/llvm-project?rev=268956&view=rev
Log:
[Myriad] Use Generic_ELF::addClangTargetOptions()
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/lib/Driver/ToolChains.h
cfe/trunk/test/Driver/m
tra updated this revision to Diff 56610.
tra added a comment.
Updated tests in CodeGenCUDA/address-spaces.cu
http://reviews.llvm.org/D20034
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/CodeGenCUDA/address-spaces.cu
test/CodeGenCUDA/device-var-init.cu
Ind
Author: tra
Date: Mon May 9 14:36:08 2016
New Revision: 268962
URL: http://llvm.org/viewvc/llvm-project?rev=268962&view=rev
Log:
[CUDA] Only __shared__ variables can be static local on device side.
According to CUDA programming guide (v7.5):
> E.2.9.4: Within the body of a device or global funct
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268962: [CUDA] Only __shared__ variables can be static local
on device side. (authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D20034?vs=56610&id=56611#toc
Repository:
rL LLVM
http
rivanvx added a comment.
Thanks for the reviews!
http://reviews.llvm.org/D19780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra updated this revision to Diff 56619.
tra added a comment.
Reworded comments.
Removed tests that no longer apply as we don't generate constructors for static
local variables on device side.
Empty constructor cases are already covered by
test/CodeGenCUDA/device-var-init.cu.
http://reviews.l
Hello everyone,
Below are some buildbot numbers for week of 4/24/2016 - 4/30/2016.
Thanks
Galina
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green):
buildername| bu
Hello everyone,
Below are some buildbot numbers for the last week of 5/01/2016 - 5/07/2016.
Thanks
Galina
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green):
buildername
> On May 9, 2016, at 10:39, Anastasia Stulova via cfe-commits
> wrote:
>
> Since it's not a part of any official spec we could of course make it
> accepted with anything.
>
> Just out of curiosity what other programming models supported by Clang do you
> think this attribute would be useful
saugustine updated this revision to Diff 56634.
saugustine marked an inline comment as done.
saugustine added a comment.
- Handle elaborated types even more cleanly.
http://reviews.llvm.org/D20040
Files:
lib/Tooling/Core/QualTypeNames.cpp
unittests/Tooling/QualTypeNamesTest.cpp
Index: unit
saugustine added a comment.
Thanks for the reviews. I believe I have addressed all issues. Take another
look when you get the chance.
Comment at: lib/Tooling/Core/QualTypeNames.cpp:401-403
@@ -397,6 +400,5 @@
// move the qualifiers on the outer type (avoid 'std::const string
On Sun, May 8, 2016 at 12:43 PM, Matt Arsenault via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On May 6, 2016, at 18:12, Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> On Fri, May 6, 2016 at 4:20 PM, Matt Arsenault via cfe-commits <
> cfe-commits@lists.llvm.org> w
On Mon, May 9, 2016 at 2:43 PM, Richard Smith wrote:
> On Sun, May 8, 2016 at 12:43 PM, Matt Arsenault via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> On May 6, 2016, at 18:12, Richard Smith via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>> On Fri, May 6, 2016 at 4:20 PM,
Hello everyone,
In the nearest time I am going to take few builders off line one by one for
short time for upgrades.
Thank you for understanding.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM with a couple of minor tweaks, thanks!
Comment at: lib/Tooling/Core/QualTypeNames.cpp:400-401
@@ -395,8 +399,4 @@
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
Art makes the good point that any code which is broken by this change is itself
currently racy at the very best. And we have a way to fix any code which hits
this new error (just manually ini
tra added a comment.
In http://reviews.llvm.org/D20039#424067, @jlebar wrote:
> While I think this is 100% the right thing to do, I am worried about breaking
> existing targets. Maybe we need an escape valve, at least until we get that
> sorted out? Unless you're pretty confident this isn't h
Author: tra
Date: Mon May 9 17:09:56 2016
New Revision: 268982
URL: http://llvm.org/viewvc/llvm-project?rev=268982&view=rev
Log:
[CUDA] Restrict init of local __shared__ variables to empty constructors only.
Allow only empty constructors for local __shared__ variables in a way
identical to restr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268982: [CUDA] Restrict init of local __shared__ variables
to empty constructors only. (authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D20039?vs=56619&id=56642#toc
Repository:
rL
saugustine added a comment.
Thanks again. I've addressed the last little bits. Mind checking this in for me?
http://reviews.llvm.org/D20040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
saugustine updated this revision to Diff 56643.
saugustine marked 4 inline comments as done.
saugustine added a comment.
- Address remaining nits from review.
http://reviews.llvm.org/D20040
Files:
lib/Tooling/Core/QualTypeNames.cpp
unittests/Tooling/QualTypeNamesTest.cpp
Index: unittests/T
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM.
Thanks.
-eric
http://reviews.llvm.org/D19796
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
anemet added a comment.
Ping.
(I am getting a bit concerned that because this was already marked accepted, it
does not show up @rsmith' active queue...)
http://reviews.llvm.org/D19403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
RKSimon closed this revision.
RKSimon added a comment.
Fixed in http://reviews.llvm.org/rL265218
http://reviews.llvm.org/D18182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Mon May 9 18:06:14 2016
New Revision: 268988
URL: http://llvm.org/viewvc/llvm-project?rev=268988&view=rev
Log:
When forming a fully-qualified type name, put any qualifiers outside/before the
nested-name-specifier. Patch by Sterling Augustine!
Modified:
cfe/trunk/lib/Tool
rsmith closed this revision.
rsmith added a comment.
Committed as http://reviews.llvm.org/rL268988.
http://reviews.llvm.org/D20040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
- Original Message -
> From: "Anastasia Stulova via cfe-commits"
> To: "Matt Arsenault" , "Ettore Speziale"
> , "Aaron Ballman"
>
> Cc: "nd" , "Clang Commits"
> Sent: Monday, May 9, 2016 12:39:19 PM
> Subject: RE: [Clang] Convergent Attribute
>
> Since it's not a part of any official s
- Original Message -
> From: "Richard Smith via cfe-commits"
> To: "Matt Arsenault"
> Cc: "Clang Commits"
> Sent: Monday, May 9, 2016 4:45:04 PM
> Subject: Re: [Clang] Convergent Attribute
> On Mon, May 9, 2016 at 2:43 PM, Richard Smith < rich...@metafoo.co.uk
> > wrote:
> > On Sun, M
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1153
@@ +1152,3 @@
+def warn_non_template_friend : Warning<"friend declaration %q0 depends on "
+ "template parameter but is not a template function">,
+ InGroup;
template func
Author: jlebar
Date: Mon May 9 19:34:50 2016
New Revision: 269000
URL: http://llvm.org/viewvc/llvm-project?rev=269000&view=rev
Log:
[CUDA] Fix flush-denormals.cu test so that it checks what it intends to CHECK.
FileCheck does not evaluate plain CHECKs if you pass -check-prefix; you
have to ask f
Author: gbiv
Date: Mon May 9 20:59:34 2016
New Revision: 269005
URL: http://llvm.org/viewvc/llvm-project?rev=269005&view=rev
Log:
[Sema] Fix an overload resolution bug with enable_if.
Currently, if clang::isBetterOverloadCandidate encounters an enable_if
attribute on either candidate that it's i
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:686
@@ -685,3 +685,3 @@
const Expr *ArgExpr = nullptr;
if (Idx < Call.getNumArgs())
ArgExpr = Call.getArgExpr(Idx);
This conditional will assert if:
98 matches
Mail list logo
