rcox2 added a comment.
Of course, it would be my preference to mirror the functionality of what is
available in the "new" hierarchical form of optimization report Intel compiler.
So, I would like to distinguish between what Hal is proposing (which we call
an "annotated listing") and what I am
eric_niebler created this revision.
eric_niebler added a reviewer: bruno.
eric_niebler added a subscriber: cfe-commits.
Full discussion of this diff can be found here:
http://lists.llvm.org/pipermail/cfe-dev/2016-April/048298.html
See D19842 for the corresponding LLVM diff.
Before this is accep
Author: dyung
Date: Mon May 2 19:29:56 2016
New Revision: 268344
URL: http://llvm.org/viewvc/llvm-project?rev=268344&view=rev
Log:
Adding a test for a compiler crash that was fixed in r248069.
Differential Revision: http://reviews.llvm.org/D19048
Added:
cfe/trunk/test/Modules/Inputs/getSou
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268344: Adding a test for a compiler crash that was fixed in
r248069. (authored by dyung).
Changed prior to commit:
http://reviews.llvm.org/D19048?vs=55495&id=55925#toc
Repository:
rL LLVM
http://re
Author: ericwf
Date: Mon May 2 19:36:57 2016
New Revision: 268346
URL: http://llvm.org/viewvc/llvm-project?rev=268346&view=rev
Log:
Guard use of in test.
Modified:
libcxx/trunk/test/std/numerics/rand/rand.device/ctor.pass.cpp
Modified: libcxx/trunk/test/std/numerics/rand/rand.device/ctor.p
STL_MSFT added a comment.
I think this will work for me. Thanks!
http://reviews.llvm.org/D19758
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hfinkel added a comment.
In http://reviews.llvm.org/D19678#419361, @rcox2 wrote:
> Of course, it would be my preference to mirror the functionality of what is
> available in the "new" hierarchical form of optimization report Intel
> compiler. So, I would like to distinguish between what Hal is
Author: eugenezelenko
Date: Mon May 2 20:13:27 2016
New Revision: 268349
URL: http://llvm.org/viewvc/llvm-project?rev=268349&view=rev
Log:
[Clang-tidy] Fix Clang-tidy modernize-use-override and some Include What You
Use warnings in modernize/MakeSmartPtrCheck.h.
Modified:
clang-tools-extra/
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
Lift some common code used by multiple checkers.
This function is also used by checkers that are coming.
It is quite common for a checker to parse a list of names.
http://reviews.llvm.org
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thank you!
http://reviews.llvm.org/D19819
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: flx
Date: Mon May 2 20:41:19 2016
New Revision: 268352
URL: http://llvm.org/viewvc/llvm-project?rev=268352&view=rev
Log:
[clang-tidy] ProTypeMemberInitCheck - check that field decls do not have
in-class initializer.
Reviewers: alexfh, JVApen, aaron.ballman
Subscribers: flx, aaron.ballm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268352: [clang-tidy] ProTypeMemberInitCheck - check that
field decls do not have in… (authored by flx).
Changed prior to commit:
http://reviews.llvm.org/D18300?vs=51123&id=55934#toc
Repository:
rL LL
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/utils/Matchers.h:20
@@ -19,1 +19,3 @@
+AST_MATCHER_P(StringLiteral, lengthIs, unsigned, N) {
+ return Node.getLength() == N;
All these should go to
rjmccall added a comment.
This discussion of the command line interface makes me think that we should be
taking Richard's suggestion one step further. Why is Clang's involvement here
more than just handing down specific requests for optimization data to LLVM and
packaging that information back
flx created this revision.
flx added a reviewer: alexfh.
flx added a subscriber: cfe-commits.
flx set the repository for this revision to rL LLVM.
Repository:
rL LLVM
http://reviews.llvm.org/D19849
Files:
clang-tidy/misc/MoveConstructorInitCheck.cpp
test/clang-tidy/misc-move-constructor-in
wristow updated this revision to Diff 55936.
wristow added a comment.
Moved "test/PCH/pragma-once.h" to the "test/PCH/Inputs" directory (and changed
"pragma-once.c" appropriately).
http://reviews.llvm.org/D19815
Files:
include/clang/Lex/PreprocessorOptions.h
lib/Frontend/InitPreprocessor.c
Sorry, I meant remove the /store/, if it's dead. The do/while loop
overwrites the store immediately, so just remove the assignment to Record?
On Mon, May 2, 2016 at 2:59 PM, Apelete Seketeli via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> apelete added a comment.
>
> In http://reviews.llvm
Author: ericwf
Date: Mon May 2 21:04:26 2016
New Revision: 268354
URL: http://llvm.org/viewvc/llvm-project?rev=268354&view=rev
Log:
Don't use std::__clz in 'test/support/hexfloat.h'.
std::__clz is a libc++ specific function so it can't be used in the test suite.
This patch implements a dumb "cou
alexfh added inline comments.
Comment at: clang-tidy/misc/MoveConstructorInitCheck.cpp:114
@@ -114,1 +113,3 @@
+ "value argument %0 can be moved to avoid copy")
+ << MovableParam->getName();
DiagOut << FixItHint::CreateReplacement(
-
Author: ericwf
Date: Mon May 2 21:12:26 2016
New Revision: 268355
URL: http://llvm.org/viewvc/llvm-project?rev=268355&view=rev
Log:
[libcxx] [test] Replace non-Standard "atomic_flag f(false);" with Standard
"atomic_flag f;"
Summary:
Replace non-Standard "atomic_flag f(false);" with Standard "a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268355: [libcxx] [test] Replace non-Standard "atomic_flag
f(false);" with Standard… (authored by EricWF).
Changed prior to commit:
http://reviews.llvm.org/D19758?vs=55920&id=55937#toc
Repository:
rL
EricWF added a comment.
In http://reviews.llvm.org/D19412#417729, @rmaprath wrote:
> So, perhaps it is best to leave these pthread mutexes alone, purely for
> performance reasons. We'll have to excuse a couple of `#ifdef
> _LIBCPP_THREAD_API_` conditionals in the library sources to allow th
mcrosier added a subscriber: mcrosier.
mcrosier added a comment.
I believe the LLVM blog post is in error. Loop vectorization commonly
generates two versions of the loop: vectorized and scalar. The scalar loop is
necessary to handle the case where the trip count isn't evenly divisible by the
Author: etienneb
Date: Mon May 2 21:54:05 2016
New Revision: 268356
URL: http://llvm.org/viewvc/llvm-project?rev=268356&view=rev
Log:
[clang-tidy] Cleanup namespace in utils folder.
Summary:
This is a step forward cleaning up the namespaces in clang-tidy/utils.
There is no behavior change.
Revi
etienneb added a comment.
Who is the owner of ASTMatcher?
If he is willing to receive these matchers in ASTMatcher, I'll lift them.
Otherwise, we should at least lift them within clang-tidy.
http://reviews.llvm.org/D19841
___
cfe-commits mailing li
Author: ericwf
Date: Mon May 2 23:26:02 2016
New Revision: 268359
URL: http://llvm.org/viewvc/llvm-project?rev=268359&view=rev
Log:
Fix PR27538. Remove __is_convertible specializations for array and function
types.
This patch fixes a bunch of bugs in the fallback implementation of
is_convertibl
nicholas created this revision.
nicholas added a reviewer: cfe-commits.
The attached patch adds a warning when placing a call like:
func(*static_cast(nullptr));
to the existing -Wnull-dereference warning.
The existing warning catches the case where the empty lvalue undergoes
lvalue-to-rvalue c
mlemay-intel created this revision.
mlemay-intel added reviewers: pcc, eugenis.
mlemay-intel added a subscriber: cfe-commits.
SafeStack uses thread-local storage by default in most OSes for the unsafe stack
pointer. For SafeStack to be applied to functions that may be invoked while
initializing th
mlemay-intel created this revision.
mlemay-intel added reviewers: pcc, eugenis.
mlemay-intel added a subscriber: cfe-commits.
It is defined with support for the SafeStack sanitizer on x86.
http://reviews.llvm.org/D19854
Files:
lib/Driver/Driver.cpp
lib/Driver/ToolChains.cpp
lib/Driver/Tool
Author: ericwf
Date: Tue May 3 00:34:38 2016
New Revision: 268363
URL: http://llvm.org/viewvc/llvm-project?rev=268363&view=rev
Log:
Fix dependencies on install-libcxx CMake target
Modified:
libcxx/trunk/lib/CMakeLists.txt
Modified: libcxx/trunk/lib/CMakeLists.txt
URL:
http://llvm.org/viewv
mclow.lists added a comment.
How about not using XFAIL?
Instead, just test for those two conditions.
Psuedo-code:
#if defined(GLIBC)
#if GLIBC < 226
#error
#elif TEST_STD_VER >= 11
#error
#endif.
http://reviews.llvm.org/D19835
___
cfe-
Author: pxl
Date: Tue May 3 00:37:07 2016
New Revision: 268364
URL: http://llvm.org/viewvc/llvm-project?rev=268364&view=rev
Log:
[OpenCL] Fix pipe type dump.
Summary:
Fix the dump of PipeType.
Now we will have "pipe int" and element type.
Reviewers: yaxunl, Anastasia
Subscribers: cfe-commits,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268364: [OpenCL] Fix pipe type dump. (authored by pxl).
Changed prior to commit:
http://reviews.llvm.org/D19524?vs=55161&id=55946#toc
Repository:
rL LLVM
http://reviews.llvm.org/D19524
Files:
cfe/
EricWF added a subscriber: cfe-commits.
EricWF added a comment.
Adding cfe-commits to the subscribers.
http://reviews.llvm.org/D19856
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Fri, Apr 29, 2016 at 4:17 PM, Chris Bieneman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: cbieneman
> Date: Fri Apr 29 17:17:15 2016
> New Revision: 268124
>
> URL: http://llvm.org/viewvc/llvm-project?rev=268124&view=rev
> Log:
> [CMake] Create a separate install target for li
EricWF added a comment.
In http://reviews.llvm.org/D19835#419547, @mclow.lists wrote:
> How about not using XFAIL?
> Instead, just test for those two conditions.
>
> Psuedo-code:
>
> #if defined(GLIBC)
> #if GLIBC < 226
> #error
> #elif TEST_STD_VER >= 11
> #error
> #endif.
Because
apelete added a comment.
In http://reviews.llvm.org/D19831#419456, @dblaikie wrote:
> Sorry, I meant remove the /store/, if it's dead. The do/while loop
> overwrites the store immediately, so just remove the assignment to Record?
Makes sense, I overlooked that. Will fix in next revision.
htt
apelete updated this revision to Diff 55952.
apelete added a comment.
[scan-build] fix dead store warnings emitted on clang code base
Changes since last revision:
- remove dead store since the do {} while() loop overwrite it immediatly anyway.
http://reviews.llvm.org/D19831
Files:
tools/c-i
101 - 138 of 138 matches
Mail list logo
