r268213 - [Clang][BuiltIn][avx512] Adding intrinsics for vpshufd instruction set

Author: mzuckerm Date: Mon May 2 02:35:27 2016 New Revision: 268213 URL: http://llvm.org/viewvc/llvm-project?rev=268213&view=rev Log: [Clang][BuiltIn][avx512] Adding intrinsics for vpshufd instruction set Differential Revision: http://reviews.llvm.org/D19580 Modified: cfe/trunk/include/cl

Re: [PATCH] D19183: [clang-tidy] Add modernize-make-shared check

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D19183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D19534: [clang-tidy] new google-default-arguments check

hokein added inline comments. Comment at: clang-tidy/google/DefaultArgumentsCheck.cpp:31 @@ +30,3 @@ + diag(MatchedDecl->getLocation(), + "default argument given for virtual or override method."); +} Usually, clang-tidy's warning message is not a sentence,

r268214 - [Clang][avx512][builtin] Adding intrinsics for vexpand{d|q|ps|pd} instrctuon set

Author: mzuckerm Date: Mon May 2 03:36:41 2016 New Revision: 268214 URL: http://llvm.org/viewvc/llvm-project?rev=268214&view=rev Log: [Clang][avx512][builtin] Adding intrinsics for vexpand{d|q|ps|pd} instrctuon set Differential Revision: http://reviews.llvm.org/D19467 Modified: cfe/trunk/i

r268217 - [Clang][AVX512][BuiltIn] Adding intrinsics for cvtps2pd instruction set

Author: mzuckerm Date: Mon May 2 04:42:31 2016 New Revision: 268217 URL: http://llvm.org/viewvc/llvm-project?rev=268217&view=rev Log: [Clang][AVX512][BuiltIn] Adding intrinsics for cvtps2pd instruction set Differential Revision: http://reviews.llvm.org/D19774 Modified: cfe/trunk/include/cla

[PATCH] D19802: Fix a crash in cppcoreguidelines-pro-type-member-init when checking a class that initializes itself as a base

michael_miller created this revision. michael_miller added reviewers: hokein, alexfh, aaron.ballman. michael_miller added a subscriber: cfe-commits. Fix a crash when a record type initializes itself in its own base class initializer list. http://reviews.llvm.org/D19802 Files: clang-tidy/cppco

[PATCH] D19796: Add new intrinsic support for MONITORX and MWAITX instructions.

GGanesh created this revision. GGanesh added reviewers: echristo, craig.topper. GGanesh added subscribers: cfe-commits, llvm-commits. Herald added a subscriber: joker.eph. This patch adds new intrinsics, new flag (-mwaitx) and flag enablement based on cpuid for the instructions MONITORX and MWAIT

Re: [PATCH] D19769: [clang-tidy] Add explicitly given array size heuristic to misc-suspicious-missing-comma check.

szdominik added inline comments. Comment at: clang-tidy/misc/SuspiciousMissingCommaCheck.cpp:94 @@ -93,3 +93,3 @@ Finder->addMatcher(StringsInitializerList.bind("list"), this); } etienneb wrote: > If it's working as-is,... this is neat :) Well, the array fi

Re: [PATCH] D19769: [clang-tidy] Add explicitly given array size heuristic to misc-suspicious-missing-comma check.

szdominik marked 3 inline comments as done. Comment at: clang-tidy/misc/SuspiciousMissingCommaCheck.cpp:106 @@ +105,3 @@ + if (InitializerList->hasArrayFiller()) { + diag(InitializerList->getExprLoc(), + "wrong string array initialization: " etienn

Re: [clang-tools-extra] r268140 - [Release Notes] Mention Clang-tidy cert-err34-c check.

On Fri, Apr 29, 2016 at 8:11 PM, Eugene Zelenko via cfe-commits wrote: > Author: eugenezelenko > Date: Fri Apr 29 19:11:10 2016 > New Revision: 268140 > > URL: http://llvm.org/viewvc/llvm-project?rev=268140&view=rev > Log: > [Release Notes] Mention Clang-tidy cert-err34-c check. Thank you for thi

Re: [PATCH] D19754: Allow 'nodebug' on local variables

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:86-88 @@ -85,1 +85,5 @@ +def NonParmVar : SubsetSubjectgetKind() != Decl::ImplicitParam && + S->getKind() != Decl::ParmVar && + S->getKind()

Re: [PATCH] D19802: Fix a crash in cppcoreguidelines-pro-type-member-init when checking a class that initializes itself as a base

aaron.ballman added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:342 @@ +341,3 @@ + +template +class PositiveSelfInitialization : NegativeAggregateType Is it required to be a templated class to trigger the crash? http:

Re: [PATCH] D14274: Add alloc_size attribute to clang

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you for working on this! LGTM, but please wait for @rsmith to okay as well. Comment at: test/SemaCXX/constant-expression-cxx11.cpp:1171 @@ -1170,3 +1170,3

[PATCH] D19804: Make clang-format cleaner remove redundant commas/colons in constructor initializer list.

ioeric created this revision. ioeric added reviewers: djasper, klimek. ioeric added a subscriber: cfe-commits. Herald added a subscriber: klimek. Make clang-format cleaner remove redundant commas/colons in constructor initializer list. http://reviews.llvm.org/D19804 Files: lib/Format/Format.c

r268230 - [CLANG][AVX512][BUILTIN]movap{d|s}{128|256|512}

Author: mzuckerm Date: Mon May 2 09:02:01 2016 New Revision: 268230 URL: http://llvm.org/viewvc/llvm-project?rev=268230&view=rev Log: [CLANG][AVX512][BUILTIN]movap{d|s}{128|256|512} Differential Revision: http://reviews.llvm.org/D17818 Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def

Re: [PATCH] D19770: Add FixedSizeStorage to TrailingObjects; NFC

hubert.reinterpretcast updated this revision to Diff 55820. hubert.reinterpretcast added a comment. Replace alias template with struct and typedef member; add usage example http://reviews.llvm.org/D19770 Files: include/llvm/Support/TrailingObjects.h Index: include/llvm/Support/TrailingObject

Re: [PATCH] D19770: Add FixedSizeStorage to TrailingObjects; NFC

hubert.reinterpretcast marked 5 inline comments as done. hubert.reinterpretcast added a comment. Responded to all comments. http://reviews.llvm.org/D19770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D19771: Rework FixedSizeTemplateParameterListStorage

hubert.reinterpretcast updated this revision to Diff 55825. hubert.reinterpretcast added a comment. Adjust for changes to http://reviews.llvm.org/D19770 http://reviews.llvm.org/D19771 Files: include/clang/AST/DeclTemplate.h Index: include/clang/AST/DeclTemplate.h

Re: [PATCH] D19754: Allow 'nodebug' on local variables

probinson added inline comments. Comment at: include/clang/Basic/Attr.td:86-88 @@ -85,1 +85,5 @@ +def NonParmVar : SubsetSubjectgetKind() != Decl::ImplicitParam && + S->getKind() != Decl::ParmVar && + S->getKind() !=

Re: [PATCH] D19403: Add loop pragma for Loop Distribution

anemet added a comment. @rsmith, hi! Do you have any comments on this or you're OK with this per Aaron's LGTM? Thanks, Adam http://reviews.llvm.org/D19403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D19811: [clang-tidy] Cleaning namespaces to be more consistant across checkers.

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. The goal of the patch is to bring checkers in their appropriate namespace. This path doesn't change any behavior. http://reviews.llvm.org/D19811 Files: clang-tidy/cert/CERTTidyModule.cp

Re: [PATCH] D19625: [libc++] Void-cast runtime-unused variables.

STL_MSFT added a comment. No problem! With these changes, my test runs are currently clean wrt "warning C4100: unreferenced formal parameter" and "warning C4101: unreferenced local variable", but note that (1) Clang may emit unused-variable warnings in somewhat different situations, and (2) I'v

Re: [PATCH] D19811: [clang-tidy] Cleaning namespaces to be more consistant across checkers.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks! http://reviews.llvm.org/D19811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D19812: [OpenMP] Check for associated statements with hasAssociatedStmt() when scanning for device code.

sfantao created this revision. sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0. sfantao added subscribers: caomhin, cfe-commits. `getAssociatedStmt()` contains an assertion that assumes the statement always exists. In device code scanning, we need to look into the

[clang-tools-extra] r268253 - [clang-tidy] Add modernize-make-shared check

Author: prazek Date: Mon May 2 11:56:39 2016 New Revision: 268253 URL: http://llvm.org/viewvc/llvm-project?rev=268253&view=rev Log: [clang-tidy] Add modernize-make-shared check Because modernize-make-shared do almost the same job as modernize-make-unique, I refactored common code to MakeSmartPtr

Re: [PATCH] D19484: [OpenCL] Add supported OpenCL extensions to target info.

yaxunl added inline comments. Comment at: test/CodeGenOpenCL/builtins-r600.cl:2 @@ -1,3 +1,3 @@ // REQUIRES: amdgpu-registered-target -// RUN: %clang_cc1 -triple r600-unknown-unknown -S -emit-llvm -o - %s | FileCheck %s +// RUN: %clang_cc1 -triple r600-unknown-unknown -target-cp

Re: [PATCH] D19484: [OpenCL] Add supported OpenCL extensions to target info.

yaxunl updated this revision to Diff 55839. yaxunl marked 2 inline comments as done. yaxunl added a comment. Add comments about macros for enumerating extensions. Improve diagnostics about extensions. http://reviews.llvm.org/D19484 Files: include/clang/Basic/DiagnosticParseKinds.td include/

r268256 - [WebAssembly] Rename memory_size intrinsic to current_memory

Author: dschuff Date: Mon May 2 12:26:19 2016 New Revision: 268256 URL: http://llvm.org/viewvc/llvm-project?rev=268256&view=rev Log: [WebAssembly] Rename memory_size intrinsic to current_memory This follows the recent change in the wasm spec. Modified: cfe/trunk/include/clang/Basic/Builtins

[PATCH] D19815: Support '#pragma once' in headers when using PCH

wristow created this revision. wristow added a reviewer: rsmith. wristow added a subscriber: cfe-commits. The '#pragma once' directive was erroneously ignored when encountered in the header-file specified in generate-PCH-mode. This resulted in compile-time errors in some cases with legal code, an

Re: [PATCH] D19815: Support '#pragma once' in headers when using PCH

wristow added a comment. To check for whether we're in "generate a PCH file mode", I added a new flag (`GeneratePCHMode`) to `PreprocessorOptions`. If the `CompilerInstance` had been visible in lexical analysis, it would have been easy to do this without adding a new flag. Is there a better w

Re: [PATCH] D19756: Expand aggregate arguments more often on 32-bit Windows

rnk marked an inline comment as done. rnk added a comment. In http://reviews.llvm.org/D19756#417718, @hans wrote: > This is awesome! lgtm Great! > Want to reference PR27522 in the patch description? > > Also in the description: > > > I also expanded the workaround handle C++ records with

r268261 - Expand aggregate arguments more often on 32-bit Windows

Author: rnk Date: Mon May 2 12:41:07 2016 New Revision: 268261 URL: http://llvm.org/viewvc/llvm-project?rev=268261&view=rev Log: Expand aggregate arguments more often on 32-bit Windows Before this change, we would pass all non-HFA record arguments on Windows with byval. Byval often blocks optimi

Re: [PATCH] D19756: Expand aggregate arguments more often on 32-bit Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL268261: Expand aggregate arguments more often on 32-bit Windows (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D19756?vs=55695&id=55845#toc Repository: rL LLVM http://reviews.ll

Re: [PATCH] D19755: [include-fixer] Fix Clang-tidy modernize-use-override and some Include What You Use warnings

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rL LLVM http://reviews.llvm.org/D19755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[clang-tools-extra] r268262 - [include-fixer] Fix Clang-tidy modernize-use-override and some Include What You Use warnings.

Author: eugenezelenko Date: Mon May 2 12:49:00 2016 New Revision: 268262 URL: http://llvm.org/viewvc/llvm-project?rev=268262&view=rev Log: [include-fixer] Fix Clang-tidy modernize-use-override and some Include What You Use warnings. Differential revision: http://reviews.llvm.org/D19755 Modifie

Re: [PATCH] D19755: [include-fixer] Fix Clang-tidy modernize-use-override and some Include What You Use warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rL268262: [include-fixer] Fix Clang-tidy modernize-use-override and some Include What… (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D19755?vs=55694&id=55849#toc Repositor

Re: [PATCH] D19802: Fix a crash in cppcoreguidelines-pro-type-member-init when checking a class that initializes itself as a base

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:342 @@ +341,3 @@ + +template +class PositiveSelfInitialization : NegativeAggregateType --

Re: [PATCH] D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC

hubert.reinterpretcast updated this revision to Diff 55850. hubert.reinterpretcast added a comment. Address Faisal's comment; supercedes http://reviews.llvm.org/D19771 Replaces the custom FixedSizeTemplateParameterListStorage implementation with one that follows the interface provided by llvm::T

Re: [PATCH] D19815: Support '#pragma once' in headers when using PCH

rnk added a subscriber: rnk. rnk added a comment. I think threading this through PP options is reasonable. Comment at: test/PCH/pragma-once.h:1 @@ +1,2 @@ +#pragma once + This should be in test/PCH/Inputs http://reviews.llvm.org/D19815 _

[clang-tools-extra] r268264 - [clang-tidy] Cleaning namespaces to be more consistant across checkers.

Author: etienneb Date: Mon May 2 13:00:29 2016 New Revision: 268264 URL: http://llvm.org/viewvc/llvm-project?rev=268264&view=rev Log: [clang-tidy] Cleaning namespaces to be more consistant across checkers. Summary: The goal of the patch is to bring checkers in their appropriate namespace. This p

Re: [PATCH] D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC

hubert.reinterpretcast marked 2 inline comments as done. hubert.reinterpretcast added a comment. @rsmith; I've addressed Faisal's comment. Please let me know if this patch (and http://reviews.llvm.org/D19770) is good to go. If it isn't ready yet, I'd like your opinion on http://reviews.llvm.org/

Re: [PATCH] D19802: Fix a crash in cppcoreguidelines-pro-type-member-init when checking a class that initializes itself as a base

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with a commenting request. Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:342 @@ +341,3 @@ + +template +class PositiveSelfInitialization : NegativeAggregateType ho

Re: [PATCH] D19567: PR21823: 'nodebug' attribute on global/static variables

dblaikie added a comment. In http://reviews.llvm.org/D19567#414906, @probinson wrote: > Huh. There are strange interactions here, which makes me even more nervous > about testing fewer cases. Generally this sort of thing makes me more interested in testing fewer cases so we can see/make sure

[PATCH] D19819: [clang-tidy] Cleanup namespace in utils folder.

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. This is a step forward cleaning up the namespaces in clang-tidy/utils. There is no behavior change. http://reviews.llvm.org/D19819 Files: clang-tidy/cppcoreguidelines/ProBoundsConstantA

Re: [PATCH] D19754: Allow 'nodebug' on local variables

dblaikie added inline comments. Comment at: test/CodeGenCXX/debug-info-nodebug.cpp:50 @@ -49,1 +49,3 @@ NODEBUG static int static_local = 6; + NODEBUG const int const_local = 7; + NODEBUGint normal_local = 8; Doesn't look like the const case is any d

Re: [PATCH] D19819: [clang-tidy] Cleanup namespace in utils folder.

etienneb updated this revision to Diff 55858. etienneb added a comment. add missing case http://reviews.llvm.org/D19819 Files: clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.h clang-tidy/cppcoreguidelines/Pro

Re: [PATCH] D19758: [libcxx] [test] Replace non-Standard "atomic_flag f(false); " with Standard "atomic_flag f = ATOMIC_FLAG_INIT; ".

EricWF added a comment. This is a small problem. We actually provide in C++03 minus `ATOMIC_FLAG_INIT` since it requires C++11. I'll come up with a way to fix these tests so they keep working in C++03. http://reviews.llvm.org/D19758 ___ cfe-commit

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna marked 8 inline comments as done. krystyna added a comment. Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r268284 - Void cast runtime-unused variables. Patch from s...@microsoft.com

Author: ericwf Date: Mon May 2 14:15:48 2016 New Revision: 268284 URL: http://llvm.org/viewvc/llvm-project?rev=268284&view=rev Log: Void cast runtime-unused variables. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/depr/depr.c.headers/setjmp_h.pass.cpp libcxx/trunk/test/st

Re: [PATCH] D19625: [libc++] Void-cast runtime-unused variables.

EricWF closed this revision. EricWF added a comment. r268284. In http://reviews.llvm.org/D19625#418697, @STL_MSFT wrote: > No problem! With these changes, my test runs are currently clean wrt "warning > C4100: unreferenced formal parameter" and "warning C4101: unreferenced local > variable", b

Re: [PATCH] D19623: [libcxx] [test] Initialize local doubles to NaN.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I have no objections to this change. Howard seems to agree. http://reviews.llvm.org/D19623 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

Re: [PATCH] D19758: [libcxx] [test] Replace non-Standard "atomic_flag f(false); " with Standard "atomic_flag f = ATOMIC_FLAG_INIT; ".

STL_MSFT added a comment. Since you control the definition of ATOMIC_FLAG_INIT, can you make it something like __secret_tag_type() in C++03? That would allow you to continue to provide the atomic_flag(bool) extension in C++03. http://reviews.llvm.org/D19758

[libcxx] r268285 - Initialize local doubles to NaN. Patch from s...@microsoft.com

Author: ericwf Date: Mon May 2 14:20:16 2016 New Revision: 268285 URL: http://llvm.org/viewvc/llvm-project?rev=268285&view=rev Log: Initialize local doubles to NaN. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/numerics/rand/rand.dis/rand.dist.samp/rand.dist.samp.plinear/eva

Re: [PATCH] D19623: [libcxx] [test] Initialize local doubles to NaN.

EricWF closed this revision. EricWF added a comment. r268285. http://reviews.llvm.org/D19623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19758: [libcxx] [test] Replace non-Standard "atomic_flag f(false); " with Standard "atomic_flag f = ATOMIC_FLAG_INIT; ".

EricWF added a comment. I actually want this form of initialization to break in C++03, From the original review: > After putting this question up on cfe-dev I have decided that it would be > best to allow the use of in C++03. Although static initialization is > a concern the syntax required t

Re: [PATCH] D19758: [libcxx] [test] Replace non-Standard "atomic_flag f(false); " with Standard "atomic_flag f = ATOMIC_FLAG_INIT; ".

STL_MSFT added a comment. Makes sense. MSVC will never have C++03 or C++11 modes (only 14/17/future) so anything you do in C++03 mode is fine by me. http://reviews.llvm.org/D19758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna added a comment. hide done comments Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna updated this revision to Diff 55867. Repository: rL LLVM http://reviews.llvm.org/D18919 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseUsingCheck.cpp clang-tidy/modernize/UseUsingCheck.h docs/clang-tidy/checks/

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna marked 4 inline comments as done. krystyna added a comment. Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19819: [clang-tidy] Cleanup namespace in utils folder.

etienneb updated this revision to Diff 55876. etienneb added a comment. fix unittests http://reviews.llvm.org/D19819 Files: clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.h clang-tidy/cppcoreguidelines/ProTyp

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

yaxunl added inline comments. Comment at: lib/Headers/opencl-c.h:4872 @@ +4871,3 @@ + +#ifdef cl_khr_fp64 +char __const_func __attribute__((overloadable)) convert_char(double); Anastasia wrote: > Interesting, macro has the same name as an extension? The spec requi

[libcxx] r268294 - Cleanup warnings and remove use of __builtin_va_list in depr.c.headers

Author: ericwf Date: Mon May 2 15:08:16 2016 New Revision: 268294 URL: http://llvm.org/viewvc/llvm-project?rev=268294&view=rev Log: Cleanup warnings and remove use of __builtin_va_list in depr.c.headers Modified: libcxx/trunk/test/std/depr/depr.c.headers/fenv_h.pass.cpp libcxx/trunk/test

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

yaxunl added a comment. typo. saved 300KB space. http://reviews.llvm.org/D18369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D19827: Do not disable completely loop unroll according to optimization level.

mamai created this revision. mamai added a reviewer: chandlerc. mamai added a subscriber: cfe-commits. mamai set the repository for this revision to rL LLVM. By disabling completely the loop unroll at some optimization levels (e.g. /Os), the #pragma unroll have no effect at those optimization lev

Re: [PATCH] D19708: [CGDebugInfo] Generate debug info for member calls in the context of the callee expression

- Original Message - > From: "David Blaikie" > To: reviews+d19708+public+e9ddc42503732...@reviews.llvm.org, "Hal Finkel" > > Cc: "Richard Smith" , "Adrian Prantl" > , "Duncan P. N. Exon Smith" > , "Eric Christopher" , "Jun Bum > Lim" , > "cfe-commits" > Sent: Friday, April 29, 2016 4:

r268297 - Revert "[Driver] Quote clang full version in dwarf producer when invoking cc1as"

Author: bruno Date: Mon May 2 15:20:49 2016 New Revision: 268297 URL: http://llvm.org/viewvc/llvm-project?rev=268297&view=rev Log: Revert "[Driver] Quote clang full version in dwarf producer when invoking cc1as" This reverts commit r264813 / 6484b95d634f53dd929c75265ef3c4decf397584. While using

[PATCH] D19829: [scan-build] fix dead store warnings emitted on clang code base

apelete created this revision. apelete added reviewers: rjmccall, rtrieu, rsmith. apelete added a subscriber: cfe-commits. This fixes dead store warnings of the type "dead assignment" reported by CLang Static Analyzer on the following files: - lib/Sema/SemaDeclCXX.cpp, - lib/Sema/SemaExpr.cpp, -

[PATCH] D19830: [scan-build] fix dead store warnings emitted on clang code base

apelete created this revision. apelete added a reviewer: doug.gregor. apelete added a subscriber: cfe-commits. This fixes dead store warnings of the type "dead assignment" reported by CLang Static Analyzer on the following files: - lib/Lex/Lexer.cpp, - lib/Lex/ModuleMap.cpp. Signed-off-by: Apele

Re: [PATCH] D19748: [CUDA] Make sure device-side __global__ functions are always visible.

This revision was automatically updated to reflect the committed changes. Closed by commit rL268299: [CUDA] Make sure device-side __global__ functions are always visible. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D19748?vs=55674&id=55885#toc Repository: rL LLVM htt

r268299 - [CUDA] Make sure device-side __global__ functions are always visible.

Author: tra Date: Mon May 2 15:30:03 2016 New Revision: 268299 URL: http://llvm.org/viewvc/llvm-project?rev=268299&view=rev Log: [CUDA] Make sure device-side __global__ functions are always visible. __global__ functions are a special case in CUDA. Even when the symbol would normally not be exte

[PATCH] D19831: [scan-build] fix dead store warnings emitted on clang code base

apelete created this revision. apelete added a reviewer: akyrtzi. apelete added a subscriber: cfe-commits. This fixes dead store warnings of the type "dead assignment" reported by CLang Static Analyzer on the following file: - tools/c-index-test/c-index-test.c. Signed-off-by: Apelete Seketeli

Re: [PATCH] D19831: [scan-build] fix dead store warnings emitted on clang code base

Any reason not to remove the story instead? On Mon, May 2, 2016 at 1:36 PM, Apelete Seketeli via cfe-commits < cfe-commits@lists.llvm.org> wrote: > apelete created this revision. > apelete added a reviewer: akyrtzi. > apelete added a subscriber: cfe-commits. > > This fixes dead store warnings of

[PATCH] D19835: Tolerate incorrect return type for 'isinf' and 'isnan' it tests.

EricWF created this revision. EricWF added reviewers: rsmith, mclow.lists. EricWF added a subscriber: cfe-commits. GLIBC recently removed the incorrect `int isinf(double)` and `int isnan(double)` overloads in C++11 and greater. This causes previously `XFAIL: linux` tests to start passing. Sinc

Re: [PATCH] D19835: Tolerate incorrect return type for 'isinf' and 'isnan' in tests.

jroelofs added a subscriber: jroelofs. jroelofs added a comment. I think you could lean on the linker to cause the test to fail when the type is wrong: bool isinf(double); typedef int (*expected_signature)(double); void assert_via_linker(decltype(isinf) blah); void assert_via_linke

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Prazek added a comment. lgtm, but I'd rather see Hokein acceptance. Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Eugene.Zelenko added a comment. Check is still not mentioned in docs/ReleaseNotes.rst. Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D19835: Tolerate incorrect return type for 'isinf' and 'isnan' in tests.

EricWF added a comment. In http://reviews.llvm.org/D19835#419211, @jroelofs wrote: > I think you could lean on the linker to cause the test to fail when the type > is wrong: > > bool isinf(double); > > typedef int (*expected_signature)(double); > > void assert_via_linker(decltype(isinf

r268314 - [CodeGenObjCXX] Don't rematerialize default arguments of function

Author: ahatanak Date: Mon May 2 16:52:57 2016 New Revision: 268314 URL: http://llvm.org/viewvc/llvm-project?rev=268314&view=rev Log: [CodeGenObjCXX] Don't rematerialize default arguments of function parameters in the body of a block. This fixes a bug where clang would materialize the default ar

Re: [PATCH] D19831: [scan-build] fix dead store warnings emitted on clang code base

apelete added a comment. In http://reviews.llvm.org/D19831#419140, @dblaikie wrote: > Any reason not to remove the story instead? What do you mean by "remove the story" ? http://reviews.llvm.org/D19831 ___ cfe-commits mailing list cfe-commits@lis

Re: r268314 - [CodeGenObjCXX] Don't rematerialize default arguments of function

On Mon, May 2, 2016 at 2:52 PM, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ahatanak > Date: Mon May 2 16:52:57 2016 > New Revision: 268314 > > URL: http://llvm.org/viewvc/llvm-project?rev=268314&view=rev > Log: > [CodeGenObjCXX] Don't rematerialize default argum

Re: r268314 - [CodeGenObjCXX] Don't rematerialize default arguments of function

I see. Perhaps this should be an assert? > On May 2, 2016, at 3:05 PM, Richard Smith wrote: > > On Mon, May 2, 2016 at 2:52 PM, Akira Hatanaka via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: ahatanak > Date: Mon May 2 16:52:57 2016 > New Revision: 268314 > > URL: http:/

Re: r268314 - [CodeGenObjCXX] Don't rematerialize default arguments of function

It looks like turning it to an assert wouldn’t be correct, I’ll probably just remove it. > On May 2, 2016, at 3:12 PM, Akira Hatanaka via cfe-commits > wrote: > > I see. Perhaps this should be an assert? > >> On May 2, 2016, at 3:05 PM, Richard Smith > > wrote: >

Re: [PATCH] D19802: Fix a crash in cppcoreguidelines-pro-type-member-init when checking a class that initializes itself as a base

michael_miller added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:342 @@ +341,3 @@ + +template +class PositiveSelfInitialization : NegativeAggregateType aaron.ballman wrote: > hokein wrote: > > aaron.ballman wrote: > > >

r268318 - Remove unneeded test in tryCaptureAsConstant.

Author: ahatanak Date: Mon May 2 17:29:40 2016 New Revision: 268318 URL: http://llvm.org/viewvc/llvm-project?rev=268318&view=rev Log: Remove unneeded test in tryCaptureAsConstant. It isn't necessary to call hasDefaultArg because we can't rematerialize a captured variable that is a function param

Re: [PATCH] D19536: [CodeGenObjCXX] Fix handling of blocks in lambda

ahatanak added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:806 @@ -792,1 +805,3 @@ + } + src = Builder.CreateStructGEP(Addr, Idx, Offset, FD->getName()); } else { rjmccall wrote: > Hmm. It's become increasingly clear that my original deci

Re: [PATCH] D19802: Fix a crash in cppcoreguidelines-pro-type-member-init when checking a class that initializes itself as a base

michael_miller marked 4 inline comments as done. Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:342 @@ +341,3 @@ + +// This pathological template fails to compile if actually instantiated. It +// results in the check seeing a null RecordDecl when examining

Re: [PATCH] D19802: Fix a crash in cppcoreguidelines-pro-type-member-init when checking a class that initializes itself as a base

michael_miller updated this revision to Diff 55904. michael_miller added a comment. Added a comment explaining the new test added. http://reviews.llvm.org/D19802 Files: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp Index:

Re: [PATCH] D19835: Tolerate incorrect return type for 'isinf' and 'isnan' in tests.

jroelofs added a comment. > Alternatively `static_assert(std::is_same bool>::value);` :-P > > Testing the return type isn't the problem. The problem is telling LIT *when* > we expect the test to fail using the `XFAIL` directive. O. I see. http://reviews.llvm.org/D19835 ___

Re: r268314 - [CodeGenObjCXX] Don't rematerialize default arguments of function

Thanks, fixed in r268318. > On May 2, 2016, at 3:05 PM, Richard Smith wrote: > > On Mon, May 2, 2016 at 2:52 PM, Akira Hatanaka via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: ahatanak > Date: Mon May 2 16:52:57 2016 > New Revision: 268314 > > URL: http://llvm.org/viewv

r268319 - [CMake] Adding clang-headers to the Apple-stage2 distribution

Author: cbieneman Date: Mon May 2 17:38:06 2016 New Revision: 268319 URL: http://llvm.org/viewvc/llvm-project?rev=268319&view=rev Log: [CMake] Adding clang-headers to the Apple-stage2 distribution This installs the clang headers as part of the install-distribution target. Modified: cfe/trun

r268321 - Fix argument expansion of reference fields of structs

Author: rnk Date: Mon May 2 17:42:34 2016 New Revision: 268321 URL: http://llvm.org/viewvc/llvm-project?rev=268321&view=rev Log: Fix argument expansion of reference fields of structs r268261 made Clang "expand" more struct arguments on Windows. It removed the check for 'RD->isCLike()', which was

r268320 - [CMake] Install libcxx-headers as part of the Apple-stage2 distribution

Author: cbieneman Date: Mon May 2 17:42:09 2016 New Revision: 268320 URL: http://llvm.org/viewvc/llvm-project?rev=268320&view=rev Log: [CMake] Install libcxx-headers as part of the Apple-stage2 distribution This installs the clang headers as part of the install-distribution target. Modified:

r268322 - [CMake] Enable LIBCXX HEADERS in Apple-Stage2.cmake

Author: cbieneman Date: Mon May 2 17:43:23 2016 New Revision: 268322 URL: http://llvm.org/viewvc/llvm-project?rev=268322&view=rev Log: [CMake] Enable LIBCXX HEADERS in Apple-Stage2.cmake This enables installing the libcxx headers. Modified: cfe/trunk/cmake/caches/Apple-stage2.cmake Modifie

Re: [PATCH] D19678: Annotated-source optimization reports (a.k.a. "listing" files)

hfinkel updated this revision to Diff 55907. hfinkel added a comment. Renamed the option from -flisting to -foptimization-report as suggested. Moved I/O-related and formatting-related code into Frontend. http://reviews.llvm.org/D19678 Files: include/clang/Driver/CC1Options.td include/clang

Re: [PATCH] D19802: Fix a crash in cppcoreguidelines-pro-type-member-init when checking a class that initializes itself as a base

aaron.ballman added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:342 @@ +341,3 @@ + +// This pathological template fails to compile if actually instantiated. It +// results in the check seeing a null RecordDecl when examining the base cla

Re: [PATCH] D19678: Annotated-source optimization reports (a.k.a. "listing" files)

hfinkel added a comment. In http://reviews.llvm.org/D19678#416127, @rcox2 wrote: > Actually, the Intel compiler distinguishes between an optimization report > (-qopt-report) and an annotated listing (-qopt-report-annotate). The > optimization report lists the info for optimizations in a hierar

Re: [PATCH] D19678: Annotated-source optimization reports (a.k.a. "listing" files)

On Mon, May 2, 2016 at 4:14 PM, Hal Finkel via cfe-commits < cfe-commits@lists.llvm.org> wrote: > hfinkel added a comment. > > In http://reviews.llvm.org/D19678#416127, @rcox2 wrote: > > > Actually, the Intel compiler distinguishes between an optimization > report (-qopt-report) and an annotated l

[PATCH] D19841: [clang-tidy] Lift common matchers to utils namespace

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. This patch is lifting matchers used by more than one checkers to the common namespace. http://reviews.llvm.org/D19841 Files: clang-tidy/misc/BoolPointerImplicitConversionCheck.cpp cla

Re: [PATCH] D19758: [libcxx] [test] Replace non-Standard "atomic_flag f(false); " with Standard "atomic_flag f = ATOMIC_FLAG_INIT; ".

EricWF commandeered this revision. EricWF edited reviewers, added: STL_MSFT; removed: EricWF. EricWF added a comment. Stealing this review from STL. http://reviews.llvm.org/D19758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

Re: [PATCH] D19758: [libcxx] [test] Replace non-Standard "atomic_flag f(false); " with Standard "atomic_flag f; "

EricWF retitled this revision from "[libcxx] [test] Replace non-Standard "atomic_flag f(false);" with Standard "atomic_flag f = ATOMIC_FLAG_INIT;"." to "[libcxx] [test] Replace non-Standard "atomic_flag f(false);" with Standard "atomic_flag f;" ". EricWF updated the summary for this revision. Er

  1   2   >