szdominik added inline comments.
================
Comment at: clang-tidy/misc/SuspiciousMissingCommaCheck.cpp:94
@@ -93,3 +93,3 @@
Finder->addMatcher(StringsInitializerList.bind("list"), this);
}
----------------
etienneb wrote:
> If it's working as-is,... this is neat :)
Well, the array filler has a problematic limitation.
I forget that I used the explicit given size for reduce false positives in my
checker.
e.g.
```
struct MusicIntervalArray {
int n;
const char* list[5];
} intervals[2] = {
{5, {"second", "third", "fourth", "fifth" "sixth"}},
{5, {"ninth", "tenth", "eleventh", "twelfth", "thir" "teenth"}},
};
```
The first is simple: has array filler, so warn because of size.
But the second one is a good initialization, it has 5 elements, which is the
explicit size. But your implementation warns us, that there is a missing comma.
If I work with the length (from declaration or type), I can filter these cases.
http://reviews.llvm.org/D19769
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
