r267338 - Improve diagnostic checking for va_start to also warn on other instances of undefined behavior, such as a parameter declared with the register keyword in C, or a parameter of a type that und

2016-04-24 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sun Apr 24 08:30:21 2016 New Revision: 267338 URL: http://llvm.org/viewvc/llvm-project?rev=267338&view=rev Log: Improve diagnostic checking for va_start to also warn on other instances of undefined behavior, such as a parameter declared with the register keyword in C,

Re: [PATCH] D19244: Extend checking of va_start builtin

2016-04-24 Thread Aaron Ballman via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit in r267338. http://reviews.llvm.org/D19244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19458: Add address space 258 to Clang documentation

2016-04-24 Thread Michael Kuperstein via cfe-commits
mkuper accepted this revision. mkuper added a comment. This revision is now accepted and ready to land. LGTM with a small nit - can you change the heading from "Memory references off the GS segment" to something more general? http://reviews.llvm.org/D19458 ___

Re: [PATCH] D19204: clang-format: [JS] generator and async functions.

2016-04-24 Thread Daniel Jasper via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D19204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

2016-04-24 Thread Haojian Wu via cfe-commits
hokein added inline comments. Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:49 @@ -47,1 +48,3 @@ CheckFactories.registerCheck("modernize-use-override"); +CheckFactories.registerCheck( +"modernize-use-using"); You can put it in one-line,

Re: [PATCH] D19183: [clang-tidy] Add modernize-make-shared check

2016-04-24 Thread Haojian Wu via cfe-commits
hokein added a comment. The patch looks almost good, some nits. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:1 @@ +1,2 @@ + +//===--- MakeSmartPtrCheck.cpp - clang-tidy===// Extra blank line. Comment a

[libunwind] r267365 - unwind: remove unnecessary header

2016-04-24 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Apr 24 16:01:04 2016 New Revision: 267365 URL: http://llvm.org/viewvc/llvm-project?rev=267365&view=rev Log: unwind: remove unnecessary header Availablity.h is not used within config.h. The locations which use the availability infrastructure already include the necessar

[libunwind] r267364 - unwind: unify _LIBUNWIND_ABORT

2016-04-24 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Apr 24 16:00:59 2016 New Revision: 267364 URL: http://llvm.org/viewvc/llvm-project?rev=267364&view=rev Log: unwind: unify _LIBUNWIND_ABORT Rather than use the `__assert_rtn` on libSystem based targets and a local `assert_rtn` function on others, expand the function defi

Re: [PATCH] D19183: [clang-tidy] Add modernize-make-shared check

2016-04-24 Thread Piotr Padlewski via cfe-commits
Prazek added inline comments. Comment at: test/clang-tidy/modernize-make-shared.cpp:81 @@ +80,3 @@ + + std::shared_ptr R(new int()); + hokein wrote: > Why can't this case convert to `std::shared_ptr R = > std::make_shared(new int())`? You mean std::shared_ptr R

Re: [PATCH] D19204: clang-format: [JS] generator and async functions.

2016-04-24 Thread Martin Probst via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL267368: clang-format: [JS] generator and async functions. (authored by mprobst). Changed prior to commit: http://reviews.llvm.org/D19204?vs=54195&id=54814#toc Repository: rL LLVM http://reviews.llvm

r267368 - clang-format: [JS] generator and async functions.

2016-04-24 Thread Martin Probst via cfe-commits
Author: mprobst Date: Sun Apr 24 17:05:09 2016 New Revision: 267368 URL: http://llvm.org/viewvc/llvm-project?rev=267368&view=rev Log: clang-format: [JS] generator and async functions. For generators, see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Iterators_and_generators async

r267369 - Debug info: Apply an empty debug location for global OpenMP destructors.

2016-04-24 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Sun Apr 24 17:22:29 2016 New Revision: 267369 URL: http://llvm.org/viewvc/llvm-project?rev=267369&view=rev Log: Debug info: Apply an empty debug location for global OpenMP destructors. LLVM really wants a debug location on every inlinable call in a function with debug info, be

r267380 - [Clang][AVX512][BuiltIn] Adding support to intrinsics of VPERMD and VPERMW instruction set

2016-04-24 Thread Michael Zuckerman via cfe-commits
Author: mzuckerm Date: Mon Apr 25 00:32:35 2016 New Revision: 267380 URL: http://llvm.org/viewvc/llvm-project?rev=267380&view=rev Log: [Clang][AVX512][BuiltIn] Adding support to intrinsics of VPERMD and VPERMW instruction set Differential Revision: http://reviews.llvm.org/D19195 Modified: