hokein added a comment. The patch looks almost good, some nits.
================ Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:1 @@ +1,2 @@ + +//===--- MakeSmartPtrCheck.cpp - clang-tidy--------------------------------===// ---------------- Extra blank line. ================ Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:27 @@ +26,3 @@ + : + + ClangTidyCheck(Name, Context), ---------------- Remove two extra blanks. ================ Comment at: test/clang-tidy/modernize-make-shared.cpp:81 @@ +80,3 @@ + + std::shared_ptr<int> R(new int()); + ---------------- Why can't this case convert to `std::shared_ptr<int> R = std::make_shared<int>(new int())`? Repository: rL LLVM http://reviews.llvm.org/D19183 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
