Re: [PATCH] D19312: Warn about UB at member function calls from base class ctor initializers.

2016-04-21 Thread Raphael Isemann via cfe-commits
teemperor updated this revision to Diff 54464. teemperor added a comment. - Standard reference is now specifying what standard (C++11) - Added test based on the standard example - Also check base classes now for member calls (to pass the test from the standard example). http://reviews.llvm.org/

Re: r266719 - Warn if function or variable cannot be implicitly instantiated

2016-04-21 Thread Serge Pavlov via cfe-commits
Let me demonstrate the problem using excerpt from v8 sources: -- lithium.h template struct LSubKindOperand { static int* Create(int index) { return &cache[index]; } static void SetUpCache(); static int* cache; }; struct LOperand {

[clang-tools-extra] r266970 - Fix cast compiler warning message in include-fixer.

2016-04-21 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Apr 21 04:16:32 2016 New Revision: 266970 URL: http://llvm.org/viewvc/llvm-project?rev=266970&view=rev Log: Fix cast compiler warning message in include-fixer. Reviewers: bkramer Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D19323 Modified:

Re: [PATCH] D19323: Fix cast compiler warning message in include-fixer.

2016-04-21 Thread Haojian Wu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266970: Fix cast compiler warning message in include-fixer. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D19323?vs=54361&id=54473#toc Repository: rL LLVM http://reviews.llv

[PATCH] D19356: [Tooling] Inject -resource-dir instead of overwriting argv[0].

2016-04-21 Thread Benjamin Kramer via cfe-commits
bkramer created this revision. bkramer added a reviewer: klimek. bkramer added a subscriber: cfe-commits. Herald added a subscriber: klimek. This allows using a different standard library (the one from argv[0] in the compilation database) with the correct builtins. http://reviews.llvm.org/D19356

[PATCH] D19357: [ASTMatchers] New matcher forFunction

2016-04-21 Thread Balogh , Ádám via cfe-commits
baloghadamsoftware created this revision. baloghadamsoftware added a reviewer: sbenza. baloghadamsoftware added subscribers: cfe-commits, xazax.hun, o.gyorgy. Herald added a subscriber: klimek. Matcher proposed in the review of checker misc-assign-operator (name pending). Its goal is to find the

Re: [PATCH] D18551: Added Fixer implementation and fix() interface in clang-format for removing redundant code.

2016-04-21 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 54476. ioeric added a comment. - Added comments for endsWithInternal(). http://reviews.llvm.org/D18551 Files: include/clang/Format/Format.h lib/Format/AffectedRangeManager.cpp lib/Format/AffectedRangeManager.h lib/Format/CMakeLists.txt lib/Format/F

Re: [PATCH] D19356: [Tooling] Inject -resource-dir instead of overwriting argv[0].

2016-04-21 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D19356 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

r266972 - Compilation for Intel MCU (Part 1/3)

2016-04-21 Thread Andrey Turetskiy via cfe-commits
Author: aturetsk Date: Thu Apr 21 05:16:48 2016 New Revision: 266972 URL: http://llvm.org/viewvc/llvm-project?rev=266972&view=rev Log: Compilation for Intel MCU (Part 1/3) Add -miamcu option which: * Sets IAMCU triple * Sets IAMCU ABI * Enforces static compilation Differential Revision: ht

r266973 - [Tooling] Inject -resource-dir instead of overwriting argv[0].

2016-04-21 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Apr 21 05:18:18 2016 New Revision: 266973 URL: http://llvm.org/viewvc/llvm-project?rev=266973&view=rev Log: [Tooling] Inject -resource-dir instead of overwriting argv[0]. This allows using a different standard library (the one from argv[0] in the compilation database) with t

Re: [PATCH] D19356: [Tooling] Inject -resource-dir instead of overwriting argv[0].

2016-04-21 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266973: [Tooling] Inject -resource-dir instead of overwriting argv[0]. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D19356?vs=54474&id=54478#toc Repository: rL LLVM http://rev

r266975 - Back out the test case for r266973 for now.

2016-04-21 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Apr 21 05:46:14 2016 New Revision: 266975 URL: http://llvm.org/viewvc/llvm-project?rev=266975&view=rev Log: Back out the test case for r266973 for now. It breaks on windows, need to investigate. It's not testing the important part of that change anyways. Modified: cfe/t

r266976 - Correctly parse GCC-style asm line following MS-style asm line.

2016-04-21 Thread Denis Zobnin via cfe-commits
Author: dzobnin Date: Thu Apr 21 05:59:18 2016 New Revision: 266976 URL: http://llvm.org/viewvc/llvm-project?rev=266976&view=rev Log: Correctly parse GCC-style asm line following MS-style asm line. Quit parsing MS-style inline assembly if the following statement has GCC style. Enables compilation

Re: [PATCH] D18652: [Inline asm] Correctly parse GCC-style asm line following MS-style asm line

2016-04-21 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266976: Correctly parse GCC-style asm line following MS-style asm line. (authored by dzobnin). Changed prior to commit: http://reviews.llvm.org/D18652?vs=53543&id=54480#toc Repository: rL LLVM http:

Re: [PATCH] D18265: [clang-tidy] New: checker misc-unconventional-assign-operator replacing misc-assign-operator-signature

2016-04-21 Thread Balogh , Ádám via cfe-commits
baloghadamsoftware retitled this revision from "[clang-tidy] New: checker misc-assign-operator-return" to "[clang-tidy] New: checker misc-unconventional-assign-operator replacing misc-assign-operator-signature". baloghadamsoftware updated this revision to Diff 54486. baloghadamsoftware added a co

Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

2016-04-21 Thread Marek via cfe-commits
edyp87 added a comment. Yes, please apply this patch for me. As for macro cases - I also thought about this but check's author has taken care of macros in `check()` method : void RawStringLiteralCheck::check(const MatchFinder::MatchResult &Result) { [...] if (Literal->getLocStart().

[PATCH] D19361: [MS] Improved implementation of MS stack pragmas (vtordisp, *_seg)

2016-04-21 Thread Denis Zobnin via cfe-commits
d.zobnin.bugzilla created this revision. d.zobnin.bugzilla added a reviewer: rnk. d.zobnin.bugzilla added a subscriber: cfe-commits. This patch attempts to improve implementation of several MS pragmas that use stack (vtordisp, { bss | code | const | data }_seg) and fix some compatibility issues.

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-04-21 Thread Aaron Ballman via cfe-commits
aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Please run clang\docs\tools\dump_ast_matchers.py to regenerate the documentation as well. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724 @@ +

Re: [PATCH] D19357: [ASTMatchers] New matcher forFunction

2016-04-21 Thread Aaron Ballman via cfe-commits
aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a comment. Please be sure to run clang\docs\tools\dump_ast_matchers.py to regenerate the documentation as well. http://reviews.llvm.org/D19357 ___ cfe-commits mailing list cfe-com

Re: r266976 - Correctly parse GCC-style asm line following MS-style asm line.

2016-04-21 Thread Renato Golin via cfe-commits
On 21 April 2016 at 11:59, Denis Zobnin via cfe-commits wrote: > Author: dzobnin > Date: Thu Apr 21 05:59:18 2016 > New Revision: 266976 > > URL: http://llvm.org/viewvc/llvm-project?rev=266976&view=rev > Log: > Correctly parse GCC-style asm line following MS-style asm line. > > Quit parsing MS-sty

Re: [PATCH] D19357: [ASTMatchers] New matcher forFunction

2016-04-21 Thread Balogh , Ádám via cfe-commits
baloghadamsoftware added a comment. I will run it, once we are approaching the final version. This one is more of a question than a real patch. http://reviews.llvm.org/D19357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

r266983 - [Clang][AVX512][BuiltIn] Adding intrinsics of VGATHER{DPS|DPD} , VPGATHER{QD|QQ|DD|DQ} and VGATHERPF{0|1}{DPS|QPS|DPD|QPD} instruction set .

2016-04-21 Thread Michael Zuckerman via cfe-commits
Author: mzuckerm Date: Thu Apr 21 07:47:27 2016 New Revision: 266983 URL: http://llvm.org/viewvc/llvm-project?rev=266983&view=rev Log: [Clang][AVX512][BuiltIn] Adding intrinsics of VGATHER{DPS|DPD} , VPGATHER{QD|QQ|DD|DQ} and VGATHERPF{0|1}{DPS|QPS|DPD|QPD} instruction set . Differential Revisio

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-04-21 Thread Clement Courbet via cfe-commits
courbet added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:2084 @@ +2083,3 @@ + Code1, ForEachOverriddenInClass("C"), + new VerifyIdIsBoundTo("override", "f", 1))); + EXPECT_TRUE(matchAndVerifyResultTrue( aaron.ballman wrote: >

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-04-21 Thread Clement Courbet via cfe-commits
courbet added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724 @@ +3723,3 @@ + bool Matched = false; + for (auto It = Node.begin_overridden_methods(); + It != Node.end_overridden_methods(); ++It) { aaron.ballman wrote: > Can you ra

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-04-21 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724 @@ +3723,3 @@ + bool Matched = false; + for (auto It = Node.begin_overridden_methods(); + It != Node.end_overridden_methods(); ++It) { courbet wrote: > aaron.ball

[PATCH] D19362: [ASTMatchers] Statically specify ownership of verifiers in tests. NFC

2016-04-21 Thread Clement Courbet via cfe-commits
courbet created this revision. courbet added a reviewer: aaron.ballman. courbet added a subscriber: cfe-commits. Herald added a subscriber: klimek. Statically specify ownership of verifiers in tests. NFC http://reviews.llvm.org/D19362 Files: unittests/ASTMatchers/ASTMatchersTest.cpp unittest

Re: [PATCH] D19362: [ASTMatchers] Statically specify ownership of verifiers in tests. NFC

2016-04-21 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thank you for the cleanup, this is more clear about the ownership semantics. http://reviews.llvm.org/D19362 ___ cfe-commits

Re: [PATCH] D19362: [ASTMatchers] Statically specify ownership of verifiers in tests. NFC

2016-04-21 Thread Clement Courbet via cfe-commits
courbet added a comment. Thanks! Would you mind submitting this for me ? http://reviews.llvm.org/D19362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19362: [ASTMatchers] Statically specify ownership of verifiers in tests. NFC

2016-04-21 Thread Aaron Ballman via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Commit in r266986, thank you! http://reviews.llvm.org/D19362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19312: Warn about UB at member function calls from base class ctor initializers.

2016-04-21 Thread Filipe Cabecinhas via cfe-commits
filcab added a comment. The patch needs to get through clang-format. Should we deal with typeid and dynamic_cast, since they're mentioned in the same paragraph in the standard? Comment at: lib/Sema/SemaDeclCXX.cpp:3895 @@ +3894,3 @@ + // Check if member call is actually to

Re: r266976 - Correctly parse GCC-style asm line following MS-style asm line.

2016-04-21 Thread Krzysztof Parzyszek via cfe-commits
On 4/21/2016 7:49 AM, Renato Golin via cfe-commits wrote: MS-style inline assembly is not available: No available targets are compatible with this triple. http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/11538 Same thing on Hexagon: http://lab.llvm.org:8011/builders/clang-hexago

r266986 - Clarify memory ownership semantics; NFC.

2016-04-21 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Apr 21 08:51:07 2016 New Revision: 266986 URL: http://llvm.org/viewvc/llvm-project?rev=266986&view=rev Log: Clarify memory ownership semantics; NFC. Patch by Clement Courbet Modified: cfe/trunk/unittests/ASTMatchers/ASTMatchersTest.cpp cfe/trunk/unittests/A

r266989 - [Hexagon] Define architecture version macros for hexagonv55

2016-04-21 Thread Krzysztof Parzyszek via cfe-commits
Author: kparzysz Date: Thu Apr 21 09:30:04 2016 New Revision: 266989 URL: http://llvm.org/viewvc/llvm-project?rev=266989&view=rev Log: [Hexagon] Define architecture version macros for hexagonv55 Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/test/Preprocessor/hexagon-predefines.c Mo

[clang-tools-extra] r266992 - [Clang-tidy] Fix for crash in modernize-raw-string-literal check

2016-04-21 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Thu Apr 21 09:39:12 2016 New Revision: 266992 URL: http://llvm.org/viewvc/llvm-project?rev=266992&view=rev Log: [Clang-tidy] Fix for crash in modernize-raw-string-literal check Summary: Clang-tidy modernize-raw-string-literal check crashes on run-time assert while it is eval

r266993 - [x86] Force mixes asm syntax test to check for x86

2016-04-21 Thread Renato Golin via cfe-commits
Author: rengolin Date: Thu Apr 21 09:40:06 2016 New Revision: 266993 URL: http://llvm.org/viewvc/llvm-project?rev=266993&view=rev Log: [x86] Force mixes asm syntax test to check for x86 Modified: cfe/trunk/test/CodeGen/inline-asm-mixed-style.c Modified: cfe/trunk/test/CodeGen/inline-asm-mixe

Re: r266976 - Correctly parse GCC-style asm line following MS-style asm line.

2016-04-21 Thread Renato Golin via cfe-commits
On 21 April 2016 at 14:58, Krzysztof Parzyszek via cfe-commits wrote: > Same thing on Hexagon: > http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/37972 Trying to fix in r266993. --renato ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2016-04-21 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. In http://reviews.llvm.org/D19201#403585, @Prazek wrote: > Do you know guys is it possible to get to noexcept source location, or we > have to do by hand using lexer? If it might be possible to get the location of `noexcept(expression)` using `FunctionProtoType::getNoE

Re: [PATCH] D19357: [ASTMatchers] New matcher forFunction

2016-04-21 Thread Samuel Benzaquen via cfe-commits
sbenza added a comment. Thanks for doing this! I think we want the version that iterates all parents. Otherwise it will have problems with templates. That is, you won't know which `FunctionDecl` you will get: the template or the instantiation. And you might need one or the other specifically.

Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

2016-04-21 Thread Alexander Kornienko via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266992: [Clang-tidy] Fix for crash in modernize-raw-string-literal check (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D19331?vs=54401&id=54504#toc Repository: rL LLVM http:

Re: [PATCH] D19194: fix for clang-tidy modernize-pass-by-value on copy constructor

2016-04-21 Thread Alexander Kornienko via cfe-commits
alexfh added a subscriber: alexfh. alexfh requested changes to this revision. alexfh added a reviewer: alexfh. This revision now requires changes to proceed. Comment at: clang-tidy/modernize/PassByValueCheck.cpp:166 @@ -150,3 +165,3 @@ hasDeclaration(cxxCo

Re: r266976 - Correctly parse GCC-style asm line following MS-style asm line.

2016-04-21 Thread Krzysztof Parzyszek via cfe-commits
On 4/21/2016 9:46 AM, Renato Golin wrote: On 21 April 2016 at 14:58, Krzysztof Parzyszek via cfe-commits wrote: Same thing on Hexagon: http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/37972 Trying to fix in r266993. It worked! Thanks! -Krzysztof -- Qualcomm Innovation Center, I

Re: [PATCH] D18745: [clang-tidy] Adds modernize-use-bool-literals check.

2016-04-21 Thread Alexander Kornienko via cfe-commits
alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:30 @@ +29,3 @@ + + Finder->addMatcher(implicitCastExpr(hasIntegerLiteralCastToBool, + unless(ha

Re: [PATCH] D19362: [ASTMatchers] Statically specify ownership of verifiers in tests. NFC

2016-04-21 Thread Clement Courbet via cfe-commits
courbet added a comment. Thanks ! http://reviews.llvm.org/D19362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-04-21 Thread Clement Courbet via cfe-commits
courbet updated this revision to Diff 54512. courbet marked 4 inline comments as done. courbet added a comment. - add overridden_methods() to CXXMethodDecl and plumbing. - Use range-based for loop for iterating over overridden methods. http://reviews.llvm.org/D19324 Files: include/clang/AST/A

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-04-21 Thread Clement Courbet via cfe-commits
courbet marked an inline comment as done. courbet added a comment. http://reviews.llvm.org/D19324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-04-21 Thread Clement Courbet via cfe-commits
courbet updated this revision to Diff 54514. courbet added a comment. Regenerate doc. http://reviews.llvm.org/D19324 Files: docs/LibASTMatchersReference.html include/clang/AST/ASTContext.h include/clang/AST/DeclCXX.h include/clang/ASTMatchers/ASTMatchers.h lib/AST/ASTContext.cpp lib

Re: [PATCH] D19249: Fix include path in ClangTidy.cpp.

2016-04-21 Thread Alexander Kornienko via cfe-commits
alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/ClangTidy.cpp:61 @@ -60,3 +60,3 @@ FULLNAME, -#include "../../../lib/StaticAnalyzer/Checkers/Checkers.inc" +#include "Checkers.inc" #undef CHECKER

Re: [PATCH] D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC

2016-04-21 Thread Faisal Vali via cfe-commits
faisalv added inline comments. Comment at: include/clang/AST/DeclTemplate.h:175 @@ -152,2 +174,3 @@ + Expr *RequiresClause; public: Yuk - this entire guy (FizedSizeTemplateParameterListStorage) seems quite fragile (dependent on object layout) - are the gains

Re: [PATCH] D19200: [clang-tidy] Cleanup some ast-matchers and lift some to utils.

2016-04-21 Thread Etienne Bergeron via cfe-commits
etienneb updated this revision to Diff 54522. etienneb added a comment. rebased, merge: http://reviews.llvm.org/D19262 http://reviews.llvm.org/D19200 Files: clang-tidy/misc/BoolPointerImplicitConversionCheck.cpp clang-tidy/misc/IncorrectRoundings.cpp clang-tidy/misc/MacroParenthesesCheck.

Re: [PATCH] D19249: Fix include path in ClangTidy.cpp.

2016-04-21 Thread Stephen Hines via cfe-commits
srhines added inline comments. Comment at: clang-tidy/ClangTidy.cpp:61 @@ -60,3 +60,3 @@ FULLNAME, -#include "../../../lib/StaticAnalyzer/Checkers/Checkers.inc" +#include "Checkers.inc" #undef CHECKER alexfh wrote: > As it is, the change leaves almost no conte

[clang-tools-extra] r267003 - [clang-tidy] Cleanup some ast-matchers and lift some to utils.

2016-04-21 Thread Etienne Bergeron via cfe-commits
Author: etienneb Date: Thu Apr 21 11:57:56 2016 New Revision: 267003 URL: http://llvm.org/viewvc/llvm-project?rev=267003&view=rev Log: [clang-tidy] Cleanup some ast-matchers and lift some to utils. Summary: Little cleanup to lift-out and to remove some frequently used ast-matchers. Some of these

Re: [PATCH] D18442: A clang-tidy check for std:accumulate.

2016-04-21 Thread Alexander Kornienko via cfe-commits
alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/misc/FoldInitTypeCheck.cpp:23 @@ +22,3 @@ + // Note: Right now we check only builtin types. + const auto BuiltinTypeWithId = [](const char *id) { +return hasCanon

Re: [PATCH] D18703: [clang-tidy] Add new checker for comparison with runtime string functions.

2016-04-21 Thread Etienne Bergeron via cfe-commits
etienneb updated this revision to Diff 54526. etienneb marked 2 inline comments as done. etienneb added a comment. rebased http://reviews.llvm.org/D18703 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/SuspiciousStringCompareCheck.cpp clang-tidy/

Re: [PATCH] D19194: fix for clang-tidy modernize-pass-by-value on copy constructor

2016-04-21 Thread Kamal Essoufi via cfe-commits
Kessoufi marked an inline comment as done. Kessoufi added a comment. Done http://reviews.llvm.org/D19194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19194: fix for clang-tidy modernize-pass-by-value on copy constructor

2016-04-21 Thread Kamal Essoufi via cfe-commits
Kessoufi updated this revision to Diff 54524. Kessoufi added a comment. removed the redundant matcher http://reviews.llvm.org/D19194 Files: clang-tidy/modernize/PassByValueCheck.cpp Index: clang-tidy/modernize/PassByValueCheck.cpp =

Re: [PATCH] D19194: fix for clang-tidy modernize-pass-by-value on copy constructor

2016-04-21 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Now the problem is that the check changed behavior, but the tests are not updated. Do the tests still pass? If yes, we need to add tests for this behavior. If no, please fix the tests. http://reviews.llvm.org/D19194 ___ cfe

Re: [PATCH] D18703: [clang-tidy] Add new checker for comparison with runtime string functions.

2016-04-21 Thread Etienne Bergeron via cfe-commits
etienneb updated this revision to Diff 54531. etienneb added a comment. fix integration http://reviews.llvm.org/D18703 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/SuspiciousStringCompareCheck.cpp clang-tidy/misc/SuspiciousStringCompareCheck.h

Re: [PATCH] D19299: lower __builtin_expect() directly to prof metadata instead of LLVM intrinsic

2016-04-21 Thread David Li via cfe-commits
davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D19299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang-tools-extra] r267009 - [clang-tidy] Add new checker for comparison with runtime string functions.

2016-04-21 Thread Etienne Bergeron via cfe-commits
Author: etienneb Date: Thu Apr 21 12:19:36 2016 New Revision: 267009 URL: http://llvm.org/viewvc/llvm-project?rev=267009&view=rev Log: [clang-tidy] Add new checker for comparison with runtime string functions. Summary: This checker is validating suspicious usage of string compare functions. Exam

Re: [PATCH] D19146: [clang-tidy] New checker to detect suspicious string constructor.

2016-04-21 Thread Etienne Bergeron via cfe-commits
etienneb updated this revision to Diff 54532. etienneb added a comment. rebased http://reviews.llvm.org/D19146 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/StringConstructorCheck.cpp clang-tidy/misc/StringConstructorCheck.h docs/clang-tidy/c

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-04-21 Thread Samuel Benzaquen via cfe-commits
sbenza added inline comments. Comment at: lib/AST/ASTContext.cpp:1279 @@ -1282,1 +1278,3 @@ +const ASTContext::CXXMethodVector * +ASTContext::overridden_methods(const CXXMethodDecl *Method) const { llvm::DenseMap::const_iterator Pos It would be simpler to retur

[clang-tools-extra] r267011 - [clang-tidy] New checker to detect suspicious string constructor.

2016-04-21 Thread Etienne Bergeron via cfe-commits
Author: etienneb Date: Thu Apr 21 12:28:08 2016 New Revision: 267011 URL: http://llvm.org/viewvc/llvm-project?rev=267011&view=rev Log: [clang-tidy] New checker to detect suspicious string constructor. Summary: Checker to validate string constructor parameters. A common mistake is to swap paramet

Re: [PATCH] D19071: [OpenCL] Add predefined macros.

2016-04-21 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:418 @@ +417,3 @@ +// A shared OpenCL header file requires a macro to indicate the language +// standard. As a workaround, __CLANG_OPENCL_C_VERSION__ is defined for +// OpenCL v1.0 and v1.1.

Re: [PATCH] D18624: [PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name.

2016-04-21 Thread Rong Xu via cfe-commits
I tried D17864 and D18624 with the latest trunk of r267006 on a clean client. The built compiler works fine with povray. the meta data only has the files name. How did you build povray? can you show me your command line in building (for example, csg.cpp) for both--fprofile-instr-use and -fprofile

Re: [PATCH] D18624: [PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name.

2016-04-21 Thread Rong Xu via cfe-commits
xur added a comment. I tried http://reviews.llvm.org/D17864 and http://reviews.llvm.org/D18624 with the latest trunk of r267006 on a clean client. The built compiler works fine with povray. the meta data only has the files name. How did you build povray? can you show me your command line in bui

[PATCH] D19379: [clang-tidy] Fix broken build bot.

2016-04-21 Thread Etienne Bergeron via cfe-commits
etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. There is a build bot that doesn't support 'constexpr'. ``` FAILED: C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\cl.exe /nologo /TP /DWIN32 /D_WINDOWS /W4 -wd4141 -wd4146 -wd4180 -wd4244 -wd425

[clang-tools-extra] r267026 - [Release Notes] Mention Clang-tidy misc-string-constructor and misc-suspicious-string-compare checks.

2016-04-21 Thread Eugene Zelenko via cfe-commits
Author: eugenezelenko Date: Thu Apr 21 13:13:09 2016 New Revision: 267026 URL: http://llvm.org/viewvc/llvm-project?rev=267026&view=rev Log: [Release Notes] Mention Clang-tidy misc-string-constructor and misc-suspicious-string-compare checks. Fix excessive line in misc-string-constructor document

Re: [PATCH] D19071: [OpenCL] Add predefined macros.

2016-04-21 Thread Yaxun Liu via cfe-commits
yaxunl updated this revision to Diff 54552. yaxunl added a comment. Revised as Anastasia suggested. http://reviews.llvm.org/D19071 Files: lib/Frontend/CompilerInvocation.cpp lib/Frontend/InitPreprocessor.cpp test/Frontend/std.cl test/Frontend/stdlang.c test/Preprocessor/predefined-mac

[clang-tools-extra] r267027 - [clang-tidy] Fix broken build bot.

2016-04-21 Thread Etienne Bergeron via cfe-commits
Author: etienneb Date: Thu Apr 21 13:15:35 2016 New Revision: 267027 URL: http://llvm.org/viewvc/llvm-project?rev=267027&view=rev Log: [clang-tidy] Fix broken build bot. Summary: There is a build bot that doesn't support 'constexpr'. ``` FAILED: C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\cl.exe /nolo

Re: [PATCH] D18624: [PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name.

2016-04-21 Thread Adam Nemet via cfe-commits
anemet added a comment. > How did you build povray? > can you show me your command line in building (for example, csg.cpp) for > both--fprofile-instr-use and -fprofile-instr-generate? Sent it in an email. http://reviews.llvm.org/D18624 ___ cfe

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

2016-04-21 Thread Eric Fiselier via cfe-commits
EricWF added a comment. Sorry about the long delay in reviewing this. @eugenis Are you still able/willing to proceed with this? Repository: rL LLVM http://reviews.llvm.org/D14411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] D19382: [OpenMP] Improve mappable expressions Sema.

2016-04-21 Thread Samuel Antao via cfe-commits
sfantao created this revision. sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0. sfantao added subscribers: caomhin, cfe-commits. This patch adds logic to save the components of mappable expressions in the clause that uses it, so that they don't have to be recompute

Re: [PATCH] D18624: [PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name.

2016-04-21 Thread Rong Xu via cfe-commits
I was using spec-run where the command line has the pathless filename. The source in Atam's command-line has the absolute path. In meta-data creation, we used Module's getSourceFileName() which has the source name appeared in the command line (in this case, a full patch name). While in Clang's se

Re: [PATCH] D18624: [PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name.

2016-04-21 Thread Rong Xu via cfe-commits
xur added a comment. I was using spec-run where the command line has the pathless filename. The source in Atam's command-line has the absolute path. In meta-data creation, we used Module's getSourceFileName() which has the source name appeared in the command line (in this case, a full patch name)

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

2016-04-21 Thread Steven Wu via cfe-commits
steven_wu updated this revision to Diff 54559. steven_wu added a comment. Ping. Rebase the patch over trunk and tweak the testcase. http://reviews.llvm.org/D17392 Files: include/clang/CodeGen/BackendUtil.h include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def includ

Re: [PATCH] D16749: [OpenMP] Map clause codegeneration.

2016-04-21 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4393-4431 @@ +4392,41 @@ +/// retrieved from the provided map clause expression. +DeclarationMapInfoEntry(const Expr *MCE, OpenMPMapClauseKind MapType, +

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

2016-04-21 Thread Evgeniy Stepanov via cfe-commits
eugenis added a comment. Yes, I'd like to try. I think this is blocked on the changes that move visibility attributes to the first declaration, right? Also, re: cfi-commits thread for r255177, it appears that on Mac we can neither hide nor expose existing methods (i.e. if something was hidden, i

Re: [PATCH] D15404: Cleanup: move visibility/linkage attributes to the first declaration (part 2).

2016-04-21 Thread Eric Fiselier via cfe-commits
EricWF added a comment. So you pointed out that my changes to the streams is not ABI compatible. Obviously that cannot be a part of this patch then. Repository: rL LLVM http://reviews.llvm.org/D15404 ___ cfe-commits mailing list cfe-commits@list

Re: [PATCH] D15404: Cleanup: move visibility/linkage attributes to the first declaration (part 2).

2016-04-21 Thread Evgeniy Stepanov via cfe-commits
eugenis updated this revision to Diff 54562. eugenis added a comment. Updates with Eric's patch from https://gist.github.com/EricWF/487e5b1de2bb320e93fbb3c9c758b013 without the iostream changes. Repository: rL LLVM http://reviews.llvm.org/D15404 Files: include/complex include/experimenta

Re: [PATCH] D15404: Cleanup: move visibility/linkage attributes to the first declaration (part 2).

2016-04-21 Thread Evgeniy Stepanov via cfe-commits
eugenis added a comment. This change does not affect libc++.so on Linux in any way. Repository: rL LLVM http://reviews.llvm.org/D15404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D19385: [scan-build] fix logic error warnings emitted on clang code base

2016-04-21 Thread Apelete Seketeli via cfe-commits
apelete created this revision. apelete added reviewers: rjmccall, zaks.anna, rsmith. apelete added a subscriber: cfe-commits. Herald added a subscriber: klimek. Fixing another set of "Logic error" warnings of the type "Called c++ object pointer is null" reported by Clang Static Analyzer on the fol

Re: [PATCH] D15031: CFG: Add CFGElement for automatic variables that leave the scope

2016-04-21 Thread Matthias Gehre via cfe-commits
mgehre added a comment. Ping http://reviews.llvm.org/D15031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r267040 - clang-cl: Don't assert on using /Yc with non-source files, PR27450

2016-04-21 Thread Nico Weber via cfe-commits
Author: nico Date: Thu Apr 21 14:59:10 2016 New Revision: 267040 URL: http://llvm.org/viewvc/llvm-project?rev=267040&view=rev Log: clang-cl: Don't assert on using /Yc with non-source files, PR27450 Move phase handling after input type validation. Modified: cfe/trunk/lib/Driver/Driver.cpp

Re: r267040 - clang-cl: Don't assert on using /Yc with non-source files, PR27450

2016-04-21 Thread Vedant Kumar via cfe-commits
Hi Nico, This seems to be causing a test failure on one of our bots: http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/17279/testReport/junit/Clang/Driver/cl_pch_cpp/ Command Output (stderr): -- /Users/buildslave/jenkins/sharedspace/phase1@2/llvm/tools/clang/test/Driver/cl-pch.c

Re: r267040 - clang-cl: Don't assert on using /Yc with non-source files, PR27450

2016-04-21 Thread Nico Weber via cfe-commits
Does removing -Werror help? All the bots on http://lab.llvm.org:8011/console look happy. On Thu, Apr 21, 2016 at 4:58 PM, Vedant Kumar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Nico, > > This seems to be causing a test failure on one of our bots: > > > http://lab.llvm.org:8080/gre

r267054 - Split interesting warnings off from -Wfloat-conversion

2016-04-21 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Thu Apr 21 16:04:55 2016 New Revision: 267054 URL: http://llvm.org/viewvc/llvm-project?rev=267054&view=rev Log: Split interesting warnings off from -Wfloat-conversion Restructure the implict floating point to integer conversions so that interesting sub-groups are under differ

Re: [PATCH] D19312: Warn about UB at member function calls from base class ctor initializers.

2016-04-21 Thread Richard Trieu via cfe-commits
rtrieu added a subscriber: rtrieu. rtrieu added a comment. Have you looked at http://reviews.llvm.org/D6561 which was a previous attempt at this warning? http://reviews.llvm.org/D19312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

Re: [PATCH] D18073: Add memory allocating functions

2016-04-21 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. This looks reasonable to me, but you should wait for @zaks.anna to sign off. http://reviews.llvm.org/D18073 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: r267040 - clang-cl: Don't assert on using /Yc with non-source files, PR27450

2016-04-21 Thread Vedant Kumar via cfe-commits
No, removing -Werror doesn't help. What's strange is that this doesn't reproduce on my machine -- just on the bots. I'll poke around a bit more. vedant > On Apr 21, 2016, at 2:08 PM, Nico Weber wrote: > > Does removing -Werror help? All the bots on http://lab.llvm.org:8011/console > look hap

r267059 - [esan] EfficiencySanitizer driver flags

2016-04-21 Thread Derek Bruening via cfe-commits
Author: bruening Date: Thu Apr 21 16:32:04 2016 New Revision: 267059 URL: http://llvm.org/viewvc/llvm-project?rev=267059&view=rev Log: [esan] EfficiencySanitizer driver flags Summary: Adds a framework to enable the instrumentation pass for the new EfficiencySanitizer ("esan") family of tools. Ad

r267062 - [CUDA] removed unneeded __nvvm_reflect_anchor()

2016-04-21 Thread Artem Belevich via cfe-commits
Author: tra Date: Thu Apr 21 16:40:27 2016 New Revision: 267062 URL: http://llvm.org/viewvc/llvm-project?rev=267062&view=rev Log: [CUDA] removed unneeded __nvvm_reflect_anchor() Since r265060 LLVM infers correct __nvvm_reflect attributes, so explicit declaration of __nvvm_reflect() is no longer n

Re: [PATCH] D19074: [CUDA] removed unneeded __nvvm_reflect_anchor()

2016-04-21 Thread Artem Belevich via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL267062: [CUDA] removed unneeded __nvvm_reflect_anchor() (authored by tra). Changed prior to commit: http://reviews.llvm.org/D19074?vs=53618&id=54585#toc Repository: rL LLVM http://reviews.llvm.org/D

Re: r267040 - clang-cl: Don't assert on using /Yc with non-source files, PR27450

2016-04-21 Thread Vedant Kumar via cfe-commits
Hm, here's something weird -- The test passes if I change this RUN line: // RUN: %clang_cl -Werror /Ycpchfile.h /FIpchfile.h /c -### %S/Inputs/file.prof To this: // RUN: %clang_cl -Werror /Ycpchfile.h /FIpchfile.h /c -### /%S/Inputs/file.prof The output I get with the original RUN li

[PATCH] D19393: Move Checkers.inc to clang/include/.../Checkers

2016-04-21 Thread Chih-Hung Hsieh via cfe-commits
chh created this revision. chh added reviewers: srhines, alexfh. chh added a subscriber: cfe-commits. Herald added subscribers: danalbert, tberghammer. https://llvm.org/bugs/show_bug.cgi?id=27355 To compile with other binary output directory structures in build systems like Android. Allow clang-t

Re: [PATCH] D19249: Fix include path in ClangTidy.cpp.

2016-04-21 Thread Chih-Hung Hsieh via cfe-commits
chh updated this revision to Diff 54587. http://reviews.llvm.org/D19249 Files: clang-tidy/ClangTidy.cpp Index: clang-tidy/ClangTidy.cpp === --- clang-tidy/ClangTidy.cpp +++ clang-tidy/ClangTidy.cpp @@ -58,7 +58,7 @@ #define GET_C

Re: [PATCH] D19249: Fix include path in ClangTidy.cpp.

2016-04-21 Thread Chih-Hung Hsieh via cfe-commits
chh added a comment. This change depends on http://reviews.llvm.org/D19393. http://reviews.llvm.org/D19249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19393: Move Checkers.inc to clang/include/.../Checkers

2016-04-21 Thread Chih-Hung Hsieh via cfe-commits
chh added a comment. See dependent change of ClangTidy.cpp in http://reviews.llvm.org/D19393. http://reviews.llvm.org/D19393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r267074 - Fix most GCC attribute ignored warnings

2016-04-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Apr 21 17:54:21 2016 New Revision: 267074 URL: http://llvm.org/viewvc/llvm-project?rev=267074&view=rev Log: Fix most GCC attribute ignored warnings Modified: libcxx/trunk/include/__config libcxx/trunk/include/__functional_base libcxx/trunk/include/bitset l

[libcxx] r267076 - Make ios_base::failure visibility specified consistent

2016-04-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Apr 21 18:00:33 2016 New Revision: 267076 URL: http://llvm.org/viewvc/llvm-project?rev=267076&view=rev Log: Make ios_base::failure visibility specified consistent Modified: libcxx/trunk/include/ios Modified: libcxx/trunk/include/ios URL: http://llvm.org/viewvc/llvm-

[libcxx] r267079 - Add is_swappable/is_nothrow_swappable traits

2016-04-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Apr 21 18:38:59 2016 New Revision: 267079 URL: http://llvm.org/viewvc/llvm-project?rev=267079&view=rev Log: Add is_swappable/is_nothrow_swappable traits Added: libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_nothrow_swappable.pass.cpp libcxx/t

  1   2   >