Re: [PATCH] D19194: fix for clang-tidy modernize-pass-by-value on copy constructor

[Kamal Essoufi via cfe-commits]

Kessoufi updated this revision to Diff 54524.
Kessoufi added a comment.

removed the redundant matcher


http://reviews.llvm.org/D19194

Files:
  clang-tidy/modernize/PassByValueCheck.cpp

Index: clang-tidy/modernize/PassByValueCheck.cpp
===================================================================
--- clang-tidy/modernize/PassByValueCheck.cpp
+++ clang-tidy/modernize/PassByValueCheck.cpp
@@ -148,7 +148,7 @@
                                           nonConstValueType()))))
                                 .bind("Param")))),
                         hasDeclaration(cxxConstructorDecl(
-                            isCopyConstructor(), unless(isDeleted()),
+                            unless(isCopyConstructor()),
                             hasDeclContext(
                                 cxxRecordDecl(isMoveConstructible())))))))
                     .bind("Initializer")))



Index: clang-tidy/modernize/PassByValueCheck.cpp
===================================================================
--- clang-tidy/modernize/PassByValueCheck.cpp
+++ clang-tidy/modernize/PassByValueCheck.cpp
@@ -148,7 +148,7 @@
                                           nonConstValueType()))))
                                 .bind("Param")))),
                         hasDeclaration(cxxConstructorDecl(
-                            isCopyConstructor(), unless(isDeleted()),
+                            unless(isCopyConstructor()),
                             hasDeclContext(
                                 cxxRecordDecl(isMoveConstructible())))))))
                     .bind("Initializer")))

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits