jbcoe updated this revision to Diff 53519.
jbcoe added a comment.
Remove python test for deleted method.
I missed this because the python tests are not run as part of check-clang - is
this something I could submit a patch to change?
http://reviews.llvm.org/D15469
Files:
bindings/python/clan
baloghadamsoftware added inline comments.
Comment at: clang-tidy/misc/AssignOperatorCheck.cpp:63
@@ +62,3 @@
+
+ Finder->addMatcher(returnStmt(IsBadReturnStatement,
hasAncestor(IsGoodAssign))
+ .bind("returnStmt"),
sbenza wrote:
> balogha
Author: rsmith
Date: Wed Apr 13 02:41:35 2016
New Revision: 266176
URL: http://llvm.org/viewvc/llvm-project?rev=266176&view=rev
Log:
[modules] Add some missing blockinfo records. No functionality change except to
llvm-bcanalyzer output.
Modified:
cfe/trunk/lib/Serialization/ASTWriter.cpp
Mo
Author: chapuni
Date: Wed Apr 13 02:45:10 2016
New Revision: 266177
URL: http://llvm.org/viewvc/llvm-project?rev=266177&view=rev
Log:
ASTWriterDecl.cpp: Prune a couple of \param(s), corresponding to r266160.
[-Wdocumentation]
Modified:
cfe/trunk/lib/Serialization/ASTWriterDecl.cpp
Modified:
Author: rsmith
Date: Wed Apr 13 02:47:38 2016
New Revision: 266178
URL: http://llvm.org/viewvc/llvm-project?rev=266178&view=rev
Log:
constexpr -> const to appease MSVC bots.
Modified:
cfe/trunk/include/clang/Serialization/ASTWriter.h
Modified: cfe/trunk/include/clang/Serialization/ASTWriter.
Author: bader
Date: Wed Apr 13 03:33:41 2016
New Revision: 266180
URL: http://llvm.org/viewvc/llvm-project?rev=266180&view=rev
Log:
[OpenCL] Move OpenCLImageTypes.def from clangAST to clangBasic library.
Putting OpenCLImageTypes.def to clangAST library violates layering requirement:
"It's not OK
baloghadamsoftware added a comment.
misc-unconventional-assign-operator, misc-assign-operator-conventions,
misc-non-idiomatic-assign-operator or something else then?
http://reviews.llvm.org/D18265
___
cfe-commits mailing list
cfe-commits@lists.llvm
Author: alexfh
Date: Wed Apr 13 03:46:32 2016
New Revision: 266181
URL: http://llvm.org/viewvc/llvm-project?rev=266181&view=rev
Log:
[clang-tidy] add_new_check.py should fail if check name starts with the module
name
+ updated formatting
Modified:
clang-tools-extra/trunk/clang-tidy/add_new_
Author: alexfh
Date: Wed Apr 13 03:47:42 2016
New Revision: 266182
URL: http://llvm.org/viewvc/llvm-project?rev=266182&view=rev
Log:
[clang-tidy] Disable misc-unused-parameters for clang.
Modified:
cfe/trunk/.clang-tidy
Modified: cfe/trunk/.clang-tidy
URL:
http://llvm.org/viewvc/llvm-projec
Author: alexfh
Date: Wed Apr 13 03:59:49 2016
New Revision: 266184
URL: http://llvm.org/viewvc/llvm-project?rev=266184&view=rev
Log:
Try to use readability-identifier-naming check on Clang.
Modified:
cfe/trunk/.clang-tidy
Modified: cfe/trunk/.clang-tidy
URL:
http://llvm.org/viewvc/llvm-proj
Author: nemanjai
Date: Wed Apr 13 04:49:45 2016
New Revision: 266186
URL: http://llvm.org/viewvc/llvm-project?rev=266186&view=rev
Log:
Enable support for __float128 in Clang
This patch corresponds to review:
http://reviews.llvm.org/D15120
It adds support for the __float128 keyword, literals and
pilki added inline comments.
Comment at: clang-tidy/readability/DeletedDefaultCheck.cpp:37
@@ +36,3 @@
+
+void DeletedDefaultCheck::check(const MatchFinder::MatchResult &Result) {
+ const StringRef Message = "%0 is explicitly defaulted but implicitly "
alexfh wr
pilki updated this revision to Diff 53525.
pilki marked 2 inline comments as done.
http://reviews.llvm.org/D18961
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/DeletedDefaultCheck.cpp
clang-tidy/readability/DeletedDefaultCheck.h
clang-tidy/readability/Readability
Author: bader
Date: Wed Apr 13 04:54:47 2016
New Revision: 266187
URL: http://llvm.org/viewvc/llvm-project?rev=266187&view=rev
Log:
[modules] Add OpenCLImageTypes.def to module map to fix the modules build.
Modified:
cfe/trunk/include/clang/module.modulemap
Modified: cfe/trunk/include/clang/
alexfh added a comment.
Thank you for addressing the comments!
I'll commit the patch for you.
http://reviews.llvm.org/D18961
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
The patch doesn't apply cleanly. Please rebase it against current HEAD.
http://reviews.llvm.org/D18961
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pilki updated this revision to Diff 53529.
http://reviews.llvm.org/D18961
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/DeletedDefaultCheck.cpp
clang-tidy/readability/DeletedDefaultCheck.h
clang-tidy/readability/ReadabilityTidyModule.cpp
docs/ReleaseNotes.rst
pilki added a comment.
I did svn up and reuploaded the diff. I did not see any changes on files I
touched, so I'm not sure it worked.
http://reviews.llvm.org/D18961
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
Author: mzuckerm
Date: Wed Apr 13 05:49:37 2016
New Revision: 266188
URL: http://llvm.org/viewvc/llvm-project?rev=266188&view=rev
Log:
[Clang][AVX512][Builtin] Adding supporting to intrinsics of
cvt{b|d|q}2mask{128|256|512} and cvtmask2{b|d|q}{128|256|512} instruction set.
Differential Revision:
alexfh added a comment.
Something is weird with your patch: it has names starting with a space (note
two spaces between "Index:" and "clang-tidy/..."):
Index: clang-tidy/readability/CMakeLists.txt
===
--- clang-tidy/readabil
pilki updated this revision to Diff 53532.
http://reviews.llvm.org/D18961
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/DeletedDefaultCheck.cpp
clang-tidy/readability/DeletedDefaultCheck.h
clang-tidy/readability/ReadabilityTidyModule.cpp
docs/ReleaseNotes.rst
alexfh added a comment.
LG.
http://reviews.llvm.org/D19038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pilki updated this revision to Diff 53533.
http://reviews.llvm.org/D18961
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/DeletedDefaultCheck.cpp
clang-tidy/readability/DeletedDefaultCheck.h
clang-tidy/readability/ReadabilityTidyModule.cpp
docs/ReleaseNotes.rst
doc
pilki added a comment.
Sorry, both my 'diff' and my 'svn' command added some magical coloring... It
should be good now.
http://reviews.llvm.org/D18961
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: alexfh
Date: Wed Apr 13 06:13:08 2016
New Revision: 266189
URL: http://llvm.org/viewvc/llvm-project?rev=266189&view=rev
Log:
Add AST Matchers for CXXConstructorDecl::isDelegatingConstructor and
CXXMethodDecl::isUserProvided.
Summary: Added two AST matchers: isDelegatingConstructor for
C
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266189: Add AST Matchers for
CXXConstructorDecl::isDelegatingConstructor and… (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D19038?vs=53479&id=53534#toc
Repository:
rL LLVM
ikudrin added a comment.
Ping...
http://reviews.llvm.org/D17815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: alexfh
Date: Wed Apr 13 06:33:40 2016
New Revision: 266190
URL: http://llvm.org/viewvc/llvm-project?rev=266190&view=rev
Log:
[clang-tidy] Add a readability-deleted-default clang-tidy check.
Checks if constructors and assignment operators that are marked '= default' are
actually deleted by
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266190: [clang-tidy] Add a readability-deleted-default
clang-tidy check. (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D18961?vs=53533&id=53536#toc
Repository:
rL LLVM
http:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266191: Complete support for C++ Core Guidelines Type.6:
Always initialize a member… (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D18584?vs=53480&id=53537#toc
Repository:
rL
Author: alexfh
Date: Wed Apr 13 06:35:47 2016
New Revision: 266191
URL: http://llvm.org/viewvc/llvm-project?rev=266191&view=rev
Log:
Complete support for C++ Core Guidelines Type.6: Always initialize a member
variable.
Summary: Added the remaining features needed to satisfy C++ Core Guideline
T
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: rnk.
DmitryPolukhin added a subscriber: cfe-commits.
The example below should work identically with and without compiler native
wchar_t support.
void foo(wchar_t * t = L"");
http://reviews.llvm.org/D19056
Files:
lib/Sema/
Author: cycheng
Date: Wed Apr 13 00:16:31 2016
New Revision: 266166
URL: http://llvm.org/viewvc/llvm-project?rev=266166&view=rev
Log:
[PPC64][VSX] Add a couple of new data types for vec_vsx_ld and vec_vsx_st
intrinsics and fix incorrect testcases with minor refactoring
New added data types:
ve
d.zobnin.bugzilla added a reviewer: rsmith.
d.zobnin.bugzilla removed a subscriber: rsmith.
d.zobnin.bugzilla updated this revision to Diff 53543.
d.zobnin.bugzilla added a comment.
Richard, thank you for the review!
I've created a static function to check if this is a GCC asm statement as you
r
tstellarAMD accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/Basic/Targets.cpp:1854-1857
@@ -1853,1 +1853,6 @@
+ bool isCLZForZeroUndef() const override {
+// It is -1 instead of expected for intrinsic.
+return true;
+ }
+
--
Author: mzuckerm
Date: Wed Apr 13 07:58:01 2016
New Revision: 266195
URL: http://llvm.org/viewvc/llvm-project?rev=266195&view=rev
Log:
[Clang][AVX512][Builtin] Adding support for VBROADCAST and VPBROADCASTB/W/D/Q
instruction set
Differential Revision: http://reviews.llvm.org/D19012
Modified:
sepavloff updated this revision to Diff 53547.
sepavloff added a comment.
Updated patch according to review notes.
The patch adds diagnostics for undefined function templates, in a similar way
as for template variables. These two warnings are classified into different
groups.
Warnings on undefin
Author: abataev
Date: Wed Apr 13 08:36:48 2016
New Revision: 266198
URL: http://llvm.org/viewvc/llvm-project?rev=266198&view=rev
Log:
[OPENMP 4.0] Fixed DSA analysis for taskloop directives.
Patch make clang to perform analysis for task-based directives also for
taskloop-based directives.
Modifi
vbyakovl updated this revision to Diff 53548.
vbyakovl added a comment.
Sema/SemaType.cpp: Vla works in C++ by default. An error is printed if a class
has not default constructor.
test/SemaCXX/c99-variable-length-array.cpp: Changes is removed
test/SemaCXX/vla.cpp: changes is removed.
test/CodeGen
malcolm.parsons added a subscriber: malcolm.parsons.
Comment at: docs/clang-tidy/checks/misc-sizeof-expression.rst:16
@@ +15,3 @@
+A common mistake is to query the ``sizeof`` of an integer literal. This is
+equivalent to query the size of it's type (probably ``int``). The intent o
Author: aaronballman
Date: Wed Apr 13 08:55:58 2016
New Revision: 266199
URL: http://llvm.org/viewvc/llvm-project?rev=266199&view=rev
Log:
Add functions declared in ctype.h to builtin function database. All functions
are annotated with nothrow and pure attribute, which enables better
optimizatio
aaron.ballman closed this revision.
aaron.ballman added a comment.
Commit in r266199, thank you!
http://reviews.llvm.org/D18970
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin.
NoQ added a subscriber: cfe-commits.
Essentially, if `s` is a structure, and `foo(const void *)` is evaluated
conservatively, then `foo(&s)` does not invalidate `s`, but `foo(&(s.x))`
invalidates the whole `s`, because the sto
Author: aaronballman
Date: Wed Apr 13 09:53:52 2016
New Revision: 266201
URL: http://llvm.org/viewvc/llvm-project?rev=266201&view=rev
Log:
Reverting r266199; it causes build bot failures.
http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/3255
http://lab.llvm.org:8011/builders/clang-ppc64
aaron.ballman added a comment.
I reverted this in r266201; it was causing build bot failures like:
http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/3517
Can you please take a look?
Thanks!
http://reviews.llvm.org/D18970
___
cfe-commit
Sure, I'll take a look.
Thanks!
-- Taewook
On 4/13/16, 8:00 AM, "Aaron Ballman" wrote:
>aaron.ballman added a comment.
>
>I reverted this in r266201; it was causing build bot failures like:
>
>https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8011_bu
>ilders_clang-2Dppc64be-2Dl
Author: mzuckerm
Date: Wed Apr 13 10:02:04 2016
New Revision: 266202
URL: http://llvm.org/viewvc/llvm-project?rev=266202&view=rev
Log:
[Clang][AVX512][Builtin] Adding support to intrinsics of
pmovs{d|q}{b|w|d}{128|256|512} instruction set
Differential Revision: http://reviews.llvm.org/D19023
M
alexfh created this revision.
alexfh added a reviewer: sbenza.
alexfh added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
AllKindInfo is being indexed by NodeKindId, so the order must match.
I've updated the tests, though I'm not sure what exactly they verify and whether
the new st
nemanjai closed this revision.
nemanjai added a comment.
Committed revision 266186.
Repository:
rL LLVM
http://reviews.llvm.org/D15120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
mxbOctasic created this revision.
mxbOctasic added a reviewer: djasper.
mxbOctasic added subscribers: cameron314, cfe-commits.
Herald added a subscriber: klimek.
The `*` was treated as multiplication operator in complex pointer type casts.
e.g.
(type *const)bar
(type *restrict)bar
Patch by came
alexfh updated this revision to Diff 53566.
alexfh added a comment.
- Added a test
http://reviews.llvm.org/D19059
Files:
lib/AST/ASTTypeTraits.cpp
unittests/AST/ASTTypeTraitsTest.cpp
unittests/ASTMatchers/Dynamic/ParserTest.cpp
unittests/ASTMatchers/Dynamic/RegistryTest.cpp
Index: unit
sbenza added a comment.
Those tests are testing the code completion you get in clang-query.
The type list must match what that matcher supports.
`hasParent` is declared as
const internal::ArgumentAdaptingMatcherFunc<
internal::HasParentMatcher,
internal::TypeList,
internal::T
alexfh updated this revision to Diff 53569.
alexfh added a comment.
Added a Decl descendant for a test.
http://reviews.llvm.org/D19059
Files:
lib/AST/ASTTypeTraits.cpp
unittests/AST/ASTTypeTraitsTest.cpp
unittests/ASTMatchers/Dynamic/ParserTest.cpp
unittests/ASTMatchers/Dynamic/Registry
alexfh marked an inline comment as done.
alexfh added a comment.
http://reviews.llvm.org/D19059
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This looks good to me, except for the noisy tests.
Comment at:
test/std/containers/associative/set/insert_and_emplace_allocator_requirements.pass.cpp:29
@@ +28,3 @@
mclow.lists added a comment.
Let's retire this patch, then.
I'll be watching for your replacement patches.
http://reviews.llvm.org/D18217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
twoh created this revision.
twoh added a reviewer: aaron.ballman.
twoh added subscribers: joerg, cfe-commits, rsmith.
Add functions declared in ctype.h to builtin function database. All functions
are annotated with nothrow and const attribute, which enables better
optimization.
This patch has
mclow.lists added a comment.
This direction looks fine to me. All the test changes look fine to me.
http://reviews.llvm.org/D17469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jyknight added a comment.
The large amount of casting to/from integers for AtomicOrderingCABI makes me
think that it probably ought not actually be converted to an enum class after
all.
http://reviews.llvm.org/D18876
___
cfe-commits mailing list
c
hintonda added a comment.
Will do -- moved and started new job, so got a bit behind.
Btw, I have a new checker that's under review that will take care of the
noexcept for you. And I think someone else has something that might take care
of the implicit copy/assignment.
So this should be trivia
EricWF added inline comments.
Comment at:
test/std/containers/associative/set/insert_and_emplace_allocator_requirements.pass.cpp:29
@@ +28,3 @@
+template
+void PrintInfo(int line, Arg&& arg)
+{
mclow.lists wrote:
> In general, we want tests to be silent on succe
> On 2016-Apr-13, at 09:50, Eric Fiselier wrote:
>
> EricWF added inline comments.
>
>
> Comment at:
> test/std/containers/associative/set/insert_and_emplace_allocator_requirements.pass.cpp:29
> @@ +28,3 @@
> +template
> +void PrintInfo(int line, Arg&& arg)
> +{
> ---
Author: marshall
Date: Wed Apr 13 12:02:23 2016
New Revision: 266209
URL: http://llvm.org/viewvc/llvm-project?rev=266209&view=rev
Log:
Qualify calls to addressof to avoid getting ADL. Fixes PR#27254.
Modified:
libcxx/trunk/include/__mutex_base
libcxx/trunk/include/shared_mutex
Modified:
Author: tnorthover
Date: Wed Apr 13 12:08:51 2016
New Revision: 266211
URL: http://llvm.org/viewvc/llvm-project?rev=266211&view=rev
Log:
ARM: make Darwin's "-arch armv7em" default to hard-float.
We've already paid the price for separate "armv7m" and "armv7em" slices
(support in other tools), it's
Author: tnorthover
Date: Wed Apr 13 12:08:55 2016
New Revision: 266212
URL: http://llvm.org/viewvc/llvm-project?rev=266212&view=rev
Log:
AArch64: allow 64-bit access to sysregs.
Although all the registers are actually 32-bits, I think we have to assume the
high 32-bits could be RES0 (the ARM ARM
Author: cbieneman
Date: Wed Apr 13 12:12:56 2016
New Revision: 266213
URL: http://llvm.org/viewvc/llvm-project?rev=266213&view=rev
Log:
[OrderFiles] Don't allow lit to run dtrace multithreaded
Dtrace is implemented to try and minimize performance impact on the process
being traced. This results
Prazek added a comment.
In http://reviews.llvm.org/D18821#399079, @alexfh wrote:
> In http://reviews.llvm.org/D18821#399064, @Prazek wrote:
>
> > In http://reviews.llvm.org/D18821#398843, @alexfh wrote:
> >
> > > BTW, why is the check in the 'modernize' module? It doesn't seem to make
> > > anyt
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: test/SemaCXX/no-wchar.cpp:12
@@ +11,2 @@
+void foo1(wchar_t * t = L"");
+// expected-warning@-1 {{conversion from string literal to 'wchar_t *' (aka
'unsigned shor
mxbOctasic created this revision.
mxbOctasic added a reviewer: djasper.
mxbOctasic added subscribers: cameron314, cfe-commits.
Herald added a subscriber: klimek.
Including `VirtualFileSystem.h` in the clangFormat.h indirectly includes
``.
This header is blocked when compiling with /clr.
I added a
mxbOctasic created this revision.
mxbOctasic added a reviewer: djasper.
mxbOctasic added subscribers: cameron314, cfe-commits.
Herald added a subscriber: klimek.
This bug occurred when the end of the file was reached while parsing a block.
The indentation of the last line was reset to the initial
mxbOctasic created this revision.
mxbOctasic added a reviewer: djasper.
mxbOctasic added subscribers: cameron314, cfe-commits.
Herald added a subscriber: klimek.
`getNextMergedLine` merged pairs of adjacent lines instead of merging them all
with the first one.
Consider `AnnotatedLine` `A`, `B` a
Author: dcoughlin
Date: Wed Apr 13 12:59:24 2016
New Revision: 266219
URL: http://llvm.org/viewvc/llvm-project?rev=266219&view=rev
Log:
[analyzer] Nullability: Suppress diagnostic on bind with cast.
Update the nullability checker to allow an explicit cast to nonnull to
suppress a warning on an as
mxbOctasic created this revision.
mxbOctasic added a reviewer: djasper.
mxbOctasic added subscribers: cameron314, cfe-commits.
Herald added a subscriber: klimek.
This patch adds two new spacing options.
`SpaceAfterTemplate` inserts a space between the template keyword and the
opening chevron.
`
Author: dblaikie
Date: Wed Apr 13 13:23:33 2016
New Revision: 266222
URL: http://llvm.org/viewvc/llvm-project?rev=266222&view=rev
Log:
Simplify memory management of CXEvalResultKind/ExprEvalResult using unique_ptr
and a dtor
This doesn't seem to need to be a C type, C only handles a void*, so us
Didn't seem to be too invasive - r266222.
On Tue, Apr 12, 2016 at 10:54 AM, Hans Wennborg wrote:
> While useful, that would require a lot of restructuring, I think.
>
> This file seems to mostly be dealing with C-style objects;
> ExprEvalResult doesn't even have a C++ destructor. I'm not going t
Author: dblaikie
Date: Wed Apr 13 13:36:19 2016
New Revision: 266224
URL: http://llvm.org/viewvc/llvm-project?rev=266224&view=rev
Log:
libclang: Use early-return to reduce indentation.
& since I'll get blamed for all the lines anyway, remove some
else-after-return and otherwise tidy things up.
M
Author: hubert.reinterpretcast
Date: Wed Apr 13 13:41:03 2016
New Revision: 266226
URL: http://llvm.org/viewvc/llvm-project?rev=266226&view=rev
Log:
Remove redundant null-check; NFC
Modified:
cfe/trunk/lib/Parse/ParseDeclCXX.cpp
Modified: cfe/trunk/lib/Parse/ParseDeclCXX.cpp
URL:
http://llv
tigerleapgorge created this revision.
tigerleapgorge added a reviewer: rsmith.
tigerleapgorge added a subscriber: cfe-commits.
13 tests have been updated for C++11 compatibility.
CXX/class.access/class.access.dcl/p1.cpp
Access declarations are deprecated in C++11.
As a result, there are 4 ty
djasper added a comment.
Please read
http://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options.
The "template" option was discussed multiple times and I remain convinced that
the costs outweigh the benefit here.
For the other option:
- Can you make statements wrt
mxbOctasic created this revision.
mxbOctasic added a reviewer: djasper.
mxbOctasic added subscribers: cameron314, cfe-commits.
Herald added a subscriber: klimek.
Multiple brace wrapping flag combination were broken.
First, IndentBraces + !AfterControlStatement caused the whole If-Else construct
mxbOctasic added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:789-790
@@ -773,4 +788,4 @@
if (FormatTok->Tok.is(tok::l_brace)) {
-if (Style.BraceWrapping.AfterObjCDeclaration)
- addUnwrappedLine();
+CompoundStatementIndenter Inden
sbenza added inline comments.
Comment at: clang-tidy/misc/AssignOperatorCheck.cpp:63
@@ +62,3 @@
+
+ Finder->addMatcher(returnStmt(IsBadReturnStatement,
hasAncestor(IsGoodAssign))
+ .bind("returnStmt"),
baloghadamsoftware wrote:
> sbenza
Author: bruno
Date: Wed Apr 13 14:28:24 2016
New Revision: 266235
URL: http://llvm.org/viewvc/llvm-project?rev=266235&view=rev
Log:
[CrashReproducer] Add test to run the reproducer script + modules
Now that we have basic support in place, make sure the reproducer script
works with modules for a s
Author: bruno
Date: Wed Apr 13 14:28:21 2016
New Revision: 266234
URL: http://llvm.org/viewvc/llvm-project?rev=266234&view=rev
Log:
[CrashReproducer] Setup 'use-external-names' in YAML files.
Hide the real paths when rebuilding from VFS by setting up the crash
reproducer to use 'use-external-name
Author: bruno
Date: Wed Apr 13 14:28:16 2016
New Revision: 266233
URL: http://llvm.org/viewvc/llvm-project?rev=266233&view=rev
Log:
[VFS] Move default values to in-class member initialization. NFC
Modified:
cfe/trunk/lib/Basic/VirtualFileSystem.cpp
Modified: cfe/trunk/lib/Basic/VirtualFileSy
djasper added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:1272
@@ +1271,3 @@
+// Casts are never binary operators, regardless of IsExpression
+if (NextToken->isOneOf(tok::r_paren, tok::greater))
+ return TT_PointerOrReference;
I think i
djasper added a comment.
Nice catch.
Comment at: unittests/Format/FormatTest.cpp:285
@@ +284,3 @@
+
+ EXPECT_EQ("class Foo\n"
+"{\n"
How does this break? I generally add an Before and After of one of the test
cases into my patch descriptions.
htt
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: include/clang/Format/Format.h:30
@@ +29,3 @@
+namespace vfs {
+
+class FileSystem;
nit: Remove this empty line.
http://reviews.llv
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D19065
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
djasper added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:1388-1390
@@ -1372,3 +1387,5 @@
parseBlock(/*MustBeDeclaration=*/false);
-if (Style.BraceWrapping.BeforeElse)
+if (Style.BraceWrapping.BeforeElse ||
+Style.BraceWrapping.AfterControl
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Thanks! This looks great.
Comment at: test/SemaCXX/MicrosoftExtensions.cpp:89
@@ +88,3 @@
+void foo_unaligned(int *arg) {}
+void foo_unaligned(__unaligned int *arg) {}
+void foo_una
Author: lcharles
Date: Wed Apr 13 15:00:45 2016
New Revision: 266239
URL: http://llvm.org/viewvc/llvm-project?rev=266239&view=rev
Log:
Lit C++11 Compatibility Patch #7
13 tests have been updated for C++11 compatibility.
Differential Revision: http://reviews.llvm.org/D19068
Modified:
cfe/trun
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266239: Lit C++11 Compatibility Patch #7 (authored by
lcharles).
Changed prior to commit:
http://reviews.llvm.org/D19068?vs=53603&id=53607#toc
Repository:
rL LLVM
http://reviews.llvm.org/D19068
Fil
mxbOctasic updated this revision to Diff 53608.
mxbOctasic added a comment.
Removed empty line.
http://reviews.llvm.org/D19064
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
Index: lib/Format/Format.cpp
===
--- lib
etienneb added inline comments.
Comment at: clang-tidy/misc/SizeofExpressionCheck.cpp:28
@@ +27,3 @@
+ return Node.getValue().getZExtValue() > N;
+}
+
alexfh wrote:
> There are no firm rules. It mostly depends on how generic/useful in other
> tools the matcher c
etienneb updated this revision to Diff 53609.
etienneb marked 2 inline comments as done.
etienneb added a comment.
alexfh@ comment: top-down approach.
http://reviews.llvm.org/D19014
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/SizeofExpressionCh
yaxunl created this revision.
yaxunl added reviewers: Anastasia, bader, pxli168.
yaxunl added subscribers: tstellarAMD, cfe-commits.
OpenCL spec 1.2/2.0 requires `__OPENCL_C_VERSION__` to be defined based on
-cl-std option. This patch implements that.
OpenCL spec 1.0/1.1 does not have a predefin
george.burgess.iv updated this revision to Diff 53611.
george.burgess.iv added a comment.
Now that `allocsize` is in LLVM (r266032), this isn't blocked. Yay!
Rebased, added a few tests, did a few tiny refactors, and fixed an overflow bug
when the user tried to allocate `2**63 < N < 2**64` bytes
Author: hans
Date: Wed Apr 13 15:21:15 2016
New Revision: 266242
URL: http://llvm.org/viewvc/llvm-project?rev=266242&view=rev
Log:
Make sure CheckDestructor gets called on dllimported classes if the vtable is
used (PR27319)
Modified:
cfe/trunk/lib/Sema/SemaDeclCXX.cpp
cfe/trunk/test/Code
mxbOctasic added inline comments.
Comment at: unittests/Format/FormatTest.cpp:285
@@ +284,3 @@
+
+ EXPECT_EQ("class Foo\n"
+"{\n"
djasper wrote:
> How does this break? I generally add an Before and After of one of the test
> cases into my patch descr
1 - 100 of 126 matches
Mail list logo
