> On 2016-Apr-13, at 09:50, Eric Fiselier <e...@efcs.ca> wrote:
> 
> EricWF added inline comments.
> 
> ================
> Comment at: 
> test/std/containers/associative/set/insert_and_emplace_allocator_requirements.pass.cpp:29
> @@ +28,3 @@
> +template <class Arg>
> +void PrintInfo(int line, Arg&& arg)
> +{
> ----------------
> mclow.lists wrote:
>> In general, we want tests to be silent on success.
> I'll see what I can do. The reason these tests are so noisy is because almost 
> all of the assertions are in "container_test_types.h". Meaning that when the 
> tests fail the diagnostic points into the header with no information about 
> what code actually triggered the assertion.  Hence why these tests manually 
> print what they are testing.
> 
> I'll try and come up with something better.

You might be able to change the API to use macros that pass in __FILE__
and __LINE__ as arguments.

> 
> 
> http://reviews.llvm.org/D18637
> 
> 
> 

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to