r266117 - Pass -backend-option to LLVM when there is no target machine.

Author: yaxunl Date: Tue Apr 12 15:22:32 2016 New Revision: 266117 URL: http://llvm.org/viewvc/llvm-project?rev=266117&view=rev Log: Pass -backend-option to LLVM when there is no target machine. Clang should pass -backend-option to LLVM even though there is no target machine, since LLVM passes a

Re: [PATCH] D17552: Pass -backend-option to LLVM when there is no target machine

This revision was automatically updated to reflect the committed changes. Closed by commit rL266117: Pass -backend-option to LLVM when there is no target machine. (authored by yaxunl). Changed prior to commit: http://reviews.llvm.org/D17552?vs=51326&id=53449#toc Repository: rL LLVM http://r

Re: [PATCH] D18584: Complete support for C++ Core Guidelines Type.6: Always initialize a member variable.

alexfh added a comment. Do you have svn commit access? http://reviews.llvm.org/D18584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D19029: Always use --eh-frame-hdr on FreeBSD, even for -static

emaste created this revision. emaste added reviewers: dim, andrew, davide. emaste added a subscriber: cfe-commits. Herald added subscribers: emaste, aemerson. FreeBSD uses LLVM's libunwind on FreeBSD/arm64 today (and we expect to use it more widely in the future) and it requires the EH frame segm

Re: [PATCH] D19014: [clang-tidy] Add new checker for suspicious sizeof expressions

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: docs/ReleaseNotes.rst:100 @@ -99,1 +99,3 @@ +- New `misc-sizeof-expression + `_ check Please put this check after misc-mi

Re: [PATCH] D18584: Complete support for C++ Core Guidelines Type.6: Always initialize a member variable.

michael_miller added a comment. In http://reviews.llvm.org/D18584#398929, @alexfh wrote: > Do you have svn commit access? I do not... this is my first contribution to llvm/clang. http://reviews.llvm.org/D18584 ___ cfe-commits mailing list cfe-com

Re: [PATCH] D19029: Always use --eh-frame-hdr on FreeBSD, even for -static

emaste updated this revision to Diff 53452. emaste added a comment. Test --eh-frame-hdr addition http://reviews.llvm.org/D19029 Files: lib/Driver/Tools.cpp test/Driver/freebsd.c Index: test/Driver/freebsd.c === --- test/Driver

Re: [PATCH] D19029: Always use --eh-frame-hdr on FreeBSD, even for -static

rafael added a subscriber: rafael. rafael accepted this revision. rafael added a reviewer: rafael. rafael added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D19029 ___ cfe-commits mailing list cfe-commits@

Re: [PATCH] D19031: clang-format: Flexible line endings

cameron314 added a comment. ClangFormat still needs to know what kind of newline to insert when reformatting code. It already had the "auto-detect newline" behaviour; this patch simply allows the auto-detection to be overridden with an explicit setting. This is important for short files that ha

Re: [PATCH] D19031: clang-format: Flexible line endings

djasper added a comment. Can you elaborate more on what case this is actually addressing? Are you saying that you have a one-line file without linebreaks that you want clang-format to format? http://reviews.llvm.org/D19031 ___ cfe-commits mailing

Re: [PATCH] D18584: Complete support for C++ Core Guidelines Type.6: Always initialize a member variable.

alexfh added a comment. I can commit the patch for you, but you need to split it in two: one for the cfe repository, one for clang-tools-extra. http://reviews.llvm.org/D18584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

Re: [PATCH] D19031: clang-format: Flexible line endings

cameron314 added a comment. Sure :-) The motivation behind this patch (and a few more upcoming ones) is to make ClangFormat (the library) more friendly for IDE integration (which is our primary use case), in particular for on-the-fly auto-formatting. In an IDE auto-format setting, it's often t

r266122 - Add a couple of missing vsx load and store intrinsics.

Author: echristo Date: Tue Apr 12 16:08:54 2016 New Revision: 266122 URL: http://llvm.org/viewvc/llvm-project?rev=266122&view=rev Log: Add a couple of missing vsx load and store intrinsics. Patch by Jing Yu! Modified: cfe/trunk/lib/Headers/altivec.h cfe/trunk/test/CodeGen/builtins-ppc-vs

Re: [PATCH] D19031: clang-format: Flexible line endings

djasper added a comment. Passing snippets / single lines from an IDE does not make sense. Don't try to go down this road. clang-format always needs the full file as context. If you are already in an IDE, that IDE should control the line endings, not clang-format. Write a thin wrapper that chang

Re: [PATCH] D19029: Always use --eh-frame-hdr on FreeBSD, even for -static

This revision was automatically updated to reflect the committed changes. Closed by commit rL266123: Always use --eh-frame-hdr on FreeBSD, even for -static (authored by emaste). Changed prior to commit: http://reviews.llvm.org/D19029?vs=53452&id=53460#toc Repository: rL LLVM http://reviews.

r266123 - Always use --eh-frame-hdr on FreeBSD, even for -static

Author: emaste Date: Tue Apr 12 16:11:46 2016 New Revision: 266123 URL: http://llvm.org/viewvc/llvm-project?rev=266123&view=rev Log: Always use --eh-frame-hdr on FreeBSD, even for -static FreeBSD uses LLVM's libunwind on FreeBSD/arm64 today (and is expected to use it more widely in the future), a

Re: [PATCH] D18473: AMDGPU: Add test for generic builtin behavior

arsenm added inline comments. Comment at: lib/Basic/Targets.cpp:1854-1857 @@ -1853,1 +1853,6 @@ + bool isCLZForZeroUndef() const override { +// It is -1 instead of expected for intrinsic. +return true; + } + tstellarAMD wrote: > Why do we need to add t

Re: [PATCH] D19031: clang-format: Flexible line endings

cameron314 added a comment. Too late ;-) We've successfully integrated it as the engine behind our auto-formatting feature, passing only the minimal context necessary. We tried at first to supply the full file context, but that turned out to be much too slow in larger files. (We did a fair bit o

r266127 - Add a fixme for an old patch I had lying around that I'm not going to finish any time so n

Author: dblaikie Date: Tue Apr 12 16:22:48 2016 New Revision: 266127 URL: http://llvm.org/viewvc/llvm-project?rev=266127&view=rev Log: Add a fixme for an old patch I had lying around that I'm not going to finish any time so n Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/tru

Re: [PATCH] D18584: Complete support for C++ Core Guidelines Type.6: Always initialize a member variable.

michael_miller added a comment. In http://reviews.llvm.org/D18584#399024, @alexfh wrote: > I can commit the patch for you, but you need to split it in two: one for the > cfe repository, one for clang-tools-extra. Great—thanks! I have them separated already and had to merge them for the Phabri

Re: [PATCH] D19031: clang-format: Flexible line endings

djasper added a comment. It has very basic newline detection, but if possible, I'd like to not significantly increase that. Specifically, I don't think it is worth the complexity of additional configuration options that users have to worry about, if it can just do the right thing (which IMO, it

Re: [PATCH] D18821: Add modernize-bool-to-integer-conversion

Prazek added a comment. In http://reviews.llvm.org/D18821#398843, @alexfh wrote: > BTW, why is the check in the 'modernize' module? It doesn't seem to make > anything more modern. I would guess, the pattern it detects is most likely to > result from a programming error. Also, the fix, though it

r266133 - [AMDGPU] Add debugger related target options

Author: kzhuravl Date: Tue Apr 12 16:42:15 2016 New Revision: 266133 URL: http://llvm.org/viewvc/llvm-project?rev=266133&view=rev Log: [AMDGPU] Add debugger related target options Differential Revision: http://reviews.llvm.org/D18748 Added: cfe/trunk/test/Driver/amdgpu-features.c Modified:

Re: [PATCH] D18748: [AMDGPU] Add debugger related target options

This revision was automatically updated to reflect the committed changes. Closed by commit rL266133: [AMDGPU] Add debugger related target options (authored by kzhuravl). Changed prior to commit: http://reviews.llvm.org/D18748?vs=52516&id=53466#toc Repository: rL LLVM http://reviews.llvm.org

Re: [PATCH] D18821: Add modernize-bool-to-integer-conversion

alexfh added a comment. In http://reviews.llvm.org/D18821#399064, @Prazek wrote: > In http://reviews.llvm.org/D18821#398843, @alexfh wrote: > > > BTW, why is the check in the 'modernize' module? It doesn't seem to make > > anything more modern. I would guess, the pattern it detects is most likel

Re: [PATCH] D18584: Complete support for C++ Core Guidelines Type.6: Always initialize a member variable.

alexfh added a comment. In http://reviews.llvm.org/D18584#399056, @michael_miller wrote: > In http://reviews.llvm.org/D18584#399024, @alexfh wrote: > > > I can commit the patch for you, but you need to split it in two: one for > > the cfe repository, one for clang-tools-extra. > > > Great—thanks

Re: [PATCH] D19029: Always use --eh-frame-hdr on FreeBSD, even for -static

LGTM. On Tue, Apr 12, 2016 at 2:17 PM, Ed Maste wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL266123: Always use --eh-frame-hdr on FreeBSD, even for > -static (authored by emaste). > > Changed prior to commit: > http://reviews.llvm.org/

Re: [PATCH] D19029: Always use --eh-frame-hdr on FreeBSD, even for -static

davide added a subscriber: davide. davide added a comment. LGTM. Repository: rL LLVM http://reviews.llvm.org/D19029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18997: [SemaObjC] Properly diagnose type arguments and protocols mix in parameterized classes

bruno updated this revision to Diff 53470. bruno added a comment. New patch after Manman's review. http://reviews.llvm.org/D18997 Files: include/clang/Sema/Sema.h lib/Parse/ParseObjc.cpp lib/Sema/SemaDeclObjC.cpp test/SemaObjC/parameterized_classes.m Index: test/SemaObjC/parameterized_

Re: [PATCH] D19031: clang-format: Flexible line endings

cameron314 added a comment. We did profile at one point, to see if it was something we could trivially speed up (it wasn't). Most of it was on the parsing/annotation side, yes (which makes sense, since that's the majority of the work when the format region itself is limited). I'm afraid I don't

Re: [PATCH] D19031: clang-format: Flexible line endings

cameron314 added a comment. Ooh, and I should also add, there's a non-trivial cost to grabbing the entire file contents as a string and then converting it to UTF-8. If ClangFormat was faster, this would certainly become a significant bottleneck that can't really be worked around. http://revie

[PATCH] D19038: Add AST Matchers for CXXConstructorDecl::isDelegatingConstructor and CXXMethodDecl::isUserProvided.

michael_miller created this revision. michael_miller added reviewers: alexfh, aaron.ballman. michael_miller added a subscriber: cfe-commits. Herald added a subscriber: klimek. Added two AST matchers: isDelegatingConstructor for CXXConstructorDecl::IsDelegatingConstructor; and isUserProvided corre

Re: [PATCH] D18584: Complete support for C++ Core Guidelines Type.6: Always initialize a member variable.

michael_miller updated this revision to Diff 53480. michael_miller added a comment. Broke out the cfe parts into its own change (http://reviews.llvm.org/D19038). http://reviews.llvm.org/D18584 Files: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tidy/cppcoreguidelines/ProTyp

Re: [PATCH] D18997: [SemaObjC] Properly diagnose type arguments and protocols mix in parameterized classes

manmanren added a comment. LGTM. Manman http://reviews.llvm.org/D18997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r266146 - ObjC class properties: add diagnostics for unimplemented class properties.

Author: mren Date: Tue Apr 12 18:01:55 2016 New Revision: 266146 URL: http://llvm.org/viewvc/llvm-project?rev=266146&view=rev Log: ObjC class properties: add diagnostics for unimplemented class properties. rdar://24711047 Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe

r266147 - [ObjC] Pop all cleanups created in EmitObjCForCollectionStmt before

Author: ahatanak Date: Tue Apr 12 18:10:58 2016 New Revision: 266147 URL: http://llvm.org/viewvc/llvm-project?rev=266147&view=rev Log: [ObjC] Pop all cleanups created in EmitObjCForCollectionStmt before exiting the for-in loop. This commit fixes a bug where EmitObjCForCollectionStmt didn't pop cl

Re: [PATCH] D18618: [ObjC] Pop all cleanups created in CodeGenFunction::EmitObjCForCollectionStmt

This revision was automatically updated to reflect the committed changes. Closed by commit rL266147: [ObjC] Pop all cleanups created in EmitObjCForCollectionStmt before (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D18618?vs=52609&id=53489#toc Repository: rL LLVM

Re: [PATCH] D18849: [modules] Avoid module relocation error when building modules from VFS

bruno abandoned this revision. bruno added a comment. Hi Ben, Comment at: lib/Basic/FileManager.cpp:221-223 @@ -220,2 +220,5 @@ // See if there is already an entry in the map. + // FIXME: Note that when first requested, the returned file name equals to the + // requested p

Re: [PATCH] D18073: Add memory allocating functions

ariccio updated this revision to Diff 53495. ariccio added a comment. Changed the new file name. http://reviews.llvm.org/D18073 Files: llvm/tools/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp llvm/tools/clang/test/Analysis/alternative-malloc-api.c llvm/tools/clang/test/Analysis/mall

Re: [PATCH] D18073: Add memory allocating functions

ariccio added a comment. In http://reviews.llvm.org/D18073#398882, @zaks.anna wrote: > "Since we are adding support for so many new APIs that are only available on > Windows, could you please condition checking them only when we build for > Windows. You probably can look and Language Options to

r266154 - clang/test/Driver/cl-options.c: Fix an expression to recognize dos r'\\'.

Author: chapuni Date: Tue Apr 12 19:22:25 2016 New Revision: 266154 URL: http://llvm.org/viewvc/llvm-project?rev=266154&view=rev Log: clang/test/Driver/cl-options.c: Fix an expression to recognize dos r'\\'. Modified: cfe/trunk/test/Driver/cl-options.c Modified: cfe/trunk/test/Driver/cl-opti

r266157 - [analyzer] Nullability: Treat nil _Nonnull ivar as invariant violation.

Author: dcoughlin Date: Tue Apr 12 19:41:54 2016 New Revision: 266157 URL: http://llvm.org/viewvc/llvm-project?rev=266157&view=rev Log: [analyzer] Nullability: Treat nil _Nonnull ivar as invariant violation. Treat a _Nonnull ivar that is nil as an invariant violation in a similar fashion to how a

Re: [PATCH] D18596: [MSVC] PR27132: Proper mangling for __unaligned qualifier

andreybokhanko updated this revision to Diff 53509. andreybokhanko added a comment. 1. Added more comprehensive overloading tests 2. Added a warning (in C mode) / error (in C++ mode) on __unaligned to non-__unaligned type conversion Andrey http://reviews.llvm.org/D18596 Files: include/clang

Re: [PATCH] D18596: [MSVC] PR27132: Proper mangling for __unaligned qualifier

andreybokhanko marked an inline comment as done. Comment at: test/SemaCXX/MicrosoftExtensions.cpp:89 @@ +88,3 @@ +void foo_unaligned(int *arg) {} +void foo_unaligned(__unaligned int *arg) {} +void foo_unaligned(int arg) {} // expected-note {{previous definition is here}} -

[PATCH] D19048: Test for a module related crash in CGDebugInfo.cpp

dyung created this revision. dyung added a reviewer: aprantl. dyung added a subscriber: cfe-commits. In our internal testing, we found a crash in the compiler which was reduced to the attached test case. The issue was "fixed" a while back with Adrian's change in r248069 as the code causing the c

Re: [PATCH] D16797: Update clang support on recent Haiku

korli updated this revision to Diff 53464. korli added a comment. Updated patch against trunk (following changes in lib/Basic/Targets.cpp). Repository: rL LLVM http://reviews.llvm.org/D16797 Files: lib/Basic/Targets.cpp lib/Driver/Driver.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolC

Re: [PATCH] D18551: Added Fixer implementation and fix() interface in clang-format for removing redundant code.

djasper added inline comments. Comment at: lib/Format/Format.cpp:1677 @@ +1676,3 @@ + +class Formatter { +public: I think FormatStyle in the Processor should be const and Formatter should make its own copy to modify it. Comment at: lib/Format/Fo

<    1   2