Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

sberg added a comment. friendly ping http://reviews.llvm.org/D16628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18276: [OpenMP] Allow reduction on pointer dereference

Hahnfeld abandoned this revision. Comment at: lib/CodeGen/CGStmtOpenMP.cpp:913-929 @@ -912,9 +912,19 @@ }); - } else if (auto *ASE = dyn_cast(IRef)) { -auto *Base = ASE->getBase()->IgnoreParenImpCasts(); -while (auto *TempASE = dyn_cast(Base)) -

Re: [PATCH] D17596: [OpenCL] Add ocl and spir version for spir target

pekka.jaaskelainen added inline comments. Comment at: test/CodeGenOpenCL/spir_version.cl:15 @@ +14,2 @@ +// CL20: !opencl.ocl.version = !{[[SPIR:![0-9]+]]} +// CL20: [[SPIR]] = !{i32 2, i32 0} Can you test 'spir64' too? http://reviews.llvm.org/D17596

r263921 - [Cxx1z] Implement Lambda Capture of *this by Value as [=, *this] (P0018R3)

Author: faisalv Date: Mon Mar 21 04:25:37 2016 New Revision: 263921 URL: http://llvm.org/viewvc/llvm-project?rev=263921&view=rev Log: [Cxx1z] Implement Lambda Capture of *this by Value as [=,*this] (P0018R3) Implement lambda capture of *this by copy. For e.g.: struct A { int d = 10; auto foo

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

danielmarjamaki added a comment. ping http://reviews.llvm.org/D13126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D18309: sourceRange function for MemRegion

Alexander_Droste created this revision. Alexander_Droste added a reviewer: zaks.anna. Alexander_Droste added subscribers: dcoughlin, xazax.hun, cfe-commits. Retrieve source range from memory region. The range retrieval is based on the decl obtained from the memory region. http://reviews.llvm.or

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

With the latest changes unit tests are successfully passed on Windows! You can go forward in completing the fix. Thanks, --Serge 2016-03-18 21:44 GMT+06:00 Aleksei Sidorin : > a.sidorin updated this revision to Diff 51027. > a.sidorin added a comment. > > Serge, thank you for help! > GNUNullExpr

r263922 - Reorder data members to be consistent with member initializers, to silence warnings.

Author: faisalv Date: Mon Mar 21 05:37:42 2016 New Revision: 263922 URL: http://llvm.org/viewvc/llvm-project?rev=263922&view=rev Log: Reorder data members to be consistent with member initializers, to silence warnings. Modified: cfe/trunk/include/clang/Sema/ScopeInfo.h Modified: cfe/trunk/i

r263931 - clang/test/Frontend/plugin-annotate-functions.c requires the target examples/AnnotateFunctions.

Author: chapuni Date: Mon Mar 21 06:03:39 2016 New Revision: 263931 URL: http://llvm.org/viewvc/llvm-project?rev=263931&view=rev Log: clang/test/Frontend/plugin-annotate-functions.c requires the target examples/AnnotateFunctions. Modified: cfe/trunk/test/CMakeLists.txt Modified: cfe/trunk/t

[PATCH] D18311: Clang tests for ARM Cortex-A32 support.

samparker created this revision. samparker added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. http://reviews.llvm.org/D18311 Files: test/CodeGen/arm-target-features.c test/Driver/arm-cortex-cpus.c test/Preprocessor/arm-target-features.c Index: test/Preprocessor/

Re: [PATCH] D18311: Clang tests for ARM Cortex-A32 support.

rengolin added inline comments. Comment at: test/Preprocessor/arm-target-features.c:349 @@ -349,1 +348,3 @@ +// Test whether predefines are as expected when targeting ARMv8-A Cortex implementations +// RUN: %clang -target armv8 -mcpu=cortex-a32 -x c -E -dM %s -o - | FileCheck --

Re: [PATCH] D18293: [clang-tidy] Fix redundant-string-init check with msvc 14 headers.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. The patch looks good to me. http://reviews.llvm.org/D18293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

Re: [PATCH] D16044: getDescriptiveName() for MemRegion

Alexander_Droste added a comment. I submitted the sourceRange patch here: http://reviews.llvm.org/D18309 If also this patch would get committed as part of the package, there would be no need for an incremental commit procedure. http://reviews.llvm.org/D16044 _

r263934 - clang/test/CodeGenCXX/cxx1z-lambda-star-this.cpp: Satisfy -Asserts.

Author: chapuni Date: Mon Mar 21 06:40:15 2016 New Revision: 263934 URL: http://llvm.org/viewvc/llvm-project?rev=263934&view=rev Log: clang/test/CodeGenCXX/cxx1z-lambda-star-this.cpp: Satisfy -Asserts. Modified: cfe/trunk/test/CodeGenCXX/cxx1z-lambda-star-this.cpp Modified: cfe/trunk/test/Co

r263936 - Remove debug output. Sorry for the noise.

Author: chapuni Date: Mon Mar 21 06:44:05 2016 New Revision: 263936 URL: http://llvm.org/viewvc/llvm-project?rev=263936&view=rev Log: Remove debug output. Sorry for the noise. Modified: cfe/trunk/test/CodeGenCXX/cxx1z-lambda-star-this.cpp Modified: cfe/trunk/test/CodeGenCXX/cxx1z-lambda-star

Re: [PATCH] D18264: [clang-tidy] misc-assign-operator-signature checker checks return value of all assign operators

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D18264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D18264: [clang-tidy] misc-assign-operator-signature checker checks return value of all assign operators

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a comment. I don't think this is a safe assumption to make -- for instance, DSLs tend to have operator overload return types that aren't necessarily the same as the class type. Also, it's quite common for older code (pre C++11

[PATCH] D18313: clang-format: Make include sorting's main include detection configurable.

djasper created this revision. djasper added a reviewer: klimek. djasper added a subscriber: cfe-commits. Herald added a subscriber: klimek. This patch adds a regular expression to configure suffixes of an included file to check whether it is the "main" include of the current file. Previously, c

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

PING On Mon, Mar 14, 2016 at 8:18 PM Eric Liu wrote: > ioeric updated this revision to Diff 50627. > ioeric marked 10 inline comments as done. > ioeric added a comment. > > - renamed calculateChangedRangesInFile to calculateChangedRanges; removed > const from FileToReplacementsMap key type. > >

Re: [PATCH] D18313: clang-format: Make include sorting's main include detection configurable.

djasper updated this revision to Diff 51154. http://reviews.llvm.org/D18313 Files: include/clang/Format/Format.h lib/Format/Format.cpp unittests/Format/FormatTest.cpp unittests/Format/SortIncludesTest.cpp Index: unittests/Format/SortIncludesTest.cpp ==

Re: [PATCH] D18313: clang-format: Make include sorting's main include detection configurable.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Comment at: include/clang/Format/Format.h:415 @@ +414,3 @@ + /// as the "main" include in both a.cc and a_test.cc. + std::string IncludeMainRegex; + I'd

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

klimek added inline comments. Comment at: include/clang/Tooling/Core/Replacement.h:231 @@ +230,3 @@ +typedef std::map +FileToReplacementsMap; + Honestly, I'd get rid of the typedef. Daniel, what do you think? Comment at: lib/Tooling/Refactori

Re: [PATCH] D17986: [ASTMatchers] New matcher hasReturnValue added

baloghadamsoftware updated this revision to Diff 51155. http://reviews.llvm.org/D17986 Files: include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTMatchersTest.cpp Index: unittests/ASTMatchers/ASTMatchersTest.cpp

Re: [PATCH] D18294: clang-format: [JS] no space in union and intersection types.

djasper added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:526 @@ +525,3 @@ +case tok::amp: + if (Style.Language == FormatStyle::LK_JavaScript && + !Contexts.back().IsExpression) { Don't use braces and possibly pull the comment out

Re: [PATCH] D18313: clang-format: Make include sorting's main include detection configurable.

djasper added inline comments. Comment at: include/clang/Format/Format.h:415 @@ +414,3 @@ + /// as the "main" include in both a.cc and a_test.cc. + std::string IncludeMainRegex; + I chose this name for better alphabetical ordering. I don't strongly lean either

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

djasper added inline comments. Comment at: include/clang/Tooling/Core/Replacement.h:231 @@ +230,3 @@ +typedef std::map +FileToReplacementsMap; + klimek wrote: > Honestly, I'd get rid of the typedef. Daniel, what do you think? I agree. I don't think it carries

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

ioeric added inline comments. Comment at: lib/Tooling/Refactoring.cpp:90 @@ +89,3 @@ + +// FIXME: duplicated code here. Any better way to overload? +bool formatAndApplyAllReplacements(const Replacements &Replaces, klimek wrote: > Just call the above with the forma

Re: [PATCH] D18313: clang-format: Make include sorting's main include detection configurable.

klimek added inline comments. Comment at: include/clang/Format/Format.h:415 @@ +414,3 @@ + /// as the "main" include in both a.cc and a_test.cc. + std::string IncludeMainRegex; + djasper wrote: > I chose this name for better alphabetical ordering. I don't strong

Re: [PATCH] D18294: clang-format: [JS] no space in union and intersection types.

mprobst updated this revision to Diff 51159. mprobst marked 2 inline comments as done. mprobst added a comment. - Address review comments. http://reviews.llvm.org/D18294 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Forma

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

klimek added inline comments. Comment at: lib/Tooling/Refactoring.cpp:90 @@ +89,3 @@ + +// FIXME: duplicated code here. Any better way to overload? +bool formatAndApplyAllReplacements(const Replacements &Replaces, ioeric wrote: > klimek wrote: > > Just call the ab

Re: [PATCH] D18149: Add check for unneeded copies of locals

hokein added inline comments. Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.cpp:87 @@ +86,3 @@ + +namespace { +void recordFixes(const VarDecl &Var, ASTContext &Context, I prefer to move the anonymous namespace under `namespace performance {` st

r263943 - clang-format: Make include sorting's main include detection configurable.

Author: djasper Date: Mon Mar 21 09:11:27 2016 New Revision: 263943 URL: http://llvm.org/viewvc/llvm-project?rev=263943&view=rev Log: clang-format: Make include sorting's main include detection configurable. This patch adds a regular expression to configure suffixes of an included file to check w

Re: [PATCH] D18264: [clang-tidy] misc-assign-operator-signature checker checks return value of all assign operators

xazax.hun added a comment. In http://reviews.llvm.org/D18264#379092, @aaron.ballman wrote: > Also, it's quite common for older code (pre C++11) to return void and make > these functions private (with no definition) as an early form of deleting the > operator. This checker will not warn on pri

Re: [PATCH] D18264: [clang-tidy] misc-assign-operator-signature checker checks return value of all assign operators

aaron.ballman added a comment. In http://reviews.llvm.org/D18264#379159, @xazax.hun wrote: > In http://reviews.llvm.org/D18264#379092, @aaron.ballman wrote: > > > Also, it's quite common for older code (pre C++11) to return void and make > > these functions private (with no definition) as an ear

Re: [PATCH] D17986: [ASTMatchers] New matcher hasReturnValue added

sbenza added a comment. Can you rerun the doc script (dump_ast_matchers.py)? http://reviews.llvm.org/D17986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18311: Clang tests for ARM Cortex-A32 support.

samparker updated this revision to Diff 51165. samparker added a comment. Changed A53-ARM and A53-THUMB test prefixes to ARMV8-ARM and ARMV8-THUMB. http://reviews.llvm.org/D18311 Files: test/Preprocessor/arm-target-features.c Index: test/Preprocessor/arm-target-features.c ===

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

ioeric added inline comments. Comment at: lib/Tooling/Refactoring.cpp:90 @@ +89,3 @@ + +// FIXME: duplicated code here. Any better way to overload? +bool formatAndApplyAllReplacements(const Replacements &Replaces, klimek wrote: > ioeric wrote: > > klimek wrote: >

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

ioeric updated this revision to Diff 51166. ioeric marked 8 inline comments as done. ioeric added a comment. - removed FileToReplacementsMap typedef; refactored formatAndApplyReplacements to reduce duplicated code. http://reviews.llvm.org/D17852 Files: include/clang/Basic/SourceManager.h i

Re: [PATCH] D18311: Clang tests for ARM Cortex-A32 support.

rengolin accepted this revision. rengolin added a reviewer: rengolin. rengolin added a comment. This revision is now accepted and ready to land. Hi Sam, The patch looks good, thanks! A few comments on the process: 1. When you send an update, send the whole patch again, not just the new diff. E

clang-tidy modernize-use-override

Hi, First time poster here, Please advise... Can I contribute these patches for clang-tidy modernize-use-override addressing two problems: 1: missing spaces on pure function decls Orig: void pure() const=0 Problem: void pure() constoverride =0 Fixed: void pure() const override =0 2: This is m

Re: [PATCH] D18311: Clang tests for ARM Cortex-A32 support.

samparker added a comment. Hi Renato, Thanks for the tips, one patch makes much more sense. I'm currently in the process of obtaining commit access and this patch depends on http://reviews.llvm.org/D18239. Thanks again, sam http://reviews.llvm.org/D18311 __

Re: [PATCH] D18294: clang-format: [JS] no space in union and intersection types.

djasper added a comment. Looks good. http://reviews.llvm.org/D18294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16993: Add missing __builtin_bitreverse8

arsenm added a comment. ping http://reviews.llvm.org/D16993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18294: clang-format: [JS] no space in union and intersection types.

mprobst added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:2154 @@ -2141,1 +2153,3 @@ return Style.SpacesInAngles; + if (Style.Language == FormatStyle::LK_JavaScript && + (Left.is(TT_JsTypeOperator) || Right.is(TT_JsTypeOperator))) djasper

Re: [PATCH] D18243: [ASTMatchers] Existing matcher hasAnyArgument fixed

baloghadamsoftware updated this revision to Diff 51167. http://reviews.llvm.org/D18243 Files: include/clang/ASTMatchers/ASTMatchers.h unittests/ASTMatchers/ASTMatchersTest.cpp Index: unittests/ASTMatchers/ASTMatchersTest.cpp ===

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

klimek added inline comments. Comment at: unittests/Tooling/RefactoringTest.cpp:206 @@ +205,3 @@ +TEST_F(ReplacementTest, ReplaceAndFormatNoStyle) { + std::string Code = "MyType012345678901234567890123456789 *a =\n" + "new MyType012345678901234567890123456

Re: [PATCH] D18311: Clang tests for ARM Cortex-A32 support.

rengolin added a comment. Right, if you could update both reviews with the full patch, I could commit them for you, for now. http://reviews.llvm.org/D18311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MPI-Checker/MPIChecker.cpp:136 @@ +135,3 @@ + auto NodeIt = G.eop_begin(); + const auto NodeEndIt = G.eop_end(); + Alexander_Droste wrote: > zaks.anna wrote: > > The analyzer does not do a

Re: [PATCH] D17986: [ASTMatchers] New matcher hasReturnValue added

baloghadamsoftware added a comment. I can rerun the script, however it seems it was not executed before the last commit on the master branch, thus if I rerun it then changes will appear in my diff which are not related to my work. What is the exect policy about running this scipt? Should it be

Re: [PATCH] D18311: Clang tests for ARM Cortex-A32 support.

samparker updated this revision to Diff 51173. samparker added a comment. Combined the two diffs http://reviews.llvm.org/D18311 Files: test/CodeGen/arm-target-features.c test/Driver/arm-cortex-cpus.c test/Preprocessor/arm-target-features.c Index: test/Preprocessor/arm-target-features.c =

r263947 - clang-cl: support __cdecl-on-struct anachronism

Author: rnk Date: Mon Mar 21 11:08:49 2016 New Revision: 263947 URL: http://llvm.org/viewvc/llvm-project?rev=263947&view=rev Log: clang-cl: support __cdecl-on-struct anachronism Summary: The Microsoft compiler emits warning C4229: anachronism used : modifiers on data are ignored for struct

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

This revision was automatically updated to reflect the committed changes. Closed by commit rL263947: clang-cl: support __cdecl-on-struct anachronism (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D16628?vs=46228&id=51176#toc Repository: rL LLVM http://reviews.llvm.org/D

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

zaks.anna added a comment. Why is there such a large jump in the number of warnings reported in the last patch iteration? It went from "1678 projects where scanned. In total I got 124 warnings" to "In 2215 projects it found 875 warnings." Did the number of warnings in the initial 1678 projects

[PATCH] D18319: Add a PragmaHandler Registry for plugins to add PragmaHandlers to

john.brawn created this revision. john.brawn added reviewers: bkramer, rsmith, rnk. john.brawn added a subscriber: cfe-commits. john.brawn set the repository for this revision to rL LLVM. This allows plugins which add AST passes to also define pragmas to do things like only enable certain behavio

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste updated this revision to Diff 51179. Alexander_Droste added a comment. - remove `checkMissingWaitsGlobals` to prevent potential false positives http://reviews.llvm.org/D12761 Files: lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/Checkers.td lib/Sta

Re: [PATCH] D18319: Add a PragmaHandler Registry for plugins to add PragmaHandlers to

rnk added a comment. This seems reasonable. Repository: rL LLVM http://reviews.llvm.org/D18319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste marked 6 inline comments as done. Comment at: lib/StaticAnalyzer/Checkers/MPI-Checker/MPIBugReporter.cpp:39 @@ +38,3 @@ + + if (Range.isValid()) +Report->addRange(Range); `sourceRange` patch -> http://reviews.llvm.org/D18309

Re: [PATCH] D17440: clang-format: [JS] do not wrap ES6 imports/exports.

mprobst marked an inline comment as done. mprobst added a comment. As discussed offline, this matches existing very similar behaviour for destructured goog.require calls: js const {X, Y, Z} = goog.require('a'); // won't ever wrap import {X, Y, Z} from 'a'; // Shouldn't ever wrap It also

r263953 - clang-cl: Move /FC from "Unsupported" to "Ignored" list.

Author: nico Date: Mon Mar 21 12:19:31 2016 New Revision: 263953 URL: http://llvm.org/viewvc/llvm-project?rev=263953&view=rev Log: clang-cl: Move /FC from "Unsupported" to "Ignored" list. /FC affects if diagnostics print with full paths and if __FILE__ expands with a full path. clang-cl does bot

r263955 - NFC: wrap Availability-related data in its own struct in AttributeList.

Author: mren Date: Mon Mar 21 12:26:40 2016 New Revision: 263955 URL: http://llvm.org/viewvc/llvm-project?rev=263955&view=rev Log: NFC: wrap Availability-related data in its own struct in AttributeList. This makes it easy to add more data into Availability. Modified: cfe/trunk/include/clang/

Re: [PATCH] D18311: Clang tests for ARM Cortex-A32 support.

rengolin closed this revision. rengolin added a comment. Committed in r263957. http://reviews.llvm.org/D18311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r263957 - [ARM] Clang tests for ARM Cortex-A32 support

Author: rengolin Date: Mon Mar 21 12:29:51 2016 New Revision: 263957 URL: http://llvm.org/viewvc/llvm-project?rev=263957&view=rev Log: [ARM] Clang tests for ARM Cortex-A32 support Patch by Sam Parker. Modified: cfe/trunk/test/CodeGen/arm-target-features.c cfe/trunk/test/Driver/arm-cortex

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

ioeric added inline comments. Comment at: unittests/Tooling/RefactoringTest.cpp:206 @@ +205,3 @@ +TEST_F(ReplacementTest, ReplaceAndFormatNoStyle) { + std::string Code = "MyType012345678901234567890123456789 *a =\n" + "new MyType012345678901234567890123456

r263958 - Add replacement = "xxx" to AvailabilityAttr.

Author: mren Date: Mon Mar 21 12:30:55 2016 New Revision: 263958 URL: http://llvm.org/viewvc/llvm-project?rev=263958&view=rev Log: Add replacement = "xxx" to AvailabilityAttr. This commit adds a named argument to AvailabilityAttr, while r263652 adds an optional string argument to __attribute__((d

r263961 - clang-format: [JS] no space in union and intersection types.

Author: djasper Date: Mon Mar 21 12:57:31 2016 New Revision: 263961 URL: http://llvm.org/viewvc/llvm-project?rev=263961&view=rev Log: clang-format: [JS] no space in union and intersection types. The operators | and & in types, as opposed to the bitwise operators, should not have whitespace around

Re: [PATCH] D18294: clang-format: [JS] no space in union and intersection types.

djasper closed this revision. djasper added a comment. Submitted as r263961. http://reviews.llvm.org/D18294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r263963 - [clang-tidy] Fix check broken in rL263822.

Author: sbenza Date: Mon Mar 21 13:00:43 2016 New Revision: 263963 URL: http://llvm.org/viewvc/llvm-project?rev=263963&view=rev Log: [clang-tidy] Fix check broken in rL263822. Add names missing from rL263822 and add tests to prevent future omissions. Modified: clang-tools-extra/trunk/clang-t

Re: [PATCH] D18264: [clang-tidy] misc-assign-operator-signature checker checks return value of all assign operators

etienneb added a subscriber: etienneb. Comment at: clang-tidy/misc/AssignOperatorSignatureCheck.cpp:39 @@ -37,1 +38,3 @@ + const auto IsSelfAssign = +cxxMethodDecl(IsAssign, hasParameter(0, parmVarDecl(hasType(IsSelf nit: could you +2

Re: [PATCH] D16749: [OpenMP] Map clause codegeneration.

sfantao added a comment. In http://reviews.llvm.org/D16749#378969, @ABataev wrote: > Samuel, this is true for device part of codegen. But what about host? If > this code must be executed on host, will it be handled correctly? Hi Alexey, Yes, it will be handled correctly. The map clause doesn

Re: [PATCH] D17986: [ASTMatchers] New matcher hasReturnValue added

sbenza added a comment. In http://reviews.llvm.org/D17986#379271, @baloghadamsoftware wrote: > I can rerun the script, however it seems it was not executed before the last > commit on the master branch, thus if I rerun it then changes will appear in > my diff which are not related to my work. W

Fwd: r202683 - Introduce '-fmodules-user-build-path' which accepts the "canonical" path to a user workspace build.

[Resend to new ML] What is this option for? This seems, in effect, to provide a way to use a distinct module cache. Why would someone use this rather than specifying a module cache path? On Mon, Mar 3, 2014 at 12:12 AM, Argyrios Kyrtzidis wrote: > Author: akirtzidis > Date: Mon Mar 3 02:12:05 2

r263970 - [modules] Don't invent a module cache path unless implicit module builds are enabled.

Author: rsmith Date: Mon Mar 21 14:06:06 2016 New Revision: 263970 URL: http://llvm.org/viewvc/llvm-project?rev=263970&view=rev Log: [modules] Don't invent a module cache path unless implicit module builds are enabled. Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Modules/no-im

Re: [PATCH] D17950: Implement is_always_lock_free

jyknight added a comment. > Changed to what you suggested. Much nicer. I don't remember why I thought it > was a bad idea. Thanks, great! I don't have any opinion on what remains in this patch; someone else should review now. http://reviews.llvm.org/D17950

Re: [PATCH] D18110: [OpenMP] Fix SEMA bug in the capture of global variables in template functions.

sfantao added a comment. Ping! http://reviews.llvm.org/D18110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

Jordan,Does the attached patch look OK?On Mar 18, 2016, at 1:19 PM, Jordan Rose wrote:No, that case worked already. The case you fixed is the one where Base is 'foo' and Property is 'prop'…and actually, thinking more about it, this should not be considered "exact". *sigh* Th

r263974 - clang-cl: With -fmsc-version=1900, use MSVS2015 diag formatting.

Author: nico Date: Mon Mar 21 14:44:18 2016 New Revision: 263974 URL: http://llvm.org/viewvc/llvm-project?rev=263974&view=rev Log: clang-cl: With -fmsc-version=1900, use MSVS2015 diag formatting. Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/lib/Frontend/TextDiagnostic.cpp cfe/tr

Re: [PATCH] D18149: Add check for unneeded copies of locals

fowles updated this revision to Diff 51215. fowles marked 2 inline comments as done. http://reviews.llvm.org/D18149 Files: clang-tidy/performance/UnnecessaryCopyInitialization.cpp clang-tidy/performance/UnnecessaryCopyInitialization.h docs/clang-tidy/checks/performance-unnecessary-copy-init

[PATCH] D18325: export additional header modules from xmmintrin

jtsoftware created this revision. jtsoftware added reviewers: silvas, probinson. jtsoftware added a subscriber: cfe-commits. If someone only includes xmmintrin.h, but references any definitions from stdlib.h (included via mm_malloc.h), if module are enabled it will fail, but if modules are not e

Re: [PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

Yes, that looks good. For bonus points, add a similar test using the new property syntax @property (class) NSBundle *foo2; instead of the method. (I expect that version to behave nearly the same, including the "may" in the diagnostic.) Jordan > On Mar 21, 2016, at 12:36, Akira Hatanaka wrot

Re: [PATCH] D9557: Remove duplicate type definitions from f16cintrin.h

jtsoftware abandoned this revision. jtsoftware added a comment. It looks like this has already been addressed. http://reviews.llvm.org/D9557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

On Mon, Mar 21, 2016 at 6:36 PM Eric Liu wrote: > ioeric added inline comments. > > > Comment at: unittests/Tooling/RefactoringTest.cpp:206 > @@ +205,3 @@ > +TEST_F(ReplacementTest, ReplaceAndFormatNoStyle) { > + std::string Code = "MyType012345678901234567890123456789 *a =\n" >

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

Just wanted to check if there are existing test cases for format::getStyle. If there is no test for it, I'll add test cases for sure :=) On Mon, Mar 21, 2016, 21:20 Manuel Klimek wrote: > On Mon, Mar 21, 2016 at 6:36 PM Eric Liu wrote: > >> ioeric added inline comments. >> >> >

[PATCH] D18327: [sema] [CUDA] Use std algorithms in EraseUnwantedCUDAMatchesImpl.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added a subscriber: cfe-commits. NFC http://reviews.llvm.org/D18327 Files: lib/Sema/SemaCUDA.cpp Index: lib/Sema/SemaCUDA.cpp === --- lib/Sema/SemaCUDA.cpp +++ li

[PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

jlebar created this revision. jlebar added reviewers: tra, rnk. jlebar added subscribers: cfe-commits, jhen. clang --cuda-allow-std-complex translates into cc1 -fcuda-allow-std-complex. With this flag, we will mark all functions inside within namespace std as host+device, other than operator>> a

r263984 - Revert "Convert some ObjC msgSends to runtime calls."

Author: pete Date: Mon Mar 21 15:50:03 2016 New Revision: 263984 URL: http://llvm.org/viewvc/llvm-project?rev=263984&view=rev Log: Revert "Convert some ObjC msgSends to runtime calls." This reverts commit r263607. This change caused more objc_retain/objc_release calls in the IR but those are the

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. One minor question, LGTM otherwise. Comment at: lib/Sema/SemaCUDA.cpp:474 @@ +473,3 @@ + SourceLocation Loc = FD.getLocation(); + if (!SM.isInSystemHeader(Loc)) +return false;

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

weimingz added a comment. In http://reviews.llvm.org/D17741#374725, @weimingz wrote: > In http://reviews.llvm.org/D17741#372098, @weimingz wrote: > > > rebased > > > ping~ HI, Any comments/suggestions? http://reviews.llvm.org/D17741 ___ cfe-comm

r263989 - [modules] Renumber DECL_UPDATES from 30 to 50, so it no longer collides with

Author: rsmith Date: Mon Mar 21 16:16:01 2016 New Revision: 263989 URL: http://llvm.org/viewvc/llvm-project?rev=263989&view=rev Log: [modules] Renumber DECL_UPDATES from 30 to 50, so it no longer collides with TYPE_TEMPLATE_SPECIALIZATION. This was fine in practice because both record kinds are on

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

jlebar added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:474 @@ +473,3 @@ + SourceLocation Loc = FD.getLocation(); + if (!SM.isInSystemHeader(Loc)) +return false; tra wrote: > Can C++ library headers ever be non-system? I.e. can someone use libc++ via

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

rsmith added a subscriber: rsmith. rsmith added a comment. I would much prefer for us to, say, provide a header that wraps the system one and does something like // #pragma clang cuda_implicit_host_device { #include_next #pragma clang cuda_implicit_host_device } or to provide an expl

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

rnk added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:474 @@ +473,3 @@ + SourceLocation Loc = FD.getLocation(); + if (!SM.isInSystemHeader(Loc)) +return false; jlebar wrote: > tra wrote: > > Can C++ library headers ever be non-system? I.e. can someone

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

jlebar added a comment. Thanks for the suggestions, Richard. I'm not sure any of them will work, but I don't defend this patch as anything other than a hack, so if we can come up with something that works for what we need to accomplish and is cleaner, that's great. In http://reviews.llvm.org/

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

tra added a comment. In http://reviews.llvm.org/D18328#379824, @rsmith wrote: > I would much prefer for us to, say, provide a header that wraps the > system one and does something like > > // > #pragma clang cuda_implicit_host_device { > #include_next > #pragma clang cuda_implicit_hos

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

jlebar added a comment. Here are two other approaches we considered and rejected, for the record: 1. Copy-paste a implementation from e.g. libc++ into __clang_cuda_runtime_wrapper.h, and edit it appropriately. Then #define the real 's include guards. Main problem with this is the obvious o

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

jlebar added inline comments. Comment at: include/clang/Driver/Options.td:383-384 @@ -382,2 +382,4 @@ HelpText<"Enable device-side debug info generation. Disables ptxas optimizations.">; +def cuda_allow_std_complex : Flag<["--"], "cuda-allow-std-complex">, + HelpText<"Allow C

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

rnk added a comment. In http://reviews.llvm.org/D18328#379824, @rsmith wrote: > I would much prefer for us to, say, provide a header that wraps the > system one and does something like > > // > #pragma clang cuda_implicit_host_device { > #include_next > #pragma clang cuda_implicit_hos

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

jlebar added inline comments. Comment at: include/clang/Driver/Options.td:383-384 @@ -382,2 +382,4 @@ HelpText<"Enable device-side debug info generation. Disables ptxas optimizations.">; +def cuda_allow_std_complex : Flag<["--"], "cuda-allow-std-complex">, + HelpText<"Allow C

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

rsmith added inline comments. Comment at: include/clang/Driver/Options.td:383-384 @@ -382,2 +382,4 @@ HelpText<"Enable device-side debug info generation. Disables ptxas optimizations.">; +def cuda_allow_std_complex : Flag<["--"], "cuda-allow-std-complex">, + HelpText<"Allow C

r263996 - [modules] Store mangling numbers in a deterministic order so they don't cause the resulting .pcm files to be nondeterministic.

Author: rsmith Date: Mon Mar 21 17:33:02 2016 New Revision: 263996 URL: http://llvm.org/viewvc/llvm-project?rev=263996&view=rev Log: [modules] Store mangling numbers in a deterministic order so they don't cause the resulting .pcm files to be nondeterministic. Modified: cfe/trunk/include/clan

  1   2   >